hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

bugfix lrpad expr return freed memory in mysql mode

Browse Source
This commit is contained in:
shadowao
2024-01-23 07:52:03 +00:00
committed by ob-robot
parent 6356ddaa89
commit fa3abbb4b1
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/sql/engine/expr/ob_expr_lrpad.cpp
View File

@ -579,7 +579,8 @@ int ObExprBaseLRpad::calc_mysql_inner(const LRpadType pad_type,
}
}
}
if (OB_SUCC(ret) && ob_is_text_tc(type) && !res.is_null() &&
if (OB_FAIL(ret)) {
} else if (ob_is_text_tc(type) && !res.is_null() &&
has_lob_header && !has_set_to_lob_locator) {
ObString data = res.get_string();
ObTextStringResult result_buffer(type, has_lob_header, &res_alloc);
@ -593,6 +594,18 @@ int ObExprBaseLRpad::calc_mysql_inner(const LRpadType pad_type,
result_buffer.get_result_buffer(output);
res.set_string(output);
}
} else if (ob_is_text_tc(expr.args_[0]->datum_meta_.type_) && ob_is_string_tc(type)
&& ! has_set_to_lob_locator && ! res.is_null()) {
// in mysql mode, input is lob, but output is varchar
// if lob is outrow, may cause return data that's allocated from tmp allocator
ObString data = res.get_string();
ObString output;
if (data.empty()) { // skip empty string
} else if (OB_FAIL(ob_write_string(res_alloc, data, output))) {
LOG_WARN("ob_write_string fail", K(ret));
} else {
res.set_string(output);
}
}
return ret;
}