hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix SIGFPE caused by dividing INT64_MIN by -1

Browse Source
This commit is contained in:
hezuojiao
2024-10-15 05:14:07 +00:00
committed by ob-robot
parent 09cece6cd6
commit fb421d6717
2 changed files with 24 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/sql/engine/expr/ob_expr_div.cpp
View File

@ -954,16 +954,20 @@ struct ObDecimalIntBatchDivRaw : public ObArithOpRawType<L, L, R>
{
using val_type = typename common::wide::CommonType<L, R>::type;
UNUSED(is_error_div_by_zero);
res = l / r;
const val_type round = l % r;
const val_type abs_right = r < 0 ? -r : r;
const val_type abs_round = round < 0 ? -round : round;
// if |right| is odd, |right|/2 < |r| => need_carry
// if |right| is even, |right|/2 <= |r| => need_carry
const bool need_carry = ((abs_right >> 1) + (abs_right & 1)) <= abs_round;
if (need_carry) {
const int32_t carry = res < 0 ? -1 : 1;
res = res + carry;
if (r == -1) {
res = -l;
} else {
res = l / r;
const val_type round = l % r;
const val_type abs_right = r < 0 ? -r : r;
const val_type abs_round = round < 0 ? -round : round;
// if |right| is odd, |right|/2 < |r| => need_carry
// if |right| is even, |right|/2 <= |r| => need_carry
const bool need_carry = ((abs_right >> 1) + (abs_right & 1)) <= abs_round;
if (need_carry) {
const int32_t carry = res < 0 ? -1 : 1;
res = res + carry;
}
}
}