hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove defend codes in group by pushdown

Browse Source
This commit is contained in:
haitaoyang
2024-06-18 03:57:43 +00:00
committed by ob-robot
parent f5c8989764
commit fc8b7e2d54
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/storage/access/ob_pushdown_aggregate.cpp
View File

@ -3470,8 +3470,8 @@ int ObGroupByCell::init(const ObTableAccessParam &param, const ObTableAccessCont
group_by_col_offset_ = param.iter_param_.group_by_cols_project_->at(0);
for (int64_t i = 0; OB_SUCC(ret) && i < param.output_exprs_->count(); ++i) {
if (T_PSEUDO_GROUP_ID == param.output_exprs_->at(i)->type_) {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("Unexpected group idx expr", K(ret));
LOG_TRACE("Group by pushdown in batch nlj", K(ret));
continue;
} else if (nullptr == param.output_sel_mask_ || param.output_sel_mask_->at(i)) {
int32_t col_offset = param.iter_param_.out_cols_project_->at(i);
int32_t col_index = param.iter_param_.read_info_->get_columns_index().at(col_offset);

6
src/storage/access/ob_table_access_param.cpp
View File

@ -284,11 +284,7 @@ int ObTableAccessParam::init(
iter_param_.set_use_stmt_iter_pool();
}
if (OB_UNLIKELY(iter_param_.enable_pd_group_by() && scan_param.use_index_skip_scan())) {
ret = OB_INVALID_ARGUMENT;
STORAGE_LOG(WARN, "Invalid argument for group by pushdown, vectorize must be enabled and not skip scan",
K(ret), K(iter_param_.vectorized_enabled_), K(scan_param.use_index_skip_scan()));
} else if (!iter_param_.is_use_column_store()
if (!iter_param_.is_use_column_store()
&& iter_param_.enable_pd_blockscan()
&& iter_param_.enable_pd_filter()
&& iter_param_.enable_skip_index()