hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix storage schema used after free

Browse Source
This commit is contained in:
Charles0429 2024-06-17 10:12:52 +00:00 committed by ob-robot
parent 57dda3e8ed
commit fffbfd98ab
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/storage/ddl/ob_direct_insert_sstable_ctx_new.cpp
View File

@ -2251,16 +2251,14 @@ int ObTabletDirectLoadMgr::prepare_storage_schema(ObTabletHandle &tablet_handle)
{
int ret = OB_SUCCESS;
if (nullptr != sqc_build_ctx_.storage_schema_) {
ObTabletObjLoadHelper::free(sqc_build_ctx_.schema_allocator_, sqc_build_ctx_.storage_schema_);
sqc_build_ctx_.storage_schema_ = nullptr;
sqc_build_ctx_.schema_allocator_.reset();
}
if (OB_UNLIKELY(!tablet_handle.is_valid())) {
LOG_INFO("storage schema has been prepared before", K(*sqc_build_ctx_.storage_schema_));
} else if (OB_UNLIKELY(!tablet_handle.is_valid())) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("invalid tablet handle", K(ret), K(tablet_handle));
} else if (OB_FAIL(tablet_handle.get_obj()->load_storage_schema(sqc_build_ctx_.schema_allocator_, sqc_build_ctx_.storage_schema_))) {
LOG_WARN("load storage schema failed", K(ret));
} else {
}
if (OB_SUCC(ret)) {
sqc_build_ctx_.commit_scn_ = get_commit_scn(tablet_handle.get_obj()->get_tablet_meta());
}
return ret;