hcq/openGauss-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ss switchover reform dfx: reform fail during demote

Browse Source
This commit is contained in:
bowenliu
2024-02-08 10:10:03 +08:00
parent b8fc227823
commit 53a6691cbc
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/gausskernel/ddes/adapter/ss_dms_callback.cpp
View File

@ -349,17 +349,27 @@ static inline void SSResetDemoteReqType(void)
SpinLockRelease(&t_thrd.walsender_cxt.WalSndCtl->mutex); SpinLockRelease(&t_thrd.walsender_cxt.WalSndCtl->mutex);
} }
static inline void SSHandleDemoteFailure(DemoteMode demote_mode) static void SSHandleReformFailDuringDemote(DemoteMode demote_mode)
{ {
ereport(WARNING, ereport(WARNING,
(errmodule(MOD_DMS), (errmodule(MOD_DMS),
errmsg("[SS switchover] Failure in %s primary demote, pmState=%d, need reform rcy.", errmsg("[SS switchover] Failure in %s primary demote, pmState=%d, need reform rcy.",
DemoteModeDesc(demote_mode), pmState))); DemoteModeDesc(demote_mode), pmState)));
/* backends exiting, simply rollback */ /*
if (pmState == PM_WAIT_BACKENDS) { * Shutdown checkpoint would cause concurrency as DMS is starting next round of reform.
pmState = PM_RUN; * If we allow ckpt to finish and recover, DMS would not be aware of the recovery process.
* Therefore we flush as many dirty pages as we can, then trigger a DMS normal reform.
*/
if (CheckpointInProgress() || pmState >= PM_SHUTDOWN) {
ereport(ERROR,
(errmodule(MOD_DMS),
errmsg("[SS switchover DFX] reform failed after shutdown ckpt has started, exit now")));
_exit(0);
} }
/* backends exiting, simply rollback */
pmState = PM_RUN;
g_instance.demotion = NoDemote; g_instance.demotion = NoDemote;
SSResetDemoteReqType(); SSResetDemoteReqType();
} }
@ -400,7 +410,7 @@ static int CBSwitchoverDemote(void *db_handle)
return DMS_SUCCESS; return DMS_SUCCESS;
} else { } else {
if (ntries >= WAIT_DEMOTE || dms_reform_failed()) { if (ntries >= WAIT_DEMOTE || dms_reform_failed()) {
SSHandleDemoteFailure(demote_mode); SSHandleReformFailDuringDemote(demote_mode);
return DMS_ERROR; return DMS_ERROR;
} }
ntries = 0; ntries = 0;