diff -Naur a/lib/curl_rtmp.c b/lib/curl_rtmp.c --- a/lib/curl_rtmp.c 2023-06-08 21:47:27.846551637 +0800 +++ b/lib/curl_rtmp.c 2023-06-08 21:49:43.748132707 +0800 @@ -229,7 +229,7 @@ /* We have to know if it's a write before we send the * connect request packet */ - if(data->set.upload) + if(data->state.upload) r->Link.protocol |= RTMP_FEATURE_WRITE; /* For plain streams, use the buffer toggle trick to keep data flowing */ @@ -261,7 +261,7 @@ if(!RTMP_ConnectStream(r, 0)) return CURLE_FAILED_INIT; - if(data->set.upload) { + if(data->state.upload) { Curl_pgrsSetUploadSize(data, data->state.infilesize); Curl_setup_transfer(data, -1, -1, FALSE, FIRSTSOCKET); } diff -Naur a/lib/file.c b/lib/file.c --- a/lib/file.c 2023-06-08 21:47:27.846551637 +0800 +++ b/lib/file.c 2023-06-08 21:49:43.744132660 +0800 @@ -200,7 +200,7 @@ file->freepath = real_path; /* free this when done */ file->fd = fd; - if(!data->set.upload && (fd == -1)) { + if(!data->state.upload && (fd == -1)) { failf(data, "Couldn't open file %s", data->state.up.path); file_done(data, CURLE_FILE_COULDNT_READ_FILE, FALSE); return CURLE_FILE_COULDNT_READ_FILE; @@ -382,7 +382,7 @@ Curl_pgrsStartNow(data); - if(data->set.upload) + if(data->state.upload) return file_upload(data); file = data->req.p.file; diff -Naur a/lib/ftp.c b/lib/ftp.c --- a/lib/ftp.c 2023-06-08 21:47:27.850551682 +0800 +++ b/lib/ftp.c 2023-06-08 21:49:43.740132613 +0800 @@ -1381,7 +1381,7 @@ data->set.str[STRING_CUSTOMREQUEST]? data->set.str[STRING_CUSTOMREQUEST]: (data->state.list_only?"NLST":"LIST")); - else if(data->set.upload) + else if(data->state.upload) result = Curl_pp_sendf(data, &ftpc->pp, "PRET STOR %s", conn->proto.ftpc.file); else @@ -3365,7 +3365,7 @@ /* the response code from the transfer showed an error already so no use checking further */ ; - else if(data->set.upload) { + else if(data->state.upload) { if((-1 != data->state.infilesize) && (data->state.infilesize != data->req.writebytecount) && !data->set.crlf && @@ -3637,7 +3637,7 @@ connected back to us */ } } - else if(data->set.upload) { + else if(data->state.upload) { result = ftp_nb_type(data, conn, data->state.prefer_ascii, FTP_STOR_TYPE); if(result) @@ -4217,7 +4217,7 @@ ftpc->file = NULL; /* instead of point to a zero byte, we make it a NULL pointer */ - if(data->set.upload && !ftpc->file && (ftp->transfer == PPTRANSFER_BODY)) { + if(data->state.upload && !ftpc->file && (ftp->transfer == PPTRANSFER_BODY)) { /* We need a file name when uploading. Return error! */ failf(data, "Uploading to a URL without a file name!"); free(rawPath); diff -Naur a/lib/http.c b/lib/http.c --- a/lib/http.c 2023-06-08 21:47:27.846551637 +0800 +++ b/lib/http.c 2023-06-08 21:49:43.748132707 +0800 @@ -2028,7 +2028,7 @@ Curl_HttpReq httpreq = data->state.httpreq; const char *request; if((conn->handler->protocol&(PROTO_FAMILY_HTTP|CURLPROTO_FTP)) && - data->set.upload) + data->state.upload) httpreq = HTTPREQ_PUT; /* Now set the 'request' pointer to the proper request string */ @@ -2343,7 +2343,7 @@ if((conn->handler->protocol & PROTO_FAMILY_HTTP) && (((httpreq == HTTPREQ_POST_MIME || httpreq == HTTPREQ_POST_FORM) && http->postsize < 0) || - ((data->set.upload || httpreq == HTTPREQ_POST) && + ((data->state.upload || httpreq == HTTPREQ_POST) && data->state.infilesize == -1))) { if(conn->bits.authneg) /* don't enable chunked during auth neg */ diff -Naur a/lib/imap.c b/lib/imap.c --- a/lib/imap.c 2023-06-08 21:47:27.842551592 +0800 +++ b/lib/imap.c 2023-06-08 21:54:45.259686242 +0800 @@ -1491,11 +1491,11 @@ result = status; /* use the already set error code */ } else if(!data->set.connect_only && !imap->custom && - (imap->uid || imap->mindex || data->set.upload || + (imap->uid || imap->mindex || data->state.upload || data->set.mimepost.kind != MIMEKIND_NONE)) { /* Handle responses after FETCH or APPEND transfer has finished */ - if(!data->set.upload && data->set.mimepost.kind == MIMEKIND_NONE) + if(!data->state.upload && data->set.mimepost.kind == MIMEKIND_NONE) state(data, IMAP_FETCH_FINAL); else { /* End the APPEND command first by sending an empty line */ @@ -1561,7 +1561,7 @@ selected = TRUE; /* Start the first command in the DO phase */ - if(data->set.upload || data->set.mimepost.kind != MIMEKIND_NONE) + if(data->state.upload || data->set.mimepost.kind != MIMEKIND_NONE) /* APPEND can be executed directly */ result = imap_perform_append(data); else if(imap->custom && (selected || !imap->mailbox)) diff -Naur a/lib/rtsp.c b/lib/rtsp.c --- a/lib/rtsp.c 2023-06-08 21:47:27.842551592 +0800 +++ b/lib/rtsp.c 2023-06-08 21:49:43.740132613 +0800 @@ -508,7 +508,7 @@ rtspreq == RTSPREQ_SET_PARAMETER || rtspreq == RTSPREQ_GET_PARAMETER) { - if(data->set.upload) { + if(data->state.upload) { putsize = data->state.infilesize; data->state.httpreq = HTTPREQ_PUT; @@ -527,7 +527,7 @@ result = Curl_dyn_addf(&req_buffer, "Content-Length: %" CURL_FORMAT_CURL_OFF_T"\r\n", - (data->set.upload ? putsize : postsize)); + (data->state.upload ? putsize : postsize)); if(result) return result; } diff -Naur a/lib/setopt.c b/lib/setopt.c --- a/lib/setopt.c 2023-06-08 22:22:59.219334893 +0800 +++ b/lib/setopt.c 2023-06-08 21:49:43.740132613 +0800 @@ -299,8 +299,8 @@ * We want to sent data to the remote host. If this is HTTP, that equals * using the PUT request. */ - data->set.upload = (0 != va_arg(param, long)) ? TRUE : FALSE; - if(data->set.upload) { + arg = va_arg(param, long); + if(arg) { /* If this is HTTP, PUT is what's needed to "upload" */ data->set.method = HTTPREQ_PUT; data->set.opt_no_body = FALSE; /* this is implied */ @@ -630,7 +630,6 @@ } else data->set.method = HTTPREQ_GET; - data->set.upload = FALSE; break; case CURLOPT_HTTPPOST: @@ -878,7 +877,6 @@ */ if(va_arg(param, long)) { data->set.method = HTTPREQ_GET; - data->set.upload = FALSE; /* switch off upload */ data->set.opt_no_body = FALSE; /* this is implied */ } break; diff -Naur a/lib/smb.c b/lib/smb.c --- a/lib/smb.c 2023-06-08 21:47:27.842551592 +0800 +++ b/lib/smb.c 2023-06-08 21:49:43.740132613 +0800 @@ -536,7 +536,7 @@ byte_count = strlen(req->path); msg.name_length = smb_swap16((unsigned short)byte_count); msg.share_access = smb_swap32(SMB_FILE_SHARE_ALL); - if(data->set.upload) { + if(data->state.upload) { msg.access = smb_swap32(SMB_GENERIC_READ | SMB_GENERIC_WRITE); msg.create_disposition = smb_swap32(SMB_FILE_OVERWRITE_IF); } @@ -815,7 +815,7 @@ smb_m = (const struct smb_nt_create_response*) msg; req->fid = smb_swap16(smb_m->fid); data->req.offset = 0; - if(data->set.upload) { + if(data->state.upload) { data->req.size = data->state.infilesize; Curl_pgrsSetUploadSize(data, data->req.size); next_state = SMB_UPLOAD; diff -Naur a/lib/smtp.c b/lib/smtp.c --- a/lib/smtp.c 2023-06-08 21:47:27.842551592 +0800 +++ b/lib/smtp.c 2023-06-08 21:49:43.740132613 +0800 @@ -1387,7 +1387,7 @@ result = status; /* use the already set error code */ } else if(!data->set.connect_only && data->set.mail_rcpt && - (data->set.upload || data->set.mimepost.kind)) { + (data->state.upload || data->set.mimepost.kind)) { /* Calculate the EOB taking into account any terminating CRLF from the previous line of the email or the CRLF of the DATA command when there is "no mail data". RFC-5321, sect. 4.1.1.4. @@ -1480,7 +1480,7 @@ smtp->eob = 2; /* Start the first command in the DO phase */ - if((data->set.upload || data->set.mimepost.kind) && data->set.mail_rcpt) + if((data->state.upload || data->set.mimepost.kind) && data->set.mail_rcpt) /* MAIL transfer */ result = smtp_perform_mail(data); else diff -Naur a/lib/tftp.c b/lib/tftp.c --- a/lib/tftp.c 2023-06-08 21:47:27.846551637 +0800 +++ b/lib/tftp.c 2023-06-08 21:49:43.740132613 +0800 @@ -367,7 +367,7 @@ /* tsize should be ignored on upload: Who cares about the size of the remote file? */ - if(!data->set.upload) { + if(!data->state.upload) { if(!tsize) { failf(data, "invalid tsize -:%s:- value in OACK packet", value); return CURLE_TFTP_ILLEGAL; @@ -448,7 +448,7 @@ return result; } - if(data->set.upload) { + if(data->state.upload) { /* If we are uploading, send an WRQ */ setpacketevent(&state->spacket, TFTP_EVENT_WRQ); state->data->req.upload_fromhere = @@ -483,7 +483,7 @@ if(!data->set.tftp_no_options) { char buf[64]; /* add tsize option */ - if(data->set.upload && (data->state.infilesize != -1)) + if(data->state.upload && (data->state.infilesize != -1)) msnprintf(buf, sizeof(buf), "%" CURL_FORMAT_CURL_OFF_T, data->state.infilesize); else @@ -537,7 +537,7 @@ break; case TFTP_EVENT_OACK: - if(data->set.upload) { + if(data->state.upload) { result = tftp_connect_for_tx(state, event); } else { diff -Naur a/lib/transfer.c b/lib/transfer.c --- a/lib/transfer.c 2023-06-08 21:47:27.842551592 +0800 +++ b/lib/transfer.c 2023-06-08 21:49:43.744132660 +0800 @@ -1391,6 +1391,7 @@ { data->state.fread_func = data->set.fread_func_set; data->state.in = data->set.in_set; + data->state.upload = (data->state.httpreq == HTTPREQ_PUT); } /* @@ -1764,7 +1765,6 @@ data->state.httpreq != HTTPREQ_POST_MIME) || !(data->set.keep_post & CURL_REDIR_POST_303))) { data->state.httpreq = HTTPREQ_GET; - data->set.upload = false; infof(data, "Switch to %s", data->set.opt_no_body?"HEAD":"GET"); } @@ -1802,7 +1802,7 @@ /* if we're talking upload, we can't do the checks below, unless the protocol is HTTP as when uploading over HTTP we will still get a response */ - if(data->set.upload && + if(data->state.upload && !(conn->handler->protocol&(PROTO_FAMILY_HTTP|CURLPROTO_RTSP))) return CURLE_OK; diff -Naur a/lib/urldata.h b/lib/urldata.h --- a/lib/urldata.h 2023-06-08 21:47:27.846551637 +0800 +++ b/lib/urldata.h 2023-06-08 21:49:43.740132613 +0800 @@ -1473,6 +1473,7 @@ BIT(url_alloc); /* URL string is malloc()'ed */ BIT(referer_alloc); /* referer string is malloc()ed */ BIT(wildcard_resolve); /* Set to true if any resolve change is a wildcard */ + BIT(upload); /* upload request */ }; /* @@ -1815,7 +1816,6 @@ BIT(http_auto_referer); /* set "correct" referer when following location: */ BIT(opt_no_body); /* as set with CURLOPT_NOBODY */ - BIT(upload); /* upload request */ BIT(verbose); /* output verbosity */ BIT(krb); /* Kerberos connection requested */ BIT(reuse_forbid); /* forbidden to be reused, close after use */ diff -Naur a/lib/vssh/libssh2.c b/lib/vssh/libssh2.c --- a/lib/vssh/libssh2.c 2023-06-08 21:47:27.846551637 +0800 +++ b/lib/vssh/libssh2.c 2023-06-08 21:49:43.744132660 +0800 @@ -1840,7 +1840,7 @@ } case SSH_SFTP_TRANS_INIT: - if(data->set.upload) + if(data->state.upload) state(data, SSH_SFTP_UPLOAD_INIT); else { if(sshp->path[strlen(sshp->path)-1] == '/') @@ -2512,7 +2512,7 @@ break; } - if(data->set.upload) { + if(data->state.upload) { if(data->state.infilesize < 0) { failf(data, "SCP requires a known file size for upload"); sshc->actualcode = CURLE_UPLOAD_FAILED; @@ -2652,7 +2652,7 @@ break; case SSH_SCP_DONE: - if(data->set.upload) + if(data->state.upload) state(data, SSH_SCP_SEND_EOF); else state(data, SSH_SCP_CHANNEL_FREE); diff -Naur a/lib/vssh/libssh.c b/lib/vssh/libssh.c --- a/lib/vssh/libssh.c 2023-06-08 21:47:27.846551637 +0800 +++ b/lib/vssh/libssh.c 2023-06-08 21:49:43.744132660 +0800 @@ -1199,7 +1199,7 @@ } case SSH_SFTP_TRANS_INIT: - if(data->set.upload) + if(data->state.upload) state(data, SSH_SFTP_UPLOAD_INIT); else { if(protop->path[strlen(protop->path)-1] == '/') @@ -1812,7 +1812,7 @@ /* Functions from the SCP subsystem cannot handle/return SSH_AGAIN */ ssh_set_blocking(sshc->ssh_session, 1); - if(data->set.upload) { + if(data->state.upload) { if(data->state.infilesize < 0) { failf(data, "SCP requires a known file size for upload"); sshc->actualcode = CURLE_UPLOAD_FAILED; @@ -1917,7 +1917,7 @@ break; } case SSH_SCP_DONE: - if(data->set.upload) + if(data->state.upload) state(data, SSH_SCP_SEND_EOF); else state(data, SSH_SCP_CHANNEL_FREE); diff -Naur a/lib/vssh/wolfssh.c b/lib/vssh/wolfssh.c --- a/lib/vssh/wolfssh.c 2023-06-08 21:47:27.846551637 +0800 +++ b/lib/vssh/wolfssh.c 2023-06-08 21:49:43.744132660 +0800 @@ -553,7 +553,7 @@ } break; case SSH_SFTP_TRANS_INIT: - if(data->set.upload) + if(data->state.upload) state(data, SSH_SFTP_UPLOAD_INIT); else { if(sftp_scp->path[strlen(sftp_scp->path)-1] == '/')