hcq/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2026-02-16 11:26:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve node type forward reference

Browse Source 
Instead of using Node *, we can use an incomplete struct.  That way,
everything has the correct type and fewer casts are required.  This
technique is already used elsewhere in node type definitions.

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Tender Wang <tndrwang@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/637eeea8-5663-460b-a114-39572c0f6c6e%40eisentraut.org
This commit is contained in:
Peter Eisentraut
2024-10-17 08:36:14 +02:00
parent 41b023946d
commit eafda78fc4
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/include/nodes/primnodes.h
View File

@ -152,8 +152,8 @@ typedef struct TableFunc
* For CREATE MATERIALIZED VIEW, viewQuery is the parsed-but-not-rewritten
* SELECT Query for the view; otherwise it's NULL. This is irrelevant in
* the query jumbling as CreateTableAsStmt already includes a reference to
* its own Query, so ignore it. (Although it's actually Query*, we declare
* it as Node* to avoid a forward reference.)
* its own Query, so ignore it. (We declare it as struct Query* to avoid a
* forward reference.)
*/
typedef struct IntoClause
{
@ -166,7 +166,7 @@ typedef struct IntoClause
OnCommitAction onCommit; /* what do we do at COMMIT? */
char *tableSpaceName; /* table space to use, or NULL */
/* materialized view's SELECT query */
Node *viewQuery pg_node_attr(query_jumble_ignore);
struct Query *viewQuery pg_node_attr(query_jumble_ignore);
bool skipData; /* true for WITH NO DATA */
} IntoClause;