Commit Graph

  • 01e570e684 transformColumnDefinition failed to complain about create table foo (bar int default null default 3); due to not thinking about the special-case handling of DEFAULT NULL. Problem noticed while investigating bug #3396. Tom Lane 2007-06-20 18:21:51 +00:00
  • d9544b67ce transformColumnDefinition failed to complain about create table foo (bar int default null default 3); due to not thinking about the special-case handling of DEFAULT NULL. Problem noticed while investigating bug #3396. Tom Lane 2007-06-20 18:21:39 +00:00
  • b0bbcbe7d3 transformColumnDefinition failed to complain about create table foo (bar int default null default 3); due to not thinking about the special-case handling of DEFAULT NULL. Problem noticed while investigating bug #3396. Tom Lane 2007-06-20 18:21:25 +00:00
  • 12b9a64ccc transformColumnDefinition failed to complain about create table foo (bar int default null default 3); due to not thinking about the special-case handling of DEFAULT NULL. Problem noticed while investigating bug #3396. Tom Lane 2007-06-20 18:21:15 +00:00
  • 65e67e2bb2 transformColumnDefinition failed to complain about create table foo (bar int default null default 3); due to not thinking about the special-case handling of DEFAULT NULL. Problem noticed while investigating bug #3396. Tom Lane 2007-06-20 18:21:08 +00:00
  • cd407354ee transformColumnDefinition failed to complain about create table foo (bar int default null default 3); due to not thinking about the special-case handling of DEFAULT NULL. Problem noticed while investigating bug #3396. Tom Lane 2007-06-20 18:21:00 +00:00
  • cbe8af81b2 CREATE DOMAIN ... DEFAULT NULL failed because gram.y special-cases DEFAULT NULL and DefineDomain didn't. Bug goes all the way back to original coding of domains. Per bug #3396 from Sergey Burladyan. Tom Lane 2007-06-20 18:16:30 +00:00
  • 4ed20db4f4 CREATE DOMAIN ... DEFAULT NULL failed because gram.y special-cases DEFAULT NULL and DefineDomain didn't. Bug goes all the way back to original coding of domains. Per bug #3396 from Sergey Burladyan. Tom Lane 2007-06-20 18:16:18 +00:00
  • db6159bcd9 CREATE DOMAIN ... DEFAULT NULL failed because gram.y special-cases DEFAULT NULL and DefineDomain didn't. Bug goes all the way back to original coding of domains. Per bug #3396 from Sergey Burladyan. Tom Lane 2007-06-20 18:16:10 +00:00
  • f5bfaf9546 CREATE DOMAIN ... DEFAULT NULL failed because gram.y special-cases DEFAULT NULL and DefineDomain didn't. Bug goes all the way back to original coding of domains. Per bug #3396 from Sergey Burladyan. Tom Lane 2007-06-20 18:16:04 +00:00
  • fb573ef636 CREATE DOMAIN ... DEFAULT NULL failed because gram.y special-cases DEFAULT NULL and DefineDomain didn't. Bug goes all the way back to original coding of domains. Per bug #3396 from Sergey Burladyan. Tom Lane 2007-06-20 18:15:57 +00:00
  • a060d5ffdc CREATE DOMAIN ... DEFAULT NULL failed because gram.y special-cases DEFAULT NULL and DefineDomain didn't. Bug goes all the way back to original coding of domains. Per bug #3396 from Sergey Burladyan. Tom Lane 2007-06-20 18:15:49 +00:00
  • 52ba24a156 Quiet warnings about redefined PGPORT macros for MSVC. Andrew Dunstan 2007-06-20 17:19:00 +00:00
  • c1d89c61fc Minor code cleanup: calling FreeFile() before ereport(ERROR) is not necessary, since files opened via AllocateFile() are closed automatically as part of error recovery. Neil Conway 2007-06-20 02:02:49 +00:00
  • 9cce91dba0 Only log 'process acquired lock' if we actually did get the lock. This test seems inessential right now since the only control path for not getting the lock is via CHECK_FOR_INTERRUPTS which won't return control to ProcSleep, but it would be important if we ever allow the deadlock code to kill someone else's transaction instead of our own. Tom Lane 2007-06-19 22:01:15 +00:00
  • ec4595dae1 Remove duplicate #include. Neil Conway 2007-06-19 21:24:48 +00:00
  • 6e07228728 Code review for log_lock_waits patch. Don't try to issue log messages from within a signal handler (this might be safe given the relatively narrow code range in which the interrupt is enabled, but it seems awfully risky); do issue more informative log messages that tell what is being waited for and the exact length of the wait; minor other code cleanup. Greg Stark and Tom Lane Tom Lane 2007-06-19 20:13:22 +00:00
  • 4c310eca2e Arrange for quote_identifier() and pg_dump to not quote keywords that are unreserved according to the grammar. The list of unreserved words has gotten extensive enough that the unnecessary quoting is becoming a bit of an eyesore. To do this, add knowledge of the keyword category to keywords.c's table. (Someday we might be able to generate keywords.c's table and the keyword lists in gram.y from a common source.) For the moment, lie about WITH's status in the table so it will still get quoted --- this is because of the expectation that WITH will become reserved when the SQL recursive-queries patch gets done. Tom Lane 2007-06-18 21:40:58 +00:00
  • 532834081d Remove comment about modifying tab-complete.c for userset GUC. Magnus Hagander 2007-06-18 10:02:57 +00:00
  • 838e286247 Back-patch 8.2 fix that complains if trying to extend a relation encounters a buffer containing a non-zeroed page. This seems appropriate now that the 8.2 fix has been seen to save at least one user from data loss due to a buggy kernel (per report from Jaime Silvela 7-May-07). I'd go further back than 8.1, except that the 8.0-to-8.1 bufmgr changes are large enough that the patch doesn't work immediately; I'm hesitant to make a change without more extensive analysis than I have time for now. Tom Lane 2007-06-18 01:14:08 +00:00
  • de6a6383a7 Update obsolete comment: it's no longer the case that mdread() will allow reads beyond EOF, except by special coercion. Tom Lane 2007-06-18 00:47:20 +00:00
  • 011b51cb7e Marginal hacking to improve the speed of COPY OUT. I had found in a bit of profiling that CopyAttributeOutText was taking an unreasonable fraction of the backend run time (like 66%!) on the following trivial test case: Tom Lane 2007-06-17 23:39:28 +00:00
  • 6775c01080 Revert an ill-considered portion of my patch of 12-Mar, which tried to save a few lines in sql_exec_error_callback() by using the function source string field that the patch added to SQL function cache entries. This doesn't work because the fn_extra field isn't filled in yet during init_sql_fcache(). Probably it could be made to work, but it doesn't seem appropriate to contort the main code paths to make an error-reporting path a tad faster. Per report from Pavel Stehule. Tom Lane 2007-06-17 18:57:29 +00:00
  • 23347231a5 Tweak the API for per-datatype typmodin functions so that they are passed an array of strings rather than an array of integers, and allow any simple constant or identifier to be used in typmods; for example create table foo (f1 widget(42,'23skidoo',point)); Of course the typmodin function has still got to pack this info into a non-negative int32 for storage, but it's still a useful improvement in flexibility, especially considering that you can do nearly anything if you are willing to keep the info in a side table. We can get away with this change since we have not yet released a version providing user-definable typmods. Per discussion. Tom Lane 2007-06-15 20:56:52 +00:00
  • 839fcc9fd0 Applied patch by Joachim to enable checktcp again Michael Meskes 2007-06-15 08:23:52 +00:00
  • 7cf20db3e5 Avoid having autovacuum run multiple ANALYZE commands in a single transaction, to prevent possible deadlock problems. Per request from Tom Lane. Alvaro Herrera 2007-06-14 13:54:40 +00:00
  • a0084306e7 Avoid having autovacuum run multiple ANALYZE commands in a single transaction, to prevent possible deadlock problems. Per request from Tom Lane. Alvaro Herrera 2007-06-14 13:54:28 +00:00
  • bd06ab29ae Avoid having autovacuum run multiple ANALYZE commands in a single transaction, to prevent possible deadlock problems. Per request from Tom Lane. Alvaro Herrera 2007-06-14 13:53:14 +00:00
  • 56813a998c Add resultmap entries for mingw - same as for msvc Magnus Hagander 2007-06-14 13:15:58 +00:00
  • 6d12c7dcd4 Properly identify mingw as a win32 platform needing different diff options to deal with strange line endings. Magnus Hagander 2007-06-14 13:10:11 +00:00
  • ffa8396eee Implement a chunking protocol for writes to the syslogger pipe, with messages reassembled in the syslogger before writing to the log file. This prevents partial messages from being written, which mucks up log rotation, and messages from different backends being interleaved, which causes garbled logs. Backport as far as 8.0, where the syslogger was introduced. Andrew Dunstan 2007-06-14 01:50:35 +00:00
  • 1103beb52a Implement a chunking protocol for writes to the syslogger pipe, with messages reassembled in the syslogger before writing to the log file. This prevents partial messages from being written, which mucks up log rotation, and messages from different backends being interleaved, which causes garbled logs. Backport as far as 8.0, where the syslogger was introduced. Andrew Dunstan 2007-06-14 01:50:14 +00:00
  • 0998720d0c Implement a chunking protocol for writes to the syslogger pipe, with messages reassembled in the syslogger before writing to the log file. This prevents partial messages from being written, which mucks up log rotation, and messages from different backends being interleaved, which causes garbled logs. Backport as far as 8.0, where the syslogger was introduced. Andrew Dunstan 2007-06-14 01:49:39 +00:00
  • bd2cb9aaa5 Implement a chunking protocol for writes to the syslogger pipe, with messages reassembled in the syslogger before writing to the log file. This prevents partial messages from being written, which mucks up log rotation, and messages from different backends being interleaved, which causes garbled logs. Backport as far as 8.0, where the syslogger was introduced. Andrew Dunstan 2007-06-14 01:48:51 +00:00
  • 320f820585 Schema-qualify several references to the builtin function length(), to avoid mistakenly calling a function of the same name that might happen to appear earlier in the schema search path. Neil Conway 2007-06-13 23:59:47 +00:00
  • 7ced811d45 Update item: Bruce Momjian 2007-06-13 21:38:00 +00:00
  • a0a26c47d4 Avoid integer overflow issues in autovacuum. Alvaro Herrera 2007-06-13 21:24:56 +00:00
  • e976fd43c6 Add some simple defenses against null fields in pg_largeobject, and add comments noting that there's an alignment assumption now that the data field could be in 1-byte-header format. Per discussion with Greg Stark. Tom Lane 2007-06-12 19:46:24 +00:00
  • ee0d34ab64 ECPG requires a local include directory to override the project-wide ones. Add ability to add "prefix include directories", and use it... Magnus Hagander 2007-06-12 18:31:28 +00:00
  • 1ad08a8e9a Update documentation of resultmap file format. Magnus Hagander 2007-06-12 17:49:12 +00:00
  • 152133bfaf Add some comments about the safety of accessing rolpassword without using the normal heap_getattr() machinery. Per Greg Stark. Tom Lane 2007-06-12 17:16:52 +00:00
  • 8be9b50ab4 Minor comment fixes. Tom Lane 2007-06-12 16:01:31 +00:00
  • 83d95b572b Fix DecodeDateTime to allow timezone to appear before year. This had historically worked in some but not all cases, but as of 8.2 it failed for all timezone formats. Fix, and add regression test cases to catch future regressions in this area. Per gripe from Adam Witney. Tom Lane 2007-06-12 15:58:39 +00:00
  • d0599994da Fix DecodeDateTime to allow timezone to appear before year. This had historically worked in some but not all cases, but as of 8.2 it failed for all timezone formats. Fix, and add regression test cases to catch future regressions in this area. Per gripe from Adam Witney. Tom Lane 2007-06-12 15:58:32 +00:00
  • e41c7bb7cd VPATH fixes. Alvaro Herrera 2007-06-12 15:00:41 +00:00
  • a0de6e7b97 Specifying a dbname should override the default database, not add to it. Fixes buildfarm failures on contribcheck. Magnus Hagander 2007-06-12 13:54:58 +00:00
  • 8c0d308818 Fix missing variable initialization. Magnus Hagander 2007-06-12 13:26:45 +00:00
  • ee9d55cb52 Fix search/replace error in makefile for ecpg tests Magnus Hagander 2007-06-12 13:09:58 +00:00
  • 5e96a7b96c Fixed reduce/recuce problem due to CURRENT_P. Michael Meskes 2007-06-12 11:32:30 +00:00
  • 09922597c5 Rewrite ECPG regression test driver in C, by splitting the standard regression driver into two parts and reusing half of it. Required to run ECPG tests without a shell on MSVC builds. Magnus Hagander 2007-06-12 11:07:34 +00:00
  • e514740e69 Synced parser and keyword list. Michael Meskes 2007-06-12 07:55:56 +00:00
  • a9545b3aef Improve UPDATE/DELETE WHERE CURRENT OF so that they can be used from plpgsql with a plpgsql-defined cursor. The underlying mechanism for this is that the main SQL engine will now take "WHERE CURRENT OF $n" where $n is a refcursor parameter. Not sure if we should document that fact or consider it an implementation detail. Per discussion with Pavel Stehule. Tom Lane 2007-06-11 22:22:42 +00:00
  • bdc71c2cb1 Minor wording improvement. Tom Lane 2007-06-11 15:08:32 +00:00
  • 88a7c4822c Should not try to unlink stdout. Michael Meskes 2007-06-11 12:01:23 +00:00
  • 91411b6105 Fixed one memory leak in descriptor code. Made sure ecpg deletes output file in case of an error. Michael Meskes 2007-06-11 11:52:08 +00:00
  • 5f2bda15eb Done: Bruce Momjian 2007-06-11 01:51:50 +00:00
  • 6808f1b1de Support UPDATE/DELETE WHERE CURRENT OF cursor_name, per SQL standard. Tom Lane 2007-06-11 01:16:30 +00:00
  • 85d72f0516 Teach heapam code to know the difference between a real seqscan and the pseudo HeapScanDesc created for a bitmap heap scan. This avoids some useless overhead during a bitmap scan startup, in particular invoking the syncscan code. (We might someday want to do that, but right now it's merely useless contention for shared memory, to say nothing of possibly pushing useful entries out of syncscan's small LRU list.) This also allows elimination of ugly pgstat_discount_heap_scan() kluge. Tom Lane 2007-06-09 18:49:55 +00:00
  • 7063c46fc1 Insert ORDER BY into a few regression test queries that now have unstable results due to syncscan patch, when shared_buffers is small enough. Per buildfarm reports and some local testing with shared_buffers set to the lowest value considered by initdb. Tom Lane 2007-06-09 17:24:46 +00:00
  • 6222d866a2 Allow numeric_fac() to be interrupted, since it can take quite a while for large inputs. Also cause it to error out immediately if the result will overflow, instead of grinding through a lot of calculation first. Per gripe from Jim Nasby. Tom Lane 2007-06-09 15:52:54 +00:00
  • 09bb362087 Allow numeric_fac() to be interrupted, since it can take quite a while for large inputs. Also cause it to error out immediately if the result will overflow, instead of grinding through a lot of calculation first. Per gripe from Jim Nasby. Tom Lane 2007-06-09 15:52:47 +00:00
  • ab4f1947f3 Allow numeric_fac() to be interrupted, since it can take quite a while for large inputs. Also cause it to error out immediately if the result will overflow, instead of grinding through a lot of calculation first. Per gripe from Jim Nasby. Tom Lane 2007-06-09 15:52:38 +00:00
  • e17e40f783 Allow numeric_fac() to be interrupted, since it can take quite a while for large inputs. Also cause it to error out immediately if the result will overflow, instead of grinding through a lot of calculation first. Per gripe from Jim Nasby. Tom Lane 2007-06-09 15:52:30 +00:00
  • a4d5872719 Disallow the cost balancing code from resulting in a zero cost limit, which causes a division-by-zero error in the vacuum code. This can happen when there are more workers than cost limit units. Alvaro Herrera 2007-06-08 21:21:28 +00:00
  • 2b438c12cc Avoid passing zero as a value for vacuum_cost_limit, because it's not a valid value for the vacuum code. Instead, make zero signify getting the value from a higher level configuration facility, just like -1 in the original coding. We still document that -1 is the value that disables the feature, to avoid confusing the user unnecessarily. Alvaro Herrera 2007-06-08 21:09:49 +00:00
  • 4213e5f0db Add note that LIMIT without ORDER BY can produce outright nondeterministic results. Necessary due to introduction of syncscan patch. Tom Lane 2007-06-08 20:26:18 +00:00
  • a3e3389913 Done: Bruce Momjian 2007-06-08 18:45:22 +00:00
  • a04a423599 Arrange for large sequential scans to synchronize with each other, so that when multiple backends are scanning the same relation concurrently, each page is (ideally) read only once. Tom Lane 2007-06-08 18:23:53 +00:00
  • 6d6d14b6d5 Redefine IsTransactionState() to only return true for TRANS_INPROGRESS state, which is the only state in which it's safe to initiate database queries. It turns out that all but two of the callers thought that's what it meant; and the other two were using it as a proxy for "will GetTopTransactionId() return a nonzero XID"? Since it was in fact an unreliable guide to that, make those two just invoke GetTopTransactionId() always, then deal with a zero result if they get one. Tom Lane 2007-06-07 21:45:59 +00:00
  • 24ee8af573 Rework temp_tablespaces patch so that temp tablespaces are assigned separately for each temp file, rather than once per sort or hashjoin; this allows spreading the data of a large sort or join across multiple tablespaces. (I remain dubious that this will make any difference in practice, but certain people insisted.) Arrange to cache the results of parsing the GUC variable instead of recomputing from scratch on every demand, and push usage of the cache down to the bottommost fd.c level. Tom Lane 2007-06-07 19:19:57 +00:00
  • 02c31e885d Avoid losing track of data for shared tables in pgstats. Report by Michael Fuhr, patch from Tom Lane after a messier suggestion by me. Alvaro Herrera 2007-06-07 19:07:13 +00:00
  • bac7d7b53b Avoid losing track of data for shared tables in pgstats. Report by Michael Fuhr, patch from Tom Lane after a messier suggestion by me. Alvaro Herrera 2007-06-07 19:07:11 +00:00
  • 2d9d7a6bf5 Avoid losing track of data for shared tables in pgstats. Report by Michael Fuhr, patch from Tom Lane after a messier suggestion by me. Alvaro Herrera 2007-06-07 18:53:17 +00:00
  • 94dc2d8e3b Fix array_dims() example to be consistent with the data previously shown. Christian Rossow Tom Lane 2007-06-07 14:50:18 +00:00
  • 5e25d43893 Fix array_dims() example to be consistent with the data previously shown. Christian Rossow Tom Lane 2007-06-07 14:50:07 +00:00
  • 7c92618676 Fix array_dims() example to be consistent with the data previously shown. Christian Rossow Tom Lane 2007-06-07 14:50:00 +00:00
  • 04d919a11a Fix array_dims() example to be consistent with the data previously shown. Christian Rossow Tom Lane 2007-06-07 14:49:56 +00:00
  • b13cc9579c The functions bt_metap, bt_page_stats and bt_page_items had moved from contrib/pgstattuple to pageinspect. We've already fixed English documentation, but Japanese version does not catch up. Magnus Hagander 2007-06-07 09:56:25 +00:00
  • 2d4db3675f Fix up text concatenation so that it accepts all the reasonable cases that were accepted by prior Postgres releases. This takes care of the loose end left by the preceding patch to downgrade implicit casts-to-text. To avoid breaking desirable behavior for array concatenation, introduce a new polymorphic pseudo-type "anynonarray" --- the added concatenation operators are actually text || anynonarray and anynonarray || text. Tom Lane 2007-06-06 23:00:50 +00:00
  • 7dab4f75ca Minor editorialization: don't flush plan cache without need. Tom Lane 2007-06-05 21:50:19 +00:00
  • 31edbadf4a Downgrade implicit casts to text to be assignment-only, except for the ones from the other string-category types; this eliminates a lot of surprising interpretations that the parser could formerly make when there was no directly applicable operator. Tom Lane 2007-06-05 21:31:09 +00:00
  • 1120b99445 The session_replication_role actually can be changed at will during a session regardless of the existence of cached plans. The plancache only needs to be invalidated so that rules affected by the new setting will be reflected in the new query plans. Jan Wieck 2007-06-05 20:00:41 +00:00
  • 5e87f49a4c Move call of MarkBufferDirty() before XLogInsert() as required. Many thanks to Heikki Linnakangas <heikki@enterprisedb.com> for his sharp eyes. Teodor Sigaev 2007-06-05 12:48:21 +00:00
  • f74426283d Move call of MarkBufferDirty() before XLogInsert() as required. Many thanks to Heikki Linnakangas <heikki@enterprisedb.com> for his sharp eyes. Teodor Sigaev 2007-06-05 12:47:49 +00:00
  • 4c0fe51279 Remove ill-conceived CRLF translation for Windows in syslogger. Andrew Dunstan 2007-06-04 22:21:42 +00:00
  • 3da3c04f3a Tidy overly long configure help lines. Andrew Dunstan 2007-06-04 21:55:43 +00:00
  • 07bd1db152 Fix bundle bugs of GIN: - Fix possible deadlock between UPDATE and VACUUM queries. Bug never was observed in 8.2, but it still exist there. HEAD is more sensitive to bug after recent "ring" of buffer improvements. - Fix WAL creation: if parent page is stored as is after split then incomplete split isn't removed during replay. This happens rather rare, only on large tables with a lot of updates/inserts. - Fix WAL replay: there was wrong test of XLR_BKP_BLOCK_* for left page after deletion of page. That causes wrong rightlink field: it pointed to deleted page. - add checking of match of clearing incomplete split - cleanup incomplete split list after proceeding Teodor Sigaev 2007-06-04 15:59:20 +00:00
  • 853d1c3103 Fix bundle bugs of GIN: - Fix possible deadlock between UPDATE and VACUUM queries. Bug never was observed in 8.2, but it still exist there. HEAD is more sensitive to bug after recent "ring" of buffer improvements. - Fix WAL creation: if parent page is stored as is after split then incomplete split isn't removed during replay. This happens rather rare, only on large tables with a lot of updates/inserts. - Fix WAL replay: there was wrong test of XLR_BKP_BLOCK_* for left page after deletion of page. That causes wrong rightlink field: it pointed to deleted page. - add checking of match of clearing incomplete split - cleanup incomplete split list after proceeding Teodor Sigaev 2007-06-04 15:56:28 +00:00
  • 86c68fd0b2 Oops. Patch didn't work properly for 8.1, so don't backpatch a then-unused variable either. Magnus Hagander 2007-06-04 13:48:29 +00:00
  • 6209cb3f7d On win32, retry reading when WSARecv returns WSAEWOULDBLOCK. There seem to be cases when at least Windows 2000 can do this even though select just indicated that the socket is readable. Magnus Hagander 2007-06-04 13:39:41 +00:00
  • ca82953745 On win32, retry reading when WSARecv returns WSAEWOULDBLOCK. There seem to be cases when at least Windows 2000 can do this even though select just indicated that the socket is readable. Magnus Hagander 2007-06-04 13:39:34 +00:00
  • aae5403278 On win32, retry reading when WSARecv returns WSAEWOULDBLOCK. There seem to be cases when at least Windows 2000 can do this even though select just indicated that the socket is readable. Magnus Hagander 2007-06-04 13:39:28 +00:00
  • 0377d24fc5 On win32, don't use SO_REUSEADDR for TCP sockets. Magnus Hagander 2007-06-04 11:59:40 +00:00
  • cec960f2e3 On win32, don't use SO_REUSEADDR for TCP sockets. Magnus Hagander 2007-06-04 11:59:34 +00:00
  • 083094f34c On win32, don't use SO_REUSEADDR for TCP sockets. Magnus Hagander 2007-06-04 11:59:27 +00:00
  • 0e92f9813e On win32, don't use SO_REUSEADDR for TCP sockets. Magnus Hagander 2007-06-04 11:59:20 +00:00
  • 9539e64bc0 Remove gratuitous response messages from utility programs. Peter Eisentraut 2007-06-04 10:02:40 +00:00
  • efbd5bcb5a Update expected files for textual changes Peter Eisentraut 2007-06-04 07:48:17 +00:00
  • f4a3789b39 Clarify some error messages about duplicate things. Peter Eisentraut 2007-06-03 22:16:03 +00:00
  • 55477d742e Remove description for: Bruce Momjian 2007-06-03 18:49:28 +00:00