Commit Graph

  • cd0d50466f Rearrange use of plpgsql_add_initdatums() so that only the parsing of a DECLARE section needs to know about it. Formerly, everyplace besides DECLARE that created variables needed to do "plpgsql_add_initdatums(NULL)" to prevent those variables from being sucked up as part of a subsequent DECLARE block. This is obviously error-prone, and in fact the SQLSTATE/SQLERRM patch had failed to do it for those two variables, leading to the bug recently exhibited by Asif Ali Rehman: a DECLARE within an exception handler tried to reinitialize SQLERRM. Tom Lane 2007-02-08 18:37:52 +00:00
  • d1be38cc7d Fix an ancient logic error in plpgsql's exec_stmt_block: it thought it could get away with not (re)initializing a local variable if the variable is marked "isconst" and not "isnull". Unfortunately it makes this decision after having already freed the old value, meaning that something like Tom Lane 2007-02-08 18:37:43 +00:00
  • 799290b1c5 Rearrange use of plpgsql_add_initdatums() so that only the parsing of a DECLARE section needs to know about it. Formerly, everyplace besides DECLARE that created variables needed to do "plpgsql_add_initdatums(NULL)" to prevent those variables from being sucked up as part of a subsequent DECLARE block. This is obviously error-prone, and in fact the SQLSTATE/SQLERRM patch had failed to do it for those two variables, leading to the bug recently exhibited by Asif Ali Rehman: a DECLARE within an exception handler tried to reinitialize SQLERRM. Tom Lane 2007-02-08 18:37:38 +00:00
  • fe796ea8ac Fix an ancient logic error in plpgsql's exec_stmt_block: it thought it could get away with not (re)initializing a local variable if the variable is marked "isconst" and not "isnull". Unfortunately it makes this decision after having already freed the old value, meaning that something like Tom Lane 2007-02-08 18:37:30 +00:00
  • 7ad33cebfd Rearrange use of plpgsql_add_initdatums() so that only the parsing of a DECLARE section needs to know about it. Formerly, everyplace besides DECLARE that created variables needed to do "plpgsql_add_initdatums(NULL)" to prevent those variables from being sucked up as part of a subsequent DECLARE block. This is obviously error-prone, and in fact the SQLSTATE/SQLERRM patch had failed to do it for those two variables, leading to the bug recently exhibited by Asif Ali Rehman: a DECLARE within an exception handler tried to reinitialize SQLERRM. Tom Lane 2007-02-08 18:37:14 +00:00
  • b577aa9ebc Fix bug when localized to_char() day or month names were incorectly trnasformed to lower or upper string. Bruce Momjian 2007-02-08 18:19:33 +00:00
  • 760f4823e6 This patch fixes shared_preload_libraries on Windows hosts. It forces each backend to re-load all shared_preload_libraries. Bruce Momjian 2007-02-08 17:04:48 +00:00
  • a37b006d89 This patch fixes shared_preload_libraries on Windows hosts. It forces ach backend to re-load all shared_preload_libraries. Bruce Momjian 2007-02-08 15:46:04 +00:00
  • eea3749d2e Add lock matrix to documentation. Bruce Momjian 2007-02-08 15:32:11 +00:00
  • 6fea31b693 Win32 regression test fixes: Bruce Momjian 2007-02-08 15:28:58 +00:00
  • 51be14e928 Add /contrib/pg_standby: Bruce Momjian 2007-02-08 15:16:19 +00:00
  • 528779a2c6 Add /contrib/pg_standby: Bruce Momjian 2007-02-08 15:09:47 +00:00
  • f8ebab901b Fix reference-after-free in the new btree page split code, as reported by the buildfarm via Stefan Kaltenbrunner. Alvaro Herrera 2007-02-08 13:52:55 +00:00
  • 086c189456 Normalize fgets() calls to use sizeof() for calculating the buffer size where possible, and fix some sites that apparently thought that fgets() will overwrite the buffer by one byte. Peter Eisentraut 2007-02-08 11:10:27 +00:00
  • b79575ce45 Reduce WAL activity for page splits: Bruce Momjian 2007-02-08 05:05:53 +00:00
  • fe03a5f4ae Check if the role exists before doing more complex ident and Kerberos authentication checks in the backend. Bruce Momjian 2007-02-08 04:52:18 +00:00
  • e1c266493c Update URL for "Generalized Partial Indexes" paper to point to a cached version. Bruce Momjian 2007-02-08 04:31:41 +00:00
  • b227448d0b Update URL for "Generalized Partial Indexes" paper to point to a cached version. Bruce Momjian 2007-02-08 04:31:37 +00:00
  • 76f46f5cf6 Document that wal_sync_method open_* methods use O_DIRECT, if available. Bruce Momjian 2007-02-08 03:57:52 +00:00
  • d78f76896b Document that wal_sync_method open_* methods use O_DIRECT, if available. Bruce Momjian 2007-02-08 03:56:42 +00:00
  • 9e9e387ecf Fix bug in our code when using to_timestamp() or to_date() without "TM". Bruce Momjian 2007-02-08 03:22:28 +00:00
  • aec4cf1c8c Add a function pg_stat_clear_snapshot() that discards any statistics snapshot already collected in the current transaction; this allows plpgsql functions to watch for stats updates even though they are confined to a single transaction. Use this instead of the previous kluge involving pg_stat_file() to wait for the stats collector to update in the stats regression test. Internally, decouple storage of stats snapshots from transaction boundaries; they'll now stick around until someone calls pgstat_clear_snapshot --- which xact.c still does at transaction end, to maintain the previous behavior. This makes the logic a lot cleaner, at the price of a couple dozen cycles per transaction exit. Tom Lane 2007-02-07 23:11:30 +00:00
  • d9ce68872f Modify the stats regression test to delay until the stats file actually changes (with an upper limit of 30 seconds), and record the delay time in the postmaster log. This should give us some info about what's happening with the intermittent stats failures in buildfarm. After an idea of Andrew Dunstan's. Tom Lane 2007-02-07 18:34:56 +00:00
  • 78d1216160 Remove the xlog-centric "database system is ready" message and replace it with "database system is ready to accept connections", which is issued by the postmaster when it really is ready to accept connections. Per proposal from Markus Schiltknecht and subsequent discussion. Tom Lane 2007-02-07 16:44:48 +00:00
  • 53d7d49011 The VC++ build needs to compile the new strlcat.c file. Patch from Magnus Hagander. Alvaro Herrera 2007-02-07 13:37:42 +00:00
  • a3f9a054c1 Stamp bug template for 8.3. Bruce Momjian 2007-02-07 05:14:08 +00:00
  • d015e14880 Stamp releases notes for 8.2.3, 8.1.8, 8.0.12. REL8_2_3 Bruce Momjian 2007-02-07 04:23:01 +00:00
  • cf230f2299 Stamp releases notes for 8.2.3, 8.1.8, 8.0.12. Bruce Momjian 2007-02-07 04:22:44 +00:00
  • c0190adff9 Stamp releases notes for 8.2.3, 8.1.8, 8.0.12. REL8_1_8 Bruce Momjian 2007-02-07 04:22:25 +00:00
  • dc80902bcc Stamp releases notes for 8.2.3, 8.1.8, 8.0.12. REL8_0_12 Bruce Momjian 2007-02-07 04:22:08 +00:00
  • 18b0d7de09 Fix PG_VERSION_NUM too. Tom Lane 2007-02-07 03:59:30 +00:00
  • 5921066de4 Fix wrong spacing (I think Bruce tried to hand-edit this instead of letting autoconf do it) Tom Lane 2007-02-07 03:53:53 +00:00
  • 98e08d1aa0 Stamp releases 8.2.3, 8.1.8, 8.0.12. No release notes yet. Bruce Momjian 2007-02-07 03:48:58 +00:00
  • 94bf5466b0 Stamp releases 8.2.3, 8.1.8, 8.0.12. No release notes yet. Bruce Momjian 2007-02-07 03:48:38 +00:00
  • 8cbd1c3ba8 Stamp releases 8.2.3, 8.1.8, 8.0.12. No release notes yet. Bruce Momjian 2007-02-07 03:48:21 +00:00
  • 0b36bbf8f2 Update FAQ for 8.2.3. Bruce Momjian 2007-02-07 03:16:59 +00:00
  • ced5269a8b Update for 8.2.3. Bruce Momjian 2007-02-07 03:16:22 +00:00
  • 16059d39a0 Replace some strncpy() by strlcpy(). Peter Eisentraut 2007-02-07 00:52:35 +00:00
  • f11aa82d03 Use memcpy() instead of strncpy() for copying into varlena structures. Peter Eisentraut 2007-02-07 00:32:15 +00:00
  • 4f64a07bee Add strlcat() from OpenBSD, to be used for replacing strncat and other strange coding practices. Peter Eisentraut 2007-02-07 00:28:55 +00:00
  • dec65c9421 Fix an error in the original coding of holdable cursors: PersistHoldablePortal thought that it didn't have to reposition the underlying tuplestore if the portal is atEnd. But this is not so, because tuplestores have separate read and write cursors ... and the read cursor hasn't moved from the start. This mistake explains bug #2970 from William Zhang. Tom Lane 2007-02-06 22:49:48 +00:00
  • bb65d51c2e Fix an error in the original coding of holdable cursors: PersistHoldablePortal thought that it didn't have to reposition the underlying tuplestore if the portal is atEnd. But this is not so, because tuplestores have separate read and write cursors ... and the read cursor hasn't moved from the start. This mistake explains bug #2970 from William Zhang. Tom Lane 2007-02-06 22:49:42 +00:00
  • e41cb89a03 Fix an error in the original coding of holdable cursors: PersistHoldablePortal thought that it didn't have to reposition the underlying tuplestore if the portal is atEnd. But this is not so, because tuplestores have separate read and write cursors ... and the read cursor hasn't moved from the start. This mistake explains bug #2970 from William Zhang. Tom Lane 2007-02-06 22:49:36 +00:00
  • 04dc48b528 Fix an error in the original coding of holdable cursors: PersistHoldablePortal thought that it didn't have to reposition the underlying tuplestore if the portal is atEnd. But this is not so, because tuplestores have separate read and write cursors ... and the read cursor hasn't moved from the start. This mistake explains bug #2970 from William Zhang. Tom Lane 2007-02-06 22:49:30 +00:00
  • 5b706ba481 Fix an error in the original coding of holdable cursors: PersistHoldablePortal thought that it didn't have to reposition the underlying tuplestore if the portal is atEnd. But this is not so, because tuplestores have separate read and write cursors ... and the read cursor hasn't moved from the start. This mistake explains bug #2970 from William Zhang. Tom Lane 2007-02-06 22:49:24 +00:00
  • b93d4a75a0 Backpatch FAQs to 8.2.X branch. Bruce Momjian 2007-02-06 18:38:04 +00:00
  • 09f9553daf Update for 8.2.2 as most recent release. Bruce Momjian 2007-02-06 18:36:26 +00:00
  • 63b7afbe4f Update workding for daylight savings time. Bruce Momjian 2007-02-06 18:33:20 +00:00
  • a85a290dad Update timezone FAQ item: Bruce Momjian 2007-02-06 18:31:26 +00:00
  • 122680c514 Remove typmod checking from the recent security-related patches. It turns out that ExecEvalVar and friends don't necessarily have access to a tuple descriptor with correct typmod: it definitely can contain -1, and possibly might contain other values that are different from the Var's value. Arguably this should be cleaned up someday, but it's not a simple change, and in any case typmod discrepancies don't pose a security hazard. Per reports from numerous people :-( Tom Lane 2007-02-06 17:35:41 +00:00
  • c60125a9be Remove typmod checking from the recent security-related patches. It turns out that ExecEvalVar and friends don't necessarily have access to a tuple descriptor with correct typmod: it definitely can contain -1, and possibly might contain other values that are different from the Var's value. Arguably this should be cleaned up someday, but it's not a simple change, and in any case typmod discrepancies don't pose a security hazard. Per reports from numerous people :-( Tom Lane 2007-02-06 17:35:34 +00:00
  • 8d24b8bd7a Remove typmod checking from the recent security-related patches. It turns out that ExecEvalVar and friends don't necessarily have access to a tuple descriptor with correct typmod: it definitely can contain -1, and possibly might contain other values that are different from the Var's value. Arguably this should be cleaned up someday, but it's not a simple change, and in any case typmod discrepancies don't pose a security hazard. Per reports from numerous people :-( Tom Lane 2007-02-06 17:35:27 +00:00
  • a8c3f161fb Remove typmod checking from the recent security-related patches. It turns out that ExecEvalVar and friends don't necessarily have access to a tuple descriptor with correct typmod: it definitely can contain -1, and possibly might contain other values that are different from the Var's value. Arguably this should be cleaned up someday, but it's not a simple change, and in any case typmod discrepancies don't pose a security hazard. Per reports from numerous people :-( Tom Lane 2007-02-06 17:35:20 +00:00
  • 869585cc8f Split apart entries, one done now: Bruce Momjian 2007-02-06 16:44:14 +00:00
  • 28c3cd5c1c Fix typo in comment. Tom Lane 2007-02-06 16:20:23 +00:00
  • c76ed81513 Remove some dead code, per Heikki. Tom Lane 2007-02-06 14:55:11 +00:00
  • 33623b51b6 Backported regression test changes from HEAD so the buildfarm hopefully gets green again. Michael Meskes 2007-02-06 10:48:28 +00:00
  • 2d28b69000 Backported va_list handling cleanup Michael Meskes 2007-02-06 09:42:08 +00:00
  • 7fd912e854 Backported va_list handling cleanup Michael Meskes 2007-02-06 09:41:52 +00:00
  • b8dd3a8604 Backported va_list handling cleanup Michael Meskes 2007-02-06 09:41:44 +00:00
  • 037f8413fa Move NAMEDATALEN definition from postgres_ext.h to pg_config_manual.h. It used to be part of libpq's exported interface many releases ago, but now it's no longer necessary to make it accessible to clients. Peter Eisentraut 2007-02-06 09:16:08 +00:00
  • a95abdf856 Fix a performance regression in 8.2: optimization of MIN/MAX into indexscans had stopped working for tables buried inside views or sub-selects. This is because I had gotten rid of the simplify_jointree() preprocessing step, and optimize_minmax_aggregates() wasn't smart enough to deal with a non-canonical FromExpr. Per gripe from Bill Howe. Tom Lane 2007-02-06 06:50:33 +00:00
  • 56e59edd75 Fix a performance regression in 8.2: optimization of MIN/MAX into indexscans had stopped working for tables buried inside views or sub-selects. This is because I had gotten rid of the simplify_jointree() preprocessing step, and optimize_minmax_aggregates() wasn't smart enough to deal with a non-canonical FromExpr. Per gripe from Bill Howe. Tom Lane 2007-02-06 06:50:26 +00:00
  • 91e18dbbcc Docs updates for cross-type hashing. Tom Lane 2007-02-06 04:38:31 +00:00
  • 8076c8c7f0 Come to think of it, we should check that commutator pairs have the same merges/hashes property settings. Tom Lane 2007-02-06 03:52:59 +00:00
  • 5338847fcd Not only did we agree that this 'hint' doesn't belong here, but the markup's broken. So just remove it... Tom Lane 2007-02-06 03:05:00 +00:00
  • b259924e9f Not only did we agree that this 'hint' doesn't belong here, but the markup's broken. So just remove it... Tom Lane 2007-02-06 03:03:11 +00:00
  • ab05eedecc Add support for cross-type hashing in hashed subplans (hashed IN/NOT IN cases that aren't turned into true joins). Since this is the last missing bit of infrastructure, go ahead and fill out the hash integer_ops and float_ops opfamilies with cross-type operators. The operator family project is now DONE ... er, except for documentation ... Tom Lane 2007-02-06 02:59:15 +00:00
  • de9acc94f1 Trim down environment variable instructions for Win32, backpatch to 8.2.X. Bruce Momjian 2007-02-05 22:18:18 +00:00
  • b70e536e4d Trim down environment variable instructions for Win32, backpatch to 8.2.X. Bruce Momjian 2007-02-05 22:18:11 +00:00
  • fdd4a1ff0d Updated TODO item: Bruce Momjian 2007-02-05 17:17:13 +00:00
  • fcbddea8b7 Modify: Bruce Momjian 2007-02-05 16:49:13 +00:00
  • e7c63e522c Pass modern COPY syntax to backend, since copy (query) does not accept old syntax. Per complaint from Michael Fuhr. Andrew Dunstan 2007-02-05 15:23:24 +00:00
  • 00ade1dfcf Pass modern COPY syntax to backend, since copy (query) does not accept old syntax. Per complaint from Michael Fuhr. Andrew Dunstan 2007-02-05 15:22:18 +00:00
  • 23c4978e6c Rename MaxTupleSize to MaxHeapTupleSize to clarify that it's not meant to describe the maximum size of index tuples (which is typically AM-dependent anyway); and consequently remove the bogus deduction for "special space" that was built into it. Tom Lane 2007-02-05 04:22:18 +00:00
  • 54111e9511 Don't MAXALIGN in the checks to decide whether a tuple is over TOAST's threshold for tuple length. On 4-byte-MAXALIGN machines, the toast code creates tuples that have t_len exactly TOAST_TUPLE_THRESHOLD ... but this number is not itself maxaligned, so if heap_insert maxaligns t_len before comparing to TOAST_TUPLE_THRESHOLD, it'll uselessly recurse back to tuptoaster.c, wasting cycles. (It turns out that this does not happen on 8-byte-MAXALIGN machines, because for them the outer MAXALIGN in the TOAST_MAX_CHUNK_SIZE macro reduces TOAST_MAX_CHUNK_SIZE so that toast tuples will be less than TOAST_TUPLE_THRESHOLD in size. That MAXALIGN is really incorrect, but we can't remove it now, see below.) There isn't any particular value in maxaligning before comparing to the thresholds, so just don't do that, which saves a small number of cycles in itself. Tom Lane 2007-02-04 20:00:49 +00:00
  • a2e092e1c7 Don't MAXALIGN in the checks to decide whether a tuple is over TOAST's threshold for tuple length. On 4-byte-MAXALIGN machines, the toast code creates tuples that have t_len exactly TOAST_TUPLE_THRESHOLD ... but this number is not itself maxaligned, so if heap_insert maxaligns t_len before comparing to TOAST_TUPLE_THRESHOLD, it'll uselessly recurse back to tuptoaster.c, wasting cycles. (It turns out that this does not happen on 8-byte-MAXALIGN machines, because for them the outer MAXALIGN in the TOAST_MAX_CHUNK_SIZE macro reduces TOAST_MAX_CHUNK_SIZE so that toast tuples will be less than TOAST_TUPLE_THRESHOLD in size. That MAXALIGN is really incorrect, but we can't remove it now, see below.) There isn't any particular value in maxaligning before comparing to the thresholds, so just don't do that, which saves a small number of cycles in itself. Tom Lane 2007-02-04 20:00:37 +00:00
  • 03d442ca60 Add: Bruce Momjian 2007-02-04 04:06:08 +00:00
  • e5352a2556 Update wording. Bruce Momjian 2007-02-04 04:00:33 +00:00
  • 1a476a6145 Update wording. Bruce Momjian 2007-02-04 04:00:28 +00:00
  • 1015fd53b6 Add documentation for Windows on how to set an environment variable. Backpatch to 8.2.X. Bruce Momjian 2007-02-04 03:58:58 +00:00
  • 43aa1e59f5 Add documentation for Windows on how to set an environment variable. Backpatch to 8.2.X. Bruce Momjian 2007-02-04 03:55:51 +00:00
  • c29a0bd52c Change vacuum lazy "compacting" warning message to: Bruce Momjian 2007-02-04 03:10:55 +00:00
  • 1d6653ee80 Update URL for: Bruce Momjian 2007-02-04 02:32:03 +00:00
  • 28019984e9 Add: Bruce Momjian 2007-02-04 01:50:59 +00:00
  • 300c43e303 Add URLs for: Bruce Momjian 2007-02-03 23:52:19 +00:00
  • d68f1ecbe2 Document that a client-only install using: Bruce Momjian 2007-02-03 23:01:13 +00:00
  • 1a641c0cee Document that a client-only install using: Bruce Momjian 2007-02-03 23:01:06 +00:00
  • b6f6284802 Add: Bruce Momjian 2007-02-03 22:32:49 +00:00
  • 4c488e857e Update SQL conformance information about XML features. Peter Eisentraut 2007-02-03 17:59:36 +00:00
  • f0083ccfde Use -Wl for linker switches on freebsd --- back-port of an 8.0 change. I think this will make buildfarm member herring go green in this branch. Tom Lane 2007-02-03 17:27:11 +00:00
  • ec020e1ceb Implement XMLSERIALIZE for real. Analogously, make the xml to text cast observe the xmloption. Peter Eisentraut 2007-02-03 14:06:56 +00:00
  • 554d3a683c Fix configure detection code when --with-ldap and --enable-thread-safety are both used. Bruce Momjian 2007-02-03 02:47:35 +00:00
  • 25dc46334b Fix configure detection code when --with-ldap and --enable-thread-safety are both used. Bruce Momjian 2007-02-03 02:43:38 +00:00
  • b1b9c364cc Add patches thread for: Bruce Momjian 2007-02-03 01:59:27 +00:00
  • 635425d845 Add URL for: Bruce Momjian 2007-02-02 23:05:36 +00:00
  • 69b90c49bc Add: Bruce Momjian 2007-02-02 22:55:08 +00:00
  • 99be3fa3ee Add URL for: Bruce Momjian 2007-02-02 21:34:39 +00:00
  • b587bafef1 This patch changes the installscript for vcbuild to actually parse the generated solution files for what to install, instead of blindly copying everything as it previously did. With the previous quick-n-dirty version, it would copy old DLLs if you reconfigured in a way that didn't include subprojects like a PL for example. Neil Conway 2007-02-02 16:25:34 +00:00
  • 2f92bea3a5 Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32 under Windows. Per Magnus Hagander, this is not recommended. Neil Conway 2007-02-02 16:10:18 +00:00