Commit Graph

  • 3ef151e0b7 Fix pg_restore -n option to do what the man page says it does. The original coding only worked if one of the selTypes restriction options was also given. Per report from Nick Johnson. Tom Lane 2006-04-12 22:18:48 +00:00
  • 1cae920e32 Change int->int32, for clarity. Bruce Momjian 2006-04-12 21:46:31 +00:00
  • 6ae559daf8 Add, "How do I submit a patch" FAQ item. Bruce Momjian 2006-04-12 20:03:54 +00:00
  • 4f6039de6e Add second sentence: <P>The maximum table size, row size, and maximum number of columns can be quadrupled by increasing the default block size to 32k. The maximum table size can also be increased using table partitioning.</P> Bruce Momjian 2006-04-12 18:56:16 +00:00
  • a5884d5dc8 Updated Japanese FAQ, version 2. Bruce Momjian 2006-04-11 21:23:28 +00:00
  • 031e3c8b84 Updated Japanese FAQ, version 2. Bruce Momjian 2006-04-11 21:21:52 +00:00
  • 5052aa2edb Update Japanese FAQ, backpatch. Bruce Momjian 2006-04-11 21:19:05 +00:00
  • f54a070268 Update Japanese FAQ, backpatch. Bruce Momjian 2006-04-11 21:18:03 +00:00
  • cc1b59c951 Oops, sysctl, not sysconf, for FreeBSD. Bruce Momjian 2006-04-11 21:06:19 +00:00
  • ef5fde0881 Oops, sysctl, not sysconf, for FreeBSD. Bruce Momjian 2006-04-11 21:04:52 +00:00
  • 6d06003fbf Fix typo. Neil Conway 2006-04-11 20:26:40 +00:00
  • e860973aed More FreeBSD jail wording improvements. Bruce Momjian 2006-04-11 19:46:48 +00:00
  • 7626181bf7 More FreeBSD jail wording improvements. Bruce Momjian 2006-04-11 19:45:33 +00:00
  • cc7b6c75e3 Update jail wording to mention non-root users. Bruce Momjian 2006-04-11 19:42:27 +00:00
  • 493eea649c Add documentation about running postmasters in FreeBSD jails (use separate users). Bruce Momjian 2006-04-11 19:28:03 +00:00
  • ba60acf17e Add documentation about running postmasters in FreeBSD jails (use separate users). Bruce Momjian 2006-04-11 19:26:42 +00:00
  • 36d5976f9e There is updated Russian translation of the FAQ in the attachment. Bruce Momjian 2006-04-11 15:49:04 +00:00
  • fac2ba5da3 There is updated Russian translation of the FAQ in the attachment. Bruce Momjian 2006-04-11 15:48:11 +00:00
  • 3f040b1ff8 Done, per Tom: Bruce Momjian 2006-04-11 02:08:19 +00:00
  • 857b0cd127 Add: Bruce Momjian 2006-04-10 23:15:46 +00:00
  • 2f9b3ef7be Suppress unused-variable warning on platforms without HAVE_SYSLOG. Magnus Tom Lane 2006-04-10 21:53:38 +00:00
  • e7101b6b82 Add: Bruce Momjian 2006-04-10 21:06:23 +00:00
  • e30df619cd Fix stupid mistake in rank_cd_def cleanup Teodor Sigaev 2006-04-10 09:56:52 +00:00
  • 848692131a Fix another const-decoration mismatch, per Magnus. Tom Lane 2006-04-09 22:01:19 +00:00
  • a894a83381 Add comment for why we recompile pgport C files. Bruce Momjian 2006-04-09 20:27:27 +00:00
  • fb2b198609 Add: Bruce Momjian 2006-04-09 20:24:30 +00:00
  • 513ec43ebd Suppress a couple of minor compiler warnings, per Magnus. Tom Lane 2006-04-09 19:21:34 +00:00
  • d329913c9c Revert my best_inner_indexscan patch of yesterday, which turns out to have had a bad side-effect: it stopped finding plans that involved BitmapAnd combinations of indexscans using both join and non-join conditions. Instead, make choose_bitmap_and more aggressive about detecting redundancies between BitmapOr subplans. Tom Lane 2006-04-09 18:18:59 +00:00
  • a81e281636 Revert my best_inner_indexscan patch of yesterday, which turns out to have had a bad side-effect: it stopped finding plans that involved BitmapAnd combinations of indexscans using both join and non-join conditions. Instead, make choose_bitmap_and more aggressive about detecting redundancies between BitmapOr subplans. Tom Lane 2006-04-09 18:18:41 +00:00
  • 83843a4439 Update: Bruce Momjian 2006-04-09 03:27:06 +00:00
  • 89d75c56db Fix best_inner_indexscan to actually enforce that an "inner indexscan" use at least one join condition as an indexqual. Before bitmap indexscans, this oversight didn't really cost much except for redundantly considering the same join paths twice; but as of 8.1 it could result in silly bitmap scans that would do the same BitmapOr twice and then BitmapAnd these together :-( Tom Lane 2006-04-08 21:32:25 +00:00
  • 898eb25431 Fix best_inner_indexscan to actually enforce that an "inner indexscan" use at least one join condition as an indexqual. Before bitmap indexscans, this oversight didn't really cost much except for redundantly considering the same join paths twice; but as of 8.1 it could result in silly bitmap scans that would do the same BitmapOr twice and then BitmapAnd these together :-( Tom Lane 2006-04-08 21:32:17 +00:00
  • c6e81aeef3 Fix EXPLAIN so that it can drill down through multiple levels of subplan when trying to locate the referent of a RECORD variable. This fixes the 'record type has not been registered' failure reported by Stefan Kaltenbrunner about a month ago. A side effect of the way I chose to fix it is that most variable references in join conditions will now be properly labeled with the variable's source table name, instead of the not-too-helpful 'outer' or 'inner' we used to use. Tom Lane 2006-04-08 18:49:52 +00:00
  • cd360f2484 Fix pg_dumpall to do something sane when a pre-8.1 installation has identically named user and group: we merge these into a single entity with LOGIN permission. Also, add ORDER BY commands to ensure consistent dump ordering, for ease of comparing outputs from different installations. Tom Lane 2006-04-07 21:26:42 +00:00
  • 74bdf965a6 Fix pg_dumpall to do something sane when a pre-8.1 installation has identically named user and group: we merge these into a single entity with LOGIN permission. Also, add ORDER BY commands to ensure consistent dump ordering, for ease of comparing outputs from different installations. Tom Lane 2006-04-07 21:26:29 +00:00
  • 39ec43a271 Revert getaddrinfo configure changes until we get a solution that is properly tested on Tru64 - pre recent discussion (or lack thereof) on -hackers. Andrew Dunstan 2006-04-07 17:50:03 +00:00
  • a9351518a7 Revert getaddrinfo configure changes until we get a solution that is properly tested on Tru64 - pre recent discussion (or lack thereof) on -hackers. Andrew Dunstan 2006-04-07 17:42:50 +00:00
  • 23c6f11b09 Fix make_restrictinfo_from_bitmapqual() to preserve AND/OR flatness of its output, ie, no OR immediately below an OR. Otherwise we get Asserts or wrong answers for cases such as select * from tenk1 a, tenk1 b where (a.ten = b.ten and (a.unique1 = 100 or a.unique1 = 101)) or (a.hundred = b.hundred and a.unique1 = 42); Per report from Rafael Martinez Guerrero. Tom Lane 2006-04-07 17:05:47 +00:00
  • 2f8a7bf290 Fix make_restrictinfo_from_bitmapqual() to preserve AND/OR flatness of its output, ie, no OR immediately below an OR. Otherwise we get Asserts or wrong answers for cases such as select * from tenk1 a, tenk1 b where (a.ten = b.ten and (a.unique1 = 100 or a.unique1 = 101)) or (a.hundred = b.hundred and a.unique1 = 42); Per report from Rafael Martinez Guerrero. Tom Lane 2006-04-07 17:05:39 +00:00
  • 0914ae1c14 Remove the pgstats logic for delaying destruction of stats table entries. Per recent discussion, this seems to be making the stats less accurate rather than more so, particularly on Windows where PID values may be reused very quickly. Patch by Peter Brant. Tom Lane 2006-04-06 20:38:00 +00:00
  • 0bc2a8ca65 Build src/test/regress/README during tarball making like the other generated text files. Fix build of that file, too. Peter Eisentraut 2006-04-06 18:54:37 +00:00
  • 69ab90c775 Update AIX FAQ to show readline options more clearly. Bruce Momjian 2006-04-05 22:56:12 +00:00
  • 9e0eff05ca Update AIX FAQ to show readline options more clearly. Bruce Momjian 2006-04-05 22:55:05 +00:00
  • 7fdb4305db Fix a bunch of problems with domains by making them use special input functions that apply the necessary domain constraint checks immediately. This fixes cases where domain constraints went unchecked for statement parameters, PL function local variables and results, etc. We can also eliminate existing special cases for domains in places that had gotten it right, eg COPY. Tom Lane 2006-04-05 22:11:58 +00:00
  • 89a67e523e When merging PO files, take into consideration translations in other PO files of the same languages. That way, similar or equal translations in different programs are automatically propagated and the life of translators becomes a little bit easier. Peter Eisentraut 2006-04-05 13:40:15 +00:00
  • 09b5271ebd Add a field to the first page of each WAL file to indicate the XLOG_BLCKSZ. This ought to help in preventing configuration mismatch problems if anyone tries to ship PITR files between servers compiled with different XLOG_BLCKSZ settings. Simon Riggs Tom Lane 2006-04-05 03:34:05 +00:00
  • e6140d9052 Don't use BLCKSZ for the physical length of the pg_control file, but instead a dedicated symbol. This probably makes no functional difference for likely values of BLCKSZ, but it makes the intent clearer. Simon Riggs, minor editorialization by Tom Lane. Tom Lane 2006-04-04 22:39:59 +00:00
  • 147d4bf3e5 Modify all callers of datatype input and receive functions so that if these functions are not strict, they will be called (passing a NULL first parameter) during any attempt to input a NULL value of their datatype. Currently, all our input functions are strict and so this commit does not change any behavior. However, this will make it possible to build domain input functions that centralize checking of domain constraints, thereby closing numerous holes in our domain support, as per previous discussion. Tom Lane 2006-04-04 19:35:37 +00:00
  • eaef111396 Define a separately configurable XLOG_BLCKSZ symbol for the page size used within WAL files. Historically this was the same as the data file BLCKSZ, but there's no necessary connection, and it's possible that performance gains might ensue from reducing XLOG_BLCKSZ. In any case distinguishing two symbols should improve code clarity. This commit does not actually change the page size, only provide the infrastructure to make it possible to do so. initdb forced because of addition of a field to pg_control. Mark Wong, with some help from Simon Riggs and Tom Lane. Tom Lane 2006-04-03 23:35:05 +00:00
  • c8c864c261 Put flex'ed and bison'ed files in contrib in the distribution tarball, as is done for the analogous files in the main distribution. Peter Eisentraut 2006-04-03 18:47:41 +00:00
  • c9a2b6d4ca Fix thinko in gistRedoPageUpdateRecord: if XLR_BKP_BLOCK_1 is set, we don't have anything to do to the page, but we still have to adjust the incomplete_inserts list that we're maintaining in memory. Tom Lane 2006-04-03 16:45:50 +00:00
  • 8d02b15e33 Eliminate ajust scan code. Since concurrent GiST it doesn't do real work. That was missed during concurrence development. Teodor Sigaev 2006-04-03 13:44:33 +00:00
  • 2ba15dbfc3 Detoast query in g_intbig_consistent and copy query in g_int_consistent. Minor cleanups. Teodor Sigaev 2006-04-03 10:45:28 +00:00
  • e314c3f53f Detoast query in g_intbig_consistent and copy query in g_int_consistent. Minor cleanups. Teodor Sigaev 2006-04-03 10:27:28 +00:00
  • 06e4478877 Detoast query in g_intbig_consistent and copy query in g_int_consistent. Minor cleanups. Teodor Sigaev 2006-04-03 09:35:35 +00:00
  • cdfecf6e3e Minor cleanups Teodor Sigaev 2006-04-03 08:37:41 +00:00
  • 7f129956e1 Detoast query in g_intbig_consistent and copy query in g_int_consistent Teodor Sigaev 2006-04-03 08:21:05 +00:00
  • ef524d1775 Add to qsort TODO.detail. Bruce Momjian 2006-04-03 03:46:16 +00:00
  • 97ae541cf4 Update for max row size. Bruce Momjian 2006-04-03 03:40:20 +00:00
  • 713cc92531 Update max row size to 400gb, per Tom. Bruce Momjian 2006-04-03 03:39:23 +00:00
  • 7815ca7bef Rewrite much of psql's \connect code, for the sake of code clarity and to fix regressions introduced in the recent patch adding additional \connect options. This is based on work by Volkan YAZICI, although this version of the patch doesn't bear much resemblance to Volkan's version. Neil Conway 2006-04-02 20:08:22 +00:00
  • e88d84b737 Adjust interval-addition test so that it won't fail on DST transition days. Strange that we missed this DST dependence while fixing the others. Tom Lane 2006-04-02 19:40:02 +00:00
  • 23a1f015e5 Adjust interval-addition test so that it won't fail on DST transition days. Strange that we missed this DST dependence while fixing the others. Tom Lane 2006-04-02 19:39:54 +00:00
  • f7ae90041e Update information schema for SQL:2003 and new PostgreSQL features. Peter Eisentraut 2006-04-02 17:38:13 +00:00
  • 643b022bed Add tab-completion for REASSIGN OWNED BY and DROP OWNED BY. Also fix some whitespace issues nearby. Alvaro Herrera 2006-04-02 09:02:41 +00:00
  • d73336f8f4 Correct some errors and do some SGML police work on the reference pages for REASSIGN OWNED and DROP OWNED. Neil Conway 2006-04-02 04:02:40 +00:00
  • a619e068d3 Minor improvement to DROP TABLE reference page. Neil Conway 2006-04-02 03:56:40 +00:00
  • 0220282266 Add recent /port/qsort comparison discussion. Bruce Momjian 2006-04-02 01:27:42 +00:00
  • 89bda95d82 Remove the 'slow' path for btree index build, which built the btree incrementally by successive inserts rather than by sorting the data. We were only using the slow path during bootstrap, apparently because when first written it failed during bootstrap --- but it works fine now AFAICT. Removing it saves a hundred or so lines of code and produces noticeably (~10%) smaller initial states of the system catalog indexes. While that won't make much difference for heavily-modified catalogs, for the more static ones there may be a useful long-term performance improvement. Tom Lane 2006-04-01 03:03:37 +00:00
  • a8b8f4db23 Clean up WAL/buffer interactions as per my recent proposal. Get rid of the misleadingly-named WriteBuffer routine, and instead require routines that change buffer pages to call MarkBufferDirty (which does exactly what it says). We also require that they do so before calling XLogInsert; this takes care of the synchronization requirement documented in SyncOneBuffer. Note that because bufmgr takes the buffer content lock (in shared mode) while writing out any buffer, it doesn't matter whether MarkBufferDirty is executed before the buffer content change is complete, so long as the content change is completed before releasing exclusive lock on the buffer. So it's OK to set the dirtybit before we fill in the LSN. This eliminates the former kluge of needing to set the dirtybit in LockBuffer. Aside from making the code more transparent, we can also add some new debugging assertions, in particular that the caller of MarkBufferDirty must hold the buffer content lock, not merely a pin. Tom Lane 2006-03-31 23:32:07 +00:00
  • 89395bfa6f Improve gist XLOG code to follow the coding rules needed to prevent torn-page problems. This introduces some issues of its own, mainly that there are now some critical sections of unreasonably broad scope, but it's a step forward anyway. Further cleanup will require some code refactoring that I'd prefer to get Oleg and Teodor involved in. Tom Lane 2006-03-30 23:03:10 +00:00
  • 21b54ed81a Suppress attempts to report dropped tables to the stats collector from a startup or recovery process. Since such a process isn't a real backend, pgstat.c gets confused. This accounts for recent reports of strange "invalid server process ID -1" log messages during crash recovery. There isn't any point in attempting to make the report, since we'll discard stats in such scenarios anyhow. Tom Lane 2006-03-30 22:11:59 +00:00
  • 4243f2387a Suppress attempts to report dropped tables to the stats collector from a startup or recovery process. Since such a process isn't a real backend, pgstat.c gets confused. This accounts for recent reports of strange "invalid server process ID -1" log messages during crash recovery. There isn't any point in attempting to make the report, since we'll discard stats in such scenarios anyhow. Tom Lane 2006-03-30 22:11:55 +00:00
  • bee34e9930 Fix bad SQL, per Stefan Kaltenbrunner. Andrew Dunstan 2006-03-30 01:08:15 +00:00
  • 6d61cdec07 Clean up and document the API for XLogOpenRelation and XLogReadBuffer. This commit doesn't make much functional change, but it does eliminate some duplicated code --- for instance, PageIsNew tests are now done inside XLogReadBuffer rather than by each caller. The GIST xlog code still needs a lot of love, but I'll worry about that separately. Tom Lane 2006-03-29 21:17:39 +00:00
  • 1750f60ef3 TablespaceCreateDbspace should function normally even on platforms that do not have symlinks (ie, Windows). Although it'll never be called on to do anything useful during normal operation on such a platform, it's still needed to re-create dropped directories during WAL replay. Tom Lane 2006-03-29 15:16:00 +00:00
  • c119cdcab0 TablespaceCreateDbspace should function normally even on platforms that do not have symlinks (ie, Windows). Although it'll never be called on to do anything useful during normal operation on such a platform, it's still needed to re-create dropped directories during WAL replay. Tom Lane 2006-03-29 15:15:50 +00:00
  • 2154e1c11e TablespaceCreateDbspace should function normally even on platforms that do not have symlinks (ie, Windows). Although it'll never be called on to do anything useful during normal operation on such a platform, it's still needed to re-create dropped directories during WAL replay. Tom Lane 2006-03-29 15:15:43 +00:00
  • fdc28fdcfa Disable full_page_writes, because turning it off risks causing crash-recovery failures even when the hardware and OS did nothing wrong. Per recent analysis of a problem report from Alex Bahdushka. Tom Lane 2006-03-28 22:01:25 +00:00
  • 0a971e2f20 Disable full_page_writes, because turning it off risks causing crash-recovery failures even when the hardware and OS did nothing wrong. Per recent analysis of a problem report from Alex Bahdushka. Tom Lane 2006-03-28 22:01:16 +00:00
  • e243ba23d3 Repair longstanding error in btree xlog replay: XLogReadBuffer should be passed extend = true whenever we are reading a page we intend to reinitialize completely, even if we think the page "should exist". This is because it might indeed not exist, if the relation got truncated sometime after the current xlog record was made and before the crash we're trying to recover from. These two thinkos appear to explain both of the old bug reports discussed here: http://archives.postgresql.org/pgsql-hackers/2005-05/msg01369.php Tom Lane 2006-03-28 21:17:58 +00:00
  • b5c5c5d283 Repair longstanding error in btree xlog replay: XLogReadBuffer should be passed extend = true whenever we are reading a page we intend to reinitialize completely, even if we think the page "should exist". This is because it might indeed not exist, if the relation got truncated sometime after the current xlog record was made and before the crash we're trying to recover from. These two thinkos appear to explain both of the old bug reports discussed here: http://archives.postgresql.org/pgsql-hackers/2005-05/msg01369.php Tom Lane 2006-03-28 21:17:44 +00:00
  • 3c3ed28c75 Repair longstanding error in btree xlog replay: XLogReadBuffer should be passed extend = true whenever we are reading a page we intend to reinitialize completely, even if we think the page "should exist". This is because it might indeed not exist, if the relation got truncated sometime after the current xlog record was made and before the crash we're trying to recover from. These two thinkos appear to explain both of the old bug reports discussed here: http://archives.postgresql.org/pgsql-hackers/2005-05/msg01369.php Tom Lane 2006-03-28 21:17:31 +00:00
  • 288551fc60 Repair longstanding error in btree xlog replay: XLogReadBuffer should be passed extend = true whenever we are reading a page we intend to reinitialize completely, even if we think the page "should exist". This is because it might indeed not exist, if the relation got truncated sometime after the current xlog record was made and before the crash we're trying to recover from. These two thinkos appear to explain both of the old bug reports discussed here: http://archives.postgresql.org/pgsql-hackers/2005-05/msg01369.php Tom Lane 2006-03-28 21:17:23 +00:00
  • df7b5f5734 Comments in IndexBuildHeapScan describe the indexing of recently-dead tuples as needed "to keep VACUUM from complaining", but actually there is a more compelling reason to do it: failure to do so violates MVCC semantics. This is because a pre-existing serializable transaction might try to use the index after we finish (re)building it, and it might fail to find tuples it should be able to see. We got this mostly right, but not in the case of partial indexes: the code mistakenly discarded recently-dead tuples for partial indexes. Fix that, and adjust the comments. Tom Lane 2006-03-24 23:02:23 +00:00
  • 4e7d10c7cd Comments in IndexBuildHeapScan describe the indexing of recently-dead tuples as needed "to keep VACUUM from complaining", but actually there is a more compelling reason to do it: failure to do so violates MVCC semantics. This is because a pre-existing serializable transaction might try to use the index after we finish (re)building it, and it might fail to find tuples it should be able to see. We got this mostly right, but not in the case of partial indexes: the code mistakenly discarded recently-dead tuples for partial indexes. Fix that, and adjust the comments. Tom Lane 2006-03-24 23:02:17 +00:00
  • 0a20207060 Arrange to emit a description of the current XLOG record as error context when an error occurs during xlog replay. Also, replace the former risky 'write into a fixed-size buffer with no overflow detection' API for XLOG record description routines; use an expansible StringInfo instead. (The latter accounts for most of the patch bulk.) Tom Lane 2006-03-24 04:32:13 +00:00
  • db61437b27 Fix plpgsql to pass only one copy of any given plpgsql variable into a SQL command or expression, rather than one copy for each textual occurrence as it did before. This might result in some small performance improvement, but the compelling reason to do it is that not doing so can result in unexpected grouping failures because the main SQL parser won't see different parameter numbers as equivalent. Add a regression test for the failure case. Per report from Robert Davidson. Tom Lane 2006-03-23 04:22:45 +00:00
  • 4fb92718be Fix plpgsql to pass only one copy of any given plpgsql variable into a SQL command or expression, rather than one copy for each textual occurrence as it did before. This might result in some small performance improvement, but the compelling reason to do it is that not doing so can result in unexpected grouping failures because the main SQL parser won't see different parameter numbers as equivalent. Add a regression test for the failure case. Per report from Robert Davidson. Tom Lane 2006-03-23 04:22:37 +00:00
  • 19956e0d53 Add error location info to ResTarget parse nodes. Allows error cursor to be supplied for various mistakes involving INSERT and UPDATE target columns. Tom Lane 2006-03-23 00:19:30 +00:00
  • a155814e37 Improve performance of our private version of qsort. Per recent testing, the logic it contained to switch to insertion sort for near-sorted input was in fact a big loss, because it could fairly easily be fooled into applying insertion sort to large subfiles that weren't all that well ordered. Remove that, and instead add a simple check for already-perfectly-sorted input, as per suggestion from Dann Corbit. This adds at worst O(N*lgN) overhead, and usually far less, while sometimes allowing a subfile sort to finish in O(N) time. Preliminary testing says this is an improvement over the basic Bentley & McIlroy code for many nonrandom inputs, and it costs almost nothing when the input is random. Tom Lane 2006-03-21 19:49:19 +00:00
  • a3f0b3d68f Improve performance of our private version of qsort. Per recent testing, the logic it contained to switch to insertion sort for near-sorted input was in fact a big loss, because it could fairly easily be fooled into applying insertion sort to large subfiles that weren't all that well ordered. Remove that, and instead add a simple check for already-perfectly-sorted input, as per suggestion from Dann Corbit. This adds at worst O(N*lgN) overhead, and usually far less, while sometimes allowing a subfile sort to finish in O(N) time. Preliminary testing says this is an improvement over the basic Bentley & McIlroy code for many nonrandom inputs, and it costs almost nothing when the input is random. Tom Lane 2006-03-21 19:49:15 +00:00
  • 570b726533 Minor refactoring: initialize_SSL() only returns 0, so it should return "void" rather than "int". Neil Conway 2006-03-21 18:18:35 +00:00
  • c4826cf0b0 Merge the loading of shared object descriptions with regular descriptions, both in code and in the messages emitted to the user. Alvaro Herrera 2006-03-21 17:54:28 +00:00
  • af00c04c42 Fix psql history handling: Bruce Momjian 2006-03-21 13:38:12 +00:00
  • 3b7e2b140e Update comment that pgNotify.be_pid is pid of the notifying server process. Bruce Momjian 2006-03-20 15:07:05 +00:00
  • a323ede280 Fix a few places that were checking for the return value of palloc() to be non-NULL: palloc() ereports on OOM, so we can safely assume it returns a valid pointer. Neil Conway 2006-03-19 22:22:56 +00:00
  • ac2c2a457f Fixed bug 2330: Wrong error code in case of a duplicate key Michael Meskes 2006-03-19 12:32:13 +00:00
  • 8931dbf52a Fixed bug 2330: Wrong error code in case of a duplicate key Michael Meskes 2006-03-19 12:30:17 +00:00
  • 85fa81f65b Fixed bug 2330: Wrong error code in case of a duplicate key Michael Meskes 2006-03-19 12:29:40 +00:00