Commit Graph

  • f5df006a04 Add username for psql password prompt, if the username was specified. Bruce Momjian 2005-07-25 17:17:41 +00:00
  • 9ad9e694ac Add: Bruce Momjian 2005-07-25 15:27:06 +00:00
  • 4a2972d691 Awhile back we replaced all uses of strcasecmp and strncasecmp with pg_strcasecmp and pg_strncasecmp ... but I see some of the former have crept back in. Eternal vigilance is the price of locale independence, apparently. Tom Lane 2005-07-25 04:52:32 +00:00
  • cb504a41b2 Change build of regress.so to use Makefile.shlib instead of depending on the not-very-good .so pattern rules in the port-specific Makefiles. (This leaves only pgxs' MODULES case needing those rules.) Also, compile pgsleep.c locally and add it to regress.so to avoid failure on AIX. Tom Lane 2005-07-25 00:58:27 +00:00
  • ac652466ec Partial fixes for contrib build on AIX: include -lm where needed. Per Rocco Altier. Tom Lane 2005-07-24 23:30:10 +00:00
  • d675226e20 Regenerate badly-obsolete README file. Tom Lane 2005-07-24 17:18:52 +00:00
  • 4c80071b81 With the interval/day patch, the horology regression test no longer fails near DST transition days, so remove the advice about that testing problem. Also improve the description of variant-comparison-file selection. Tom Lane 2005-07-24 17:07:18 +00:00
  • a8a3c3c4d6 Add variant expected file to cope with different spelling of a Python error message in Python 2.3 and before. Per Michael Fuhr and buildfarm results. Tom Lane 2005-07-24 14:53:42 +00:00
  • 8b60f8e6c9 Fix rounding problem in interval_div by using rint(), and improve interval_mul function. Bruce Momjian 2005-07-24 04:37:07 +00:00
  • c17abc1c54 Fix logic error in tbm_intersect: the intersection of a normal page and a lossy page has to be lossy, because we don't know exactly which tuples on the page should remain part of the bitmap. Per Jie Zhang. Tom Lane 2005-07-24 02:25:26 +00:00
  • eaa5d52bfe Fix some failures to initialize table entries induced by recent autovacuum integration. Not clear this explains recent stats problems, but it's definitely wrong. Tom Lane 2005-07-24 00:33:28 +00:00
  • d007a95055 Simple constraint exclusion. For now, only child tables of inheritance scans are candidates for exclusion; this should be fixed eventually. Simon Riggs, with some help from Tom Lane. Tom Lane 2005-07-23 21:05:48 +00:00
  • 9af9d674c6 Remove unintended code addition. Bruce Momjian 2005-07-23 15:31:16 +00:00
  • 4098c8867d Macro alignment cleanup. Bruce Momjian 2005-07-23 15:29:47 +00:00
  • f76f24dfff Improve computations of interval_div to prevent rounding problem on AIX. Bruce Momjian 2005-07-23 14:53:21 +00:00
  • 3dbbbbf8e9 Andrew pointed out that the current fix didn't handle dates that were near daylight savings time boudaries. This handles it properly, e.g. Bruce Momjian 2005-07-23 14:25:34 +00:00
  • 6c61b0d93c In the stats test, delay for the stats collector to catch up using a function that actually sleeps, instead of busy-waiting. Perhaps this will resolve some of the intermittent stats failures we keep seeing. Tom Lane 2005-07-23 14:18:57 +00:00
  • 5ddeffb676 Fix AT TIME ZONE for timestamps without time zones: Bruce Momjian 2005-07-23 02:02:27 +00:00
  • 261026575d Fix AT TIME ZONE for timestamps without time zones: Bruce Momjian 2005-07-22 21:16:15 +00:00
  • 4749e914ae Fix insufficient check for overflow in tm2abstime(), per report from jw. Tom Lane 2005-07-22 19:55:50 +00:00
  • 4ee7e8213c Fix compare_fuzzy_path_costs() to behave a bit more sanely. The original coding would ignore startup cost differences of less than 1% of the estimated total cost; which was OK for normal planning but highly not OK if a very small LIMIT was applied afterwards, so that startup cost becomes the name of the game. Instead, compare startup and total costs fuzzily but independently. This changes the plan selected for two queries in the regression tests; adjust expected-output files for resulting changes in row order. Per reports from Dawid Kuroczko and Sam Mason. Tom Lane 2005-07-22 19:12:33 +00:00
  • 37c443eefd Fix compare_fuzzy_path_costs() to behave a bit more sanely. The original coding would ignore startup cost differences of less than 1% of the estimated total cost; which was OK for normal planning but highly not OK if a very small LIMIT was applied afterwards, so that startup cost becomes the name of the game. Instead, compare startup and total costs fuzzily but independently. This changes the plan selected for two queries in the regression tests; adjust expected-output files for resulting changes in row order. Per reports from Dawid Kuroczko and Sam Mason. Tom Lane 2005-07-22 19:12:02 +00:00
  • 3758affc9b More removal of unneeded parentheses. Bruce Momjian 2005-07-22 19:00:55 +00:00
  • ca256f3254 More spacing adjustments Bruce Momjian 2005-07-22 15:15:38 +00:00
  • 75e5aba7fe Update date/time comments. Bruce Momjian 2005-07-22 05:08:26 +00:00
  • a07628b070 More minor spacing improvements. Bruce Momjian 2005-07-22 05:03:09 +00:00
  • d5f1e08c0c Code spacing improvement, particularly *tm spacing. Bruce Momjian 2005-07-22 03:46:34 +00:00
  • e9c44bd382 More comment update of time macros. Bruce Momjian 2005-07-21 20:37:21 +00:00
  • e6b72d6af6 Update DAYS_PER_MONTH comment. Bruce Momjian 2005-07-21 18:06:13 +00:00
  • a0407f508a Add comment about void* use in MemSet. Bruce Momjian 2005-07-21 15:16:30 +00:00
  • 0e5c62d065 Add: Bruce Momjian 2005-07-21 13:43:16 +00:00
  • b4bdab8105 Fix integer timestamp build for macro changes. Bruce Momjian 2005-07-21 05:18:26 +00:00
  • aa0f6e8d06 Add comment marking non-exact time conversion macros. Bruce Momjian 2005-07-21 04:48:42 +00:00
  • 9dbd00b0e2 Remove unnecessary parentheses in assignments. Add spaces where needed. Reference time interval variables as tinterval. Bruce Momjian 2005-07-21 04:41:43 +00:00
  • 3976899f29 Fix storage size for btree_gist interval indexes. Fix penalty calculations for interval and time/timetz to behave sanely for both integer and float timestamps; up to now I think it's been doing something pretty strange... Tom Lane 2005-07-21 04:15:04 +00:00
  • a536b2dd80 Add time/date macros for code clarity: Bruce Momjian 2005-07-21 03:56:25 +00:00
  • dc73819f2e Fix breakage of INSTALL document build. Tom Lane 2005-07-20 23:57:46 +00:00
  • a45f4c2533 /contrib/btree_gist adjustments for new 'day' interval value. Bruce Momjian 2005-07-20 18:17:39 +00:00
  • ddc038cad2 Update catalog version for INTERVAL day addition. Bruce Momjian 2005-07-20 17:24:39 +00:00
  • db05f4a7eb Add 'day' field to INTERVAL so 1 day interval can be distinguished from 24 hours. This is very helpful for daylight savings time: Bruce Momjian 2005-07-20 16:42:32 +00:00
  • 826604f9e6 Fix interval division and multiplication, before: Bruce Momjian 2005-07-20 03:50:24 +00:00
  • ca76df425b Documentation tweak: make <command>CREATE OPERATOR CLASS</command> into an <xref/>. Neil Conway 2005-07-19 01:27:59 +00:00
  • 37464a0326 Fix some bogosities in geometric-function documentation: add an entry for circle(polygon), which was missing; remove bogus entry for point(lseg, lseg), which does not exist, and the documentation seemed to describe lseg_interpt, which we already document as an operator not a function. Also remove entry for box_intersect, which likewise is preferentially used via the operator #. Tom Lane 2005-07-18 22:34:14 +00:00
  • ea72596db5 It appears that Darwin (OS X) does not cope well with C functions that have the same name as the containing shared library --- as best I can tell, the compiler internally creates a function of that name, and does not warn you about the conflict. Fix buildfarm failure in back branches by renaming tsearch() trigger function at the C level. Tom Lane 2005-07-18 21:37:23 +00:00
  • 507465525e \pset numericsep -> numericlocale. Bruce Momjian 2005-07-18 20:57:53 +00:00
  • 71d0cabecd Fix len so decimal length is only added when a period appears in the output. Bruce Momjian 2005-07-18 19:27:37 +00:00
  • 2486a88b06 Back-patch fix for erroneous backslashing of LIKE pattern. Tom Lane 2005-07-18 19:18:19 +00:00
  • affcb4371c Avoid use of E'', and thereby creating an unnecessary version-dependency, by using LIKE...ESCAPE instead. Per suggestion by andrew@supernews. Tom Lane 2005-07-18 19:12:09 +00:00
  • fdd84469f7 Avoid need for E'' construct by using regexp instead of LIKE. More readable, and more like the other places in this file. Tom Lane 2005-07-18 19:09:09 +00:00
  • adeede1391 Fix numiericsep length computations. Bruce Momjian 2005-07-18 18:58:45 +00:00
  • 76f39619d7 Fix bogus backslash sequences, per Kris Jurka. Tom Lane 2005-07-18 17:48:30 +00:00
  • df38d799ea Adjust psql describe queries so that any pg_foo_is_visible() condition is applied last, after other constraints such as name patterns. This is useful first because the pg_foo_is_visible() functions are relatively expensive, and second because it minimizes the prospects for race conditions. The change is fragile though since it makes unwarranted assumptions about planner behavior, ie, that WHERE clauses will be executed in the original order if there's not reason to change it. This should fix ... or at least hide ... an intermittent failure in the prepared_xacts regression test, while we think about what else to do. Tom Lane 2005-07-18 17:40:14 +00:00
  • 24ce1438c0 pgcrypto documentation update. Marko Kreen Tom Lane 2005-07-18 17:17:12 +00:00
  • 35c675a7fd Fortuna fixes. Marko Kreen Tom Lane 2005-07-18 17:12:54 +00:00
  • 2787db9b1d Small cleanups for pgcrypto. Marko Kreen Tom Lane 2005-07-18 17:09:01 +00:00
  • dd4a190d18 Fix C++-style comments, per Rocco Altier. Tom Lane 2005-07-18 16:35:06 +00:00
  • a55a75f02d MemSet() must not cast its pointer argument to int32* until after it has checked that the pointer is actually word-aligned. Casting a non-aligned pointer to int32* is technically illegal per the C spec, and some recent versions of gcc actually generate bad code for the memset() when given such a pointer. Per report from Andrew Morrow. Tom Lane 2005-07-18 15:55:01 +00:00
  • 5394771580 MemSet() must not cast its pointer argument to int32* until after it has checked that the pointer is actually word-aligned. Casting a non-aligned pointer to int32* is technically illegal per the C spec, and some recent versions of gcc actually generate bad code for the memset() when given such a pointer. Per report from Andrew Morrow. Tom Lane 2005-07-18 15:54:30 +00:00
  • c76de7d85e MemSet() must not cast its pointer argument to int32* until after it has checked that the pointer is actually word-aligned. Casting a non-aligned pointer to int32* is technically illegal per the C spec, and some recent versions of gcc actually generate bad code for the memset() when given such a pointer. Per report from Andrew Morrow. Tom Lane 2005-07-18 15:54:11 +00:00
  • 183b1bf84f MemSet() must not cast its pointer argument to int32* until after it has checked that the pointer is actually word-aligned. Casting a non-aligned pointer to int32* is technically illegal per the C spec, and some recent versions of gcc actually generate bad code for the memset() when given such a pointer. Per report from Andrew Morrow. Tom Lane 2005-07-18 15:53:46 +00:00
  • ac43da8466 MemSet() must not cast its pointer argument to int32* until after it has checked that the pointer is actually word-aligned. Casting a non-aligned pointer to int32* is technically illegal per the C spec, and some recent versions of gcc actually generate bad code for the memset() when given such a pointer. Per report from Andrew Morrow. Tom Lane 2005-07-18 15:53:28 +00:00
  • 027b62384e Make pg_regress accept a command-line option for the temporary installation's port number, and use a default value for it that is dependent on the configuration-time DEF_PGPORT. Should make the world safe for running parallel 'make check' in different branches. Back-patch as far as 7.4 so that this actually is useful. Tom Lane 2005-07-17 18:29:37 +00:00
  • f6cb7198ed Make pg_regress accept a command-line option for the temporary installation's port number, and use a default value for it that is dependent on the configuration-time DEF_PGPORT. Should make the world safe for running parallel 'make check' in different branches. Back-patch as far as 7.4 so that this actually is useful. Tom Lane 2005-07-17 18:29:13 +00:00
  • d0f312ebfe Make pg_regress accept a command-line option for the temporary installation's port number, and use a default value for it that is dependent on the configuration-time DEF_PGPORT. Should make the world safe for running parallel 'make check' in different branches. Back-patch as far as 7.4 so that this actually is useful. Tom Lane 2005-07-17 18:28:45 +00:00
  • 509741d3d5 Looks like cube_1 variant is also needed in 7.3 branch. (Don't bother adding it in 7.2, though, since pg_regress doesn't have the capability to use it that far back. Tom Lane 2005-07-17 17:36:56 +00:00
  • cb083b26d5 Adjust alter_table regression test to avoid conflicts with rangefuncs and prepare tests, which cause intermittent failures in parallel test mode. Back-port of fix originally applied to 8.0 and 7.4 branches; the problems do not appear to exist in 7.2 branch but they do occur in 7.3. Per buildfarm results. Tom Lane 2005-07-17 17:26:31 +00:00
  • 86494de248 Back-patch recent changes to alter the order of -L flags inserted from LDFLAGS versus those built into the Makefiles. This looks like it will fix several buildfarm failures in the back branches. Tom Lane 2005-07-17 04:06:04 +00:00
  • 091c97ff3b Back-patch recent changes to alter the order of -L flags inserted from LDFLAGS versus those built into the Makefiles. This looks like it will fix several buildfarm failures in the back branches. Tom Lane 2005-07-17 04:05:49 +00:00
  • 6ec28d8503 ecpglib depends on last_path_separator from src/port/path.c, so we'd better include that in the library build. This was fixed in 8.0 and later, backport to 7.4 to fix buildfarm failure. Tom Lane 2005-07-16 20:39:24 +00:00
  • bf84d6e3bb Back-patch 8.0's tightening of ORDER BY clauses in join regression test, in hopes of eliminating buildfarm regression failure. (Not clear if we will need a join_1.out variant in this branch.) Tom Lane 2005-07-16 20:20:49 +00:00
  • dc59b47518 cube_1 variant is needed in 7.4 branch, per results from buildfarm machine 'kudu'. Tom Lane 2005-07-16 20:11:12 +00:00
  • 84e5ce7eb9 Back-patch into 7.2 branch the 7.3 changes that made contrib/seg error messages reasonably independent of the bison version used to build segparse.c. Needed to get this branch passing on buildfarm. Tom Lane 2005-07-16 19:48:16 +00:00
  • 44e7a2ae60 Back-patch into 7.2 branch the 7.3 changes that made contrib/cube error messages reasonably independent of the bison version used to build cubeparse.c. Needed to get this branch passing on buildfarm. Tom Lane 2005-07-16 19:27:20 +00:00
  • 861e3c7a07 Mark the geometry regression test as an ignorable failure in the pre-7.4 branches. Per discussion, this seems saner than trying to maintain last-significant-digit regression test outputs for all supported platforms. Tom Lane 2005-07-16 19:02:01 +00:00
  • 2401cfa155 Mark the geometry regression test as an ignorable failure in the pre-7.4 branches. Per discussion, this seems saner than trying to maintain last-significant-digit regression test outputs for all supported platforms. Tom Lane 2005-07-16 19:01:50 +00:00
  • d96e0462c7 The geometry_2 variant appears to be needed in 7.4 branch as well as later, per results from buildfarm member 'wallaroo'. Tom Lane 2005-07-16 18:39:26 +00:00
  • c969e30d7d Fix bogus "extern int errno;" in back branches, per Andrew Dunstan. Tom Lane 2005-07-16 15:24:08 +00:00
  • 24ede218a1 Fix bogus "extern int errno;" in back branches, per Andrew Dunstan. Tom Lane 2005-07-16 15:23:37 +00:00
  • 0a719d8935 Fix bogus "extern int errno;" in back branches, per Andrew Dunstan. Tom Lane 2005-07-16 15:23:29 +00:00
  • 59857b46a8 Fix create_unique_plan() so it doesn't generate useless entries in the output targetlist of the Unique or HashAgg plan. This code was OK when written, but subsequent changes to use "physical tlists" where possible had broken it: given an input subplan that has extra variables added to avoid a projection step, it would copy those extra variables into the upper tlist, which is pointless since a projection has to happen anyway. Tom Lane 2005-07-15 22:02:51 +00:00
  • 5e544e4eb7 Fix SGML spacing. Bruce Momjian 2005-07-15 19:02:12 +00:00
  • 123e25b3a3 Check for out-of-range varoattno in deparse_context_for_subplan. I have seen this case in CVS tip due to new "physical tlist" optimization for subqueries. I believe it probably can't happen in existing releases, but the check is not going to hurt anything, so backpatch to 8.0 just in case. Tom Lane 2005-07-15 18:40:20 +00:00
  • 184ba4d5ed Check for out-of-range varoattno in deparse_context_for_subplan. I have seen this case in CVS tip due to new "physical tlist" optimization for subqueries. I believe it probably can't happen in existing releases, but the check is not going to hurt anything, so backpatch to 8.0 just in case. Tom Lane 2005-07-15 18:39:59 +00:00
  • 1e31942a33 Fix overenthusiastic optimization of 'x IN (SELECT DISTINCT ...)' and related cases: we can't just consider whether the subquery's output is unique on its own terms, we have to check whether the set of output columns we are going to use will be unique. Per complaint from Luca Pireddu and test case from Michael Fuhr. Tom Lane 2005-07-15 17:09:50 +00:00
  • 0182951bc8 Fix overenthusiastic optimization of 'x IN (SELECT DISTINCT ...)' and related cases: we can't just consider whether the subquery's output is unique on its own terms, we have to check whether the set of output columns we are going to use will be unique. Per complaint from Luca Pireddu and test case from Michael Fuhr. Tom Lane 2005-07-15 17:09:26 +00:00
  • aa1110624c Adjust permissions checking for ALTER OWNER commands: instead of requiring superuserness always, allow an owner to reassign ownership to any role he is a member of, if that role would have the right to create a similar object. These three requirements essentially state that the would-be alterer has enough privilege to DROP the existing object and then re-CREATE it as the new role; so we might as well let him do it in one step. The ALTER TABLESPACE case is a bit squirrely, but the whole concept of non-superuser tablespace owners is pretty dubious anyway. Stephen Frost, code review by Tom Lane. Tom Lane 2005-07-14 21:46:30 +00:00
  • bd15782164 Enable multi-byte thousands_sep and decimal_point for numericsep. Bruce Momjian 2005-07-14 21:12:41 +00:00
  • fbc11b9dcf Make better thousands_sep default based on decimal marker value. Bruce Momjian 2005-07-14 15:54:21 +00:00
  • f3d95f3c7f Fix mis-backport of libpq memory leak fix. Per Michael Fuhr. Tom Lane 2005-07-14 14:07:50 +00:00
  • ecafa828c3 Fix mis-backport of libpq memory leak fix. Per Michael Fuhr. Tom Lane 2005-07-14 14:07:41 +00:00
  • 45a19efa9e Change numericsep to a boolean, and make it locale-aware. Bruce Momjian 2005-07-14 08:42:37 +00:00
  • 4a8bbbd2ee Add numeric separator support for latex and troff output methods. Bruce Momjian 2005-07-14 07:32:01 +00:00
  • 75c76e93c7 Mark xml2 CREATE FUNCTIONs as IMMUTABLE, and use the "STRICT" syntax rather than the deprecated "WITH (isStrict)" syntax. Patch from Ilia Kantor, minor editorializing by Neil Conway. Neil Conway 2005-07-14 07:12:27 +00:00
  • 52d1d2e67c barebones variable name -> tuples_only, for consistency. Bruce Momjian 2005-07-14 06:49:58 +00:00
  • cff9c5748a Fix malloc length for new numeric separator patch. Bruce Momjian 2005-07-14 06:46:17 +00:00
  • c3f1b0f4dd This doc patch replaces all inappropriate references to SQL:1999 when it is used as if it were the latest (and/or still valid) SQL standard. SQL:2003 is used in its place. Patch from Simon Riggs. Neil Conway 2005-07-14 06:17:36 +00:00
  • 29094193f5 Integrate autovacuum functionality into the backend. There's still a few loose ends to be dealt with, but it seems to work. Alvaro Herrera, based on the contrib code by Matthew O'Connor. Tom Lane 2005-07-14 05:13:45 +00:00
  • f2bf2d2dc5 Fix a couple of bogus comments, per Alvaro. Tom Lane 2005-07-13 22:46:09 +00:00
  • 5a4c2a75d1 Remove extraneous space after -L ... it confuses SHLIB_LINK filter -L hack. Tom Lane 2005-07-13 17:12:56 +00:00
  • 0016911b5d Fix unwanted side-effects of recent SHLIB_LINK -L patch on existing hacking of SHLIB_LINK for HPUX. Tom Lane 2005-07-13 17:00:44 +00:00