mirror of
https://git.postgresql.org/git/postgresql.git
synced 2026-02-16 11:26:59 +08:00
b83dcf7928
With its current design, a careless use of pg_cryptohash_final() could would result in an out-of-bound write in memory as the size of the destination buffer to store the result digest is not known to the cryptohash internals, without the caller knowing about that. This commit adds a new argument to pg_cryptohash_final() to allow such sanity checks, and implements such defenses. The internals of SCRAM for HMAC could be tightened a bit more, but as everything is based on SCRAM_KEY_LEN with uses particular to this code there is no need to complicate its interface more than necessary, and this comes back to the refactoring of HMAC in core. Except that, this minimizes the uses of the existing DIGEST_LENGTH variables, relying instead on sizeof() for the result sizes. In ossp-uuid, this also makes the code more defensive, as it already relied on dce_uuid_t being at least the size of a MD5 digest. This is in philosophy similar to cfc40d3 for base64.c and aef8948 for hex.c. Reported-by: Ranier Vilela Author: Michael Paquier, Ranier Vilela Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/CAEudQAoqEGmcff3J4sTSV-R_16Monuz-UpJFbf_dnVH=APr02Q@mail.gmail.com
39 lines
1.1 KiB
C
39 lines
1.1 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* cryptohash.h
|
|
* Generic headers for cryptographic hash functions.
|
|
*
|
|
* Portions Copyright (c) 1996-2021, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* IDENTIFICATION
|
|
* src/include/common/cryptohash.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
|
|
#ifndef PG_CRYPTOHASH_H
|
|
#define PG_CRYPTOHASH_H
|
|
|
|
/* Context Structures for each hash function */
|
|
typedef enum
|
|
{
|
|
PG_MD5 = 0,
|
|
PG_SHA1,
|
|
PG_SHA224,
|
|
PG_SHA256,
|
|
PG_SHA384,
|
|
PG_SHA512
|
|
} pg_cryptohash_type;
|
|
|
|
/* opaque context, private to each cryptohash implementation */
|
|
typedef struct pg_cryptohash_ctx pg_cryptohash_ctx;
|
|
|
|
extern pg_cryptohash_ctx *pg_cryptohash_create(pg_cryptohash_type type);
|
|
extern int pg_cryptohash_init(pg_cryptohash_ctx *ctx);
|
|
extern int pg_cryptohash_update(pg_cryptohash_ctx *ctx, const uint8 *data, size_t len);
|
|
extern int pg_cryptohash_final(pg_cryptohash_ctx *ctx, uint8 *dest, size_t len);
|
|
extern void pg_cryptohash_free(pg_cryptohash_ctx *ctx);
|
|
|
|
#endif /* PG_CRYPTOHASH_H */
|