mirror of
https://git.postgresql.org/git/postgresql.git
synced 2026-02-14 10:27:04 +08:00
5ed20a689e
The date-vs-timestamp, date-vs-timestamptz, and timestamp-vs-timestamptz comparators all worked by promoting the first type to the second and then doing a simple same-type comparison. This works fine, except when the conversion result is out of range, in which case we throw an entirely avoidable error. The sources of such failures are (a) type date can represent dates much farther in the future than the timestamp types can; (b) timezone rotation might cause a just-in-range timestamp value to become a just-out-of-range timestamptz value. Up to now we just ignored these corner-case issues, but now we have an actual user complaint (bug #16657 from Huss EL-Sheikh), so let's do something about it. It turns out that commit 52ad1e659 already built all the necessary infrastructure to support error-free comparisons, but neglected to actually use it in the main-line code paths. Fix that, do a little bit of code style review, and remove the now-duplicate logic in jsonpath_exec.c. Back-patch to v13 where 52ad1e659 came in. We could take this back further by back-patching said infrastructure, but given the small number of complaints so far, I don't feel a great need to. Discussion: https://postgr.es/m/16657-cde2f876d8cc7971@postgresql.org
91 lines
3.2 KiB
C
91 lines
3.2 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* date.h
|
|
* Definitions for the SQL "date" and "time" types.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2020, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/utils/date.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef DATE_H
|
|
#define DATE_H
|
|
|
|
#include <math.h>
|
|
|
|
#include "datatype/timestamp.h"
|
|
#include "fmgr.h"
|
|
#include "pgtime.h"
|
|
|
|
typedef int32 DateADT;
|
|
|
|
typedef int64 TimeADT;
|
|
|
|
typedef struct
|
|
{
|
|
TimeADT time; /* all time units other than months and years */
|
|
int32 zone; /* numeric time zone, in seconds */
|
|
} TimeTzADT;
|
|
|
|
/*
|
|
* Infinity and minus infinity must be the max and min values of DateADT.
|
|
*/
|
|
#define DATEVAL_NOBEGIN ((DateADT) PG_INT32_MIN)
|
|
#define DATEVAL_NOEND ((DateADT) PG_INT32_MAX)
|
|
|
|
#define DATE_NOBEGIN(j) ((j) = DATEVAL_NOBEGIN)
|
|
#define DATE_IS_NOBEGIN(j) ((j) == DATEVAL_NOBEGIN)
|
|
#define DATE_NOEND(j) ((j) = DATEVAL_NOEND)
|
|
#define DATE_IS_NOEND(j) ((j) == DATEVAL_NOEND)
|
|
#define DATE_NOT_FINITE(j) (DATE_IS_NOBEGIN(j) || DATE_IS_NOEND(j))
|
|
|
|
/*
|
|
* Macros for fmgr-callable functions.
|
|
*
|
|
* For TimeADT, we make use of the same support routines as for int64.
|
|
* Therefore TimeADT is pass-by-reference if and only if int64 is!
|
|
*/
|
|
#define MAX_TIME_PRECISION 6
|
|
|
|
#define DatumGetDateADT(X) ((DateADT) DatumGetInt32(X))
|
|
#define DatumGetTimeADT(X) ((TimeADT) DatumGetInt64(X))
|
|
#define DatumGetTimeTzADTP(X) ((TimeTzADT *) DatumGetPointer(X))
|
|
|
|
#define DateADTGetDatum(X) Int32GetDatum(X)
|
|
#define TimeADTGetDatum(X) Int64GetDatum(X)
|
|
#define TimeTzADTPGetDatum(X) PointerGetDatum(X)
|
|
|
|
#define PG_GETARG_DATEADT(n) DatumGetDateADT(PG_GETARG_DATUM(n))
|
|
#define PG_GETARG_TIMEADT(n) DatumGetTimeADT(PG_GETARG_DATUM(n))
|
|
#define PG_GETARG_TIMETZADT_P(n) DatumGetTimeTzADTP(PG_GETARG_DATUM(n))
|
|
|
|
#define PG_RETURN_DATEADT(x) return DateADTGetDatum(x)
|
|
#define PG_RETURN_TIMEADT(x) return TimeADTGetDatum(x)
|
|
#define PG_RETURN_TIMETZADT_P(x) return TimeTzADTPGetDatum(x)
|
|
|
|
|
|
/* date.c */
|
|
extern int32 anytime_typmod_check(bool istz, int32 typmod);
|
|
extern double date2timestamp_no_overflow(DateADT dateVal);
|
|
extern Timestamp date2timestamp_opt_overflow(DateADT dateVal, int *overflow);
|
|
extern TimestampTz date2timestamptz_opt_overflow(DateADT dateVal, int *overflow);
|
|
extern int32 date_cmp_timestamp_internal(DateADT dateVal, Timestamp dt2);
|
|
extern int32 date_cmp_timestamptz_internal(DateADT dateVal, TimestampTz dt2);
|
|
|
|
extern void EncodeSpecialDate(DateADT dt, char *str);
|
|
extern DateADT GetSQLCurrentDate(void);
|
|
extern TimeTzADT *GetSQLCurrentTime(int32 typmod);
|
|
extern TimeADT GetSQLLocalTime(int32 typmod);
|
|
extern int time2tm(TimeADT time, struct pg_tm *tm, fsec_t *fsec);
|
|
extern int timetz2tm(TimeTzADT *time, struct pg_tm *tm, fsec_t *fsec, int *tzp);
|
|
extern int tm2time(struct pg_tm *tm, fsec_t fsec, TimeADT *result);
|
|
extern int tm2timetz(struct pg_tm *tm, fsec_t fsec, int tz, TimeTzADT *result);
|
|
extern bool time_overflows(int hour, int min, int sec, fsec_t fsec);
|
|
extern bool float_time_overflows(int hour, int min, double sec);
|
|
extern void AdjustTimeForTypmod(TimeADT *time, int32 typmod);
|
|
|
|
#endif /* DATE_H */
|