Tom Lane 68f7b91e50 In rebuild_relation(), don't access an already-closed relcache entry. ...

This reliably fails with -DRELCACHE_FORCE_RELEASE, as reported by
Andrew Dunstan, and could sometimes fail in normal operation, resulting
in a wrong persistence value being used for the transient table.
It's not immediately clear to me what effects that might have beyond
the risk of a crash while accessing OldHeap->rd_rel->relpersistence,
but it's probably not good.

Bug introduced by commit f41872d0c, and made substantially worse by
commit 85b506bbf, which added a second such access significantly
later than the heap_close.  I doubt the first reference could fail
in a production scenario, but the second one definitely could.

Discussion: https://postgr.es/m/7b52f900-0579-cda9-ae2e-de5da17090e6@2ndQuadrant.com

2017-03-04 16:09:33 -05:00

..

backend

In rebuild_relation(), don't access an already-closed relcache entry.

2017-03-04 16:09:33 -05:00

bin

Fix help message for pg_basebackup -R

2017-02-18 13:46:03 +01:00

common

pgindent run for 9.6

2016-06-09 18:02:36 -04:00

fe_utils

Restore psql's SIGPIPE setting if popen() fails.

2016-12-07 12:39:24 -05:00

include

Fix unportable definition of BSWAP64() macro.

2017-02-24 15:21:39 -05:00

interfaces

Make src/interfaces/libpq/test clean up after itself.

2017-02-19 17:18:36 -05:00

makefiles

Fix typos in comments and doc

2016-01-28 16:47:36 +09:00

pl

Adjust PL/Tcl regression test to dodge a possible bug or zone dependency.

2017-02-19 16:14:52 -05:00

port

Stamp 9.6.2.

2017-02-06 16:45:25 -05:00

template

Remove some remains from Alpha support removal

2015-10-29 16:40:14 -04:00

test

Fix timeouts in PostgresNode::psql

2017-03-01 14:02:06 -05:00

timezone

Update time zone data files to tzdata release 2016j.

2017-01-30 11:40:39 -05:00

tools

Change qr/foo$/m to qr/foo\n/m, for Perl 5.8.8.

2016-11-07 20:27:35 -05:00

tutorial

Update copyright for 2016

2016-01-02 13:33:40 -05:00

.gitignore

…

bcc32.mak

…

DEVELOPERS

…

Makefile

Install TAP test infrastructure so it's available for extension testing.

2016-09-23 15:50:00 -04:00

Makefile.global.in

Document usage of COPT environment variable for adjusting configure flags.

2017-02-17 16:11:02 -05:00

Makefile.shlib

Fix typos in comments.

2017-02-06 11:34:15 +02:00

nls-global.mk

nls-global.mk: search build dir for source files, too

2016-06-07 18:55:18 -04:00

win32.mak

…