Tom Lane dd3bab5fd7 Ensure that whole-row junk Vars are always of composite type. ...

The EvalPlanQual machinery assumes that whole-row Vars generated for the
outputs of non-table RTEs will be of composite types.  However, for the
case where the RTE is a function call returning a scalar type, we were
doing the wrong thing, as a result of sharing code with a parser case
where the function's scalar output is wanted.  (Or at least, that's what
that case has done historically; it does seem a bit inconsistent.)

To fix, extend makeWholeRowVar's API so that it can support both use-cases.
This fixes Belinda Cussen's report of crashes during concurrent execution
of UPDATEs involving joins to the result of UNNEST() --- in READ COMMITTED
mode, we'd run the EvalPlanQual machinery after a conflicting row update
commits, and it was expecting to get a HeapTuple not a scalar datum from
the "wholerowN" variable referencing the function RTE.

Back-patch to 9.0 where the current EvalPlanQual implementation appeared.

In 9.1 and up, this patch also fixes failure to attach the correct
collation to the Var generated for a scalar-result case.  An example:
regression=# select upper(x.*) from textcat('ab', 'cd') x;
ERROR:  could not determine which collation to use for upper() function

2011-11-27 22:27:24 -05:00

..

Makefile

Remove cvs keywords from all files.

2010-09-20 22:08:53 +02:00

rewriteDefine.c

Try to acquire relation locks in RangeVarGetRelid.

2011-07-08 22:19:30 -04:00

rewriteHandler.c

Ensure that whole-row junk Vars are always of composite type.

2011-11-27 22:27:24 -05:00

rewriteManip.c

Rearrange planner to save the whole PlannerInfo (subroot) for a subquery.

2011-09-03 15:36:24 -04:00

rewriteRemove.c

Further consolidation of DROP statement handling.

2011-11-17 21:32:34 -05:00

rewriteSupport.c

Remove unnecessary #include references, per pgrminclude script.

2011-09-01 10:04:27 -04:00