Tom Lane 3d99a81397 Fix incorrect printing of queries with duplicated join names. ...

Given a query in which multiple JOIN nodes used the same alias
(which'd necessarily be in different sub-SELECTs), ruleutils.c
would assign the JOIN nodes distinct aliases for clarity ...
but then it forgot to print the modified aliases when dumping
the JOIN nodes themselves.  This results in a dump/reload hazard
for views, because the emitted query is flat-out incorrect:
Vars will be printed with table names that have no referent.

This has been wrong for a long time, so back-patch to all supported
branches.

Philip Dubé

Discussion: https://postgr.es/m/CY4PR2101MB080246F2955FF58A6ED1FEAC98140@CY4PR2101MB0802.namprd21.prod.outlook.com

2019-06-12 19:43:08 -04:00

..

backend

Fix incorrect printing of queries with duplicated join names.

2019-06-12 19:43:08 -04:00

bin

Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (reprise)

2019-06-10 18:56:23 -04:00

common

Fix typos in various places

2019-06-03 13:44:03 +09:00

fe_utils

Update stale comments, and fix comment typos.

2019-06-08 10:12:26 -07:00

include

tableam: Fix index_build_range_scan parameter name.

2019-06-10 20:04:48 -04:00

interfaces

Stop using spelling "nonexistant".

2019-06-08 10:12:26 -07:00

makefiles

Define WIN32_STACK_RLIMIT throughout win32 and cygwin builds.

2019-04-09 08:25:39 -07:00

pl

Clean up PL/Perl's handling of the _() macro.

2019-06-02 12:23:39 -04:00

port

Phase 2 pgindent run for v12.

2019-05-22 13:04:48 -04:00

template

Yet further rethinking of build changes for macOS Mojave.

2018-11-02 18:54:00 -04:00

test

Fix incorrect printing of queries with duplicated join names.

2019-06-12 19:43:08 -04:00

timezone

Phase 2 pgindent run for v12.

2019-05-22 13:04:48 -04:00

tools

MSVC: Reconcile clean.bat with PostgreSQL 12 work.

2019-06-09 15:50:54 -07:00

tutorial

Phase 2 pgindent run for v12.

2019-05-22 13:04:48 -04:00

.gitignore

…

DEVELOPERS

…

Makefile

Fix partial-build problems introduced by having more generated headers.

2018-04-09 16:42:10 -04:00

Makefile.global.in

Consistently test for in-use shared memory.

2019-04-12 22:36:38 -07:00

Makefile.shlib

Ensure static libraries have correct mod time even if ranlib messes it up.

2018-11-29 15:53:44 -05:00

nls-global.mk

Move logging.h and logging.c from src/fe_utils/ to src/common/.

2019-05-14 14:20:10 -04:00