mirror of
https://git.postgresql.org/git/postgresql.git
synced 2026-02-09 05:57:29 +08:00
2977a312df
Up to now, createplan.c attempted to share PARAM_EXEC slots for NestLoopParams across different plan levels, if the same underlying Var was being fed down to different righthand-side subplan trees by different NestLoops. This was, I think, more of an artifact of using subselect.c's PlannerParamItem infrastructure than an explicit design goal, but anyway that was the end result. This works well enough as long as the plan tree is executing synchronously, but the feature whereby Gather can execute the parallelized subplan locally breaks it. An upper NestLoop node might execute for a row retrieved from a parallel worker, and assign a value for a PARAM_EXEC slot from that row, while the leader's copy of the parallelized subplan is suspended with a different active value of the row the Var comes from. When control eventually returns to the leader's subplan, it gets the wrong answers if the same PARAM_EXEC slot is being used within the subplan, as reported in bug #15577 from Bartosz Polnik. This is pretty reminiscent of the problem fixed in commit 46c508fbc, and the proper fix seems to be the same: don't try to share PARAM_EXEC slots across different levels of controlling NestLoop nodes. This requires decoupling NestLoopParam handling from PlannerParamItem handling, although the logic remains somewhat similar. To avoid bizarre division of labor between subselect.c and createplan.c, I decided to move all the param-slot-assignment logic for both cases out of those files and put it into a new file paramassign.c. Hopefully it's a bit better documented now, too. A regression test case for this might be nice, but we don't know a test case that triggers the problem with a suitably small amount of data. Back-patch to 9.6 where we added Gather nodes. It's conceivable that related problems exist in older branches; but without some evidence for that, I'll leave the older branches alone. Discussion: https://postgr.es/m/15577-ca61ab18904af852@postgresql.org
44 lines
1.6 KiB
C
44 lines
1.6 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* subselect.h
|
|
* Planning routines for subselects.
|
|
*
|
|
* Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/optimizer/subselect.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef SUBSELECT_H
|
|
#define SUBSELECT_H
|
|
|
|
#include "nodes/plannodes.h"
|
|
#include "nodes/relation.h"
|
|
|
|
extern void SS_process_ctes(PlannerInfo *root);
|
|
extern JoinExpr *convert_ANY_sublink_to_join(PlannerInfo *root,
|
|
SubLink *sublink,
|
|
Relids available_rels);
|
|
extern JoinExpr *convert_EXISTS_sublink_to_join(PlannerInfo *root,
|
|
SubLink *sublink,
|
|
bool under_not,
|
|
Relids available_rels);
|
|
extern Node *SS_replace_correlation_vars(PlannerInfo *root, Node *expr);
|
|
extern Node *SS_process_sublinks(PlannerInfo *root, Node *expr, bool isQual);
|
|
extern void SS_identify_outer_params(PlannerInfo *root);
|
|
extern void SS_charge_for_initplans(PlannerInfo *root, RelOptInfo *final_rel);
|
|
extern void SS_attach_initplans(PlannerInfo *root, Plan *plan);
|
|
extern void SS_finalize_plan(PlannerInfo *root, Plan *plan);
|
|
extern Param *SS_make_initplan_output_param(PlannerInfo *root,
|
|
Oid resulttype, int32 resulttypmod,
|
|
Oid resultcollation);
|
|
extern void SS_make_initplan_from_plan(PlannerInfo *root,
|
|
PlannerInfo *subroot, Plan *plan,
|
|
Param *prm);
|
|
|
|
/* XXX deprecated: */
|
|
extern int SS_assign_special_param(PlannerInfo *root);
|
|
|
|
#endif /* SUBSELECT_H */
|