Andres Freund 483b2d7ae1 Don't access catalogs to validate GUCs when not connected to a DB. ...

Vignesh found this bug in the check function for
default_table_access_method's check hook, but that was just copied
from older GUCs. Investigation by Michael and me then found the bug in
further places.

When not connected to a database (e.g. in a walsender connection), we
cannot perform (most) GUC checks that need database access. Even when
only shared tables are needed, unless they're
nailed (c.f. RelationCacheInitializePhase2()), they cannot be accessed
without pg_class etc. being present.

Fix by extending the existing IsTransactionState() checks to also
check for MyDatabaseOid.

Reported-By: Vignesh C, Michael Paquier, Andres Freund
Author: Vignesh C, Andres Freund
Discussion: https://postgr.es/m/CALDaNm1KXK9gbZfY-p_peRFm_XrBh1OwQO1Kk6Gig0c0fVZ2uw%40mail.gmail.com
Backpatch: 9.4-

2019-06-10 23:36:59 -07:00

..

attoptcache.c

Update copyright for 2015

2015-01-06 11:43:47 -05:00

catcache.c

Remove AtEOXact_CatCache().

2017-08-13 16:15:14 -04:00

evtcache.c

Update copyright for 2015

2015-01-06 11:43:47 -05:00

inval.c

Limit depth of forced recursion for CLOBBER_CACHE_RECURSIVELY.

2018-09-07 18:14:30 -04:00

lsyscache.c

Further patch rangetypes_selfuncs.c's statistics slot management.

2017-05-08 15:02:58 -04:00

Makefile

Add infrastructure for mapping relfilenodes to relation OIDs.

2013-07-22 11:09:10 -04:00

plancache.c

Invalidate cached plans on FDW option changes.

2017-01-06 14:12:52 -05:00

relcache.c

Fix reindexing of pg_class indexes some more.

2019-05-02 19:11:28 -04:00

relfilenodemap.c

Reduce initial size of RelfilenodeMapHash.

2017-05-12 18:30:02 -04:00

relmapper.c

PANIC on fsync() failure.

2018-11-19 14:13:22 +13:00

spccache.c

Update copyright for 2015

2015-01-06 11:43:47 -05:00

syscache.c

Avoid searching for callback functions in CallSyscacheCallbacks().

2017-05-12 19:05:29 -04:00

ts_cache.c

Don't access catalogs to validate GUCs when not connected to a DB.

2019-06-10 23:36:59 -07:00

typcache.c

Fix typcache's failure to treat ranges as container types.

2017-10-20 17:12:27 -04:00