Tom Lane d6b059ec74 Document intentional violations of header inclusion policy. ...

Although there are good reasons for our policy of including postgres.h
as the first #include in every .c file, never from .h files, there are
two places where it seems expedient to violate the policy because the
alternative is to modify externally-supplied .c files.  (In the case
of the regexp library, the idea that it's externally-supplied is kind
of at odds with reality, but I haven't entirely given up hope that it
will become a standalone project some day.)  Add some comments to make
it explicit that this is a policy violation and provide the reasoning.

In passing, move #include "miscadmin.h" out of regcomp.c and into
regcustom.h, which is where it should be if we're taking this reasoning
seriously at all.

Discussion: https://postgr.es/m/CAEepm=2zCoeq3QxVwhS5DFeUh=yU6z81pbWMgfOB8OzyiBwxzw@mail.gmail.com
Discussion: https://postgr.es/m/11634.1488932128@sss.pgh.pa.us

2017-03-08 17:01:13 -05:00

..

regcustom.h

Document intentional violations of header inclusion policy.

2017-03-08 17:01:13 -05:00

regerrs.h

Improve memory-usage accounting in regular-expression compiler.

2015-10-16 15:55:59 -04:00

regex.h

Make locale-dependent regex character classes work for large char codes.

2016-09-05 17:06:29 -04:00

regexport.h

Update copyright via script for 2017

2017-01-03 13:48:53 -05:00

regguts.h

Make locale-dependent regex character classes work for large char codes.

2016-09-05 17:06:29 -04:00