Tom Lane ea5ae3ae1a Fix misbehavior of DROP OWNED BY with duplicate polroles entries. ...

Ordinarily, a pg_policy.polroles array wouldn't list the same role
more than once; but CREATE POLICY does not prevent that.  If we
perform DROP OWNED BY on a role that is listed more than once,
RemoveRoleFromObjectPolicy either suffered an assertion failure
or encountered a tuple-updated-by-self error.  Rewrite it to cope
correctly with duplicate entries, and add a CommandCounterIncrement
call to prevent the other problem.

Per discussion, there's other cleanup that ought to happen here,
but this seems like the minimum essential fix.

Per bug #17062 from Alexander Lakhin.  It's been broken all along,
so back-patch to all supported branches.

Discussion: https://postgr.es/m/17062-11f471ae3199ca23@postgresql.org

2021-06-18 18:00:09 -04:00

..

backend

Fix misbehavior of DROP OWNED BY with duplicate polroles entries.

2021-06-18 18:00:09 -04:00

bin

Work around portability issue with newer versions of mktime().

2021-06-13 14:32:42 -04:00

common

Replace use of sys_siglist[] with strsignal().

2020-07-15 22:05:12 -04:00

fe_utils

Fix incautious handling of possibly-miscoded strings in client code.

2021-06-07 14:15:25 -04:00

include

Fix decoding of speculative aborts.

2021-06-15 09:02:32 +05:30

interfaces

Fix incautious handling of possibly-miscoded strings in client code.

2021-06-07 14:15:25 -04:00

makefiles

Select CFLAGS_SL at configure time, not in platform-specific Makefiles.

2019-10-21 12:32:36 -04:00

pl

Update plpython_subtransaction alternative expected files

2021-06-18 06:51:56 +02:00

port

Stamp 11.12.

2021-05-10 16:45:49 -04:00

template

Further tweaking of PG_SYSROOT heuristics for macOS.

2021-01-20 12:07:41 -05:00

test

Fix misbehavior of DROP OWNED BY with duplicate polroles entries.

2021-06-18 18:00:09 -04:00

timezone

Update time zone data files to tzdata release 2021a.

2021-01-24 16:29:47 -05:00

tools

fix syntax error

2021-05-28 09:35:49 -04:00

tutorial

tutorial: land height is "elevation", not "altitude"

2021-03-10 20:25:18 -05:00

.gitignore

…

DEVELOPERS

…

Makefile

Fix partial-build problems introduced by having more generated headers.

2018-04-09 16:42:10 -04:00

Makefile.global.in

Select CFLAGS_SL at configure time, not in platform-specific Makefiles.

2019-10-21 12:32:36 -04:00

Makefile.shlib

Ensure static libraries have correct mod time even if ranlib messes it up.

2018-11-29 15:53:44 -05:00

nls-global.mk

…