Commit Graph

2141 Commits

Author SHA1 Message Date
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
c9f3c508bb Resolves: #i76558# jump by Enter key on the Object catalog
(cherry picked from commit 7bc75c1a7b05d81631ebccf05bf022636d1a3a14)

Conflicts:
	basctl/source/basicide/objdlg.cxx
	basctl/source/basicide/objdlg.hxx

Change-Id: Id3fa3686fd60df192c02cc8137c9bc59e68c1d49
2014-05-19 08:57:45 +01:00
70895b691e remove legacy svheader.hxx
none of the corresponding headers is included...

Change-Id: I85061dc159ace0fd727e3d32e52b14c123690584
2014-05-15 17:47:39 +02:00
248145f99e Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.

Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-14 08:10:22 +00:00
261b1ad80a '!= false' is redundant, and confusing - kill it.
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
2014-05-09 22:28:44 +02:00
13c01aac25 coverity#1209811 Dereference before null check
Change-Id: I7e3778e5203438bc5db942c813a03896d7df895b
2014-05-09 09:43:15 +01:00
148b9a23fa coverity#1209554 Explicit null dereferenced
Change-Id: Iacf4373221b93a97e030b09501cc91589f2fdff7
2014-05-07 15:47:24 +01:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
883481fd20 Improve TabBar return types
DeactivatePage() goes from returning long to returning bool.
StartRenaming goes from returning long to returning bool.
AllowRenaming goes from returning long to returning a
constant from a new enum.

Change-Id: Ib87e8d7ceb4e23846547257b358ca4dfd41eb6ca
Reviewed-on: https://gerrit.libreoffice.org/9161
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-28 11:37:37 +00:00
0eb160ef13 coverity#736993 Uncaught exception
Change-Id: Ib8e5d13da0e26f67da16edf0eb55341208ec2337
2014-04-25 20:19:11 +01:00
7f49f4227b coverity#736992 Uncaught exception
Change-Id: Ia074dc867cc068fccb2d4eb613d04b945b8711e7
2014-04-25 20:19:11 +01:00
2d4c90e82e coverity#736990 Uncaught exception
Change-Id: I3b7f4c732a5a3369c05c75ede1580b32837be671
2014-04-25 20:19:11 +01:00
702f9c5176 huge hrc and src file cleanup
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 22:49:57 +00:00
5973c2d34a fixincludeguards.sh: basctl 2014-04-19 11:10:07 +02:00
29d5ce2d88 sfx2: Move InitInterface_Impl() out of SFX_DECL_INTERFACE too.
Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
2014-04-18 22:51:06 +02:00
b731d71c67 sfx2: Move InitInterface_Impl() method out of SFX_IMPL_INTERFACE.
SFX_IMPL_INTERFACE previously looked like a function; where in fact it is
several methods defined at once, and only the last one has a body.

This is extremely confusing and hard to read; let's kill that nonsense.

Change-Id: Ia4ae22eb58b1260c9c827c894f5345693bad49e7
2014-04-18 22:51:06 +02:00
8c3ab6093a sfx2: Kill SFX_STATUSBAR_REGISTRATION macro.
Change-Id: Iff0ffdb955892117a767e1f31c1f854a93feb560
2014-04-18 22:51:06 +02:00
72d8c94dfa sfx2: Kill SFX_FEATURED_CHILDWINDOW_REGISTRATION macro.
Change-Id: I9bf1c2404eeb6c59525061157e91b8777f2da540
2014-04-18 22:51:05 +02:00
f4d61eca61 sfx2: Kill SFX_CHILDWINDOW_REGISTRATION macro.
Change-Id: Icd56e0cee1ce0283e8a1cbaafc81ecca25469185
2014-04-18 22:51:04 +02:00
9f83ea4bc6 sfx2: Kill SFX_POPUPMENU_REGISTRATION macro.
Change-Id: Ie68ccbe5874ec7c7e1bb73cb2937e06bb4910cd0
2014-04-18 22:49:27 +02:00
5e91217c6a no temporary instance of SvtLanguageTable necessary here
Change-Id: I3172e4d174a7f632a4259bd7330b41d3f065daed
2014-04-17 23:15:02 +02:00
0424163d03 no temporary instance of SvtLanguageTable necessary here
Change-Id: Iabb3aadf35eb6b3575d916f2400f606264572537
2014-04-17 23:15:02 +02:00
23dc4e1a00 basctl: sal_Bool->bool
Change-Id: I85e1e94557a238f629151d9ce46a502efed3696d
2014-04-15 15:23:28 +02:00
380d4600d7 use TriState instead of sal_Bool as there's three possibilities
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
2014-04-08 09:18:33 +01:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
6ef2df7b9b Remove remaining DBG_NAME* uses
...that had been used for DBG_CTOR, DBG_PROF, etc.

Change-Id: I8eac38e24b7110511feb7813aaf5a20ab82bdbe0
2014-03-28 17:26:09 +01:00
1714f4d3e8 Remove remaining DBG_CTOR etc. remnants from basctl
Change-Id: I383021580f69ac51ca65f3464bf863b800ccd931
2014-03-28 15:02:18 +01:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
5fb78604c1 Split TYPEINFO into plain and TYPEINFO_OVERRIDE
...where the latter contains SAL_OVERRIDE annotations

Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-26 11:54:55 +01:00
436cd90095 svtools: sal_Bool->bool
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
9278df2c21 sfx2: sal_Bool->bool
Change-Id: I73acb3a150b01114d32274a6842f6db9654b3e63
2014-03-19 09:21:24 +02:00
c3e3f46657 sfx2: sal_Bool->bool
Change-Id: I375a72c34e46778385a9fdc24c9ebd0f0a3f3c9b
2014-03-18 11:27:39 +02:00
7e8af4b249 basct: prefer passing OUString by reference
Change-Id: Ide803f793e829767fad89ab2aef776ef24fedb37
2014-03-17 13:30:51 +02:00
684baef506 sal_Bool to bool
Change-Id: Ib19ecab287396dc6d6cf4a77dcf7072c5c4c84f8
2014-03-16 09:39:12 +01:00
98666e8625 No need for a virtual OPropertyContainer::getTypes
(and rename to getBaseTypes for clarity)

Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-14 17:57:24 +01:00
d47ca30f1c No need for implGetBounds to be SAL_CALL
Change-Id: I4eb1f998de57a4ceeb7990c6e4a964ce0d07ea88
2014-03-11 15:35:52 +01:00
6c97bc4717 svx: sal_Bool->bool
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7
2014-03-11 08:18:24 +02:00
d2aba93a97 basctl: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I422ec5b0ad485d1f74191d4bf713367aeb7a0a3d
2014-03-10 17:39:52 +01:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
381f8a5673 sal_Bool -> bool in mostly vcl module
Conflicts:
	include/vcl/settings.hxx
	svtools/source/table/tablecontrol_impl.cxx
	sw/source/core/frmedt/fecopy.cxx
	vcl/inc/canvasbitmap.hxx
	vcl/inc/headless/svpframe.hxx
	vcl/inc/unx/salframe.h
	vcl/inc/win/salframe.h
	vcl/inc/win/salprn.h
	vcl/inc/win/salvd.h
	vcl/osx/DragSource.cxx
	vcl/osx/DragSource.hxx
	vcl/osx/DropTarget.cxx
	vcl/osx/DropTarget.hxx
	vcl/osx/OSXTransferable.cxx
	vcl/osx/OSXTransferable.hxx
	vcl/osx/clipboard.cxx
	vcl/osx/clipboard.hxx
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/canvasbitmaptest.cxx
	vcl/source/components/fontident.cxx
	vcl/source/control/edit.cxx
	vcl/source/control/spinfld.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/virdev.cxx
	vcl/source/helper/canvasbitmap.cxx
	vcl/source/window/dockwin.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/kde/UnxFilePicker.cxx
	vcl/unx/kde/UnxFilePicker.hxx
	vcl/unx/kde4/KDE4FilePicker.cxx
	vcl/unx/kde4/KDE4FilePicker.hxx
	vcl/unx/kde4/KDESalFrame.hxx

Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 03:19:47 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
2fbd9825bc Remove visual noise from basctl
Change-Id: I3e6a238a0bafbb70a7c22bde1f2258b8014ed2d2
Reviewed-on: https://gerrit.libreoffice.org/8232
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 17:01:07 +00:00
295bc8703f basic: remove use of sal_uIntptr in favor of more appropriate type
Change-Id: Ie878f43c7245838519fe7477b039827b079dde63
Reviewed-on: https://gerrit.libreoffice.org/8214
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-25 00:26:43 +00:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
dbfc495a9a Add config option used when we try to link one huge object file.
In theory, it should not be used, we use it now to mark duplicated
symbols from sdi slots as weak. See idl/source/objects/types.cxx.

Change-Id: I3c6fccfb96884df6b9e6eb35b8615ba4d66ca208
2014-02-21 07:52:24 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
bbe3bec949 Drop unused #include
Change-Id: Id05440ffb8eb9990d2d08f721d6914f3dbc86cab
2014-02-14 18:44:05 +09:00
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
064c628842 fdo#63154 Remove unused solar.h ref in vcl, basctl, desktop..
Change-Id: Ic0187495d8f7f64ddf9d3c202ec41201c9ac3a8c
Reviewed-on: https://gerrit.libreoffice.org/8001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-12 07:23:09 +00:00