3db8d606d5
hrc and src files: squeeze multiple newlines
...
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
0d8908b359
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part16
...
Change-Id: I78b3a0151397d4e69521e6b2451e93ea6e463376
2014-05-18 00:36:10 +02:00
d1516d488c
WaE: private field 'm_bOwnershipIsWellKnown' is not used
...
Change-Id: Ic4b784cb26f9127fe549f3866cbe53f0d0be0a78
2014-05-12 12:14:03 +03:00
4cbfbf4597
m_bOwnershipIsWellKnown is unused
...
Change-Id: I4dee9c4ce674249fca590e1c6d86685ed86da885
2014-05-12 09:46:36 +01:00
7209f84fd3
coverity#736136 Dereference null return value
...
Change-Id: I7668c95e2d40bb4e1e8e24627038b92f93b0008f
2014-05-08 09:56:21 +01:00
db3b1dd86e
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part3
...
Change-Id: Ibabd6d2d5e84fe007364bd1a4182a01ea2352b7a
2014-05-06 22:51:42 +02:00
4f9b21248f
simplify ternary conditions "xxx ? yyy : false"
...
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
45e7b4c18d
chart::ChartController::queryGL3DChart(): crash on concurrent model close
...
As seen in JunitTest_chart2_unoapi
[sch.ChXChartDocument::com::sun:⭐ 🫘 :XPropertySet]
it is possible that one thread closes the model while the main thread
tries to paint the chart via timeout.
In chart::ChartController::modeChanged() It's not obviously possible
to lock m_aModelMutex since that might deadlock with SolarMutex.
6 in SolarMutexGuard::SolarMutexGuard (this=0x2b742f846cc0) at /include/vcl/svapp.hxx:1579
7 in (anonymous namespace)::Frame::isActionLocked (this=0x1dbe1b0) at /framework/source/services/frame.cxx:2597
8 in (anonymous namespace)::Frame::close (this=0x1dbe1b0, bDeliverOwnership=0 '\000') at /framework/source/services/frame.cxx:1773
9 in chart::ChartController::notifyClosing (this=0x1e4ec00, rSource=...) at /chart2/source/controller/main/ChartController.cxx:877
10 in apphelper::CloseableLifeTimeManager::impl_doClose (this=0x1e03b98) at /chart2/source/tools/LifeTime.cxx:368
11 in apphelper::CloseableLifeTimeManager::g_close_endTryClose_doClose (this=0x1e03b98) at /chart2/source/tools/LifeTime.cxx:311
12 in chart::ChartModel::close (this=0x1e03ac0, bDeliverOwnership=1 '\001') at /chart2/source/model/main/ChartModel.cxx:654
main thread:
21 in chart::ChartController::TheModel::getModel (this=0x0) at /chart2/source/controller/main/ChartController.hxx:470
22 in chart::ChartController::queryGL3DChart (this=0x1e4ec00) at /chart2/source/controller/main/ChartController.cxx:1398
23 in chart::ChartController::modeChanged (this=0x1e4ec00, rEvent=...) at /chart2/source/controller/main/ChartController.cxx:486
24 in chart::ChartView::impl_notifyModeChangeListener (this=0x1e149f0, rNewMode="valid") at /chart2/source/view/main/ChartView.cxx:2823
25 in chart::ChartView::impl_updateView (this=0x1e149f0) at /chart2/source/view/main/ChartView.cxx:2730
26 in chart::ChartView::update (this=0x1e149f0) at /chart2/source/view/main/ChartView.cxx:2861
27 in chart::ChartController::execute_Paint (this=0x1e4ec00, rRect=Rectangle = {...}) at /chart2/source/controller/main/ChartController_Window.cxx:493
28 in chart::ChartWindow::Paint (this=0x201c970, rRect=Rectangle = {...}) at /chart2/source/controller/main/ChartWindow.cxx:83
Change-Id: Ib99edbb9862bc9dab76ed3e0c21eca5589fe7fdb
2014-05-03 00:48:13 +02:00
0a861a50b6
error C2872: ´chart´ : ambiguous symbol
...
Change-Id: Ic6d8366b2754c7f626552d66821d40319910559c
2014-04-25 19:15:30 +01:00
38b9fe8269
chart2: use constructor feature for WizardDialog
...
Change-Id: Ifcaae6401f1ad5069248111b568a1cf5c033f5ab
2014-04-25 10:51:25 +02:00
f7731b7301
chart2: use constructor feature for ShapeToolbarController
...
Change-Id: Ic0a9dc23ddfde00cbb2bfa7cf3983ff0c6276654
2014-04-25 10:51:25 +02:00
50634a20d3
chart2: use constructor feature for ChartTypeDialog
...
Change-Id: I5efc89d8d0139216c1ae92aa692704f9f58915ca
2014-04-25 10:51:25 +02:00
167cd68084
chart2: use constructor feature for ChartFrameLoader
...
Change-Id: Ibbbd41a30cd240250720aac7b45d0a394be5230b
2014-04-25 10:51:25 +02:00
b038c4ecdc
chart2: use constructor feature for ChartDocumentWrapper
...
Change-Id: I5b99d64be17a0e7d3c1bb630e1f35afe0eb62c81
2014-04-25 10:51:25 +02:00
899c018a2f
chart2: use constructor feature for ChartController
...
Change-Id: Ie6c5c0e20ae2b2f38f176dee90c33e5baba100a5
2014-04-25 10:51:25 +02:00
c1e8cd6f82
chart2: use constructor feature for ElementSelectorToolbarController
...
Change-Id: Iee99f1f86af4ed494dbbe33b31baeb707b7ed544
2014-04-24 22:03:37 +02:00
97a5ba4a71
remove comments why a file gets included
...
also remove some commented out code
Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
329332ba52
chart2: sal_Bool->bool
...
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
8d202fa72f
typo: paramter -> parameter
2014-04-14 12:32:54 +02:00
ba1452c261
Several more Window events to intercept for the GL3D chart.
...
But not painting or resizing events. Those are generic enough that no
branching is needed.
Change-Id: I0fb186da61c583c5326d2608b2153aced3fab77b
2014-04-11 09:36:40 -04:00
a3354ecf4f
Separate mouse event handlers for GL3D bar chart.
...
They are just skeletons for now.
Change-Id: I7e5e95ad8a2809125cbcf3affd17e663aafa99b0
2014-04-11 09:36:40 -04:00
6f97be903b
Reduce indentation by early bailout.
...
Change-Id: I64c88b007564d3ca7b4f4bd95a458fee6bda7854
2014-04-10 10:13:54 -04:00
ae4060cae9
Let's remove these...
...
Change-Id: Ie4f15c894c13fd52e1ee175381a1e62b33864d39
2014-04-10 10:13:54 -04:00
4b243d2201
whitespace cleanup in chart2
...
Change-Id: I85fdb62ff0e6606e2ac8537f477e7cb5bec3827a
2014-04-06 17:19:55 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
5b5e626503
Remove remaining DBG_CTOR etc. remnants from chart2
...
Change-Id: Iaf07f77b4228d4debb2620625b14ce7dc41e3a98
2014-03-28 15:23:09 +01:00
6e61ecd096
Merge back branch alg_writerframes to trunk
...
(cherry picked from commit b635b4fa4e42053d30ab639643d2236a20243f62)
Conflicts:
comphelper/inc/comphelper/TypeGeneration.hxx
comphelper/source/property/TypeGeneration.cxx
cui/source/factory/dlgfact.hxx
cui/source/inc/cuitabarea.hxx
cui/source/tabpages/tabarea.cxx
cui/source/tabpages/tabarea.hrc
cui/source/tabpages/tabarea.src
cui/source/tabpages/tparea.cxx
drawinglayer/source/primitive2d/polypolygonprimitive2d.cxx
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
drawinglayer/source/texture/texture.cxx
editeng/inc/editeng/unotext.hxx
editeng/source/items/frmitems.cxx
include/drawinglayer/texture/texture.hxx
include/editeng/brushitem.hxx
include/svx/sdr/primitive2d/sdrdecompositiontools.hxx
include/svx/svxids.hrc
include/xmloff/xmltypes.hxx
reportdesign/source/ui/misc/UITools.cxx
sc/source/ui/drawfunc/drawsh.cxx
sfx2/source/dialog/tabdlg.cxx
svl/source/undo/undo.cxx
svx/inc/svx/unoshprp.hxx
sw/Library_sw.mk
sw/inc/doc.hxx
sw/inc/format.hxx
sw/inc/frmfmt.hxx
sw/inc/swatrset.hxx
sw/inc/unomap.hxx
sw/inc/unoprnms.hxx
sw/source/core/access/accpara.cxx
sw/source/core/attr/format.cxx
sw/source/core/attr/swatrset.cxx
sw/source/core/doc/docdraw.cxx
sw/source/core/doc/docfly.cxx
sw/source/core/doc/notxtfrm.cxx
sw/source/core/inc/frame.hxx
sw/source/core/inc/frmtool.hxx
sw/source/core/layout/atrfrm.cxx
sw/source/core/layout/paintfrm.cxx
sw/source/core/text/inftxt.cxx
sw/source/core/text/porfld.cxx
sw/source/core/text/txtfly.cxx
sw/source/core/txtnode/fntcache.cxx
sw/source/core/uibase/app/docst.cxx
sw/source/core/uibase/app/docstyle.cxx
sw/source/core/uibase/shells/drawdlg.cxx
sw/source/core/uibase/shells/frmsh.cxx
sw/source/core/unocore/unoframe.cxx
sw/source/core/unocore/unomap.cxx
sw/source/core/unocore/unoprnms.cxx
sw/source/core/unocore/unostyle.cxx
sw/source/ui/fmtui/tmpdlg.cxx
sw/source/ui/fmtui/tmpdlg.src
sw/source/ui/frmdlg/frmdlg.cxx
sw/source/ui/frmdlg/frmpage.src
sw/source/ui/inc/frmsh.hxx
xmloff/source/text/txtprhdl.cxx
xmloff/source/text/txtprmap.cxx
Change-Id: Id3ffaa83bb5594d287f1ac8f2c1c9cf55c70946d
2014-03-28 14:31:08 +01:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
b5e11641a7
svtools: sal_Bool->bool
...
Change-Id: I90320997ed79be2556eafa4c35af6b968b378454
2014-03-25 14:32:56 +02:00
6292dbc3ef
Better to associate true for "enable" and false for "disable".
...
The code reads better this way, and certainly is easier on human brain
to process their logic.
Change-Id: I3150fca3385931b9fe01ad13cb11fab410331349
2014-03-24 22:24:30 -04:00
6c97bc4717
svx: sal_Bool->bool
...
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7
2014-03-11 08:18:24 +02:00
d1bffe3596
svx: sal_Bool->bool
...
Change-Id: I64d9c1bbe6ed85108783bf6a97329fcdc167ca62
2014-03-11 08:18:24 +02:00
57b89ea1c2
coverity#704563 Unchecked dynamic cast
...
Change-Id: I314d1110a45275be905c60b36e3e3a560a052272
2014-03-07 20:33:55 -06:00
c521f07208
editeng: sal_Bool->bool
...
Change-Id: I7da10ad3ba8017d64c723b53795348edf0e7dd6d
2014-02-27 12:30:30 +02:00
57779aa019
editeng: sal_Bool->bool
...
Change-Id: Id4174904487fc153d8e80471da7c829c52092f78
2014-02-27 12:30:26 +02:00
f2cdf8848c
Remove visual noise from chart2
...
Change-Id: Ic8dc71c2815df265e1935e629e0220396a50aaac
Reviewed-on: https://gerrit.libreoffice.org/8239
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2014-02-27 00:44:41 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
42deae1e9d
Translate German comments and remove superfluous ones as well as visual noise
...
Conflicts:
sc/source/ui/view/select.cxx
sc/source/ui/view/viewdata.cxx
sw/source/core/text/redlnitr.cxx
sw/source/core/text/txtfrm.cxx
sw/source/core/text/txtftn.cxx
sw/source/ui/table/tabledlg.cxx
Change-Id: I23371b913514d656552bc6f7fb4ba554ee6a3694
2014-02-21 15:31:09 +00:00
e8f8f24c84
vcl: sal_Bool -> bool
...
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a32ed92c95
editeng: sal_Bool->bool
...
Change-Id: I64cde75157fbdcda6ac92ca4064e6ab8197114c1
2014-02-21 12:19:24 +02:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
12f1faf7bf
svl: sal_Bool -> bool
...
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
0309070fb2
coverity#737027 Uncaught exception
...
Change-Id: I96b07d58233cf19708bbda68bcb19f5d7f6404df
2014-02-13 14:56:18 +00:00
5d061edbd7
coverity#737024 Uncaught exception
...
Change-Id: Ifdb5fb60c436e847ba85d690f8ca0087bd516ab7
2014-02-13 14:56:18 +00:00
5718b17d2d
Related: #i123862# use O*String's isEmpty() method...
...
to check for emptiness in chart2 module
Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 17b6784443432419e9aa9fddf56e5fa6c3ce4c60)
Conflicts:
chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx
chart2/source/controller/dialogs/ChartTypeDialogController.cxx
chart2/source/controller/dialogs/DataBrowserModel.cxx
chart2/source/controller/dialogs/ObjectNameProvider.cxx
chart2/source/controller/dialogs/res_ErrorBar.cxx
chart2/source/controller/dialogs/tp_DataSource.cxx
chart2/source/controller/dialogs/tp_RangeChooser.cxx
chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
chart2/source/controller/itemsetwrapper/ErrorBarItemConverter.cxx
chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
chart2/source/controller/main/ChartController.cxx
chart2/source/controller/main/ChartController_TextEdit.cxx
chart2/source/controller/main/ChartController_Tools.cxx
chart2/source/controller/main/ChartController_Window.cxx
chart2/source/controller/main/ControllerCommandDispatch.cxx
chart2/source/controller/main/DrawCommandDispatch.cxx
chart2/source/controller/main/ElementSelector.cxx
chart2/source/controller/main/ObjectHierarchy.cxx
chart2/source/controller/main/SelectionHelper.cxx
chart2/source/controller/main/StatusBarCommandDispatch.cxx
chart2/source/controller/main/UndoCommandDispatch.cxx
chart2/source/model/filter/XMLFilter.cxx
chart2/source/model/main/ChartModel_Persistence.cxx
chart2/source/tools/ExplicitCategoriesProvider.cxx
chart2/source/tools/InternalDataProvider.cxx
chart2/source/tools/NamedProperties.cxx
chart2/source/tools/ObjectIdentifier.cxx
chart2/source/tools/PropertyHelper.cxx
chart2/source/tools/RegressionCurveHelper.cxx
chart2/source/tools/WrappedProperty.cxx
chart2/source/tools/XMLRangeHelper.cxx
chart2/source/view/axes/VCartesianAxis.cxx
chart2/source/view/main/ChartView.cxx
chart2/source/view/main/ShapeFactory.cxx
chart2/source/view/main/VLegend.cxx
chart2/source/view/main/VTitle.cxx
Change-Id: Ia013e3d1d215f7391d5bee4b4e80eedc2a3a724f
2014-02-10 11:43:46 +00:00
61e28e86ed
add a way to dump chart content to console
...
CTRL + F12 will dump the chart with the XShapeDumper
Change-Id: I1f40ddf7f51c2038be7af8fc56f626393f11da90
2014-02-06 16:15:05 +01:00
186b4ebc99
convert specialised SvStream::operator>> methods to ReadXXX methods
...
as preparation for converting the SvStream::operator>> methods on
primitive types
Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-02-04 22:50:39 +00:00
90d39a8a22
Resolves: #i124085# disabled CF_DIBV5...
...
(no advantages but some problems), increased png support
(cherry picked from commit c991f7cae8dcb306cb0d1f32bc5fcd8ea0a1ea81)
Change-Id: I52bef1295b32eb3692a0428c96edd0c55287f34a
2014-01-30 09:21:30 +00:00
d5d2e280bd
bool improvements
...
Change-Id: I4fb554a0b703b29cb2dc70fc11111a4f2fa9af8e
2014-01-28 20:26:30 +01:00
