Commit Graph

82 Commits

Author SHA1 Message Date
036a660a86 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part11
Change-Id: Ibe0a1006aba2b6cbd87c0bd6ca3acbf9ba7b0fbe
2014-05-13 23:20:26 +02:00
da1425650b add missing modelines to idl files
Change-Id: If52651c70ee659c83ef127da4fe5e266cfe7eec2
2014-04-24 11:58:14 +02:00
27b7175e36 Clean up function declarations
Change-Id: I2478861e79bbb0f6d7e8a0b7bc59a81f457d92dc
2014-04-09 09:47:36 +02:00
1fc26b8112 Cosmetics (to ease work related to finding unused functions)
Change-Id: I88b7659fdfdcba43e69ef7489573b28952c8328c
2014-04-03 15:28:50 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
c6d114be1f std::exception retrofit sequel
Change-Id: Ide9234c50592fe4f12eb1f6ea836ad60ce4697df
2014-02-27 08:39:30 +01:00
83d51e244d Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Change-Id: Ife614637082036dd17412f247be79233326c4f0b
2014-01-22 11:39:22 +01:00
66397a4fd2 fdo#72598 Remove SunStudio cruft from code base
Change-Id: I5150eec33228e18e274a8ae4effd3f185851b7f4
Reviewed-on: https://gerrit.libreoffice.org/7103
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-16 20:52:39 +00:00
9a01133a66 -Werror,-Wunused-member-function
Change-Id: I557d9628478b0cddf5a2b176403bdd67db5a0695
2013-11-14 10:14:58 +01:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
ca78613fa0 Unlike idlc, unoidl doesn't support out-of-range byte consts
Change-Id: Ib1c98ea10a2d05e74a3aae9b2868a69c66efa543
2013-09-19 08:16:18 +02:00
e67b072c8e Avoid warnings about unused test functions
Change-Id: I6b2a40c4b95555c4d8bf0d8674fce46accd49965
2013-05-07 10:14:01 +02:00
904b3d1fce Up-cast conversion constructor for css::uno::Reference
Based on a previous patch by Noel Grandin,
<https://gerrit.libreoffice.org/#/c/3613/>, and borrowing from
boost::is_base_and_derived (see comment in include/com/sun/star/uno/Reference.h)
to avoid including Boost headers in URE headers.

Change-Id: Iade5af144dd73ef03bd7d96000134c7a66a5e591
Reviewed-on: https://gerrit.libreoffice.org/3699
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-05-07 07:14:41 +00:00
ce2991ee86 Forbid old-style services/singletons inheriting new-style services
...does not make sense.  Adapted some old-style services accordingly, where the
inherited service had been changed to new-style after the fact.

Change-Id: I5f3e4ddf99160778a319062a6c84f83529ff177b
2013-04-03 11:30:06 +02:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
b854de954f deprecate oustringostreaminserter.hxx
the intent of this header has canged over time. now it is already
systematically included with ustring.hxx and the operator overload it
provide fit nicely there...

Just to be safe, since that include as been added to the api during the
3.5 timeframe and therefore is already in 'production'
the header remain and simply attempt to include ustring.hxx
but a warning is issued indicating that this header should not be used
anymore... in a couple of major release we will thenr emove it completely

All internal users of that header are converted.

Change-Id: I8934c55f089e29d78c0f5649b7c87b2ecf024bad
Reviewed-on: https://gerrit.libreoffice.org/634
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-18 10:10:06 +00:00
195f17ee40 migrate some of the biggest consumer of osl_*InterlockedCount to osl_atomic
Change-Id: I0e6992afbeffaf3b993e6630fb396d93012890e0
Reviewed-on: https://gerrit.libreoffice.org/632
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-17 14:26:12 +00:00
850d9be56d Bin no longer used iOS cppunit stuff that breaks build even
Change-Id: I78c71b22816834c66c8283e3d85e357b7b8d2836
2012-08-01 19:19:04 +03:00
753e9b3d45 udkapi, offapi: do not use #include "foo":
Evidently on Windows, the newfangled ucpp handles #include "foo"
differently from #include <foo> and treats it as a relative path, while
the angle brackets always result in absolute paths.
Since relative paths result in infinite rebuilds if make is invoked in a
different directory, don't use #include "foo" in IDL files.

Change-Id: Iedcda3a4be5542389a0be086f14541cda8dc5323
2012-07-30 20:49:09 +02:00
6080259862 allow using rtl::OUString etc. simply as OUString, without rtl::
http://lists.freedesktop.org/archives/libreoffice/2012-April/029940.html

The RTL_USING #define (set by gbuild for anything that's not public
API) allows to use such classes simply by their name, without having
to use the namespace or do explicit using rtl::OUString (which half
of the sources do anyway).

Change-Id: I7edaf12cd278489cdc1d5ff782f0a86361c13c0a
2012-07-16 16:03:03 +02:00
328e2263fb targetted re-work of cppunit pieces. 2012-06-27 19:13:11 +01:00
46b8dbda43 re-base on ALv2 code. 2012-06-26 21:48:59 +01:00
c3a6a57fc2 re-base on ALv2 code. 2012-06-13 14:18:29 +01:00
9e7d5cd530 cppu: use InternalUnoApi 2012-04-09 21:04:37 +02:00
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
6e67c03dc0 Enable -Wnon-virtual-dtor for GCC 4.6
...which has the necessary features to support it.

Change a lot of classes to either contain a protected non-virtual dtor
(which is backwards compatible, so even works for cppumaker-generated
UNO headers) or a public virtual one.

cppuhelper/propertysetmixin.hxx still needs to disable the warning, as
the relevant class has a non-virtual dtor but friends, which would still
cause GCC to warn.

Includes a patch for libcmis, intended to be upstreamed.
2012-03-14 13:32:02 +01:00
7c704c78d3 Removed some unused parameters; added SAL_UNUSED_PARAMETER.
SAL_UNUSED_PARAMETER (expanding to __attribute__ ((unused)) for GCC)
is used to annotate legitimately unused parameters, so that static
analysis tools can tell legitimately unused parameters from truly
unnecessary ones.  To that end, some patches for external modules
are also added, that are only applied when compiling with GCC and
add necessary __attribute__ ((unused)) in headers.
2012-01-21 15:21:16 +01:00
63141d21b1 -Werror=sign-promo fixes 2011-12-19 11:33:12 +01:00
051fdda153 cppu: convert to gbuild
Because of unit tests is here custom target where are idl files
processed.
2011-12-19 10:14:51 +01:00
24b4c075d5 remove include of pch header in cppu 2011-11-27 13:02:56 -06:00
70a6b9ffbd New sal/log.h obsoletes osl/diagnose.h and tools/debug.hxx.
* New SAL_INFO..., SAL_WARN... macros.
* New SAL_STREAM supersedes OSL_FORMAT.
* oustringostreaminserter.hxx moved from unotest to rtl (and always UTF-8 now).
* TODO to enable GCC __attribute__((format)) in sal/log.h (requires call-site
  cleanup).
* Further functionality in tools/debug.hxx (DBG_MEMTEST, DBG_CTOR, etc.) not yet
  addressed.
* Some replacements tools String -> rtl::OUString.
2011-11-22 09:41:47 +01:00
c506e1852a fdo#42865: cppu,cppuhelper,testtools: no mapfile
Instead, build with VISIBILITY_HIDDEN.
2011-11-15 20:52:00 +01:00
e3712f9d35 Fix build --all depend=x. 2011-11-14 11:50:26 +01:00
bf1f0183d5 Some fixes for "clang version 3.1 (trunk 142234)" (with --enable-werror, on Linux x86_64). 2011-10-18 23:10:56 +02:00
6671fa81db Removed uses of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *(). 2011-09-27 20:22:03 +02:00
1c69052b52 Bypass building the iOS cppu_unittester_all for now
We can't build it here at this point during the build after all. We
use static linking on iOS, and we would need to link with -lgcc3_uno
from bridges which has not been built yet. It seems that any
meaningful unit tests for iOS actually need to be built in a
"subsequent" stage.
2011-09-20 16:59:05 +03:00
d996328cd5 sb140: #i113503# mixing system CppUnit and OOo STLport does not work, backed out a6913c9677c2
For LibO, that just means replacing sal/cppunit.h with sal/precppunit.hxx.
2011-09-12 22:47:50 +02:00
07ded12adc Use OBJCXXFLAGS instead of duplicating it 2011-08-01 14:47:08 +03:00
46bd39b0d3 Add statically linked cppu unit test for iOS 2011-08-01 00:59:09 +03:00
e224ac0e31 use rm -f to not complain about attempting to remove nonexisting file 2011-06-13 16:27:50 +02:00
28bff17eac Can't run any qa when cross-compiling 2011-06-05 02:23:46 +03:00
1fa55878d9 restore cppunit test, Sequence ctor from sal_Int32 is now explicit 2011-03-18 21:49:26 +00:00
a4632bb6a2 only test this on certain archs 2011-03-18 13:37:29 +00:00
16d941cb03 Add PowerPC to the right branch 2011-03-18 14:30:33 +01:00
71dee2f153 move cppumaker test to cppu 2011-03-15 13:41:19 +00:00
5f66037d6d remove empty TESTSHL2LIB 2011-02-24 20:44:46 +00:00
81ef04be69 Trying to remove the stlport mention from the code 2011-02-09 19:58:43 +01:00