Commit Graph

34 Commits

Author SHA1 Message Date
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00
8bb2ce61c0 fixincludeguards.sh: some smaller dirs
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-19 11:10:13 +02:00
6a964dcf0f Avoid possible memory leaks in case of exceptions
Change-Id: Ibadadacbe09a93e7d7a7210868c52a8fa582d427
2014-04-17 10:57:00 +09:00
8d202fa72f typo: paramter -> parameter 2014-04-14 12:32:54 +02:00
a78aa2038d Remove visual noise from helpcompiler
Change-Id: Ied20352592de019c3b4735af8cc63947cd7d61a2
Reviewed-on: https://gerrit.libreoffice.org/8266
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 09:11:06 -06:00
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
52bbd9cc00 remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls
Convert code like:
    aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
    aStrBuf.append( "ln(x)" );
which compiles down to the same code.

Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20 10:07:32 +02:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
176ac1e616 Remove unnecessary SyntaxHighlighter::Tokenizer statefulness
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it.

Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
2013-10-28 13:48:14 +01:00
c99267b326 Fold SyntaxHighlighter::initialize into ctor
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused.

Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28 13:48:14 +01:00
f5e8be8bb1 Remove unused SimpleTokenizer_Impl::nLine/nCol
...which are never read; remove thereby unused parameters from functions.

Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-28 13:48:13 +01:00
9932749854 Use conventional std::vector idioms
Change-Id: I4d26372ea40e7890b76461a764435f8948466ae1
2013-10-22 18:19:18 +02:00
b7f20ef33f Unwind HighlightPortions typedef
Change-Id: I0ecc15f9bfd557d0a70a05536906a4984a46463c
2013-10-22 18:19:18 +02:00
ae1bb97f14 remove last uses of config 'GUI' variable
Change-Id: I97188235f0b72b5b54423e05deeaf17c5c681048
Reviewed-on: https://gerrit.libreoffice.org/4188
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-06-20 11:51:10 +00:00
0bb8c03253 helpcompiler: remove Package_inc
Change-Id: Iddafa9068edcc20135c08ed205b8fb7fb5382eba
2013-05-07 01:41:23 +02:00
72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
18af827875 HelpLinker: add comment for mysterious XML parsing
Change-Id: I9aa5fd2cb0cb4eae0a94f8d3d6b6185a1fcffdc4
2013-04-08 13:40:59 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
cfe0fbb039 do not create index for shared help module
Change-Id: I83f9b99abcc952dfea924662a0db8d98efc56307
2013-02-28 12:30:50 +01:00
f094641d3a add opt -nolangroot needed for gbuild
Change-Id: Id76dfc5698619f8095e0c682ae4ce5e181c9a599
2013-02-26 15:24:53 +01:00
2f1c0be453 avoid string substr/replace with invalid pos
Change-Id: Iceb9851bcb5e6fe66efd701fcb31e16596fe8b5a
2013-02-26 15:24:53 +01:00
a775aa57f7 compact help xml files with xslt which removes the cruft
Change-Id: Iee923174169d6ba9961a9cee14115c9a4bf7ba09
2013-02-13 16:37:35 +01:00
496222d64d add headers to new files
Change-Id: Iaa390e50ed3cfe2ba9770c446869158b758bc48d
2013-02-13 12:11:08 +00:00
62fb1958f6 make building help not crash
a) subStr is not ours to delete, belongs to the OString
b) and anyway subStr points to the buffer of the out-of-scope temporary OString

Change-Id: I1689c6626c52ae9d94e0cfa5de4235be3c1f3262
2013-02-13 11:52:57 +00:00
67b8c0339e fdo#41737 syntax highlighting of Basic code examples in offline help
Change-Id: I7dc5b189e98a0351bac0eab28c1161b5893f5ef1
2013-02-13 10:19:21 +01:00
4ab3d5bb6f WaE: warning C4101: 'ex' : unreferenced local variable
Change-Id: I99a66ac3af8e391b5feaeafbb3abd63dcdd2bb2b
2013-02-13 10:19:15 +01:00
d06c698b79 Basic code syntaxhighlighting added to LibreOffice help
Change-Id: Id47172d0386e7aa28d82178f04b5f626f0c441fe
2013-02-13 10:19:14 +01:00
c29098917a Get rid of (most uses of) GUI
GUI only takes values UNX or WNT, so it is fairly pointless. One can check
whether OS is WNT or not instead.

Change-Id: I78ae32c03536a496a563e5deeb0fca78aebf9c34
Reviewed-on: https://gerrit.libreoffice.org/1304
Reviewed-by: Peter Foley <pefoley2@verizon.net>
Tested-by: Peter Foley <pefoley2@verizon.net>
2012-12-25 17:53:25 +00:00
fb0b27491d loplugin: unused std::strings
Change-Id: I1b1bbed72cf3e54115ce1a10c31f80eb8e3bea28
2012-11-14 10:11:33 +00:00
b9d1006ebb re-base on ALv2 code. Includes:
#i118662# remove berkeleyDB from module l10tools
    Patch contributed by Oliver-Rainer Wittmann
    http://svn.apache.org/viewvc?view=revision&revision=1213189

    reportdesign: remove extra items from Help menu
    Patch contributed by Ariel Constenla-Haile
    http://svn.apache.org/viewvc?view=revision&revision=1201215
2012-10-02 12:15:41 +01:00
eaa81cc2f0 move help compiler/linker/indexer to a new module
we may want to use syntax highlighter class from svtools later,
which is not available for l10ntools

Change-Id: I5a06b77cb6935e3ef68015fb608aa26ac7c53fac
2012-09-16 20:41:26 +02:00