2bd7767d01
Resolves fdo#70681: fixincludeguards.pl: all that's left
...
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-15 12:50:46 +00:00
8fd54c107a
Related fdo#60338: Do not use umask(3) in a MT program
...
Change-Id: Ie515201e44ad58faf623a04981e891c0b3f4a19d
2014-05-13 11:39:30 +02:00
096d1d6e7c
This code is not linked against sal
...
Change-Id: I7f44cd54732a60e9655f0bbb90615f3d3988ce58
2014-05-12 12:32:56 +02:00
70e744b215
fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IF
...
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-05-12 11:32:38 +02:00
c327acab9e
remove globally disabled warnings from source files
...
Change-Id: Ic7b092a24b4d1e48ca11e53b507da5c2bfdeabe8
2014-05-10 13:03:20 +02:00
9037e2289d
remove presys.h and postsys.h
...
Both files are nearly identical to prewin.h and postwin.h
Change-Id: I1f45e46dfcc00043a9e2df82e0070cd1b976c4af
Reviewed-on: https://gerrit.libreoffice.org/9294
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-09 18:17:19 +00:00
177d32b6b8
shell: sal_Bool->bool
...
Change-Id: I4313819fa40885a3cfa4a137888ae457d8d839a8
2014-04-30 08:43:41 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
d59fe933fe
Use boost::noncopyable
...
Change-Id: I1cd2ad1284f2fb9f6847cdb9175a5872a66726cd
2014-04-03 08:20:19 +02:00
6a3b0b7cc4
Explicitly mark overriding destructors as "virtual," Mac OS X redux
...
Change-Id: Ib7ab02bc3cdadbdfe0e0787560d1dd562eb85be9
2014-04-01 21:30:38 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
5eb733cf67
loplugin:saloverride
...
Change-Id: I028d6da250bad64cca2d85c8bbf4a3b5a1300f1b
2014-03-30 21:55:17 +02:00
22a7f8b1f5
coverity#982766 Dereference null return value
...
Change-Id: Ic9efce80ea2c2489e3ef070ac4c6106c811e9889
2014-03-28 13:13:59 +00:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
bc13d935e6
coverity#708176 Uninitialized scalar field
...
Change-Id: I1d7b005c563a17b31a3bf565dd27d43868b3129c
2014-03-22 20:56:28 +00:00
86a32589e9
Find places where OUString and OString are passed by value.
...
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
c84f0dae40
Blind Windows build fix
...
Change-Id: Ib8403f199057bec926fe1da1bac5738046ccb245
2014-03-07 10:32:45 +02:00
ff3f66d4be
Simplify
...
Change-Id: Id6dc46c8b24441481d950ef0423da800a0f2ed9d
2014-03-07 10:17:19 +02:00
ee39446353
Why would we need GNOME and KDE scripts on OS X?
...
Also, the senddoc script seems fairly AIX/Linux/X11-specific.
Change-Id: I06c417df3256204d2b8b29b3978f89b00c15f6f0
2014-03-07 10:12:29 +02:00
42c9f35da2
shell: get rid of separate Library_syssh_win.mk
...
Change-Id: I12f38bab6ea7207b79994556f0ab6798d2d1d9da
2014-03-03 23:44:11 +01:00
72ef2d526b
std::exception retrofit sequel
...
Change-Id: I7461c320e98b9a3605db26f4d58200789e1477df
2014-02-27 08:39:31 +01:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e44a7eefb7
KDE: don't throw on TemplatePathVariable
...
This is required after commit
838b77f5f3d6d8fd98891e99a23ff78a6a357cb2.
Actual functionality is still missing.
Change-Id: Ib94d8a982609de730d9c61bf7bf9886093c51f5b
Reviewed-on: https://gerrit.libreoffice.org/8367
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 09:09:40 -06:00
d18a2753d5
Remove visual noise from shell
...
Change-Id: I1857fd7a9aeda38cb8ef2a0eda7783203b7658ed
Reviewed-on: https://gerrit.libreoffice.org/8311
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 07:55:24 -06:00
838b77f5f3
Resolves: rhbz#1065807 use xdg ~/Templates for default Template location
...
(if it exists)
Change-Id: I98fc9fd54d1f56c8bed24ce4d2ebf53756ded2cc
2014-02-25 10:45:27 +00:00
5673bac9a7
Revert partially "Replace deprecated std::auto_ptr with boost::scoped_ptr"
...
This reverts partially commit 4a9347fa320d892b60fd03082925f63a1d69cfb9.
Change-Id: Ibbc626f8d30de040fe9e809b44d5ffc9513720fb
2014-02-25 16:55:00 +09:00
4a9347fa32
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: I8e11ffe888aac8887c4c0875c41de51f343debae
2014-02-25 16:33:15 +09:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
eeee164f67
cppcheck: redundantAssignment
...
Let's not forget the result of RegDeleteValueA call
Change-Id: I9458040bc3a8960ab740ee3c5211eaa9ba24b1aa
Reviewed-on: https://gerrit.libreoffice.org/7772
Tested-by: David Tardon <dtardon@redhat.com >
Reviewed-by: David Tardon <dtardon@redhat.com >
2014-02-16 10:45:43 +00:00
5c8a3bfc7e
Don't call pclose(NULL)
...
Change-Id: I6540ec2b900e82745d5e661dfa920f85db6c0ff2
2014-02-10 11:23:45 +01:00
f669e7907b
Properly encode cmd line for popen
...
Change-Id: I1f7799920b6732a6cd128143dfa7ce282bad25c6
2014-02-10 11:23:45 +01:00
46e63b70d9
instdir/program/senddoc lacks executable mode bits
...
(but appears OK in "true" installation sets)
Change-Id: I1c044409b97bd3121509a2185dfac89298312954
2014-02-10 10:12:08 +01:00
be053c9a80
Spelling correction: s/retrive/retrieve/
...
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20 23:26:58 +02:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
9ed364774c
Adapt all (non-extension, SharedLibrary) .components to environment="..."
...
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
a83b2af9ab
Clean-up uno/lbnames.h
...
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
2013-12-16 21:43:12 +01:00
181769251d
Looks like the Windows tag is still LANG_ORIYA
...
Change-Id: I16e0be513b0b7ecbc54c0e2cb8974e801c13adbe
2013-12-12 08:56:18 +01:00
108eee306e
Related: rhbz#1040291 Change language name from 'Oriya' to 'Odia'
...
Except for our external api where the Oriya is stuck (and similar for
the vba implementation)
Change-Id: I8288c930567385eea49a4c303727b13ef8b8a89f
2013-12-11 15:11:18 +00:00
73342dbb82
remove unnecessary RTL_CONSTASCII_STRINGPARAM
...
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.
Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-22 08:07:19 +02:00
f01580ce9c
Windows: Require at least Windows XP SP2
...
* Windows XP SP2 is 0x0502, see
http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
this is done module wide now. So the overall behavior
is as before. This seems to be the best compromise for
now.
* We need at least SP2 because of the bluetooth stuff
used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
project specific precompiled header files.
* All local definitions of WINVER are removed, because
the global WINVER setting makes them obsolete now.
To the relation of the three macros:
Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.
WINVER and NTDDI_VERSION can be set idenpendently each
for itself.
Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org >
Tested-by: Thorsten Behrens <thb@documentfoundation.org >
2013-11-20 07:15:16 -06:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
6b1aff89ed
-Werror,-Wunused-member-function
...
Change-Id: I5c14c2c305aa6809b4a1e164b8bdc4eeb877abbd
2013-11-14 10:14:58 +01:00
89b1a0419f
-Werror,-Wunused-exception-parameter
...
Change-Id: Ia5b7f7629a07b84b4e8042aa7f8778faa4a11b50
2013-11-14 10:14:58 +01:00
0a9ef5a18e
convert OUString 0==compareToAscii to equalsAscii
...
Convert code like:
0 == aStr.compareToAscii("XXX")
to
aStr.equalsAscii("XXX")
which is both clearer and faster.
Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11 12:58:12 +02:00
da20c7f439
remove unnecessary use of OUString constructor in SHELL module
...
Change-Id: Ibdb750dc8e0f4cd0f186d5801c0a269edd939547
2013-11-08 14:50:59 +02:00
bcb51cff22
fdo#63020: Replace ::comphelper::stl_begin()...
...
And use some templates inside include/com/sun/star/uno/Sequence.hxx
Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47
Reviewed-on: https://gerrit.libreoffice.org/6599
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2013-11-07 10:43:34 -06:00
9bd00edca5
include <stack>
...
Change-Id: Iedaacd9981a6ca186ab5e1f9715ed4fcf4ff0cb7
2013-11-06 17:45:04 +09:00
9c2ab71230
Drop unnecessary #includes
...
Change-Id: I9659279233067a8946a9e54be2f22439854a961e
2013-11-06 17:08:58 +09:00
5811602287
windows: remove _CRTIMP and _NTSDK definitions
...
Those have no effects with current windows SDKs.
Change-Id: I6fb2f8045fe1fc0ed4beef51dde487b7a7dfdc28
2013-11-05 09:28:55 +01:00
48dd3571f8
fixincludeguards.sh: shell
...
Change-Id: I987c54b15c271fc80b7efd25933e13950f974423
2013-11-05 09:28:53 +01:00
