Commit Graph

57 Commits

Author SHA1 Message Date
48f0a5ed35 Typos
Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4
2015-02-18 21:59:02 +01:00
edbb1b6be7 loplugin:deletedspecial
Change-Id: I0b91d813d0ec432f15aaf2d31a11dd4c505e2e54
2015-02-07 12:35:57 +01:00
0866023faf Get rid of std::auto_ptr in stable URE interface
...the deprecation-warning noise is getting ever louder, and eventually auto_ptr
will just disappear.  Just surrender and use good-old plain pointer and deletion
in dtor---it's probably the best to do in this stable interface.

The change is backwards compatible.  For one, in all relevant standard libraries
(libstdc++, even in debug mode; libc++; msvcrt) sizeof(auto_ptr<T>) equals
sizeof(T*).  And for another, the removed UnoUrlDescriptor ctor was only called
from within cppuhelper and had deliberately been left out of
cppuhelper/source/gcc3.map (so isn't exported at least on Linux)---marking it
SAL_DLLPRIVATE had probably just been forgotten when retrofitting cppuhelper
with CPPUHELPER_DLLPUBLIC annotations.

Change-Id: Ic8bce29d93938f2b2e0a264baee85132668e1294
2015-01-27 10:03:01 +01:00
619b13f054 Variadic cppu::WeakComponentImplHelper
Change-Id: I79371b4ad9d29a5ab8fd01244c3f80db92b07f97
2015-01-16 15:17:05 +01:00
d3ce5b298e Fix getTypes() of OPropertySetHelper and derived
...broken with 60d60caf99a40ca0c3891bf230c5a1fdbae5f49c "Renamed XPropertySet2
to XPropertySetOption" et al

Change-Id: I684736ffafc4642548b7c24171cc52c1acb32252
2015-01-16 10:19:36 +01:00
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
45ec1d9b56 brute-force find-and-remove of unused #define constants.
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
43a0bae9f6 bla, bla
Change-Id: Ied7a6f8d5b4555dc561fc24d3b6b9743e9e2a266
2015-01-07 17:45:56 +01:00
8ad48d881b Variadic cppu::ImplInheritanceHelper
Change-Id: I7d958fdf328e44a0d299b29a3a165425731ccf7c
2015-01-07 17:42:23 +01:00
0d44e98d6a Variadic cppu::WeakImplHelper
Change-Id: Ia02a7c94ca282f28fa3c191dd65a71b6bf031792
2015-01-07 12:20:54 +01:00
40d4f917e3 sal, cppuhelper headers a little more complete and self-contained
All of them now build as-is (doing that is actually a pain because some
are named the same as C library headers and clang looks first in the
directory where the source file is in...).

Change-Id: Ief6e245c8f49fcee678aebd46394c19e4cb47f51
2014-11-19 11:55:11 +01:00
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
b4895186c3 coverity#706283 Uncaught exception
Change-Id: I2c3f10894ffe514dbc71cd1dd672685aa8f09a0d
2014-10-08 20:45:11 +01:00
3b59dbbffd remove HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macro
This is supported in GCC 4.6.0 already:
https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html

Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
2014-10-02 20:00:18 +02:00
86cd29772e remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macro
This has been supported by GCC and clang for a very long time.

Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-10-02 20:00:17 +02:00
5139fad429 loplugin: cstylecast
Change-Id: I84873c9f84651dc8a1337f37c63020b461314e1b
2014-09-22 12:24:23 +02:00
9685276b97 cppu and cppuhelper: loplugin: cstylecast
Add a macro in include/cppuhelper/implbase_ex.hxx
to make initialising the type_entry classes a little less verbose.

Change-Id: I0904b5b9db269c92bc89e7ce3d6c8b09350c9897
2014-09-17 07:08:23 +02:00
03e0bd6b3b [API CHANGE] Removed two cppuhelper deprecated headers.
The headers cppuheader/compbase.hxx and implbase.hxx. They have been deprecated
since 2001. Moved the definitions of the deprecated functions to
cppuhelper/source/compat.cxx.

Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, adding fixes and clean-up
in cppuhelper/source/compat.cxx and odk/Package_odk_headers.mk

Change-Id: I48b3cbf551b59d72614737a883a96aab55fc2090
2014-08-08 11:25:55 +02:00
8416a65af1 fix spelling structur -> structure
Change-Id: I7aa4a9bf72732db95a67cee368f3a83a0d71bb9c
2014-07-17 14:49:41 +02:00
594a5e20f7 coverity#1224998 Uncaught exception
Change-Id: I96db9ab47b9494a1d71259e93ad393bd70c39d97
2014-07-14 09:21:00 +01:00
da906ab937 cppuhelper: remove SAL_THROW macro
Change-Id: I54141071396d04e7bead56da14a665b8556ba6d2
2014-06-05 08:17:46 +02:00
aa668984f6 coverity#707714: Uninitialized pointer
Change-Id: I98e21ad28ea31bae41894d1804cbafe0c247035d
2014-05-01 08:59:46 +01:00
a1b1b79adb For GCC 4.9, extend range where -Wnon-virtual-dtor is ignored
Change-Id: Ib44f5b2f6be7ae583d8931fc8bf5cb060ef21610
2014-04-16 14:41:45 +02:00
fa0ffdbeb5 cppu::OMultiTypeInterfaceContainerHelperVar hashImpl param is unused
...since f059134fab0f91b7a15594ad06536a13fbfae034 "INTEGRATION: CWS
cppuhelpshrink: #i72766# save memory in cppuhelper, using a vector instead of a
hash_map" (but a dummy "void" default is left in place for backwards
compatibility).

Change-Id: I3bb0af8158f34737d41c344464f3cf944e2891ed
2014-04-15 07:46:43 +02:00
0e970f3ba2 typo: occuring -> occurring 2014-04-14 12:33:14 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
60c2b472de coverity#708183 Uninitialized scalar field
Change-Id: I45563c32a75ec2c95d4ea13d1cf9179c44cf1fd8
2014-03-22 20:53:48 +00:00
38cf887abd Replace UTF-8 no-break space to ASCII space
UTF-8 no-break space causes C4819 warning in MSVC with CP932.

Change-Id: I83a6ea6d060d132d21d8ea3141051f850d0e6bd2
Reviewed-on: https://gerrit.libreoffice.org/8628
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-19 10:25:27 +00:00
8fb6f4a74b Mark overriding cppuhelper class template member functions as SAL_OVERRIDE
Change-Id: I51942d37eacd11000c08a784d8a995bd8f9f972c
2014-03-11 18:31:48 +01:00
023c00b7c4 cppuhelper: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I1e355c0ef9548d505de996304837d3d0910bd9b8
2014-03-10 17:39:53 +01:00
4c2f8fd74c coverity#707714: Uninitialized pointer
Change-Id: Id8cf528f9c4ab76fda5be80d8fd44d7202a377d7
2014-03-08 16:36:55 -06:00
8792ec7b21 Remove visual noise from include
Conflicts:
	include/framework/preventduplicateinteraction.hxx
	include/sfx2/sfxbasecontroller.hxx
	include/sfx2/sfxbasemodel.hxx
	include/toolkit/awt/vclxtabpagemodel.hxx
	include/vcl/field.hxx
	include/vcl/settings.hxx

Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 09:51:32 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
7f902e1697 cppuhelper: sal_Bool -> bool
Change-Id: I6e0e6c1e4880a652ea4d8f0cccf9d8103c2cbbef
2014-02-17 17:55:18 +01:00
bd20500cf3 Simplify access to theCoreReflection singleton
Change-Id: I9901991a320b87895230a92095c9c7d3109380a6
2014-02-07 12:03:03 +01:00
9bd0e895a4 coverity#1079000 Uncaught exception
Change-Id: I7ffee42abe03c34d68b6168328143666d72e7efc
2014-01-29 16:41:32 +00:00
9038a3ef7c cppuhelper: Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Change-Id: Ibed63566266328f84432ad2019e58265d9d30fc3
2014-01-29 11:08:32 +01:00
c2c530da69 Introduce static inline cppu::acquire(), and make use of that.
This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.

Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-22 15:09:28 +01:00
f278397787 Change _get_implementation()'s not to do initialization directly.
Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.

As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.

Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-21 21:25:22 +01:00
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
66397a4fd2 fdo#72598 Remove SunStudio cruft from code base
Change-Id: I5150eec33228e18e274a8ae4effd3f185851b7f4
Reviewed-on: https://gerrit.libreoffice.org/7103
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-16 20:52:39 +00:00
2f7b329297 [API CHANGE] remove cppu::loadSharedLibComponentFactory w/ rPrefix again
...it was never meant to be called by client code anyway and is no longer needed
to be exposed since the global service manager implementation moved to
cppuhelper.

Change-Id: If2d0510b2364084d36edeb156a3459d9b8aeb983
2013-12-13 15:13:57 +01:00
5ee74052ed Clarify cppuhelper/shlib.hxx should never have gone into URE interface
Change-Id: I44415f976a47bf676ab8c2f309590eb2c8afb6ce
2013-12-13 12:37:32 +01:00
0fa31bed9a Default OMultiTypeInferfaceContainerHelperVar equalImpl parameter
...and assorted OUStringHash clean up

Change-Id: I779904e1275e8df88f567beb388d1d11af9e9671
2013-12-06 12:03:59 +01:00
2f3305e939 fdo#65108 inter-module includes <> include/cppuhelper
Change-Id: Ife81bf3dacb574b664982f3b4d2c7af9eb78a66a
2013-11-09 18:48:40 -06:00
0bd7f12d41 fixincludeguards.sh: include/c*
Change-Id: Icba422d99836518a1b662b15144bc9334bed1473
2013-10-23 23:22:30 +02:00
615a69e33f Clean-up std::bad_alloc handling
...post 0bc89aac4c64bb833e387657f680e194c26aef97 "cppumaker: Allow UNO interface functions to throw std::exception."

Change-Id: I232a1b266a45d39856d44a2f4e012b5df10fa880
2013-10-20 18:24:57 +02:00