Commit Graph

6635 Commits

Author SHA1 Message Date
479862c750 coverity#1317300 Untrusted array index read
Change-Id: Ia9fe42974ffe24f6a679396b5d7ca672c0459f4b
2015-08-24 14:32:28 +01:00
7f4e0d6aa2 oox: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: I8a82df7ea24874d8e246dc983418d872f1943c8e
Reviewed-on: https://gerrit.libreoffice.org/17919
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-23 06:06:04 +00:00
79fb61efb8 tdf#92379: svx: don't overwrite fo:background-color on ODF import
getSvxBrushItemFromSourceSet() is called once for each property of a
frame style that is set, and the "solid" fill-style is set by first
applying the BackColorRGB and then BackTransparency property.  So there
is an intermediate state that has fill-style NONE but a XFillColorItem
set - don't reset the color to white in that case!

Apparently writerfilter generally relies on the current reset-to-AUTO
implementation (loads of test failures), so for now limit the fix for
when we know that a frame style is imported from ODF.

(regression from 3d399b0e45720354fc64dc3d121ee486e01eff89)

Change-Id: Ia987fe586ec819a1f3cd85acdbfb03c74ca0ec2c
2015-08-22 01:00:03 +02:00
395e67764c disentangle the Dzongkha mess a little
As per [MS-LCID] rev. 7.0 2015-06-30

Change-Id: If4980d2b1149d93b39e5b57f5741bbdfb5680516
2015-08-22 00:50:12 +02:00
6257ea7d92 sal_uLong to size_t
Change-Id: Ie1774045329f543c05316ba2acfa332e3b323c7c
2015-08-21 22:29:42 +02:00
adc5e7d554 ColorMask: sal_uLong to better types, minor code rework
Change-Id: I426fa847038e7a6f788761242cb43e38cb355a36
2015-08-21 22:29:42 +02:00
aa62086495 sal_uLong to sal_uInt16 as return type of BitmapColor::GetColorError
Change-Id: I62c0d073d6b22346b65e3560303d7fc9373bfc7e
2015-08-21 22:29:41 +02:00
e28c9ccb01 There's no need to loop backward, in the end
Change-Id: I2ef533fcc2ac29446a07b98ab34acf1887909c6b
2015-08-21 22:29:41 +02:00
2c3fcc57ea Bail-out early and rework loops to use correct unsigned type
Change-Id: If70d600e1253e9d9271282c361e7edf01314eaa1
2015-08-21 22:29:40 +02:00
b6d799b548 Improve readability (minor code modification, formatting)
Change-Id: I2ce0087493f53579f155f8c399909cdb542aa8a3
2015-08-21 22:29:40 +02:00
cbb675a6cc MS finally acknowledged Cuba
As per
http://download.microsoft.com/download/9/5/E/95EF66AF-9026-4BB0-A41D-A4F81802D92C/%5BMS-LCID%5D.pdf
from https://msdn.microsoft.com/library/cc233965.aspx
Release: June 30, 2015; Revision 7.0

So do the mapping from the now obsolete user defined LCID.

Change-Id: I57cc5f4bb5d5b86d3c056123fdda9bb50b5b8968
2015-08-21 16:35:07 +02:00
b1aba5781a Resolves: tdf#93468 add Arpitan (France,Italy) [frp-FR] [frp-IT]
Change-Id: I3a50722f07f4dbaf89b4e8829dea7b41b829c038
2015-08-21 15:28:26 +02:00
75899a2b57 remove last WeakImplHelper10 use
Change-Id: I7b58249a93b5014d3e930bc5d041d8d80aed6512
2015-08-21 13:05:10 +01:00
fe6c124da7 Remove demonstrated-useless comphelper::compare
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-21 10:34:04 +02:00
5a2d6bf3a9 linguistic: tdf#88206 replace cppu::WeakImplHelper*
with the variadic variants.

Change-Id: I7a4df40d680ed9e10daacd01657df9666b8cc524
Reviewed-on: https://gerrit.libreoffice.org/17868
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-21 06:28:42 +00:00
27dec7c2b1 afl-clang-fast apparently miscompiles this
leading to the delete not getting called,
which results in temp files leaking and eventually
filling tmp

I wonder if generic clang suffers from this ?

Change-Id: Iecc266544b3c779026593a16e96bb1a2dfbe8328
2015-08-20 16:10:35 +01:00
885418c0d7 remove dead comment
Change-Id: I244e52ec494546383dcb1981c41f2d388ae7d85a
2015-08-20 13:19:16 +02:00
0075446151 make color button work in chart line sidebar panel
Change-Id: I2148fd9953b283945d2a1bcf24dbc47964b659ae
2015-08-20 03:15:57 +02:00
cf7db82262 handle new color picker correctly in chart sidebar
This implements the basics for that and implements it in the AreaPanel.

Change-Id: I6d9e5012bbcc2c953d478a09a839f35f2ef64c5b
2015-08-20 00:14:51 +02:00
6038ba92be o3tl: cow_wrapper add move constructor/assignment
Add a move constructor and move assignment operator for
o3tl::cow_wrapper. Insubstantial gains for UnsafeRefCountingPolicy, no
atomic increment needed for ThreadSafeRefCountingPolicy's move-ctor.

Change-Id: Ia2de1ca78b1e0e5a0f30535e752f1dd858fdfef0
Reviewed-on: https://gerrit.libreoffice.org/17848
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-19 21:25:29 +00:00
a4de770bab comphelper: reduce copypasta with UniquePtrValueLess functor
Change-Id: Ib93b818eeebc2f370535d1b061beabf7e8c65257
2015-08-19 19:32:18 +02:00
58c3bbfd46 comphelper: remove unnecessary include <stack>
Change-Id: I39295d69dd8a48f0f40275830cb6fda4ca0b69f3
2015-08-19 19:32:18 +02:00
39ce314c12 comphelper::isA(Type... -> Type == cppu::UnoType...
Change-Id: I1bfb99b1715a907a03af5a30df6c7a41f91fd2fb
2015-08-19 14:48:27 +02:00
884e970b8c Remove unused comphelper::isAReference
Change-Id: I7033e1e60f67e93a31d19ea08513982643dd61ae
2015-08-19 14:48:27 +02:00
d0f18382c5 comphelper::isA(Any... -> Any::has
Change-Id: I4fdc77c6fde93d9d1ee814f7614a1c4c81e18247
2015-08-19 14:48:27 +02:00
d21260cdb6 Remove two silly typedefs
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19 13:34:43 +02:00
5da0dce19c Consolidate isFileUrl checks
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-19 12:24:37 +02:00
236714e86c Clean up remaining utl::LocalFileHelper::Convert...
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040
"ConvertURLToSystemPath->getSystemPathFromFileURL" and
28f3464a571a23a2c16bd0980e9021b95d011511
"ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those
Convert... functionality with direct calls to the corresponding osl::FileBase
functions.

Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-19 10:48:42 +02:00
6d64afb31e Replace utl::LocalFileHelper::IsLocalFile -> ...::IsFileUrl
...given that vnd.sun.star.wfs is long gone.  Note that the old code could have
behaved differently in that for one it could have worked for relative URL input
(as osl_getSystemPathFromFileURL is allowed to accept relative URLs) and for
another could have failed for some file URLs (for which
osl_getSystemPathFromFileURL would return something other than osl_File_E_None
for whatever reason), but it looks plausible to assume that what the call sites
are really interested in is whether a given URL is a file URL.

Simplifies those call sites that already have a INetURLObject instance even
further.

Change-Id: Iaee4595d933a760b8321e42414a9ef0865311833
2015-08-19 09:13:33 +02:00
e0b0501452 vcl: kill 'special member functions' the compiler generates
No need to spell out otherwise auto-generated functions.

Change-Id: I1d2aec552df197f6656b0a495cef22696667dc4b
Reviewed-on: https://gerrit.libreoffice.org/17846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-19 01:05:37 +00:00
6b7354ae66 for testing allow disabling configmgr for time critical paths
Change-Id: I08021f18d53e1748927f8847649994f95252bbc2
Reviewed-on: https://gerrit.libreoffice.org/17844
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-19 01:04:00 +00:00
28f3464a57 ConvertSystemPathToURL->getFileURLFromSystemPath
Change-Id: I1c60c60f9b5318626f42e33091920a4404fb6d1c
2015-08-18 20:59:44 +01:00
58d68a1bc9 ConvertURLToSystemPath->getSystemPathFromFileURL
Change-Id: I7dc0e1b596f80b8f0870aed1722f711bb287ec0a
2015-08-18 17:24:22 +01:00
bdc3053067 rBaseURL argument now unused
Change-Id: I02cacfeaf26788ed024fa9753af132f0d5822e6f
2015-08-18 16:40:09 +01:00
954943308d Get rid of obsolete LocalFileHelper::IsFileContent
vnd.sun.star.wfs is long gone---or what else could this have been used for?

Change-Id: If39c9bdcb983f94206e0f58b7e1e8410fdcef089
2015-08-18 17:12:24 +02:00
3d1e29c55b Remove newly unused ucbhelper/fileidentifierconverter.hxx
Change-Id: I7c272383ecb115e19699ed96bf5622d979403a01
2015-08-18 15:32:16 +02:00
a5d5ce5dfa lok: namespace and re-work various types & helper functions.
Change-Id: I36e2a01822883251f9556fcde0e0a9830356ac98
Reviewed-on: https://gerrit.libreoffice.org/17833
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-18 12:32:27 +00:00
1242a3a55f Remove obsolete getLocalFileURL
...vnd.sun.star.wfs is long gone

Change-Id: I64da15a6c16e429aeda57c435e353891fb28f04d
2015-08-18 14:19:59 +02:00
c5a516bd1b lok::Document getStyles method
This method returns a JSON mapping of style families to a list of styles
from the corresponding family.
Will be used to know and apply styles in tiledrendering.

Change-Id: I0aa395c40b9573920ade44255f97c077475ae5f1
2015-08-18 13:04:35 +03:00
26821b7e2e tdf#84323: Make osl::Condition::wait more readable
Change-Id: Icd66ae1d390100549f903d45b2896cdcdca449be
2015-08-18 08:22:16 +02:00
ad1f0d1f1a o3tl: rename compat_functional header
After the cleanup, the stuff there really stands on its own (and the
remaining usage of select1st/2nd is more descriptive than lambdas).

Change-Id: I0aba131d5dc550189f8130d167dc94167e404540
Reviewed-on: https://gerrit.libreoffice.org/17806
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17 16:38:30 +00:00
9c4d75bea5 o3tl: remove unused code
Change-Id: Ia7bcb590ab5b535af8cacead1e8afd735c463aaf
Reviewed-on: https://gerrit.libreoffice.org/17805
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17 16:34:24 +00:00
b190574b6a tdf#84323: Make osl::Thread::wait more readable
Change-Id: I33eb6970050a103404344c7f16dd33349c154347
Reviewed-on: https://gerrit.libreoffice.org/15018
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-08-17 15:37:22 +00:00
3c2b80066b tdf#93482 vcl rendercontext: add Window::RequestDoubleBuffering()
This allows applications to request enabling/disabling of
double-buffering of their VCL frame and all its children. It works
after-the-fact, too: so in case the start center creates the frame and
later that frame is reused for Writer, then Writer can turn on
double-buffering, still.

From a user's point of view, this means that next to
VCL_DOUBLEBUFFERING_FORCE_ENABLE, there is now also a
VCL_DOUBLEBUFFERING_ENABLE environment variable that enables a safe
subset that is not supposed to draw directly at all. Enable this for
Writer only, for now.

Change-Id: Ie2cbf7d467eae2cee37fb58a1efc0a8984204408
2015-08-17 17:11:44 +02:00
a50cd18768 make Control::ImplCallEventListenersAndHandler take a lambda
so that we make the Link<> calls type-safe, without having to make this
a template method

Change-Id: I2e36bd6aa7c63440f72d266b593e101965b5ebce
2015-08-17 12:41:38 +02:00
9bb2c28a17 make Link<> typed
Change-Id: I50e2b05131604a6073a9234d4319f12b3906ea6d
2015-08-17 10:34:55 +02:00
23fbcf7da5 make Link<> typed
Change-Id: Ie18b1dda4039b22370a53d0ad8092a4a8b3899d7
2015-08-17 10:28:46 +02:00
83d9a900fd make Link<> typed
Change-Id: If802b3ac113217251a9dc38ce1e72ca0fdf61038
2015-08-17 10:16:50 +02:00
8cf544cb3a convert Link<> to typed
Change-Id: Ib0bf56a0e642720ff5daafdfc2dc12809be87e43
2015-08-17 09:59:59 +02:00
979b460faf make Link<> typed
Change-Id: Iffa4bbb58931075679a60132d90c3b8be6a76cc2
2015-08-17 09:59:59 +02:00