Commit Graph

197 Commits

Author SHA1 Message Date
3de4481f65 xmloff: replace boost::ptr_set with std::set
Change-Id: Idc03bf695d94f47f2057629b4175c2bdf3a83f22
2015-08-07 16:52:07 +02:00
f17f89aadc include: inline some use-once typedefs
Change-Id: I064e95c72e5f67178cf2875f457adac241cee529
2015-08-04 08:55:57 +02:00
9f27e5b0e0 Fix typos
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c
Reviewed-on: https://gerrit.libreoffice.org/17187
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-19 19:45:07 +00:00
e963a88912 formatting of public/private/protected section qualifiers
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 09:49:35 +00:00
e51fa14358 create a macro to tidy up the declaration sites of o3tl::typed_flags_set
Change-Id: Ifb8fd4fd5128188420f1dfda6b6f695160d5e77a
Reviewed-on: https://gerrit.libreoffice.org/15865
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15 23:40:19 +00:00
a62129aa63 loplugin:unusedmethods xmloff
Change-Id: I9d15d8edcc6746c055336bf31e5b0c15cb971ffe
Reviewed-on: https://gerrit.libreoffice.org/17061
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 10:36:25 +00:00
9c2a8065ad tdf#90133 Comply attributes name with OASIS#3860
See https://issues.oasis-open.org/browse/OFFICE-3860

Change-Id: I707b2e86633bc66df03dba8c43879aa6d5153062
Reviewed-on: https://gerrit.libreoffice.org/16905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-07-13 12:09:00 +00:00
35ce23bd97 Avoid loplugin:staticmethods in non-debug build
Change-Id: I9f98e86556ed4435d24f49b32b848eb9f9a66008
2015-07-08 23:26:57 +02:00
420923ba76 Fix typos
Change-Id: Ie2bbe020fc6e3a4a4f913208c245f395849bb9ee
Reviewed-on: https://gerrit.libreoffice.org/16708
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03 09:32:26 +00:00
1a8915ef83 Fix typos
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30 15:57:12 +00:00
01532b1ab8 Fix typos
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072
Reviewed-on: https://gerrit.libreoffice.org/16297
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:05:58 +00:00
b5e16d8dab Related tdf#88056: use better-fitting <text:page-name>
Implemented Regina's suggestions:
* this is a text field, therefore it belongs to text namespace
* page-name (evtl. slide-name) describes much better what this
  field really contains

This (among other changes) reverts commit 6609de8856519e0e9

Change-Id: Idab3b7c291839a9137f80d325a7d3f5ef0ff2636
2015-05-18 16:51:59 +02:00
d1ca0f4ed0 Bin some pointless comments and reduce some vertical whitespace
Bin pointless '// predeclarations' or '// forward declarations' comments.  If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?

Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.

Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-30 06:14:12 +03:00
4fee05e680 tdf#90133 Extend ODF: variable decimal in scientific format
Variable decimal is only saved in ODF for number, and do not consider
partial variable decimal: 0.0## is saved as 0.000
This patch extend ODF with loext:min-decimal-digit for number format and
scientific format

Change-Id: I5022458da47bbd33c3e195c280e75c43faca5f8d
Reviewed-on: https://gerrit.libreoffice.org/15135
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-04-28 00:19:02 +00:00
38992b419a tdf#90133 Extend ODF: exponent sign of scientific format
Scientific Format without sign in exponent, such as 0.00E0,
are managed by LibO, and can be saved in XLS format
This commit allows to save in ODF

Change-Id: Ia0c4589e2af942543ea296f970d163bc1d1d6f05
Reviewed-on: https://gerrit.libreoffice.org/14955
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-04-27 23:24:30 +00:00
57929ce5cc tdf#88056: Implement import of page title field from ODF
the field seems to get imported now, but still ain't displayed
in Impress *sigh*

Change-Id: I095b9a2c59145f984bc9db853cc22501ca103bb7
2015-04-22 15:21:38 +02:00
d34f5fe5ef tdf88056: implement export of page title field to ODF
to loext namespace so far, since it isn't approved by ODF-TC yet

Change-Id: I1bb7723bdccec9b670630da5e4d56f47cd615e43
2015-04-21 11:52:26 +02:00
c172b75b8e add attribute mandated by ODF
Make sure that it does not confuse our importer by adding an attibute to
ignore it when the new elements have been added.

Change-Id: I15991be9dd993e2aeb18c440a14de3711f8001f4
2015-04-17 17:41:43 +02:00
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
6acc6c011d text:p is not allowed as child element of draw:frame
Regression from #i118485#.

Change-Id: Ib242ca1417f46b731d62d117132cbed6c02448fb
Reviewed-on: https://gerrit.libreoffice.org/15173
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-04-08 13:40:11 +00:00
6864e3fc58 the attribute name is actually table:database-table-name
Change-Id: I9522529d918e143aafa6ea368fdb3fa55416d58b
Reviewed-on: https://gerrit.libreoffice.org/15176
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-04-08 13:38:49 +00:00
d1b27a1d9a loplugin:staticmethods
Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
2015-04-07 10:24:54 +02:00
849c1b64de also import and export to ODF the new databar property
Change-Id: Ib29a0d5c9fefe15fbd0f08a5cf9600eff58cd030
2015-03-24 16:01:58 +01:00
de6f165132 introduce SvXMLExport::getSaneDefaultVersion()
Change-Id: I1b73b4850e78f4ec0823894b93b8bc1cbadf0d0d
2015-03-22 19:29:40 +00:00
fdf8e5aaee tdf#30716 start Engineering notation: implement exponent-interval
ODF1.3 implement a new attribute for engineering notation
https://issues.oasis-open.org/browse/OFFICE-1828
This commit only add this attribute to ODF import/export.
Engineering notation is not yet available.

Treat also thousand separator with exponent-interval
Change XML_NAMESPACE_NUMBER to XML_NAMESPACE_LO_EXT for
exponent-interval

Change-Id: Ia18f9e150ca32aa9bbe133c082c3f9330e949f11
Reviewed-on: https://gerrit.libreoffice.org/14875
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-03-22 15:44:55 +00:00
f880962f5b Char highlight: ODT filters
Export merges the two background attribute.

Change-Id: I882321fbd5a7d24991fb01b8dc9d2cc0bd294051
2015-03-21 16:19:08 +01:00
7b355da685 Enhancement tdf#87972 : Cannot repeat items labels on a pivot table
Change-Id: I44b2521ea548b51a1b3e9b42cfa64c5f50d7798a
Reviewed-on: https://gerrit.libreoffice.org/14504
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2015-03-12 01:18:06 +00:00
5a308b1239 V801: Decreased performance
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-09 12:41:09 +00:00
3744d8506e boost->std
Change-Id: I8371b942d915f777a29ca01cd0aed674db0ca853
2015-02-17 16:24:05 +00:00
a1ceacc17e boost::foo_ptr->std::foo_ptr
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-16 12:54:44 +00:00
eaa9a73185 loplugin:deletedspecial
Change-Id: I806c9799f6eac357e5f200b53df3a9c1e6ecd841
2015-02-07 12:36:05 +01:00
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
5672dab6b5 Revert "Don't assume that the ZOrder property of shapes is an enumeration"
This reverts commit 66c7dbbf7dfba8cfab63f8d1df72ace87e5bf7ca.

See https://gerrit.libreoffice.org/#/c/13554/ .

Conflicts:
	include/xmloff/shapeexport.hxx
	reportdesign/source/filter/xml/xmlExport.cxx
	sc/source/filter/xml/xmlexprt.cxx
	xmloff/source/draw/shapeexport.cxx

Change-Id: I14fed9ad043a756a9e2d390c76fa907c349c3a2e
2015-01-08 16:08:11 +01:00
45ec1d9b56 brute-force find-and-remove of unused #define constants.
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
64cccf36f2 fdo#84938: convert SEF_EXPORT_ #defines to 'enum class'
Change-Id: I7165d0f1b6b4af4de5e5b39a21f36d726a1b0e30
2015-01-06 10:59:42 +02:00
8447eeb192 fdo#84938: convert ERROR_ #defines to 'enum class'
Change-Id: Ie76bac6b91a9faa4f9ff7dbdf2b455ea9016cf72
2015-01-06 10:59:42 +02:00
c29657e0d6 fdo#84938: convert EXPORT_ #defines to 'enum class'
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
2015-01-06 10:59:42 +02:00
ec5bf66d36 fdo#84938: convert XML_EXPORT_FLAG_ to 'enum class'
Change-Id: I43d778e0eee19a56ea37898ec1c4309d3407775e
2015-01-06 10:59:41 +02:00
dc28e90d20 fdo#84938: convert IMPORT_ constants to 'enum class'
Change-Id: Idaa8f07c62b3ba93c27ca5fe286720254baac10d
2015-01-06 10:59:41 +02:00
465356ecc8 remove unused #defines
Change-Id: Ia56012ec795da47a2b6c2482289b698793703918
2015-01-06 10:59:41 +02:00
d1ce6effb6 fdo#84938: convert TEXT_PROP_MAP #defines to 'enum class'
Change-Id: Ia8c5913c60e3d509a906965d813c8d1380396dc6
2015-01-06 10:59:40 +02:00
fd1372ba8b boost::unordered_map->std::unordered_map
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
66c7dbbf7d Don't assume that the ZOrder property of shapes is an enumeration
...at least when we can easily not assume it.

shapes = shapes of the same XShapes
an enumeration = it is the sequence 0, 1, 2, 3, ..., XShapes->getCount()-1

We replace the ZOrder property by the index of the XShape in the
XShapes (the same XShapes that is passed to seekShapes()... when that
is easy to find. Else, use ZOrder and hope for the best.

ZOrders are not always an enumeration. For example, in documents
(forms) created by the Base forms wizard, it is not the case.

The wrong assumptions was leading to the following bugs in the Base
form wizard:

 - Only the first two controls in the form were successfully saved. The
   others were just dropped.

 - Whereas the labels had the proper style (background and text
   colour) applied while creating the document, these were not saved
   successfully

Change-Id: I15b9a3ef3b16eafa9698332e35d82d51d51627f8
2014-12-19 23:33:33 +01:00
06344c91db remove invalid attribute that is not read anyway
Change-Id: Id7770ffda49ba7bc0ebc780c67c56b81152213f7
2014-12-07 01:13:52 +01:00
8e417a8fed use correct xml element name, related fdo#45266
Below data-pilot-groups the correct element name is
data-pilot-group-member and not data-pilot-member.

Change-Id: I41aecb7f85a881d13b3eaaa7be8de737b47ea312
2014-12-07 01:13:52 +01:00
a2df86642d last inconsitently named data table value
Change-Id: I1a558616156f5217e309c5957967a69d81c20b8e
2014-12-07 01:13:51 +01:00
6c238230d4 more fixes for inconsistent naming
Change-Id: Iedb1b30d4e3905f884bc3bb39d4703a883e95c46
2014-12-07 01:13:51 +01:00
f04802e04c use a consistent naming scheme
Change-Id: Ia420779fd875cb2a81b90871b26940f8a0258b4d
2014-12-07 01:13:51 +01:00
5c3f47e44c Remove ptr_vector header include in favor of forward declaration.
Change-Id: I0aed7ec1bd8ac30ef18147b385c8649a413e4e3a
2014-11-25 18:55:15 -05:00