7d769f9df5
loplugin: defaultparams
...
Change-Id: Ibf0ea539d2a95073a12f84964759d9c7a94baa7b
2015-08-20 13:52:17 +02:00
a811d6efe4
slideshow: replace for_each with range-based for
...
Replace ::std::for_each for a more readable range-based for loop in
cases in which the function object to be applied by for_each is more
readable as the body of a for loop. In addition, replace while loops
with range-based for loops when possible and complex implementations
of boost::bind with lambda expressions.
Change-Id: I6adfb18197bd1b8627719adfca2e4c36d58a0e05
Reviewed-on: https://gerrit.libreoffice.org/17786
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2015-08-17 16:22:31 +00:00
1e4b29e1ad
Range-based for-loops.
...
Change-Id: I6fb0d182dfccb3af42f0bbc60969c72df09b6ce6
2015-08-12 06:48:43 +02:00
2c587f08ed
slideshow: prefer value_type over manual type generation
...
Change-Id: I3e088a10e7bc0da73e4fa20db15e71581661fe4b
Reviewed-on: https://gerrit.libreoffice.org/17641
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2015-08-11 09:17:16 +00:00
ff265a5f9b
loplugin:unreffun
...
Change-Id: I130b4f1eca4cf07f17aac995c4a44a8fdf51a4df
2015-08-11 11:15:50 +02:00
28564f96e8
loplugin:cstylecast
...
Change-Id: Ie44d7b031b16647457cf08dc944526c720360f9d
2015-08-11 09:30:00 +02:00
7151a2a9ca
-Werror,-Winconsistent-missing-override
...
Change-Id: I3597b5d5cd54e6ff5398bdb5075b9fa03f9b5819
2015-08-11 09:25:53 +02:00
e5ec630414
stop inclduing canvas/verbosetraces.hxx and canvas/debug.hxx
...
also clean-up and 'standardize' the include sections of canvas' source code
Change-Id: Ib437a41ea41ae2ea6528f755ae5b2828775aaf73
Reviewed-on: https://gerrit.libreoffice.org/17633
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2015-08-11 03:57:18 +00:00
7bdc6be9c2
slideshow: stop (mis)-using VERBOSE
...
converted the use of internal 'verbose' level tracing to SAL_INFO/SAL_WARN
Change-Id: Iab89d9b5c75fe476c6516718f1cee3d01d196858
Reviewed-on: https://gerrit.libreoffice.org/17632
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2015-08-11 03:31:47 +00:00
8a7b4d5bb5
Explicit capture annotations
...
Change-Id: I7be1a36196a07a80a7b7173c3869621f5d707204
2015-08-08 15:16:34 +02:00
717b23ef27
tdf#92459 replace deprecated o3tl features
...
Replace deprecated features from the o3tl including select1st and
select2nd with lambda expressions.
Change-Id: I0cb1aedc3e193c52d25e2837a47d9d90c898079e
Reviewed-on: https://gerrit.libreoffice.org/17459
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2015-08-08 12:27:55 +00:00
6343754e31
cppcheck:noExplicitConstructor
...
Change-Id: I2717d3d120df8af5b7e9af8d147a57b9f5b5ecbe
2015-08-07 07:20:24 +02:00
e8f8c32581
slideshow: dumb this down to hopefully make non-GCC compilers happy
...
Change-Id: If08a4f0c177abf38a381dcb9ba73a09265b2bcb5
2015-08-03 17:45:42 +02:00
c05bf5e494
slideshow: convert generateEvent args from boost::bind
...
Change-Id: I85d240989e41a45b62a4631bb847daccd1919f34
2015-08-03 17:32:25 +02:00
38a4b5ea2a
slideshow: try to fix libc++/MSVC build by replacing boost::bind
...
Change-Id: I6418119f9d3e70ea89f7c8a094bbde42eeadec8c
2015-08-03 17:20:26 +02:00
34d2a07a23
slideshow: replace boost::function with std::function
...
Change-Id: Ibcb0f40d327e3086b6493cf2052caf135aa89e10
2015-08-03 14:47:44 +02:00
5a7bf1b32c
loplugin:unusedmethods slideshow
...
Change-Id: I66b6cddb638a9fc1228d3ea9df5d112300a00eb3
Reviewed-on: https://gerrit.libreoffice.org/17128
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-17 06:49:23 +00:00
7aa9f04538
do not include boost/utility.hpp
...
It just includes a bunch of other boost headers; mostly we need
boost/noncopyable.hpp so include that directly.
This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp
completely, which is the 2nd biggest header after ustring.hxx.
Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-10 23:25:22 +02:00
0b7d51df3b
Fix typos
...
Change-Id: Ic6415423f46aaee7ba90239a617c318cf92ae222
Reviewed-on: https://gerrit.libreoffice.org/16711
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-07-04 10:21:01 +00:00
2a65bf32ec
Revert "Typo: iff->if"
...
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d.
iff can mean "if and only if" so not a typo
2015-06-23 20:42:27 +02:00
cf92da3d6e
Typo: iff->if
...
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-23 20:30:11 +02:00
051bbb818f
slideshow: [loplugin:unreffun]
...
Change-Id: I112e85d999a160b9b6393e924e981231d17f439d
2015-06-18 00:36:28 +02:00
0980095619
Replace boost::scoped_array<T> with std::unique_ptr<T[]>
...
This may reduce some degree of dependency on boost.
Done by running a script like:
git grep -l '#include *.boost/scoped_array.hpp.' \
| xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
| xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'
... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.
Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-06-17 15:50:45 +00:00
01532b1ab8
Fix typos
...
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072
Reviewed-on: https://gerrit.libreoffice.org/16297
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:05:58 +00:00
dcf6abfcdf
cppcheck:unreadVariable
...
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15 14:06:31 +02:00
1afb790a11
inline COMPHELPER_SERVICEDECL_ macro
...
it was not adding any value
Change-Id: I6a911aac81e883f9155ed0cf24bfb7904efb3f92
2015-06-15 09:46:14 +02:00
c2d65e08c9
tdf#91960 presentation causes Impress crash
...
The SystenChildWindow in question is owned by ViewMediaShape
Fixed ViewMediaShape to dispose the vcl objects it creates correctly.
Also fix another crash in MediaWindowImpl child window correctly disposing its children.
Change-Id: If4aebcb6e5824266c154416f7246d73c6cb3509c
Reviewed-on: https://gerrit.libreoffice.org/16230
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2015-06-13 16:50:56 +00:00
397a0afd3b
convert B2VectorOrientation to scoped enum
...
Change-Id: Id7e444bc896ae5d52e5a0bd1b471679c4945afa4
2015-06-04 08:30:24 +02:00
f3331f7694
convert PARENTCLIPMODE constants to scoped enum
...
Change-Id: I36a53112e75fca9208b2f91e224a7c671695509b
2015-05-28 12:47:08 +02:00
ad0c5e6c66
convert META_*_ACTION constants to scoped enum
...
Change-Id: I8ecfbfecd765a35fafcbcc5452b0d04a89be2459
2015-05-15 10:05:03 +02:00
19ba9e08ca
slideshow: simplify code by replacing std::find_if by std::any_of/std::none_of
...
Change-Id: Ib8eec5074e82127e11f4fba2c0b143ab8cef3bcc
Reviewed-on: https://gerrit.libreoffice.org/15714
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-05-13 10:50:47 +00:00
0a442d3815
loplugin:staticmethods
...
Change-Id: I4d19f868a618cb135aa7a949222972dc35b47d2a
2015-05-05 14:05:20 +02:00
f304a7a14a
loplugin:staticmethods
...
Change-Id: I384a5e60f4b7b2f479c89ef97630519059ab720f
2015-05-05 09:30:39 +02:00
d883c12556
Get rid of the initial :: for the vcl namespace
...
We used it all over the place without leading :: already anyway, even
in many files in include. So let's be consistent. In the majority of
cases, prefer the easier-on-the-eyes choice, not the "safe" one.
In those files in include where *all* existing uses of ::vcl:: indeed
used the :: prefix, there let's keep it for consistency.
Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-30 07:27:52 +03:00
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
9f366a65b8
More loplugin:simplifybool
...
Change-Id: I5426400b0831a353336451409103ebeb01dcd946
2015-04-27 15:31:01 +02:00
76e8c614f7
loplugin:simplifybool
...
Change-Id: I427b32e79696bbdc521b78f4b4c1e6f4fce119a7
2015-04-24 12:36:27 +02:00
d6521b07f4
fix higher debug levels
...
Change-Id: I78a2b74a4e80018a8093457cb15a93d49c0ff8f3
2015-04-18 14:43:57 +01:00
5430eb76db
slideshow: convert new to ::Create to get initial ref-counting right.
...
Change-Id: I513dacfa0dd2e902437578611b6d39575f2e7314
2015-04-16 20:50:12 +01:00
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
26ec80f47d
loplugin:staticmethods
...
Change-Id: I33a8ca28b0c3bf1c31758d93238e74927bebde9c
2015-04-13 09:37:12 +02:00
8a65284fe3
Automated conversion of VclPtr construction to use Instance template.
...
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
2015-04-10 13:40:25 +01:00
8fa63f31ab
Fix OutputDevice members / stack allocation: slideshow, starmath, sd, sc.
...
Change-Id: I6d6d41b8a6501ce7d35c78e5b730ea45143d6b73
2015-04-10 12:17:54 +01:00
c72fac2696
vclwidget: convert lots more sites to use VclPtr
...
seems there was a lot of shared_ptr usage floating around...
Change-Id: Icd05243170eb8493709275fc36bf986fc194b781
2015-04-10 11:20:46 +01:00
13fa5bb755
WaE: Unreferenced function definition
...
Change-Id: I3190e994b7b63b258436ef5d35542722fa91fa46
2015-04-05 00:59:13 +03:00
1a3c99f2c3
callcatcher: update unusedcode
...
mostly changed due to loplugin:constantfunction
Change-Id: Ib677c78db256f8032a99b3f02a3e363fee68ebcc
2015-04-04 17:13:21 +01:00
3257da3297
fix higher debug level build
...
Change-Id: I23324d03f3388642e964c13d8a5c32311f97ef08
2015-04-02 08:15:59 +01:00
858e455634
loplugin:constantfunction: various
...
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-24 10:51:22 +02:00
d1c9e5ee53
tdf#43157: Fix format string violations in OSL_TRACE etc.
...
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32
"tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit
build
Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-03-13 18:21:36 +01:00
ee11e221d2
tdf#43157: Fix format string violations in OSL_TRACE etc.
...
...in preparation of enabling the __attribute__((format(...))) in
sal_detail_logFormat (include/sal/detail/log.h)
Change-Id: I8a859199fa11ca0f9f4f4b4b23a8ebddec955a86
2015-03-13 10:53:28 +01:00