...and the hack to locally introduce a bogus pupblished forward declaration of
XFormOperations with which this has been worked around in
cf5c36912390b2f6018f57f79085ab1fa88a08d6 "INTEGRATION: CWS dba23b: work around
idlc limitation, which does not allow to refer unpublished interfaces as
optional entities in published services" no longer works in
offapi/type_reference/offapi.idl.
So given FormController is a (deprecated, even) old-style service (i.e., little
more than glorified commentary), the best fix probably is to demote the
problematic optional property to a comment.
Change-Id: Ia38483c817dc1762ba73315abcd4f9f063db3093
...UNOIDL identifiers starting with an underscore, or starting with a lowercase
letter and containing an underscore, are invalid, so occurrences of those as
method parameter names had been changed (even though changing them is strictly
speaking incompatible, but correctness trumps compatibility here).
Change-Id: I1cd2c32ff1486a13bf0218bcb7d3df5fc615ac01
...i.e., only change it to reflect cases where we deliberately became
incompatible, do not change it to reflect compatible changes. This reverts part
of d567671196fccf20a350f3cbf210eef088fa7ce3 "fdo#57490 deprecate
IsSpellCapitalization."
Change-Id: I2ed58a1740cc22ef1ad4fdcbe04c4a0d2ef547bd
...via unoidl-write and the new source-format registry provicers, instead of
using idlc to produce .urd files, regmerge to merge them into legacy .rdb files,
and unoidl-write to translate those to new UNOIDL .rdb files.
gb_UnoApi and gb_InternalUnoApi ctors take an additional argument now that is
the path (below $(SRCDIR)) of the source-format registry from which to obtain
UNOIDL entity definitions. It can either be an .idl file (in which case no
*_add_idlfiles calls should be used and the resulting .rdb will contain all the
entities from that one .idl file; used in some tests to conveniently define all
test-specific entities in a single file) or a directory denoting the root of an
.idl file tree (in which case *_add_idlfiles calls specify the entites to
include in the resulting .idl file). (In the first case, the generated .rdb
file needs to depend on that single .idl file, so the gb_UnoApiTarget ctor
contains a dependency on that additional argument, which happens, as a side
effect, to trigger rebuilds in the second, tree-based case when addition/removal
of .idl files in the tree causes updates of directory time-stamps.)
UnoApiPartTarget and all the dependency-tracking logic based on .urd files in
solenv/gbuild/UnoApiTarget.mk is gone. Generation of an .rdb file now depends
on its source registry (see previous paragraph) and all the .idl files specified
with *_add_idlfiles (in the second, tree-based case above).
A consequence of that is that gb_UnoApi_add_idlfile, -_nohdl, and -_noheader all
do the same now. I left them in for now anyway, maybe they become relevant
again when the use of cppumaker is changed to read directly from a source-format
registry instead of going via a .rdb registry.
The legacy tools idlc, regcompare, regmerge, and regview are still contained in
the URE or SDK for now.
cb344cd59e1ddb7c6db66dbd9263b4755969d4ba "Revert 'Looks like idlc resolved
typedefs inside sequence<...>'" is re-reverted as now "the current offapi.rdb is
generated via unoidl-write instead of idlc."
Change-Id: I3d9d92f17326bc9f49dd934c85aab6a17951d06d
This reverts commit 4bcc515356e2a66417e36600bee9402efb2f9ec3, which needs to be
held back until the current offapi.rdb is generated via unoidl-write instead of
idlc.
...obtained from the old .rdb files via "unoidl-read --published". This removes
the need for update-rdb.sh.
Change-Id: I73c0d026af7e27370602f83c61dfa76fc4d17a83
...from 6ea6a422fbb6279c6fc589e86603a6864273229d
"s/wiki.services.openoffice.org/wiki.openoffice.org/g" which had caused that
offapi.rdb to be broken and effectively empty, silently reducing the
compatibility check against it to check nothing.
Change-Id: Id35d9a7c0b848faf3a9d4458b63e1d5240817c7c
...it had been deprecated at least since late OOo times, with the
css.sheet.NamedRangeFlag constant group as replacement. (UNOIDL identifiers
starting with an underscore are illegal. It would be good to be able to enforce
that in code parsing UNOIDL files, but some existing identifiers like this one
violate that.)
Change-Id: Ib8067dee47cec46356065b7b70cc6b47b97e5bc0
Revert "fdo#46808, Convert frame::FrameControl service to new style"
This reverts commit 32eaa77db33b3b1f5793e92167b9f8c2708ea543.
Conflicts:
UnoControls/source/controls/framecontrol.cxx
UnoControls/source/inc/framecontrol.hxx
.. because I can't work out how it causes fdo#67213 - I suspect my
changes might be interacting with UNO aggregation, which
is always tricky.
Change-Id: Icd14f9a7df98585393c5527a3817e05c26246de9
Add IsUTC member to:
com.sun.star.util.DateTime
com.sun.star.util.DateTimeRange
com.sun.star.util.Time
Add new stucts with explicit time zones:
com.sun.star.util.DateTimeWithTimezone
com.sun.star.util.DateWithTimezone
com.sun.star.util.TimeWithTimezone
Adapt the sax::Converter to read/write timezones, and fix the unit test.
Everything else just uses default (no time zone), this commit is just
to fix the API.
STRUCT: /UCR/com/sun/star/util/DateTime
nFields1 = 7 != nFields2 = 8
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/DateTimeRange
nFields1 = 14 != nFields2 = 15
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/Time
nFields1 = 4 != nFields2 = 5
Registry2 contains 1 more fields
Conflicts:
sc/source/filter/oox/unitconverter.cxx
Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18
Reviewed-on: https://gerrit.libreoffice.org/4833
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654. As discussed at
<http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re:
fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd
change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get
CreateUnoDialog() work again" appears to fix things again:
The problem is that the implementation of the css.awt.UnoControlDialogModel
involves UNO aggregation
(IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in
toolkit/soruce/helper/registerservices.cxx creating a
OGeometryControlModel<UnoControlDialogModel> instance that aggregates a
UnoControlDialogModel instance). That means that queryInterface can return a
reference to something that is technically a different object, and that's
what's happening here, and explains why calling setPropertyValue in two
different ways on what logically appears to be a single object can end up
calling two different implementations (of two different physical objects).
(UNO aggregation is known to be broken and should not be used. Nevertheless,
there's still code that does---code that is a horrible mess and hard to clean
up.)
That all this worked as intended in the past is just sheer luck, but any
way of substantially touching it is asking for trouble. I'm going to
revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again.
I wasn't able to revert without also reverting
be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert
awt::XUnoControlDialog to new style," as the two were tightly dependant. Also
reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431
"-Werror,-Wuninitialized" (sans the const-ness fix in
UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452
"Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix
awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086
"scripting: get CreateUnoDialog() work again."
Conflicts:
basctl/source/dlged/dlged.cxx
filter/source/t602/t602filter.cxx
xmlscript/test/imexp.cxx
Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
API-CHANGE:
Removed the following interfaces from the IDL because no-one was
using them:
interface com::sun:⭐🫘:XFastPropertySet;
interface com::sun:⭐:lang::XComponent;
But the service still implements them, so old code should keep on
working.
Change-Id: Iab058fb42bd1a54e0b9632e99e564fdc0869fe6e
- nanosecond precision
- signed (allowed negative) year
Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.
Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
The implementation in Writer has Value property read-only since initial
CVS import, and NumberingType property never existed, so adapt
com.sun.star.text.textfield.GetExpression to implementation.
Thanks to the really cool David Ostrovsky for finding these.
Change-Id: I3b12a8103d0d6de7dbf644f30db3f192b0331f0a
SERVICE: /UCR/com/sun/star/text/textfield/GetExpression
SERVICE1 contains 1 more properties as SERVICE2
incompatible change: Field 3 ('NumberingType') of r1 is not longer a property of this SERVICE in r2
incompatible change: Field 6 ('Value') of r1 is not longer a property of this SERVICE in r2
incompatible change: Field 5 ('Value') of r2 is a new property compared to this SERVICE in r1 and is not 'optional'
...does not make sense. Adapted some old-style services accordingly, where the
inherited service had been changed to new-style after the fact.
Change-Id: I5f3e4ddf99160778a319062a6c84f83529ff177b
The implementation in Writer has been read-only since initial CVS
import, so adapt com.sun.star.text.textfield.SetExpression to
implementation.
Change-Id: I70cdd5d0a44cb86426f533c00f86874e8dde8b87
SERVICE: /UCR/com/sun/star/text/textfield/SetExpression
incompatible change: Field 11 ('VariableName') of r1 is not longer a
property of this SERVICE in r2
incompatible change: Field 11 ('VariableName') of r2 is a new
property compared to this SERVICE in r1 and is not 'optional'
