Commit Graph

162 Commits

Author SHA1 Message Date
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
e8ecf30ea6 convert FRAMEWORK module from String to OUString
Change-Id: Iafa6b5f213d37093e7e46065c9264c7bb7fae377
2013-09-17 09:05:49 +02:00
a3474bab69 Try to make the Gentoo tinderbox happy with explicit OUString() values
Change-Id: If73a84a09ad54072e1251ed2db8aacc307ff32d2
2013-09-09 01:23:18 +03:00
2b3e225853 Bin some uses of the stupid DECLARE_ASCII macro
Change-Id: I076eef8069e848ec3cf9c69f1b489ad44586324e
2013-09-09 00:58:15 +03:00
9a8e2d09bc Use SAL_WARN_IF instead of framework's home-grown LOG_ASSERT(2)
Also remove declarations for debug function that don't exist (have been
removed (misguidedly?) as unused perhaps).

Change-Id: I0bc3320c52b3d50dc851a07fdc30b593cc4856b1
2013-09-08 23:51:41 +03:00
6aa0698828 Use SAL_INFO instead of framework's own LOG_WARNING
Change-Id: Ief44fceaf03d2567f4aacd9ff74d361436e5e05b
2013-09-08 23:51:41 +03:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
5efc15f000 reduce use of UniString from ResID ctor
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00
39b1fb894f fdo#46037: comphelper/configurationhelper partly not used in fmwk/accelerators
Change-Id: I710b9155b6ce8f42f46d87c80cebf37414e91c70
2013-07-26 20:44:25 +02:00
cb590428d8 fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
Change-Id: Ib0edc828691c6a8edbd1f45d3c0e2851c32c865f
Reviewed-on: https://gerrit.libreoffice.org/5013
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-23 14:05:13 +00:00
376d5a6ad9 convert more services in framework module to WeakImplHelper
Change-Id: I417ae2ce644f39fce0e8eb9fbe6a3a3c783b6227
2013-07-23 10:05:46 +02:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
dcbaf7c253 remove unused componentcontext.hxx includes
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-05 08:13:21 +02:00
052de9c16b fdo#46808, Convert some XMultiServiceFactory to XComponentContext
Change-Id: I7223d8e2c962ca90eda08119ed73a034d334329d
2013-05-28 08:10:24 +02:00
8f3cec9d7a fdo#46808, Convert ui:*AcceleratorConfiguration to new style
The services already existed, they just needed IDL files.

API CHANGE:
   The return type of XUIConfigurationManager#getShortcutManager()
   is now XAcceleratorConfiguration instead of XInterface.
   This should not be a problem because XUIConfigurationManager is
   unpublished and the client code was relying on the service
   returning that type.

Change-Id: I399fe35de3394b02a4166b75eb7ff93b28be8bef
2013-05-28 08:10:23 +02:00
cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
86c1ebc1ef fdo#46808, Convert util::PathSettings service to new style
Change-Id: I302be46b46518e1e872771e1c8a0647f7c330b30
2013-05-13 09:38:01 +02:00
11f8e53d6c Resolves: #i120029# Unregister on dispose.
Patch by: zhang jianfang
Review by: Andre Fischer
(cherry picked from commit e0d5abb649958e48660357d3fa37ab6e9707b61f)

Conflicts:
	framework/source/uielement/toolbarmanager.cxx

Change-Id: I4c6a112b27396fc7e5d42f3feef11ac1fe81efcd
2013-05-11 18:53:28 +01:00
60fbefc615 fdo#60724 informations -> information
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-15 04:49:39 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
876c619b94 new module i18nlangtag
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.

This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.

Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
2013-04-05 19:10:48 +02:00
2ac8508a2f we really don't need to assign the same value again
... to be extra sure?

Change-Id: I00d6cfafe5419b01e3e827377be030b5d1a4ee34
2013-03-28 01:39:08 +01:00
3106c4d37f eliminated useless back and forth conversion
Why convert back and forth between LanguageTag (formerly
comphelper::Locale) if all you need and use is a BCP47 string.

Change-Id: I1ec12186284211bcd7d115ee092c195b926e7cd0
2013-03-28 01:39:08 +01:00
68fac46e71 use LanguageTag instead of comphelper::Locale
Change-Id: I2c6d07bbdef62fa17e9c90ca87be6e742268c54f
2013-03-28 01:39:07 +01:00
ce33f85ffd sal_Bool to bool
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04 23:14:41 +09:00
89003e9bd8 loplugin: unused variables
Change-Id: I63553a09eec81e5ae28aa79ee1d3281053b23d06
2013-02-25 03:14:01 +01:00
e2f97dcc10 spelling: otherwhise -> otherwise
Change-Id: I2d89edbb2574b4e677c9a0682bc829d9476b54db
2013-02-17 13:57:44 +04:00
ae25ee162c fdo#46808, remove unnecessary XMultiServiceFactory fields
Change-Id: I140d82ed38afc56cbd06b0045eff0787fc99e2a6
2013-02-11 08:02:15 +02:00
e52a5e298b fdo#46808, use service constructor for ui::GlobalAcceleratorConfiguration
Change-Id: Icab69ba138b28c3baed4352da86a1b3b0c0cc195
2012-12-13 05:20:58 +02:00
2f998bdf8f fdo#46808, use service constructor for embed::FileSystemStorageFactory
Change-Id: Ic523e4b0a662a68a1a222b7697fcdae56d69903c
2012-12-13 05:20:57 +02:00
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
17ff7b41d1 re-base on ALv2 code. Includes:
Patches contributed by: Armin Le Grand.
    #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task.
    http://svn.apache.org/viewvc?view=revision&revision=1195906
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles
    http://svn.apache.org/viewvc?view=revision&revision=1293316
    #119337# Solves the wrong get/setPropertyValue calls in
    SvxShapeText (and thus in SvxOle2Shape)
    http://svn.apache.org/viewvc?view=revision&revision=1344156

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117717#: remove wrong assertion
    http://svn.apache.org/viewvc?view=revision&revision=1172349

    Patch contributed by Herbert Duerr
    goodbye Registration and License dialogs, don't let the door hit you
    http://svn.apache.org/viewvc?view=revision&revision=1172613
    help gcc 4.6.0 on 32bit ubuntu 11.10"
    http://svn.apache.org/viewvc?view=revision&revision=1245357

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

Revert "sb140: #i117082# avoid unncessary static class data members
    commit 21d97438e2944861e26e4984195f959a0cce1e41.
remove obsolete FreeBSD visibility special case.
retain consolidated BSD bridge code, remove OS/2 pieces.
2012-11-15 16:06:08 +00:00
0ac9a10d31 fdo#46808, Deprecate configuration::ConfigurationProvider old-style service
...in favor of existing new-style configuration::theDefaultProvider singleton.

Theoretically, ConfigurationProvider instances can be created with specific
Locale and EnableAsync arguments, but this is hardly used in practice, and thus
effectively all uses of the ConfigurationProvider service use the
theDefaultProvider instance, anyway.

theDefaultProvider is restricted to the XMultiServiceFactory interface, while
ConfigurationProvider also makes available XComponent.  However, dispose must
not be called manually on theDefaultProvider singleton anyway, and calls to
add-/removeEventListener are so few (and in dubious code that should better be
cleaned up) that requiring an explicit queryInterface does not really hurt
there.

This commit originated as a patch by Noel Grandin to "Adapt
configuration::ConfigurationProvider UNO service to new style [by creating] a
merged XConfigurationProvider interface for this service to implement."  It was
then modified by Stephan Bergmann by deprecating ConfigurationProvider instead
of adding XConfigurationProvider and by replacing calls to
ConfigurationProvider::create with calls to theDefaultProvider::get.

Change-Id: I9c16700afe0faff1ef6f20338a66bd7a9af990bd
2012-10-31 15:31:36 +01:00
e8aa70b5d4 fdo#46808, convert comphelper::ConfigurationHelper to XComponentContext
Convert the helper methods to take an XComponentContext parameter,
instead of XMultiServiceFactory.

Change-Id: I9f0098af37b91f107d8799f14caa04756eac82b1
2012-10-24 11:29:53 +02:00
b493b5a284 fdo#46808, use service constructor for xml::sax::Writer
Change-Id: I2b216a0e3a9694568642e9de2f4f43ecd682555f
2012-10-23 17:44:16 +02:00
a20f9a410f fdo#46808, Adapt xml::sax::XParser UNO service to new style
The xml.sax.Parser service already existed, it just did not have
a new-style service to create it.

Change-Id: I6f145a7504ff9e149c802f723991954a2801cbc9
2012-10-04 16:29:53 +02:00
2beba8f93e reduce ascii noise and useless comments
Change-Id: I317058e3b25cebb7c1d89361636261c5f16a84d4
2012-08-08 13:53:54 +02:00
49ad17e2b1 remove include comments and boxes
Change-Id: I9ccf664e8f75a68b1b87c2b29ae617a90d0741a7
2012-08-08 13:53:53 +02:00
2c757293b8 reduce static_initialization_and_destruction chain
Change-Id: I0c1b2f2d908c31d1510662880c13504d81445a6a
2012-06-25 14:19:03 +01:00
66cd9eeb90 Remove various commented out defines
Most of them in hrc files.

Change-Id: I3944f6ed9befd2b498385f61b851790362221a4f
2012-06-25 14:12:57 +02:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
bc62d262fa targeted string re-work
Change-Id: I2cded25cc1d63a02a14633e2de4c6f37662feb25
2012-06-02 20:48:30 -05:00
eeac114217 targeted string re-work
Change-Id: I3276836b76b69f04de38c2d36ae04b60c49d4873
2012-06-02 20:41:34 -05:00
00f1180c96 removed unused const rtl::OUString
Change-Id: If02be864f958de96ae1c54fe575b1828410390b1
2012-05-18 22:56:54 +09:00
383a9c777f s/pathes/paths/ 2012-04-09 14:19:58 +03:00
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
743f22045c Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\)) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 15:07:41 +02:00
d41b5a88bd reduce over use of static OUStrings 2012-03-26 12:18:08 +01:00