Commit Graph

429 Commits

Author SHA1 Message Date
be053c9a80 Spelling correction: s/retrive/retrieve/
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20 23:26:58 +02:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
0121f632ef remove unnecessary use of OUString constructor in XMLSECURITY module
Change-Id: I95b0eda83c60456f3db267183030fe5f6cd70bc4
2013-11-07 11:28:38 +02:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
094f00651a CID#708741 uninitialized members
Change-Id: I15475d560e889b0f0fc91d96cfa6ae97e81a41b5
2013-10-03 13:30:13 +01:00
6ea6a422fb s/wiki.services.openoffice.org/wiki.openoffice.org/g
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
2013-09-07 14:21:22 +02:00
b5e5ce956b fdo#57950: Remove some chained appends in xmlsecurity
Change-Id: I35ac622abb995a9259f0774f463ec2816b3668b6
Reviewed-on: https://gerrit.libreoffice.org/5477
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-08-18 13:53:54 +00:00
182bf2a63a Revert "fdo#57950: Remove some chained appends in xmlsecurity"
This reverts commit 4f20c9f6f95c117bcdb520682df4fa1429a56477

Change-Id: I4d8cef801d570b0c20e580144e79a5940b100271
Reviewed-on: https://gerrit.libreoffice.org/5476
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-08-17 15:28:01 +00:00
4f20c9f6f9 fdo#57950: Remove some chained appends in xmlsecurity
Change-Id: If70fa38ad4836b6dacdd0c5577c66b78be6826a6
Reviewed-on: https://gerrit.libreoffice.org/5465
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-08-17 07:48:21 +00:00
9499df9f8c Ifdef out code which had been accidentally un-commented-out
The code snippet had been commented out since its introduction in
2004. In 1452e5659796db395efa222d50cc8158275c5442 it was accidentally
un-commented-out, but it causes compilation errors. So ifdef it out
instead, with a comment. Note that I have no idea what the code does
and whether it actually is useful to keep for future reference or not.

Change-Id: Ie60ca065b2c65f86a7b382e246c1b650424daa1d
2013-08-12 09:28:57 +03:00
1452e56597 fdo#62475 removed pointless comments
Change-Id: I02b264a9661bcefaea96d6c5743352914154427d
Reviewed-on: https://gerrit.libreoffice.org/5345
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-11 19:37:59 +00:00
ec52a20edb fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
Change-Id: Ie959aa5a6874aae3c60273355a959c344e82699e
Reviewed-on: https://gerrit.libreoffice.org/5083
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-24 20:18:36 +00:00
bddd4d4598 Mark as const
Change-Id: I2746b92b1360c3c181879a81f653c44ef609f351
2013-07-22 21:03:55 +09:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
670e2329df fdo#46808, Convert xml::crypto services to new style
Also remove the unnecessary XInitialization implementations.

Change-Id: I81f32b2cdcf69b84fe4b15382f9294073a7f2f20
2013-06-10 10:20:44 +02:00
9eb4e4dc51 Some more modules at least building with mingw64
Change-Id: I3ea039655aecb7885bb310b1f2c29d66f9f7bb4f
2013-06-06 19:49:56 +02:00
3d8a7a435c Resolves: #i120675# the certificate store handles need to be closed
after closing the document

Found by: zhangjf
Patch by: zhangjf
(cherry picked from commit 33d9584bb6d285de1d935bf23adbb2c7666656f4)

Change-Id: I131a17276f33059eb944fc34272c50f838b6973f
2013-05-16 16:26:34 +01:00
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
3155a8e60f xmlsecurity: drop no longer needed RTL_ASCII_USTRINGPARAM macro
Change-Id: Ia08688ef3c262ba4379213231032c73404ae748b
2013-05-06 09:24:01 +02:00
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
e79b387e03 It is very wrong to #undef _DEBUG in some source files of a library
Nowadays in a dbgutil build with MSVC, the debugging runtime (C++
library) is used. Just like with the GNU libstdc++, it is not binary
compatible with the non-debugging variant.

All sources that go into one DLL or EXE must be compiled with the same
_DEBUG settings (unless one is extremely careful and knows exactly
what one is doing, which presumably is not the case with this code).

With previous compilers this has gone undetected, but with MSVC2012 at
least, you get link-time errors, which is a good thing:

nssinitializer.o : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in biginteger.o

nssinitializer.o : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MDd_DynamicDebug' in biginteger.o

Whether this actually has caused run-time erroneous behaviour or
not in a dbgutil build is another thing...

Change-Id: I0c42161f00a0e37b438e3b911e3c0058edadd800
2013-04-17 13:23:35 +03:00
ba044b1e96 remove needless forward rtl::OUString declarations
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07 14:23:12 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
a9e6e5bf4d The [_]DEBUG_WAS_DEFINED macros are not used here
...but only in connectivity/source/drivers/mozab/{pre,post}_include_mozilla.h,
which is never included from here, so this smells like cargo-cult.

Change-Id: Iac0d7d60caad7c090445d551b7adb50424130e2a
2013-03-25 08:52:56 +01:00
ec52e5e5a2 Consolidate XMLSEC_NO_SIZE_T setting in xmlsecurity/xmlsec-wrapper.h
...so all xmlsec/*.h includes are bundled there now (except, for pragmatic
reasons, the xmlsec/mscrypto/*.h ones that unconditionally include windows.h and
only work on Windows).

Change-Id: I33e642f4f6a2e40edd6950af7f209c8b76c6e5fe
2013-03-25 08:52:55 +01:00
3b006a10b7 stricmp macro is unused
...since f3eb77586e067a46211334a78987652815f47744 "further removing of dead
code."

Change-Id: I6805c5adafcf19782f352cdacd0d99a9e7681eb6
2013-03-25 08:52:55 +01:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
1af22c05c6 fix other problems found by Wundef
Change-Id: Ib4aba95436f82d2a20b07a092f0fd07e0620fdcf
2013-03-18 17:15:57 +01:00
41e03a166e doubled using
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-05 12:34:33 +01:00
875c997c7d fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher
Removed several unused methods.

Could not remove ScVbaFormat<ooo::vba::excel::XStyle>::getAddIndent() and ScVbaFormat<ooo::vba::excel::XStyle>::setAddIndent(com::sun::uno::Any const&) because it breaks compilation (they are implementing pure virtual methods).
Should Test::test1Table1Page() really be removed? (test class)

Conflicts:
        unusedcode.easy

Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
2013-02-27 15:40:16 +01:00
f1a96446fa Remove duplicate OID
This ID is refers to digestedData and hashedData.

http://msdn.microsoft.com/en-us/library/windows/desktop/aa381133(v=vs.85).aspx

Change-Id: I2b9585332e27fad860aee458ef3183a9772e9c3f
Reviewed-on: https://gerrit.libreoffice.org/2403
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-02-26 09:10:27 +00:00
3648c3226d Add OIDs for Russian crypto algorithms.
Change-Id: Id1d6a623863d7643401dce912991e61de16695f2
2013-02-24 13:56:37 +01:00
eb7185a168 Fix typo begining/beginning.
Change-Id: I9fff386181a2be0bc83787c8b5aec9c1cb4db9c3
2013-02-23 19:17:03 +01:00
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
931f62a520 coverity#735579 Logically dead code
Change-Id: I68a1dc0926b1310b196212e0ec602cc9d78b43de
Reviewed-on: https://gerrit.libreoffice.org/2230
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:51:17 +00:00
0be1b5f4a6 coverity#982735 Negative loop bound
Change-Id: I597cd1204b0b7f5c7351482c3cdd00fc6111218a
Reviewed-on: https://gerrit.libreoffice.org/2224
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:50:50 +00:00
975e269476 coverity#705782 Resource Leak
Change-Id: I8346d3fd2ce4345cc9a352abb608cfec5f6939f4
Reviewed-on: https://gerrit.libreoffice.org/2223
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:49:57 +00:00
50ba5ad06a coverity#982249 Unchecked return value
Change-Id: I959599c899b489aa42ccce60c6794869041522a0
Reviewed-on: https://gerrit.libreoffice.org/2222
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:48:32 +00:00
21f13f91f9 coverity#705976 coverity#7074977
Change-Id: Iaedb5fcd87a24f478d7c4a9c25e32cd2d0ee55da
Reviewed-on: https://gerrit.libreoffice.org/2221
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:47:47 +00:00
9a49ff646b nsscrypto_initializer: MSVC does not support C99 dynamic arrays
Change-Id: I407b2308756b46fbf0920881fc20972b486819b7
2013-02-19 11:34:29 +01:00
08ac21ddd9 coverity#705355 coverity#705356 Missing break in switch
Change-Id: I9a0a370eb1279a184a47e15bcefc6ce5e4025aa3
Reviewed-on: https://gerrit.libreoffice.org/2226
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-18 23:15:49 +00:00
21e2c2f164 coverity#982590 Explicit null dereferenced
Change-Id: Ie898603f64a4568a8502caf3db154ae5ce008af9
Reviewed-on: https://gerrit.libreoffice.org/2227
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-18 23:12:09 +00:00
cbe8883b51 coverity#982591 Dereference after null check
Change-Id: I8651ecb0287d686da3e1ca6a6e46549abe3e0c38
Reviewed-on: https://gerrit.libreoffice.org/2225
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-02-18 21:38:42 +00:00
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
a5ee0319aa Fix "scope can be reduced" for 2 variables
Change-Id: I200d7c545e82fd2167f22f5522033d6e64b975f8
2012-12-28 21:34:08 +01:00
b1959dbfad Remove unused cppuhelper/servicefactory.hxx includes
Change-Id: I27fd4d1f1dfafccaa7936defb5cd687d6266e0a2
2012-12-21 15:56:44 +01:00
973a16f9e6 Adapt to XComponentContext
Change-Id: I2f2c745245722f90b8101995367c55878d568703
2012-12-07 07:55:50 +01:00
5da74dcdea Clean up SerialNumberAdapter implementation
Change-Id: Iebf992544cb71fd2e2f4541a5a63fc962150e390
2012-12-07 07:55:48 +01:00
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00