Commit Graph

2501 Commits

Author SHA1 Message Date
267f401e2a cppcheck: noExplicitConstructor
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
2015-09-07 09:56:07 +01:00
2c1019739b svx: prefix members of SdrPaintView
'mpModel=pModel' is more readable than 'pMod=pModel1'.

Change-Id: I617d85e2c2d4b6b5b0d235cdd3cd9129e276b28d
2015-09-04 09:04:18 +02:00
6900bf41e2 o3tl/cow_wrapper: remove boost dependency
Remove boost dependencies from ::o3tl::cow_wrapper, and add
the necessary includes to files including checked_delete and
noncopyable that do not already include the necessary files.

Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686
Reviewed-on: https://gerrit.libreoffice.org/18125
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-29 22:51:36 +00:00
167bc621ef Convert vcl Button Link<> click handler to typed Link<Button*,void>
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-26 11:15:35 +02:00
ae0cd13fa3 remove last WeakImplHelper12 use
Change-Id: I804132abe01ef3a54e6824d415e19c7edc8039cb
2015-08-21 12:05:41 +01:00
0075446151 make color button work in chart line sidebar panel
Change-Id: I2148fd9953b283945d2a1bcf24dbc47964b659ae
2015-08-20 03:15:57 +02:00
e56be085ea WaE: -Werror=maybe-uninitialized
Change-Id: Ibf62ffa133aa4cde1836f7b7e735559c02ffb588
2015-08-20 02:22:26 +02:00
15fcf82a11 also need to call updateFillColor to get the UI in order
Change-Id: I689d84ef58faeb4b36159c6370b5e97a13d39736
2015-08-20 02:15:22 +02:00
acd818d973 update the color button when we select an object
Change-Id: Ib45a02248819c35844ef83435c33ab1c82f5c4dc
2015-08-20 00:14:51 +02:00
cf7db82262 handle new color picker correctly in chart sidebar
This implements the basics for that and implements it in the AreaPanel.

Change-Id: I6d9e5012bbcc2c953d478a09a839f35f2ef64c5b
2015-08-20 00:14:51 +02:00
d21260cdb6 Remove two silly typedefs
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19 13:34:43 +02:00
ad1f0d1f1a o3tl: rename compat_functional header
After the cleanup, the stuff there really stands on its own (and the
remaining usage of select1st/2nd is more descriptive than lambdas).

Change-Id: I0aba131d5dc550189f8130d167dc94167e404540
Reviewed-on: https://gerrit.libreoffice.org/17806
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17 16:38:30 +00:00
70a30fd179 loplugin: defaultparams
Change-Id: I65c0ed65b20f606cf1409a3158ff1ef1e2d6cd9f
2015-08-14 10:52:46 +02:00
0db25f68ab remove default value from SfxPoolItem::PutValue
more useful to make it explicit.

Specifically, otherwise my defaultvalue clang plugin would want to
remove lots of places that contains #define constants which, while
technically the same as the default value, convey semantic
information which is quite useful.

Change-Id: I918ad5b0e73ba279fa1b1489b62d900339ff71eb
2015-08-14 09:16:06 +02:00
f5ace6b29e no need to set the help id twice
Change-Id: Idb903eaacf35d7b826086aae0b56fb1f496c25da
2015-08-12 17:00:56 +01:00
c1c142dc64 Avoid division by zero
Change-Id: I283101cdb9b2801880b116064389beb65bd5712a
2015-08-12 14:17:05 +02:00
87130a4e18 tdf#92459 Cleanup unclear lambdas
Replace lambdas used to select the first/second member of a pair with
the new simplified select1st/2nd from o3tl/compat_functional. There
should be no side effects due to this change.

Change-Id: I17f37796e0c4defe96a10aa491d192adb9eebb89
Reviewed-on: https://gerrit.libreoffice.org/17656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11 22:29:12 +00:00
711b34d590 tdf#92997 obtain a date/time edit format according to field value
Bloody workaround hack for the fact that Chart does not handle
category/x-axis times internally and is not able to pass its own axis
numberformat to its own databrowser editor.

Change-Id: I016695ad0104366c0bb636b449a2014ade31aca3
2015-08-10 15:20:02 +02:00
8a7b4d5bb5 Explicit capture annotations
Change-Id: I7be1a36196a07a80a7b7173c3869621f5d707204
2015-08-08 15:16:34 +02:00
5a2a266d4b support more command in chart sidebar
We now have a complete toolbar controller in chart2.

Change-Id: I007d9b058e3d6800204ac035cc2aef5e93c1208b
2015-08-05 23:17:24 +02:00
5916d5866c tdf#92459 replace deprecated o3tl features
Replace all uses of deprecated features from o3tl/compat_functional.hxx
with lambda expressions.

Change-Id: I6370c80dbe675da517904e535e19bf63830c3e2c
Reviewed-on: https://gerrit.libreoffice.org/17450
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
2015-08-01 06:25:49 +00:00
8b0109f28e avoid crash when chart model is disposed
Change-Id: I70c3a06e2aa9112cd5a47b7d8839c4bd701cfc1e
2015-07-31 17:38:40 +02:00
00edc9567f Some (mostly HIG) tweaks to chart axis panel
+ added a text orientation spinbox to .ui file, but it does nothing so
far

Change-Id: Idb9177683c46fba50a153aff795aab7a2f419694
Reviewed-on: https://gerrit.libreoffice.org/17402
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-30 15:29:14 +00:00
41d1b01a90 API CHANGE: remove update() from X3DChartWindowProvider
Revert the API change from e41c33b376d8b5776e400979eb8544db596c5bbe
and use the existing css::util::XUpdatable instead.

Change-Id: I3eba4c7def98c8765a970d54a7fe84a320d4313e
Reviewed-on: https://gerrit.libreoffice.org/17382
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-30 15:27:38 +00:00
025fb3c660 prevent panel update when updating values from panel
Change-Id: I10debb5119ce78638db42315594cda4d65092fb0
2015-07-30 14:13:32 +02:00
a45827b230 loplugin:unusedmethods
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30 06:23:00 +00:00
9022556453 small fix to reduce UnknownPropertyException in chart2
accidently introduced with f1531cdaaebe706d909dc6ddde439ccb5f4ad36d

Change-Id: I292097c5f61ecb32a28a90e9f5be48fcfd6bcd7b
2015-07-30 05:45:26 +02:00
bead8d0109 also handle line width correctly
Change-Id: Ia564d3c9b821a09586a0bcb32ee3f827e71f43de
2015-07-30 05:45:25 +02:00
3dc00a8de9 handle line dash in chart line panel
Change-Id: Ia3d466c269eef62f8fa419d15869f44213a6e001
2015-07-30 05:45:24 +02:00
e517948e71 set some properties from chart line panel
Change-Id: Idbe26d7ea554512391b22299ac6dccaeaa71d584
2015-07-30 05:45:23 +02:00
57dcf78e6b provide structure for chart line panel
Change-Id: I75204a012e4bc59f40a06db814bb9057a1cf8598
2015-07-30 05:45:22 +02:00
2d4223e326 Some (mostly HIG) tweaks to chart data series panel
Additional tweak: use 'Data series %1' as frame label, substitute
%1 by real series name

Change-Id: Id5bee4c2e52ccd98fa40649ec539b3efdee55962
Reviewed-on: https://gerrit.libreoffice.org/17387
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-07-29 15:46:11 +00:00
93d301a287 Some (mostly HIG) tweaks to chart elements panel
As I wanted to represent subsections as frames (it looks kinda
better with bold labels), I tried to emulate grid behaviour by
putting widgets into 2 size groups

Other tweaks include disabling legend position listbox when legend
is not to be shown and missing clear() of that listbox

Change-Id: I0b635fe5aba1580542cf982e2e6be02eb0056352
Reviewed-on: https://gerrit.libreoffice.org/17386
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-07-29 15:40:10 +00:00
2d8f1faa97 fix the last transparency gradient issues in the chart area panel
So apparently I was looking up the gradient in the wrong table.

Change-Id: I26de6f9bb5f9baf65a7856682a327da611da3ae7
2015-07-28 02:52:05 +02:00
88f5d4ce86 use common fill property names in chart2
Change-Id: I9445344efc70d872fdb9c9a8cc49838210861a7b
2015-07-28 00:59:13 +02:00
65c2570e86 handle fill float transparence in chart area panel
Change-Id: Ibf72ba72ec193638f389167aab415b94a383f3d1
2015-07-28 00:59:12 +02:00
e5440e415a -Werror,-Winconsistent-missing-override
Change-Id: I6975b340e42b113650a6c6ba51fdb558af493132
2015-07-27 10:04:40 +02:00
9ba833f014 don't show the area sidebar for panels where it makes no sense
Change-Id: I06655e0574b28a88db920424fa515b8350133f10
2015-07-26 00:27:03 +02:00
87f750f1c5 also update for the first selected object
Change-Id: I7df8772c7414df694eda5ea30b74eccd6e9b98db
2015-07-26 00:27:02 +02:00
5845e73783 handle chart wall correctly in area panel
Change-Id: Iacd9498884a20357f217e1165a3422b6f1e2aa81
2015-07-26 00:27:02 +02:00
7b9818c4cc handle bitmap in chart area panel
Change-Id: I3137fc1ac066b712594d0cf471ca4eb8a344c0bd
2015-07-26 00:27:00 +02:00
8ab10c27be update hatch in chart sidebar
There is a huge level of insanity in the hatch handling. Apparently
different parts of the code use different case of the hatch id which
makes it difficult to handle it.

Change-Id: I5674e21a6c9a2d01d7b641473e00ab5e2bcaffd4
2015-07-26 00:27:00 +02:00
b5c0f852b5 update gradients in sidebar as well
Change-Id: I0dc737c133e905d75fab23457fb86c8d2b724ce8
2015-07-26 00:26:59 +02:00
e4daf8be5e this nasty update cycle was causing many issues
Setting the property from the sidebar was causing the model to be
changed and therefore updating the sidebar again.

Change-Id: I9ca690ae05d4cb0f2ce16f905a29582cc9e86f64
2015-07-26 00:26:58 +02:00
b3a5230459 update some area properties
Change-Id: Iab888226ef1b8f18a6cdfd0ddf58077405306510
2015-07-26 00:26:57 +02:00
427f28ea2f add selection change listener to area panel
Change-Id: I4e3f0c1c669ec1c584cc2d6932fd78e177effa89
2015-07-26 00:26:56 +02:00
bc4592132f add selection change listener
This finally allows us to handle the case where you switch between
objects of the same type.

Change-Id: Ic13e15e2a426d08995a577dfc1b7ee6f7da04f30
2015-07-26 00:26:56 +02:00
0635208edf handle more than one chart with chart sidebar
Change-Id: I4998904a9273f2c67114a246d7f234843602573c
2015-07-26 00:26:55 +02:00
cfac266d06 implement a few more methods
Change-Id: Ieab088f2ad48f313c913424c60a10b59de4e0bcb
2015-07-26 00:24:42 +02:00
c36df7c084 avoid a crash that occures sometimes
Change-Id: Iccbdfdb8a46b45b76756ff8080757db3770d691c
2015-07-26 00:24:41 +02:00