70a30fd179
loplugin: defaultparams
...
Change-Id: I65c0ed65b20f606cf1409a3158ff1ef1e2d6cd9f
2015-08-14 10:52:46 +02:00
5a2a266d4b
support more command in chart sidebar
...
We now have a complete toolbar controller in chart2.
Change-Id: I007d9b058e3d6800204ac035cc2aef5e93c1208b
2015-08-05 23:17:24 +02:00
41d1b01a90
API CHANGE: remove update() from X3DChartWindowProvider
...
Revert the API change from e41c33b376d8b5776e400979eb8544db596c5bbe
and use the existing css::util::XUpdatable instead.
Change-Id: I3eba4c7def98c8765a970d54a7fe84a320d4313e
Reviewed-on: https://gerrit.libreoffice.org/17382
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2015-07-30 15:27:38 +00:00
9022556453
small fix to reduce UnknownPropertyException in chart2
...
accidently introduced with f1531cdaaebe706d909dc6ddde439ccb5f4ad36d
Change-Id: I292097c5f61ecb32a28a90e9f5be48fcfd6bcd7b
2015-07-30 05:45:26 +02:00
b5c0f852b5
update gradients in sidebar as well
...
Change-Id: I0dc737c133e905d75fab23457fb86c8d2b724ce8
2015-07-26 00:26:59 +02:00
0635208edf
handle more than one chart with chart sidebar
...
Change-Id: I4998904a9273f2c67114a246d7f234843602573c
2015-07-26 00:26:55 +02:00
7410217b7d
loplugin:unusedmethods chart2
...
Change-Id: Ib7e8824e9e7f912963fbf07111ee3aa97773ceca
Reviewed-on: https://gerrit.libreoffice.org/17167
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-20 06:34:23 +00:00
9f27e5b0e0
Fix typos
...
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c
Reviewed-on: https://gerrit.libreoffice.org/17187
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2015-07-19 19:45:07 +00:00
95b1491dac
add chart sidebar axis panel
...
Change-Id: Ia0f75c09f11c5751428a19fca33b39a54cdbb249
2015-07-17 21:12:50 +02:00
5c420fcdf9
tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants, in chart2.
Change-Id: Ib145860cf757d932fd5710f92c7f9ce33904b619
2015-07-17 09:39:04 +02:00
75d50b7189
generate correct sidebar context strings for charts
...
Change-Id: I92adf79c461f3536475da318e03b60f2e1adc08f
2015-07-16 22:18:09 +02:00
9ce5cfff0a
enable the chart sidebar again
...
Change-Id: I0ad9d962436562aa1026c50e5ec16f844f889eef
2015-07-16 08:15:20 +02:00
49d2400f8d
remove my accidently committed debug messages
...
Change-Id: Ia890837520b57291ae119de30dc7586b65e30b81
2015-07-16 08:15:18 +02:00
1d0696a349
we need access to the chart model in the chart sidebar
...
Change-Id: I607b5ada047f84cd7a229640772a332702f93f1e
2015-07-16 08:15:17 +02:00
8de7d44f96
disable newly unused code since last disable
...
Change-Id: I9f0abc3963ac4687e29fc629f1b9e9bb1fffaf8a
2015-07-13 20:59:05 +01:00
f90307a937
disable that code for now
...
Change-Id: I9f65babd0314498145746c452180ccf4fab64720
Reviewed-on: https://gerrit.libreoffice.org/17020
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-07-13 18:20:05 +00:00
2aea9e37d6
Introduce generic sub toolbar controller
...
Currently many toolbar controllers are basically doing the
same thing - show some docked toolbar. So the idea here is
to have one generic controller that will handle all these
cases in a unified way. It will get the name of the toolbar
that it's supposed to show from the configuration, based on
the command it was registered for.
Right now it can handle both simple (i.e. with DROPDOWNONLY
bits) and split (i.e. with DROPDOWN bits) scenarios, where
for split kind it replaces the function (and the image) of
the main part of the button, with the last selected function,
for easy reusing. A button is considered to be a split one,
if the name of the initial default command was passed along
with the sub toolbar name, otherwise it will be a simple
button.
The core change is in framework/. Other parts are a usage
example, in form of converting the custom shapes buttons
to this new controller.
Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d
Reviewed-on: https://gerrit.libreoffice.org/16967
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com >
2015-07-13 12:09:52 +00:00
5b16fff9ac
loplugin:staticmethods
...
Change-Id: I8b57b7ce707438ad3c7c901b03c94d9045585ed8
2015-07-13 09:21:51 +02:00
efd13b27a4
finally manage to register chart2 in the ChartController
...
We need to do some jumps through pink hoops to connect the chart
controller with the host sidebar.
Would we use the chart window as parent for our sidebar the sidebar
would be directlz beside the chart and not at the border of the host
window.
Change-Id: Ica44ae370518882ef367999f57251b1256907016
2015-07-12 18:56:48 +02:00
498e03c2a3
fix crash
...
Change-Id: Ic1bc31b68c4a2aafb1e40ebff84fbf052df7041f
2015-07-12 18:56:47 +02:00
04716cb9ac
add SidebarChangeHandler to chart2
...
I still need to wire the correct frame to the correct sidebar for it to
work.
Change-Id: I0fecc2be674d6b024bc39e707930a4c30f67cb81
2015-07-12 18:56:47 +02:00
bc14d27dd0
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: If5ab427ab320e2623df182e6143c4e7123610eae
2015-06-08 16:23:25 +02:00
0f71828a95
cppcheck: noExplicitConstructor
...
Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf
2015-06-08 11:14:38 +01:00
b9f9576949
WaE: ‘<::’ cannot begin a template-argument list
...
This is an internal include file deep inside chart2, so just use css::. The
file uses css:: already in a couple of places anyway. So maybe I should have
been brave and just changed all the ugly ::com::sun:⭐ : into css::?
Change-Id: I705db39ff55f3e47c7e9d2f79fee625d76a22ca0
2015-06-05 17:48:33 +03:00
9509ce6103
some whitespace clean-up
...
Change-Id: I80aa6692c528176e38b5414145b484a32a9906f6
2015-06-02 00:14:43 +02:00
ba81e5c6bd
tdf#91702 - fix stack-based MessBox allocation.
...
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2015-05-29 12:16:28 +00:00
e0b2e6e3f7
loplugin:loopvartoosmall
...
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-29 08:48:41 +02:00
bb7ce3137d
convert INVALIDATE constants to scoped enum
...
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the
IDL docs for XWindowPeer
Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-26 08:30:18 +02:00
ac3802da9a
convert WINDOW_POSSIZE constants to scoped enum
...
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9
2015-05-22 10:37:59 +02:00
e929194317
convert POINTER constants to scoped enum
...
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19
Reviewed-on: https://gerrit.libreoffice.org/15825
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-22 06:32:35 +00:00
5bf6fecde7
tdf#91054: cleanup weirdo function prototypes
...
cleanup the folders chart2/ and ucb/
Change-Id: Ia5f230703e55da5710eaa52bbd9e22a6395a49ad
Reviewed-on: https://gerrit.libreoffice.org/15832
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-21 06:34:45 +00:00
ab465b90f6
bin/rename-sw-abbreviations.sh
...
renames the most annoying abbreviations in Writer (and partially
in the shared code too).
Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-20 13:05:49 +02:00
456c379ffd
convert ANTIALIASING constants to scoped enum
...
Change-Id: I175b8ea4e8bc01c3cdd3dd90506eba01b35e0085
2015-05-20 09:52:09 +02:00
3cbdf64ad5
convert DRAWMODE constants to scoped enum
...
Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f
2015-05-20 09:52:08 +02:00
4b4c23acc7
fix old GCC build
...
after my commit 10749bbf8247f0b17201b33f95a090dfc4fc3211
"remove the last of the OUString #defines in header files"
Change-Id: I592e918f7b718ddff99a8eaff04b11064fad65d9
2015-05-19 10:11:53 +02:00
5b1337f7b2
tdf#62475: partial handmade fixes
...
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com >
2015-05-15 17:55:15 +00:00
73e45da4f5
refactor chart2 classes to use RenderContext
...
Change-Id: I245af77126739bb219f6a085a47cee2efac2c351
2015-05-14 09:58:14 +09:00
47ac1b7445
perform a proper boundary check, just in case
...
Change-Id: I4713b88a2130658513fd64793129c855169f0187
Reviewed-on: https://gerrit.libreoffice.org/15720
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-05-13 10:56:21 +00:00
0ac8026773
add PostPaint and change PrePaint to include RenderContext param.
...
Change-Id: I26e03159fa6115025c6cf376e6ce71443bc98cec
2015-05-13 13:57:46 +09:00
82d68f9cbc
convert COMMAND_ constants to scoped enum
...
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-11 12:17:42 +00:00
7df89ec7a2
Remove unnecessary includes of sot/storage.hxx from include/
...
Change-Id: I242cd126814bbebdb99ea38d9e66513189c313d9
2015-05-07 11:05:05 +02:00
0241519f32
Unwind SotStorageStreamRef typedef
...
Change-Id: If7652a7c0251b741660365848a717c06954ca419
2015-05-07 11:05:04 +02:00
8cafd08278
Use typed Timer::SetTimeoutHdl Link
...
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-05 10:21:54 +02:00
5a27f808be
Get rid of initial :: for the sdr namespace
...
Change-Id: Ibbeb069b6fcb2aa0581429ac5cb6db519548fd00
2015-04-30 09:11:40 +03:00
0a9f331de4
convert SDRMOUSE constants to scoped enum
...
Change-Id: Ia5389095683a1c012a988ed71bf769a1f25d80fb
2015-04-29 10:41:40 +02:00
9905a8b953
replace Paint calls to Invalidate + fix compilation
...
Change-Id: Id716c47d56922ab6ce0c3adb3d426ea814980674
2015-04-29 09:24:20 +09:00
f50fd9692e
mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&)
...
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
2015-04-29 09:19:47 +09:00
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
e19cd844be
Rephrase comparisons between bool and sal_Bool
...
...to cater for forthcoming loplugin:implicitboolconversion improvements
Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
2015-04-28 10:21:01 +02:00
7ab8b08b6c
loplugin:staticmethods
...
Change-Id: Iab2f10b000ef41fb090e0034785d4ed0bda4cf43
2015-04-23 13:08:48 +02:00
