wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
379,629 Commits 5 Branches 0 Tags
267f401e2ad6e0094de39032671a3191772276ed
Commit Graph

6192 Commits

Author SHA1 Message Date
Ashod Nakashian
2b8e62f7b6 tdf#39080 Hide white space between pages in 'print layout' 
Merged Hide Whitespace with Browser Mode and hooked
the former with the UI. In Hide Whitespace mode
the headers and footers are removed and
page margins as well as between-page gaps are
reduced to minimum.

In single-page view the side margins are left
as-is. In multi-page and book-view the sides
are removed, however, they have twice the
width of the top and bottom.

Printing and PDF export disable this mode.

The usable screen real-estate is greatly
improved in this mode, which is controlled
from the View menu.

Change-Id: I2d0075ae9a76162c26c78e9eb23a71920cdfc522
Reviewed-on: https://gerrit.libreoffice.org/17281
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-03 08:45:07 +00:00
Stephan Bergmann
37a6fdf890 loplugin:stringconstant also for cases using char const v[] = "..." 
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
 2015-09-03 09:34:00 +02:00
Noel Grandin
5beffcf3f1 convert Link<> to typed 
Change-Id: Ic0482dc5ed26eb2fc6ccde73022eff8b4786de83
Reviewed-on: https://gerrit.libreoffice.org/18258
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-03 07:20:27 +00:00
Marco Cecchetti
2d215ceccf Fixed a bug due to conflicts with Casarin's commit. 
Change-Id: I5226a55ba804d494a8c9c9c9b5cd7ed3889eafbf
 2015-09-01 16:28:50 +01:00
Miklos Vajna
51242678e2 filter: avoid casting BitmapChecksum to sal_uInt32 
Since BitmapChecksum is a typedef for sal_uInt64.

Change-Id: I768fa5134fa6e86559f3c6cbe1071093b4e68152
 2015-09-01 16:28:49 +01:00
Marco Cecchetti
c8a46ee519 truncate checksum to 32-bit when it slips inside a file stream 
Change-Id: I2cedf8acf73f71529f4090ff2f9fce7ab7663e68
 2015-09-01 16:28:48 +01:00
Marco Cecchetti
7fe85d7633 Switching to 64-bit checksum: substituted sal_uLong with BitmapChecksum 
A typedef sal_uLong      BitmapChecksum;
has been added to include/vcl/checksum.hxx

Wherever needed sal_uLong and sal_Int32 has been substituted with
BitmapChecksum.

A BITMAP_CHECKSUM_BITS constant equal to the amount of bits used by the
BitmapChecksum type has been defined and used in
`GraphicID::GetIDString` (vstools/source/graphic/grfcache.cxx).

Change-Id: I74bd285089e58a8b18c06233d75b87023c7bf31b
 2015-09-01 16:28:46 +01:00
Caolán McNamara
cefbbd5c32 coverity#1321600 Dereference before null check 
Change-Id: I5a2e61200333ca57af990d3d7be3899da836472a
 2015-09-01 09:40:20 +01:00
Caolán McNamara
239c25ff95 check for error more frequently 
Change-Id: I909c225dd9bd92763ae24b62854a9217fc2e2a0e
 2015-09-01 09:40:20 +01:00
Stephan Bergmann
0fad62c217 -fsanitize=enum 
...as happens in CppunitTest_sw_filters_test with
sw/qa/core/data/ww8/pass/CVE-2015-2467-1.doc, first at:

> filter/source/msfilter/msdffimp.cxx:1477:17: runtime error: load of value 8193, which is not a valid value for type 'MSO_Anchor'
>  DffPropertyReader::ApplyCustomShapeTextAttributes(SfxItemSet&) const filter/source/msfilter/msdffimp.cxx:1477:17
>  DffPropertyReader::ApplyAttributes(SvStream&, SfxItemSet&, DffObjData&) const filter/source/msfilter/msdffimp.cxx:2694:9
>  SvxMSDffManager::ImportShape(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4332:21
>  SvxMSDffManager::ImportGroup(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4119:39
>  SvxMSDffManager::ImportGroup(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4106:39
>  SvxMSDffManager::ImportGroup(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4106:39
>  SvxMSDffManager::ImportGroup(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4106:39
>  SvxMSDffManager::ImportObj(SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4033:16
>  SvxMSDffManager::GetShape(unsigned long, SdrObject*&, SvxMSDffImportData&) filter/source/msfilter/msdffimp.cxx:6210:23
>  SwWW8ImplReader::Read_GrafLayer(long) sw/source/filter/ww8/ww8graf.cxx:2502:17
>  SwWW8ImplReader::ReadChar(long, long) sw/source/filter/ww8/ww8par.cxx:3634:17
>  SwWW8ImplReader::ReadChars(int&, int, long, long) sw/source/filter/ww8/ww8par.cxx:3436:27
>  SwWW8ImplReader::ReadText(int, int, ManTypes) sw/source/filter/ww8/ww8par.cxx:3974:22
>  SwWW8ImplReader::CoreLoad(WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5175:9
>  SwWW8ImplReader::LoadThroughDecryption(WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5773:19
>  SwWW8ImplReader::LoadDoc(WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6045:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6167:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20

Change-Id: Iafc548b5ba21a985521790770732f7f03e2485c9
 2015-09-01 09:49:14 +02:00
Caolán McNamara
ad6d83defb check for legal field sizes before reading 
Change-Id: I3cdb647e1a057be5bb4b32d119ee5bcbbedf7473
 2015-08-31 11:22:45 +01:00
Caolán McNamara
a8fe085f97 check stream status 
Change-Id: I65ed5979d35d8739367294a71620782b832cfd71
 2015-08-31 09:57:00 +01:00
Noel Grandin
68ddda0f3f convert Link<> to typed 
Change-Id: I53b0a7a9875a3ebcca915c8f2d8c53face6f9509
 2015-08-31 09:50:10 +02:00
Stephan Bergmann
6f6884b198 loplugin:stringconstant: OUStringBuffer: appendAscii -> append 
Change-Id: I8bbbb3f78d44ac1ddcc83170947038f20440f16f
 2015-08-31 08:03:32 +02:00
Caolán McNamara
7d4c77e374 pClientData can be null 
Change-Id: I9375f84affdaef30d9b1ded31525e6b7b8709cbc
 2015-08-30 20:18:26 +01:00
Matteo Casalin
986a172a74 sal_uLong to sal_uInt32 for CRC32 
Change-Id: Id13e07f479615b8eb39d05e6534f514277cc3d03
 2015-08-29 16:57:01 +02:00
Caolán McNamara
078235028a eof isn't a Error, so use good not GetError 
Change-Id: Ie1df87c7eb9d391d0fa4a579f744051a1f1b2ae1
 2015-08-28 20:06:37 +01:00
Caolán McNamara
1847753ab1 check seeks and reads 
Change-Id: I0c5c4784713376e0762bfbd197640f8d31b65562
 2015-08-28 20:06:36 +01:00
Caolán McNamara
5ed690a3e8 check seeks and offsets 
Change-Id: I2b6ded138b9101415fc49e93e1ec3ebcd3a9d2ae
 2015-08-27 20:32:28 +01:00
Caolán McNamara
0c713e45f9 check seek 
Change-Id: I358758999bb918e73cdee2224e575e72c2131453
 2015-08-27 20:21:41 +01:00
Caolán McNamara
d400f155fd check returns of SeekToEndOfRecord 
Change-Id: Ia593dd0e2239a97f17bb03f005d22028da482445
 2015-08-27 16:43:18 +01:00
Caolán McNamara
7e373e92fc crashtesting: tiff loop detection too slow 
moz323894-1.tiff and moz456356-1.tiff take too long to load

Change-Id: Iaafa064fd05e4a4152004e7ceb6256af68aeef01
 2015-08-27 14:45:04 +01:00
Caolán McNamara
de71eae580 avoid loops in atom chains 
Change-Id: Icc40c0ee6c7d8d305cf7cc60cbf3e511c763aedd
 2015-08-27 14:45:03 +01:00
Caolán McNamara
9a695e0710 check stream state after read attempt 
Change-Id: Ie3836f2e95acab963634181a07565343501f00f8
 2015-08-27 14:45:03 +01:00
Caolán McNamara
d417ffb7dd check SeekToEndOfRecord for success 
Change-Id: I7413a4e9e491b65122eaadb38ad574161f1aa943
 2015-08-27 14:45:02 +01:00
Caolán McNamara
c249f93d96 extend seek, loop ending tests to ppt specific code 
Change-Id: Id4419b6b902b742117e248870b6a663c9c58955f
 2015-08-27 09:16:24 +01:00
Stephan Bergmann
a6050c32f3 Clean up aEmpty 
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
 2015-08-27 08:00:32 +02:00
Stephan Bergmann
43c00bc489 Clean up aEmptyStr 
Change-Id: I5befe9deac917a28e80ed193b67ff29b5ba35149
 2015-08-26 21:24:29 +02:00
Caolán McNamara
a8b2dc80c4 various hangs, check seeks and record lengths 
Change-Id: Ided7f9376f41ee8cb1f6903e54a2d51e0e07e1a7
 2015-08-26 14:36:59 +01:00
Caolán McNamara
cadac8400a don't hang on unreachable record ends 
Change-Id: I288f7ff0327831603eda6e827c8acbae678dfaff
 2015-08-26 12:43:59 +01:00
Caolán McNamara
334dba623d fix crash on loading certain ppts 
Change-Id: I544a67e3706c7d12414cc075118ef2f0f5ddd0f6
 2015-08-26 11:30:02 +01:00
Noel Grandin
167bc621ef Convert vcl Button Link<> click handler to typed Link<Button*,void> 
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
 2015-08-26 11:15:35 +02:00
Stephan Bergmann
662498ab80 Avoid overflow in PBMReader::ImplReadHeader 
...as found by UBSan in CppunitTest_filter_ppm_test on
filter/qa/cppunit/data/pbm/fail/crash-1.pbm

Change-Id: Ib7c50ef1f07aba6b78f79c608be69c3dac38ddfe
 2015-08-25 12:01:52 +02:00
David Tardon
6b0585a5b7 upload libmwaw 0.3.6 
Change-Id: I09249673d42d36bf72ee1ffbf8f3f37734bd8bae
 2015-08-25 10:03:11 +02:00
Caolán McNamara
0a76c1fd68 in reality we are limited to max sal_Int32 here 
so accept that and test if the values were accepted or limited

Change-Id: Iaed5ebc2f12b52055506147c71117a2ad88d28ac
 2015-08-24 20:51:13 +01:00
Caolán McNamara
6b82437dca detect and reject loop in tif 
Change-Id: I77d315fa432a3eb1a65539489a2ba6da8508b283
 2015-08-24 15:32:42 +01:00
Zolnai Tamás
9a23428ff0 Use less operator here to be consistent with the original idea (see comment) 
This doesn't change the result of the BestIndex method

Change-Id: If1efc04feac3d4966c126b1fa93d017a4beafbe1
 2015-08-23 19:10:42 +02:00
Michael Weghorn
25accda781 tdf#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I6ab170c4426494ab9fc53017f88e47fbfdbd9aad
Reviewed-on: https://gerrit.libreoffice.org/17920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2015-08-22 13:02:08 +00:00
Michael Weghorn
373e71ee65 tdf#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I97726ed32e5aa92e7da7d248380a78b1b201e46e
Reviewed-on: https://gerrit.libreoffice.org/17912
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2015-08-21 22:25:03 +00:00
Matteo Casalin
aa62086495 sal_uLong to sal_uInt16 as return type of BitmapColor::GetColorError 
Change-Id: I62c0d073d6b22346b65e3560303d7fc9373bfc7e
 2015-08-21 22:29:41 +02:00
Noel Grandin
0ab1e76a29 loplugin:defaultparams 
Change-Id: Iaf6415d3b33a4ce195a00913a0df69f1fb794217
 2015-08-21 15:02:41 +02:00
Stephan Bergmann
ef1556416a Avoid css::uno::Sequence<sal_uInt8> (which is not a proper UNO type) 
Change-Id: I887c358161f7ac4032b9ad9166ff16aa0b19eaa1
 2015-08-19 14:48:28 +02:00
Stephan Bergmann
5da0dce19c Consolidate isFileUrl checks 
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
 2015-08-19 12:24:37 +02:00
Stephan Bergmann
236714e86c Clean up remaining utl::LocalFileHelper::Convert... 
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040
"ConvertURLToSystemPath->getSystemPathFromFileURL" and
28f3464a571a23a2c16bd0980e9021b95d011511
"ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those
Convert... functionality with direct calls to the corresponding osl::FileBase
functions.

Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
 2015-08-19 10:48:42 +02:00
Stephan Bergmann
6d64afb31e Replace utl::LocalFileHelper::IsLocalFile -> ...::IsFileUrl 
...given that vnd.sun.star.wfs is long gone.  Note that the old code could have
behaved differently in that for one it could have worked for relative URL input
(as osl_getSystemPathFromFileURL is allowed to accept relative URLs) and for
another could have failed for some file URLs (for which
osl_getSystemPathFromFileURL would return something other than osl_File_E_None
for whatever reason), but it looks plausible to assume that what the call sites
are really interested in is whether a given URL is a file URL.

Simplifies those call sites that already have a INetURLObject instance even
further.

Change-Id: Iaee4595d933a760b8321e42414a9ef0865311833
 2015-08-19 09:13:33 +02:00
Stephan Bergmann
88f12d9c7e Some oslCondition -> osl::Condition 
Change-Id: I57c10b14cd8a5ab821516575768891b66f834ca6
 2015-08-18 08:16:18 +02:00
Norbert Thiebaud
ef46917ff3 Put Polygon from tools under tools:: namespace 
Polygon is one of these names that Clash with some system objects
A similar work has been done earlier with PolyPolygon.

Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5
Reviewed-on: https://gerrit.libreoffice.org/17789
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2015-08-17 02:07:43 +00:00
Noel Grandin
fceee9237c loplugin: defaultparams 
Change-Id: I4080aece6fec2778a2a8646ddedd280337303591
 2015-08-14 11:09:40 +02:00
Noel Grandin
b14c9d14a1 remove default value from DffPropSet::GetPropertyValue 
more useful to make it explicit

Change-Id: Ic76fcc5ffa245b3eb3c99f3a5e4d0656b56c511e
 2015-08-14 09:16:06 +02:00
Takeshi Abe
678bb5135b tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants, for filter.

Change-Id: I30dcd7cfb3e484034f6cceceb1ff7cd9d3f4b7a6
Reviewed-on: https://gerrit.libreoffice.org/17585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-11 07:06:51 +00:00