Commit Graph

418 Commits

Author SHA1 Message Date
43691a15b3 tdf#93794 - spin buttons not rendered in gtk2/gtk3
for penance, introduce a unit test

Change-Id: I2c40285732be665e179c477e6e7603aa6f8be5d7
2015-08-31 13:59:55 +02:00
c1a9d01391 tdf#62525: use cow_wrapper for SvGlobalName
Convert the pimpled copy-on-write SvGlobalName class to use the
::o3tl::cow_wrapper using the default reference counting policy.

Change-Id: I7bceb06ddfb31ca5901e5e7d5d93dda494db945f
Reviewed-on: https://gerrit.libreoffice.org/18070
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-30 12:55:17 +00:00
1e8b7cdbbd this farcical staroffice 5.0 related junk can at least be const
Change-Id: I096d98f6e0cb61cacd9cd82a623f832b88ded1e6
2015-08-27 11:59:21 +01:00
a0ab7c31a2 Again add ability to change tint/shade of a color + unit test
Change-Id: I4c06290f09e5bfecd2c1de896e19cb5036a3a0e9
2015-08-27 08:30:49 +09:00
139b32b84c Bin the fairly useless DbgDialog stuff and handle fallout
See (short) discussion on the mailing list, "How was it again, is the
DbgDialog useful?".

Change-Id: Ibde1eb13f16edf94f1f7aebd0befd1b0b171d5c4
2015-08-26 10:33:30 +03:00
2a0f9f0891 simplify some declarations
Change-Id: I348e7f984e5e8b4b915d11de8182da07a6356f8d
2015-08-25 09:58:32 +02:00
258643235c add some comments to Rectangle mutation methods
Change-Id: I7e1d737fc1e7a431afd3cde74c2c974e0cbef9ef
2015-08-25 09:58:31 +02:00
27dec7c2b1 afl-clang-fast apparently miscompiles this
leading to the delete not getting called,
which results in temp files leaking and eventually
filling tmp

I wonder if generic clang suffers from this ?

Change-Id: Iecc266544b3c779026593a16e96bb1a2dfbe8328
2015-08-20 16:10:35 +01:00
885418c0d7 remove dead comment
Change-Id: I244e52ec494546383dcb1981c41f2d388ae7d85a
2015-08-20 13:19:16 +02:00
5109114856 Put Line under tools namespace
Change-Id: I7442848951c0d4579fb2a2a3eef3bfed7135aac4
Reviewed-on: https://gerrit.libreoffice.org/17791
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-17 06:30:01 +00:00
ef46917ff3 Put Polygon from tools under tools:: namespace
Polygon is one of these names that Clash with some system objects
A similar work has been done earlier with PolyPolygon.

Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5
Reviewed-on: https://gerrit.libreoffice.org/17789
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-17 02:07:43 +00:00
403c13487c loplugin:unusedmethods
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 09:39:22 +00:00
f17f89aadc include: inline some use-once typedefs
Change-Id: I064e95c72e5f67178cf2875f457adac241cee529
2015-08-04 08:55:57 +02:00
aedd003086 tools: prefix members of SvStream
Change-Id: Iba845749d645bc1cf9eb6d6c41829717831bc487
2015-07-31 14:45:38 +02:00
a45827b230 loplugin:unusedmethods
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30 06:23:00 +00:00
029fa6477b solar.h: avoid some Wconversion warnings
Change-Id: Id41bd4e759dea72b37db5f329e29ff5c18c75a66
Reviewed-on: https://gerrit.libreoffice.org/17306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-07-29 09:12:35 +00:00
5e6ec5bb14 errcode.hxx: avoid some Wconversion warnings
Change-Id: I48bb49c7eb472fa493fca71736acc358151e87ac
Reviewed-on: https://gerrit.libreoffice.org/17308
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-07-29 08:56:36 +00:00
38ecca9b30 inline a bunch of use-once macros
no point in having a macro unless it's actually going to reduce the
number of lines of code

Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-27 08:18:16 +02:00
efac5fa06e remove some unused defines
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188
Reviewed-on: https://gerrit.libreoffice.org/17332
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-27 06:12:01 +00:00
93774f29ec remove unused URL_PREFIX_PRIV constants
Change-Id: I4d49ebec2867e4c53661c20b277bfdbf4fd222a2
2015-07-24 12:36:53 +02:00
9582380ebc convert ImageAlign to enum class
Change-Id: I22e2e66a1f0b230403ad1d9c1f5b7f34a6ee6ea5
2015-07-24 09:52:08 +02:00
9e28cc8ca7 convert WindowAlign to scoped enum
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
2015-07-24 09:52:08 +02:00
d291fb6f28 loplugin:simplifybool
Change-Id: I33d58658b51798d667999df85318a9c649b2fc02
2015-07-16 14:00:22 +02:00
21834f14c9 tools: replace boost::ptr_vector with std::unordered_map
Change-Id: I530c5f95dda9aa80654e3a2a20a2e236221e7305
2015-07-16 13:42:11 +02:00
ec243f4341 Revert "tools: replace boost::ptr_vector with std::unordered_map"
This reverts commit 218be53fe00aebed43df0b041de609b30f99ce95.
MacOSX breaker
2015-07-15 22:28:42 -05:00
218be53fe0 tools: replace boost::ptr_vector with std::unordered_map
Change-Id: I530c5f95dda9aa80654e3a2a20a2e236221e7305
2015-07-16 00:06:21 +02:00
cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
64fe80db1f Replace GetAppData(SHL_SVDDE) with a static pointer var
Change-Id: I63d35dc3dbfb1185d5795316d2c1d77745d85451
2015-07-07 14:52:35 +02:00
2b429eff07 SHL_SHL2 is unused
Change-Id: I8e76b7e0f58143c883fa94a44d9681c6c3b9ac5a
2015-07-07 14:52:34 +02:00
f420d65b76 vcl: document Rectangle's get vs Get differences
Change-Id: Icf08f96c8d21f98a6f5a5a83b07447755f32257a
2015-07-07 14:08:16 +02:00
e69fd541ca Replace GetAppData(SHL_IDL) with a static pointer var
Change-Id: Ia1e22ff95457a958ef26974091aa2092b32505bd
2015-07-07 07:48:12 +02:00
e294fa9283 Replace GetAppData(SHL_IDL) with an rtl::Static
Change-Id: Ia7a75c4686734aa811006858343666d2edfde8a1
2015-07-07 07:48:12 +02:00
af1be90e52 Replace GetAppData(SHL_SVD) with an rtl::Static
Change-Id: Ie1ccffe5461475a0425891861f825aeea149e876
2015-07-07 07:48:11 +02:00
1fd5509aaa Replace GetAppData(SHL_ERR) with an rtl::Static
Change-Id: I3932afa803ceb6429d4e5cf63af59131307d5c6e
2015-07-07 07:48:11 +02:00
c760932fae loplugin:unusedmethods basebmp
Change-Id: I9e89fea4e94a91edbbe355780c2a12d6e6cb6e4a
Reviewed-on: https://gerrit.libreoffice.org/16728
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06 09:06:47 +00:00
420923ba76 Fix typos
Change-Id: Ie2bbe020fc6e3a4a4f913208c245f395849bb9ee
Reviewed-on: https://gerrit.libreoffice.org/16708
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03 09:32:26 +00:00
d3d4b86919 loplugin:unusedmethods tools
Change-Id: I45f5489233879126d4f9ee3d01db504d950bb597
Reviewed-on: https://gerrit.libreoffice.org/16656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-02 06:37:53 +00:00
c0a79b1dab Remove unnecessary include
Change-Id: I46fffbdbf952b2eb67a469a5960bc94c8ee7d377
2015-06-30 13:36:51 +02:00
329350919e remove custom RTTI from SvDataCopyStream
nothing is using it, except perhaps for XFillExchangeData, which was
using it incorrectly :-(

Change-Id: Ib9246a20bc97ad91d3e3e97fa642217686fc8c46
2015-06-29 10:05:35 +02:00
9ed033917b Fix typos
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce
Reviewed-on: https://gerrit.libreoffice.org/16373
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-21 19:56:13 +00:00
48c2815dd2 tdf#91727 - Unwind non-dispatch of idle handlers.
This clobbers the functionality from commit:

    06d731428ef6cf93c7333e8228bfb6088853b52f

    make idle timers actually activate only when idle

Since now all rendering and re-sizing is done in idle handlers it
does effectively the opposite of what was intended. A better solution
would allow special-casing the processing of just rendering,
re-sizing and window management to spin for eg. progress bar
rendering.

Also add helpful debugging labels to the idle & timeouts.

Also cleanup the Idle vs. Scheduler handling.

Also ensure that starting an Idle triggers a mainloop wakeup.

Also add a unit test.

Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6
2015-06-10 17:27:20 +01:00
8ca53be757 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: Iedee28da32a4333a414e06877f87851345bb4e9b
2015-06-08 16:29:11 +02:00
8d46bc15e9 Fix a wrong bit mask for StreamMode
... introduced at 7f8f277b94704a289fbbd1b836e4e5d66311580d

Change-Id: Ic9e2f6f5e01652744011a7e8a5f69f386efd6b52
Reviewed-on: https://gerrit.libreoffice.org/16015
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-02 05:15:07 +00:00
bfd33a826c callcatcher: update unused code
Change-Id: I735264eb32ebdd165d23a4717f0329f666b8b140
2015-05-25 12:32:53 +01:00
b8c3d5c485 drop now unused WB_REFMODE bit
Change-Id: I873063a8cf52652ca8d3c871170beeb4585de8f1
2015-05-24 15:40:22 +01:00
0d5ff972fb SAL_WARN_UNUSED Link
Change-Id: I646677611e46a7e33e977a5afeea9bf831b28733
2015-05-18 12:00:15 +02:00
6fb6b45c77 Add expand (contract) to Rectangle as it is often used.
Change-Id: I98e2738a1f79a1157c18b6003f70955e071f1654
2015-05-13 08:36:27 +09:00
67e82c48e1 No more need for EMPTYARG in C++11
Change-Id: I8a6abc563fa80a801d1907100d0b1138d260c36e
2015-05-10 11:25:48 +02:00
9bb254fc85 NOINSTANCE is implied now in IMPL_STATIC_LINK...
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10 11:25:47 +02:00
4d2a9bc3a6 Remove newly unused IMPL_STATIC_LINK[_TYPED]
Change-Id: Ic12cced5b90f413ca1cac943874c7e7f9ad57f1a
2015-05-10 11:25:46 +02:00