wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
349,994 Commits 5 Branches 0 Tags
2a7fdf2a7bb7345c49c988dfd1fcdb41cebb8a1e
Commit Graph

3367 Commits

Author SHA1 Message Date
Noel Grandin
1eee88dd6b basic: sal_Bool->bool 
Change-Id: I1c084ca86c0b1308eb2fc1451ba34d2e702c6a7f
 2014-04-07 13:53:50 +02:00
Stephan Bergmann
8f6c55a839 Replace SV_DECL/IMPL_REF macros with SvRef template 
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
 2014-04-07 12:38:27 +02:00
Noel Grandin
af8c8f80aa StarBASIC::ErrorHdl sal_Bool->bool 
Change-Id: I68cc6c6b63174ff16e5fda00f62172e1eaacbf0d
 2014-04-04 13:44:17 +02:00
Noel Grandin
2d1eaee66b SbxObject::Call sal_Bool->bool 
Change-Id: I2e52ddf704679a118fbbc4efebb7cf9fb36f0c34
 2014-04-04 13:44:16 +02:00
Noel Grandin
88ab8181d9 SbxObject::isClass sal_Bool->bool 
Change-Id: I71f7b3603df43924d7374969444b929e1eecca4e
 2014-04-04 13:44:16 +02:00
Caolán McNamara
675194c83d coverity#706238 Uncaught exception 
Change-Id: I10bd34115be12dc752987ddbe5d93862aa072e72
 2014-04-04 09:35:19 +01:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Stephan Bergmann
0015c9807f Remove unused BASIC CaptureAssertions functionality 
...that had originally been introduced to catch DBG_ASSERTs during smoketest,
but since made effectively unused when basing DBG_ASSERT on the sal/log.hxx
functionality, and obsoleted by the ongoing clean-up of using true assert where
appliable.

Change-Id: I2fb4f5d0873d29595b178057f83c1404c0085575
 2014-03-31 11:23:24 +02:00
Michael Stahl
4e3cf9cd8e MSVC helpfully provides warning C4310: cast truncates constant value 
Change-Id: I985216d7bade6cbb3a037b07fe44438543d63ba0
 2014-03-30 23:08:54 +02:00
Michael Stahl
ba46f32c80 deploy some asserts to detect truncated STREAM_SEEK_TO_END 
Since STREAM_SEEK_TO_END is now 64 bits it could happen that some
existing code uses it in some indirect manner and it gets truncated to
32 bits somewhere (on 32 bit platforms); try to detect that with asserts.

Of course the checked value is now a valid stream position, so
perhaps the checks should eventually be removed.

Change-Id: I4248c00d758220bdc3ee94c7aa7a7bd4c86c57f0
 2014-03-30 22:41:48 +02:00
Matúš Kukan
d761d5e219 error: no matching function for call to.. 
Change-Id: I4792f9deb162c5e7bde16e54a55f80a83eb90b70
 2014-03-29 12:08:09 +01:00
Michael Stahl
655a39d8c0 basic: for PutData()/GetData() actually 32bits should be enough 
Change-Id: I3c605a1e5b46d262ff557dac280b15136467b906
 2014-03-29 02:03:07 +01:00
Valentin Kettner
061130bd6d fdo#75280 Started cleaning up of sal_uIntPtr usage. 
Converted wrong usage of sal_uIntPtr to appropriate other types in basic
module.

The bug is not fully fixed with this since many other occurences of sal_uIntPtr remain.

Update due to code review comments:
Fixed forgetting to change some declarations in iosys.cxx.
Cleaned up the one remaining sal_uIntPtr in iosys.cxx
Fixed adding a sal_uInt64 to a Date (uses long now instead) in methods.cxx
Fixed the VarDecFromUI4 call in sbxdec.cxx from sal_uLong to ULONG .

Conflicts:
	basic/source/runtime/iosys.cxx

Change-Id: Ia6460be04967deb68b92eb62d945da8814fae605
 2014-03-28 20:08:46 +01:00
Stephan Bergmann
77fd24afc6 Remove remaining DBG_CTOR etc. remnants from basic 
Change-Id: Ia714029c2e32e28c1bb6f4f59d0c7f357eccc236
 2014-03-28 15:15:26 +01:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Noel Grandin
75ebd3bdf3 basic: sal_Bool->bool 
Change-Id: Icd78d21495f305c8f00280eee76e7262e542317d
 2014-03-27 13:45:08 +02:00
Noel Grandin
f288d7dcbd basic: sal_Bool->bool 
Change-Id: Id4952b6f97f9e8f917fea5651dee91499d109e48
 2014-03-27 13:45:08 +02:00
Noel Grandin
d7c5d9e385 basic: sal_Bool->bool 
Change-Id: Idfe18863b2c6f60da5192d661f66e85a2bac09e5
 2014-03-27 13:45:08 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Stephan Bergmann
5fb78604c1 Split TYPEINFO into plain and TYPEINFO_OVERRIDE 
...where the latter contains SAL_OVERRIDE annotations

Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
 2014-03-26 11:54:55 +01:00
Stephan Bergmann
86088dda6e osl_setDetailedDebugMessageFunc is effectively doing nothing 
...since the osl/diagnose.h macros got rebased onto sal/log.hxx, so remove the
corresponding tools/debug.h functionality.

Change-Id: Ife4b5b1a2608230d0dbfc3fa8852243c89ed292f
 2014-03-25 16:17:09 +01:00
Stephan Bergmann
6854bd6b9e These DbgOutf calls do not seem worth keeping 
Change-Id: I6da5848ee2d1d23f921e56ac2eae09c6f148ebbd
 2014-03-25 16:17:07 +01:00
Stephan Bergmann
db3d23ff9e Adapt to sal/log.hxx 
Change-Id: Ibb4549bcca6dd93ae31ef84fbb34f5054d50fe7b
 2014-03-25 16:17:07 +01:00
Stephan Bergmann
6d24c8cf77 Adapt to sal/log.hxx 
Change-Id: Ie90467573a2e0fb2da227c58ce2e89ab2318eb04
 2014-03-25 16:17:06 +01:00
Takeshi Abe
dd52330db6 Avoid possible resource leaks by boost::scoped_array 
Change-Id: I14e1f7ef217eb5e8e9db9f8962af868ab0a4ab81
 2014-03-25 20:08:26 +09:00
Noel Grandin
96710f8e46 convert OUString::match to OUString::endsWith 
Convert code like:
    rTxt.match( "---", rTxt.getLength()-3 )
to:
   rTxt.endsWith( "---" )

Change-Id: Iada74c5e714f7234f25b326526843a36255d5599
 2014-03-19 08:55:21 +02:00
Noel Grandin
39c7532933 basic: prefer passing OUString and OString by reference 
Change-Id: I8121204cdb37d4e1d8967397f3e45bdab6aaddad
 2014-03-13 08:39:26 +02:00
Stephan Bergmann
90dcd2ac13 basic: simplify deprecated XTypeProvider.getImplementationId 
Change-Id: I7f0d75c5eaa62f012cb2ae19c5107c09cbc6936a
 2014-03-10 17:39:52 +01:00
Stephan Bergmann
25cedf1dc7 Introduce com.sun.star.beans.theIntrospection singleton 
...deprecating com.sun.star.beans.Introspection (single-instance) service.

Change-Id: Ica2e3a3541c7dcb1aab79222c5abf40d6988c882
 2014-03-07 10:33:07 +01:00
Noel Grandin
f6d97d00cd remove unused code in basic/CodeCompleteDataCache 
Specifically:
  CodeCompleteDataCache::GetVars() const
  CodeCompleteDataCache::SetVars(boost::unordered_map const&)
  CodeCompleteDataCache::print() const

Change-Id: I59fb6f50ff47747c3cac959302bf6b7c4f4d79d3
 2014-02-28 08:33:14 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
6a38eace8c Remove visual noise from basic 
Change-Id: I10865b94f67de39e9dbcbe71ede42aa94d81db61
Reviewed-on: https://gerrit.libreoffice.org/8234
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-25 21:09:17 +00:00
Norbert Thiebaud
295bc8703f basic: remove use of sal_uIntptr in favor of more appropriate type 
Change-Id: Ie878f43c7245838519fe7477b039827b079dde63
Reviewed-on: https://gerrit.libreoffice.org/8214
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-02-25 00:26:43 +00:00
Matteo Casalin
83aa6d8180 Remove some temporaries around calls to SvNumberFormatter methods 
Change-Id: Ib03c97a52df120bac1ac9b2b9d2e52431ead1027
 2014-02-24 09:08:35 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx 
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-20 16:22:17 +00:00
Stephan Bergmann
12f1faf7bf svl: sal_Bool -> bool 
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
 2014-02-20 08:17:00 +01:00
Noel Grandin
b2878af322 more SvStream:operator>> conversion 
Convert the template based read_lenPrefixed methods to regular
methods.

Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019
Reviewed-on: https://gerrit.libreoffice.org/7895
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2014-02-12 15:32:11 +00:00
Noel Grandin
15535e32dd convert SvStream::operator>> methods to ReadXXX methods 
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2014-02-12 15:31:40 +00:00
Markus Mohrhard
70b3006002 fix crash when importing unsupported macro content, related fdo#59374 
Change-Id: I960c8174454074fd9ddb27fb17244d782c4cb24c
 2014-02-12 01:01:35 +01:00
Stephan Bergmann
bd20500cf3 Simplify access to theCoreReflection singleton 
Change-Id: I9901991a320b87895230a92095c9c7d3109380a6
 2014-02-07 12:03:03 +01:00
Andras Timar
ac6e8ac7e4 typo fixes in comments 
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
 2014-02-06 23:22:30 +01:00
Julien Nabet
527eb5ae5c Typo: applictaion -> application 
Change-Id: I2d578cb417bb1e814dcf3007f500fe8ff77510f7
 2014-02-06 21:51:36 +01:00
Michael Stahl
6c820a2816 basic: _FIND_STATIC likely not an error in SbiExprNode::GenElement() 
All other _FIND_* are explicitly not errors, and probably CWS npower10
forgot to adapt this assertion.

Change-Id: If721c275eb1bc31d76140898602b41e11c23d82e
Reviewed-on: https://gerrit.libreoffice.org/7863
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
 2014-02-05 10:16:09 +00:00
Herbert Dürr
a5090ccf75 Related: #i123862# use O*String's isEmpty() method... 
to check for emptiness in modules starting with 'b'

Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 87204b0f4062ef8fc8f138ad15f4378da609d4e2)

Conflicts:
	basctl/source/basicide/baside2.cxx
	basctl/source/basicide/bastype2.cxx
	basctl/source/basicide/localizationmgr.cxx
	basctl/source/dlged/dlgedobj.cxx
	basic/source/basmgr/basmgr.cxx
	basic/source/basmgr/vbahelper.cxx
	basic/source/classes/sbunoobj.cxx
	basic/source/comp/sbcomp.cxx
	basic/source/runtime/iosys.cxx
	basic/source/runtime/methods.cxx
	basic/source/runtime/methods1.cxx
	basic/source/runtime/step2.cxx
	basic/source/uno/namecont.cxx
	basic/source/uno/scriptcont.cxx
	binaryurp/source/bridge.cxx
	binaryurp/source/bridgefactory.cxx
	binaryurp/source/reader.cxx
	binaryurp/source/unmarshal.cxx
	bridges/source/cpp_uno/cc50_solaris_intel/except.cxx
	bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx
	bridges/source/cpp_uno/shared/vtablefactory.cxx
	bridges/source/jni_uno/jni_data.cxx

Change-Id: I37bd84e0a1d6426759dba81854faf32c88147fe1
 2014-02-04 12:47:59 +00:00
Thomas Arnhold
326bec33e0 some more continuous corrections 2014-02-03 14:01:40 +01:00
Alexandre Vicenzi
25d089e09d fdo#63154 Removed unused solar.h ref. in basic, cui, forms and writerfilter. 
Change-Id: I09cca73d8d77af259965e74e1b29a88aa5c315ab
Reviewed-on: https://gerrit.libreoffice.org/7731
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-30 10:48:40 +00:00
Stephan Bergmann
f96f38f8f8 bool improvements 
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
 2014-01-28 20:26:30 +01:00
Caolán McNamara
5c734f440a coverity#738565 Uninitialized scalar field 
Change-Id: Ie969773240bd7ecdcf56d7c533010d0aa32872c8
 2014-01-28 11:29:15 +00:00