Commit Graph

452 Commits

Author SHA1 Message Date
a6287e21f1 framework: sal_Bool->bool
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
2014-04-07 13:53:49 +02:00
f4e8d2ad0e Bin empty @seealso, @param, @return and @onerror metacomments
Change-Id: I30a761a21a98419816c4b67258664becd79e2db1
2014-04-06 19:37:48 +03:00
ee3945bd98 Kill superfluous spacing before semicolons
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
2014-04-06 19:37:48 +03:00
951ed199f1 Kill superfluous vertical whitespace
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
2014-04-06 19:37:48 +03:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
6147424302 Access safe members directly
Change-Id: Ie76f2219c5bce609a23a0bc70d6da43f527ce12d
2014-03-20 15:04:14 +01:00
99b6c3d413 Use SolarMutexGuard directly
Change-Id: I8c6a0873e2b0bb371775a2342292a819fe630b51
2014-03-18 09:43:16 +01:00
32a082a7b3 Use SolarMutexGuard directly
Change-Id: Ic133d616d730e332de7354d5de4a5ab21944378f
2014-03-18 09:43:16 +01:00
07b32bc2bf Consolidate framework::{Resetable,}Guard
Change-Id: I97290c2504992f4a92e6aeb71e02a2542dd35faa
2014-03-17 18:00:10 +01:00
0659daef93 Use LockHelper directly
Change-Id: I99a0b6dea0b1de2ed1afe51e2584699819eadf04
2014-03-17 17:35:20 +01:00
ab3acb7ef7 Consolidate framework::{Read,Write}Guard
...now that it is obvious that they both do the same

Change-Id: I6878acca4750ef4204fe32a695b6d9e1c5140115
2014-03-17 16:52:34 +01:00
1997de8690 Remove single, unnecessary use of framework::WriteGuard::downgrade
...and its implementation, and the now-unused E_READLOCK cases.

Change-Id: I2df514f9351a1b63da3063c8db9892e11e9bf83b
2014-03-17 16:52:33 +01:00
538492352b remove com.sun.star.comp.framework.License
its unused and removing it allows us to remove the
associated dialog and resources

Change-Id: If2796ca67428f3ba9b12e92728194967a1ab124a
2014-03-14 11:47:08 +00:00
fcbefea017 Remove visual noise from framework
Conflicts:
	framework/inc/dispatch/oxt_handler.hxx
	framework/inc/services/layoutmanager.hxx
	framework/inc/tabwin/tabwindow.hxx
	framework/source/dispatch/menudispatcher.cxx
	framework/source/helper/dockingareadefaultacceptor.cxx
	framework/source/helper/ocomponentaccess.cxx
	framework/source/helper/ocomponentenumeration.cxx
	framework/source/helper/oframes.cxx
	framework/source/layoutmanager/toolbarlayoutmanager.hxx
	framework/source/recording/dispatchrecorder.cxx
	framework/source/services/desktop.cxx
	framework/source/services/frame.cxx
	framework/source/services/urltransformer.cxx

Change-Id: Ibb04e3f6f0796e7f2be16dcce38542f8b90708d4
Reviewed-on: https://gerrit.libreoffice.org/8265
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 14:41:41 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
a77461db60 remove unused code framework::MenuManager::getContext()
Change-Id: I3b6d8bf6d83033b36a2e72eb5c984f5d9c47b771
2014-02-25 15:16:57 +02:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
a8f9feb9c1 fwk: Constructor feature for single-instance TaskCreatorService.
Change-Id: I9e994ebb4822458039709690aa5dd0a7f75735ac
2014-01-30 10:48:25 +01:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
f74149bc21 Fix some typos for "height"
Change-Id: Ibe1fdd7a63ff09097cfe053279d779592d389539
2013-11-25 23:03:11 +01:00
73342dbb82 remove unnecessary RTL_CONSTASCII_STRINGPARAM
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.

Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-22 08:07:19 +02:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
dfe1a6fbd8 Unwind SFX_REFERER_USER
...and remove remaining unused content of sfx2/source/inc/referers.hxx.

Change-Id: I5c533f63e13da930f6944af0e85d4b061c30e5b0
2013-11-08 17:54:16 +01:00
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
e8ecf30ea6 convert FRAMEWORK module from String to OUString
Change-Id: Iafa6b5f213d37093e7e46065c9264c7bb7fae377
2013-09-17 09:05:49 +02:00
c5ab14cbaf Use SAL_INFO instead of framework's own LOG_EXCEPTION
Change-Id: If1976d235f82267a85598d5d59d8ed332a39c792
2013-09-08 23:51:40 +03:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
9281fc72e7 startcenter: Rename DropTargetListener to OpenFileTargetListener, ...
...move it to svtools, and kill the cut'n'pasted version.

Change-Id: Ifacf110ff08b359bd0f611dff20b3c5142e6bcc8
2013-08-06 19:56:30 +02:00
5efc15f000 reduce use of UniString from ResID ctor
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00
04646443b3 fdo#46037: no more comphelper/configurationhelper.hxx in framework/classes
Thank you Stephan!

Change-Id: I70a7f3dbbbe71c165f823ecc207bb5995a8e1376
2013-07-26 19:13:18 +02:00
5cb2e3104b remove toolkit/unohlp.hxx hack
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913
Reviewed-on: https://gerrit.libreoffice.org/4601
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28 11:49:28 +00:00
aff5c4d76b fdo#46808, Use service constructor
Change-Id: Ia943f806ebce8afebabc76d1f74ad792ded761a9
2013-05-28 08:10:23 +02:00
fe1ac1bf90 fdo#46808, convert XMultiServiceFactory to XComponentContext
Change-Id: I5ed0b12bf37e7d235fc88182c006a6ed07ef2343
2013-05-22 15:20:07 +02:00
4fcda14828 Related: #i121442# Remove unused UNO StatusbarControllers
(cherry picked from commit 06b91eb4cc81dde86875445c5acaa5c57111333b)

Conflicts:
	framework/inc/uielement/logoimagestatusbarcontroller.hxx
	framework/inc/uielement/logotextstatusbarcontroller.hxx
	framework/inc/uielement/simpletextstatusbarcontroller.hxx
	framework/source/classes/resource.src
	framework/source/register/registerservices.cxx
	framework/source/uielement/logoimagestatusbarcontroller.cxx
	framework/source/uielement/logotextstatusbarcontroller.cxx
	framework/source/uielement/simpletextstatusbarcontroller.cxx
	officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu

Change-Id: I799bd0fa29191efce4fe9a09f74247e38d8f8873
2013-05-21 14:01:18 +01:00
60fbefc615 fdo#60724 informations -> information
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-15 04:49:39 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
fa97612d45 framework: cleanup macros
Change-Id: I955210208e148dff6a1ca5ad6f1a91db2496ca7b
2013-04-02 14:21:18 +02:00
5be14df244 ResMgr with LanguageTag
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-29 14:09:01 +01:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
0e6a5bf1d9 framework::RecentFilesMenuController clean-up, add clear item.
Conflicts:

	framework/inc/uielement/recentfilesmenucontroller.hxx
	framework/source/uielement/recentfilesmenucontroller.cxx

Change-Id: Ia8b861b42bd77a90dce3bebdfa6aefd5e5cd91dd
2013-03-26 17:35:23 +00:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
b5d7f92082 fwk: some follow up of rtl cleanup
Change-Id: I434e714b6e5a38795c0baca85b51eef85a4732fd
2013-03-08 04:00:42 +01:00
fd4380759d RTL_CONSTASCII_USTRINGPARAM and ::rtl:: removals
Change-Id: Ief6418425676d6943993513c4d05c8d22e4740cf
Reviewed-on: https://gerrit.libreoffice.org/2470
Tested-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-08 02:45:23 +00:00
26e37ca4c7 doubled includes
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
244c7cdede fdo#46808, convert task::StatusIndicatorFactory to new style
the service already existed, it just needed an IDL file.

Change-Id: I84c8e48e176ec3a38ac48a7abcec7463390523b9
2013-03-04 14:22:33 +02:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
c4cc63badc sal: update log areas
Change-Id: Id7b2c7e871abf19b70f427095371c6a6c0208607
2013-02-23 13:31:09 +01:00