Commit Graph

25 Commits

Author SHA1 Message Date
d816acd0e2 coverity#706548 Uncaught exception
Change-Id: Ie3be6d503b50cfa86be8fff162d01a72c6b47bf7
2014-04-07 10:14:50 +01:00
6d27b176fb Bin copy-pasta comments of low informative value
Change-Id: Ib9ddc516636d2150101c40ee3f249c7511bcb375
2014-04-06 20:24:02 +03:00
e32e7946aa Bin empty @seealso, @param, @return etc metacomments
Change-Id: I9582afceb5daf5993bfca1445370d8a60030c3c5
2014-04-06 20:02:08 +03:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
4d8766a29b coverity#707869 Uninitialized scalar field
Change-Id: Ifd61e6d2af525539f759dbdabc190a7b14fc19fd
2014-04-01 10:38:24 +01:00
65c3e11ea9 framework: sal_Bool->bool
Change-Id: If3276f184c63e85762fe54ce19655c30e00aeb15
2014-03-27 13:45:07 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
d697a05905 Remove unused framework::IMutexGuard::reset
Change-Id: If05ef86284c4ed7bf66a6a6de17a4bf8d49e89e1
2014-03-17 17:25:16 +01:00
00550fbd19 Fold framework::IGuard into framework::IMutexGuard
Change-Id: I14a77fc3fbf225862bc01f677d09d5b5a52bb1aa
2014-03-17 17:25:16 +01:00
8792ec7b21 Remove visual noise from include
Conflicts:
	include/framework/preventduplicateinteraction.hxx
	include/sfx2/sfxbasecontroller.hxx
	include/sfx2/sfxbasemodel.hxx
	include/toolkit/awt/vclxtabpagemodel.hxx
	include/vcl/field.hxx
	include/vcl/settings.hxx

Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 09:51:32 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
94bc29cb71 Typo: I/internaly -> I/internally
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
2014-02-09 10:12:07 +01:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
b3c4cbf70f fdo#65108 inter-module includes <> include/framework
Change-Id: Ie6587c23df03ad81b876075428014094765b5238
2013-11-09 18:48:53 -06:00
1130a359cb fixincludeguards.sh: include - the rest
Change-Id: If1ee11da444a7f96f2d8668b277540da0bb4dbe9
2013-10-23 23:22:31 +02:00
7d491bec40 Everytimes -> Every time
Change-Id: Ib84cee7dbb493387760ce68c25ec442bf0a4a121
2013-09-26 10:37:00 +02:00
ffc782c23c remove dead definitions
Change-Id: I69d2df6cb0a7f994339972a23a913938307e5791
2013-09-19 10:14:15 +02:00
189bb791d2 fdo#66691: Revert fix for i#121577 Allow setting toolbar name in Addons.xcu
...which incompatibly changed Addons.xcs and breaks extensions (and LibreLogo,
which adds to Addons.xcu even though it is not an extension).  See the mail
thread starting at
<http://lists.freedesktop.org/archives/libreoffice/2013-July/054612.html>
"[Libreoffice-commits] core.git: #i121577# Allow setting toolbar name in
Addons.xcu" for details.

This reverts commit 85f072ef33ef47b5e3e0bcd51acb5c4179cde2c2
"Resolves: #i121577# Allow setting toolbar name in Addons.xcu" plus follow-up
af572d9fbb744c9691abe465815d7927a9d11510 "Related: #i121577# Allow setting
toolbar name in Addons.xcu," f13f9b5cc5267a7a5606b1a89db91b6d7aef5f9c "various
.xcus are gone now," and 37d9921797a3ad3be8257fbfee11326549fcd987
"odk/examples/python/toolpanel/CalcWindowState.xcu is still in use," plus those
parts of f97ca6f65182efc6542c53ac5e973b3ff398a5d1 "Resolves: #i116455# Make
toolbar style settings persistent" that apparently belong to the fix for
i#121577 rather than i#116455.

Change-Id: Ib744566f3d8da7d9008d7dad8bec60f1bf32e743
2013-07-24 16:36:55 +02:00
85f072ef33 Resolves: #i121577# Allow setting toolbar name in Addons.xcu
(cherry picked from commit 37894067213a63c51c7a73083d7b0ace5f5c40da)

Conflicts:
	framework/inc/framework/addonsoptions.hxx
	framework/source/fwe/classes/addonsoptions.cxx
	framework/source/layoutmanager/toolbarlayoutmanager.cxx
	officecfg/registry/schema/org/openoffice/Office/Addons.xcs

Change-Id: Icc8ed1bb5ac2cfecd6c03c53c137c503dc78bc66
2013-06-24 11:49:53 +01:00
1768904fd9 Related: #i121442# Read Statusbar merging configuration
(cherry picked from commit b2db8c4c68553100b64af8f51bce2d496b12e882)

Conflicts:
	framework/inc/framework/addonsoptions.hxx
	framework/source/fwe/classes/addonsoptions.cxx

Change-Id: I3cd8f310990098fc61adb8287ef53596f4038fdc
2013-05-21 14:01:17 +01:00
cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
b9337e22ce execute move of global headers
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details

Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-23 22:20:31 +02:00