Commit Graph

960 Commits

Author SHA1 Message Date
d1478f42c7 -Werror,-Wunused-function
Change-Id: Ief9b2179db2e6c05dbf6e076e147a0a8adbccc04
2014-03-03 16:07:35 +01:00
885fd98fa3 convert chart type page to .ui format
Change-Id: I2e95e0dec66b8985abad81b02722e1bf632a15e0
2014-03-03 13:27:10 +00:00
f2cdf8848c Remove visual noise from chart2
Change-Id: Ic8dc71c2815df265e1935e629e0220396a50aaac
Reviewed-on: https://gerrit.libreoffice.org/8239
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-27 00:44:41 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
76b114f849 implicitboolconversion: warn about implicit conversion of call args to bool
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f
"sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it"
earlier when converting occurrences of sal_Bool to bool.

Restricting this check to function call arguments avoids too much noise while
hopefully still catching all the relevant problems.

(This check partially overlaps the pointertobool check, so implicit conversions
from pointers to bool call arguments will now generate two loplugin warnings,
but that's harmless.)

Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-24 17:25:05 +01:00
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
5c3a6d383e callcatcher: update unused code
Change-Id: Ie4df15ab292df51274d983d31ce8e21e0549de81
2014-02-21 09:05:21 +00:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
b0cf499b3e convert chart data dialog to .ui
this one was a complete pig to convert with the
conflicting home-grown existing layout code.

Change-Id: I135bd486d10f7d972e143daae44d6b24a6e8fdb8
2014-02-20 13:50:01 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
1113c243b1 Don't violate the One Definition Rule
There were two different struct types called chart::TimeBasedInfo,
which caused problems at least in statically linked iOS app.

Rename the other struct to chart::DialogModelTimeBasedInfo for now.

Change-Id: Ib95736b1046c5bd9001d7aeba2b8bbd22a18f8c2
2014-02-17 14:48:15 +02:00
829a2f9b1f this dialog is unfinished, but fix it to not crash
Change-Id: Icb6d1d1bb14678eb711100644f3f60725db4b5db
2014-02-17 10:53:37 +00:00
bbe3bec949 Drop unused #include
Change-Id: Id05440ffb8eb9990d2d08f721d6914f3dbc86cab
2014-02-14 18:44:05 +09:00
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
042fec5bf2 forgot the new files
Change-Id: I63bdb340aa06b072541bb8b0ed975457c504c9a2
2014-02-09 14:20:36 +01:00
ec4b0ed8e0 improve dialogs for mapped properties
Change-Id: I87e07a30743de0fc30d0caafd35192b18caf3dae
2014-02-09 14:16:42 +01:00
8cb2877b2d add the time based charting stuff to the ui files
Change-Id: I5ffb382f61e56d1c07dfb945f08fa354aea9d5fc
2014-02-09 14:16:41 +01:00
85cdb06fd5 sal_Bool -> bool
Change-Id: Ifc80202e0865b59931af6e50d3d60f5021f8b52e
2014-02-07 18:43:32 +01:00
16738ab4d8 coverity#1158121 Unchecked dynamic_cast
Change-Id: I961c3da368c1f2bffb4c116c325a82cf7619cf15
2014-02-07 12:24:43 +00:00
b37bce11cf Resolves: rhbz#975421 wrong chart direction in Farsi
Where Farsi (and apparenly Moroccon) are RTL but have LTR
math and charts should reportedly follow the math direction

Change-Id: Ib60eaaaa90fe46ef240030a91169fdff3f736329
2014-02-06 15:11:59 +00:00
d2d5864462 TabControl::DeactivatePage should return bool
Change-Id: I9fb774a235db2b9bc759976d2d3f84363ed944ec
2014-02-06 15:44:03 +01:00
f79bfd0ac5 convert chart type dialog to .ui
Change-Id: I6da39b06629e3913048a48490f45863de24c4f15
2014-02-04 09:21:00 +00:00
498c878ddc coverity#707670 : Uninitialized scalar field
Change-Id: I8815381cc1a9801ff5f5ecfac06ada234d5bc363
2014-01-31 23:54:18 -06:00
9c5593bebf start time based onlz after dialog is closed
everything else seems to result in serious bugs!!

Change-Id: I1afbdb7623f877781c7ef362d87608a1e2aba72e
2014-01-29 08:09:34 +01:00
d70331f9de first step for mapped properties
Only FillColor in bubble charts is supported right now.

Change-Id: If6ad0220c15e06a9a57c554f6243fd9908b2651b
2014-01-29 08:09:33 +01:00
262fccfccd fix the time based rendering
I managed to screw it up already. I really need some sleep.

Change-Id: Ie1f13496cd36a6f48b2b094ac302f293d5fd5383
2014-01-29 08:09:32 +01:00
750b46025c give up with the nice solutions and enjoy the ugly hack
I was always hitting a corner case so it seems that this need some
drastic measures.

Change-Id: I3fdd278b9c3fed178513d653ef24ad8adf20cbd2
2014-01-29 08:09:30 +01:00
46574ef1a2 add time based option to UI
we still need to notify ChartModel but I have no idea how

Change-Id: Iac5e09f2bdbcb1d4bc18d4a9dcc30db3a7ab36af
2014-01-29 08:09:29 +01:00
d5d2e280bd bool improvements
Change-Id: I4fb554a0b703b29cb2dc70fc11111a4f2fa9af8e
2014-01-28 20:26:30 +01:00
8534438397 coverity#1158136 Unchecked dynamic_cast
Change-Id: I8d4e7c497430faacd0d8f1138b9af8b2f11127a0
2014-01-25 20:56:31 +00:00
ebf5e613a5 SfxNoLayoutSingleTabDialog not needed anymore
all single tab dialogs are .ui enabled now.

So now we can remove SfxNoLayoutSingleTabDialog and merge SfxSingleTabDialog
and ~SfxNoLayoutSingleTabDialogBase together

Change-Id: If0acc792d85b7d399572257d7e9b0e12993ba3fe
2014-01-23 16:02:10 +00:00
1f63b4f3d6 Fix build error.
Change-Id: Ide87ccfe71f42d77246b6b3a2e864b5c89d80647
2014-01-17 12:49:19 -05:00
ed1878d27e -Werror,-Wunused-function
Change-Id: Ia6c6d6fe484789722987cea7d8b4b4bfc1c28953
2014-01-17 18:45:17 +01:00
9c4032921c Convert chart data source tab page & dialog to .ui
Conflicts:
	chart2/source/controller/dialogs/dlg_DataSource.cxx
	chart2/source/controller/inc/dlg_DataSource.hxx

Change-Id: Ic3e3adc578156161f16254862e1ca33a8ad9e1f6
Reviewed-on: https://gerrit.libreoffice.org/7255
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-17 16:09:50 +00:00
76702bc75d Bin leftover printf
Change-Id: I5469199841dc56e93ff82fe5c3b722d43e766240
2014-01-11 11:03:49 +02:00
7b2d1ee505 Resolves: fdo#72814 Fix Chart Data Ranges Dialog
revert part of b193123b8e658d2eb25af5debe9de9e1b2386ef8

That "hidden" column conatined data which is important to make the dialog work.
If the hidden data is causing a11y problems then it needs to be reworked in a
different way rather than removed in one place but still being looked for in
another

Change-Id: I2990ac940a52d97da193af2147f2b61281e11020
2014-01-10 20:22:19 +00:00
db666bdf0c convert data range tabdialog to .ui
Change-Id: I70e9064a13a751f6b0dae153522953eaf2ac53a5
2014-01-07 09:43:15 +00:00
44029ade1b convert chart shape paragraph dialog to .ui
Change-Id: I5682ccdaa7d0f877310b937ad12ceeeb0b91c350
2014-01-04 19:37:53 +00:00
204c2a1a02 convert chart shape character dialog to .ui
Change-Id: I03917fdceebdf5bd06c04f5719615092ee166852
2014-01-04 19:22:15 +00:00
1cedea0eef WaE: C4805: '!=' : unsafe mix of type 'sal_Bool' and type 'bool' in operation
Change-Id: If67bcfa3f3faaf7ed48493a0f8281fba70431abf
2014-01-03 15:42:55 +02:00
ce4db6fe77 Convert chart range chooser tab page to .ui
Change-Id: Ibe80ec369b8efcded6cf9ce31f7c7d66e3e61dc0
Reviewed-on: https://gerrit.libreoffice.org/7224
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-29 16:53:05 +00:00
86fcb2eaae WaE: private field 'm_pParentWindow' is not used
Change-Id: Iad6433396844cae5785b6b8ba80f0593c2dea62e
2013-12-28 11:08:45 +02:00
e6a87e17b2 Convert insert error bars dialog to widget UI
Change-Id: Ie2fbcb0bacb968a784698908c8cc62f73a80cf32
Reviewed-on: https://gerrit.libreoffice.org/7219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-28 08:44:59 +00:00
3596e88b65 Convert chart data label dialog to widget UI
Conflicts:
	chart2/AllLangResTarget_chartcontroller.mk

Change-Id: Id9054b3b0c6e7a10a72bc90b05cd7c6bbc5e82a2
Reviewed-on: https://gerrit.libreoffice.org/7205
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-27 21:19:56 +00:00
27eb33d753 remove unnecessary empty dtor, etc.
Change-Id: Ia2a1d1fe81a07d1e37437539d6d651a7c6ce1111
2013-12-27 20:59:01 +00:00
acf3949da9 Convert chart error bars tab page to widget UI
Change-Id: I9f3cb1fb3186e77b5c5ee57ff3e6086022c80bfd
Note: kept old resouce to allow dialog to be called by dlg_InsertErrorBars, util we find a way to have a dialog to call a tab page and access the resources. Once a solution is found, old- resources can be deleted, RangeEdit and RangeSelectionHelper can be nuked too.
Reviewed-on: https://gerrit.libreoffice.org/7198
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-27 20:20:35 +00:00
9143eaff72 Convert chart legend dialog to widget UI
Conflicts:
	chart2/AllLangResTarget_chartcontroller.mk

Change-Id: Ibc265efe5a8bdf3e0e5fb8135fb0487de7e96764
Reviewed-on: https://gerrit.libreoffice.org/7199
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-27 16:52:29 +00:00
1568dc2541 Convert chart polar options tab page to widget UI
Conflicts:
	chart2/AllLangResTarget_chartcontroller.mk

Change-Id: If9730589e44ab40331ea217986e79d78b926d5af
2013-12-27 15:07:26 +00:00