wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
346,944 Commits 5 Branches 0 Tags
2c62596cf264ef10749d8bfdb2bb2ebef2d98fbc
Commit Graph

2236 Commits

Author SHA1 Message Date
Alexander Wilms
bed18b128f Remove visual noise from forms 
Conflicts:
	forms/source/component/DatabaseForm.cxx

Change-Id: I4005fe65e89794bd92191c37221c252a3e964917
Reviewed-on: https://gerrit.libreoffice.org/8262
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 14:54:56 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Julien Nabet
f1a73892b3 Typo: apropriate -> appropriate 
Change-Id: I05e23039dc3ae0b6595c87fe550f4228ad93d5d6
 2014-02-25 22:04:17 +01:00
Stephan Bergmann
76b114f849 implicitboolconversion: warn about implicit conversion of call args to bool 
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f
"sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it"
earlier when converting occurrences of sal_Bool to bool.

Restricting this check to function call arguments avoids too much noise while
hopefully still catching all the relevant problems.

(This check partially overlaps the pointertobool check, so implicit conversions
from pointers to bool call arguments will now generate two loplugin warnings,
but that's harmless.)

Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
 2014-02-24 17:25:05 +01:00
Stephan Bergmann
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState 
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
 2014-02-24 12:27:32 +01:00
Stephan Bergmann
146c7c5c89 toolkit: sal_Bool -> bool 
Change-Id: I5153c4413004d1b50cc503b3e70657bc831a5793
 2014-02-24 11:13:42 +01:00
Stephan Bergmann
b7259532d8 Remove unnecessary bool2any 
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
 2014-02-24 08:08:00 +01:00
Stephan Bergmann
ad73967e99 Remove unnecessary extractInterface 
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
 2014-02-24 08:08:00 +01:00
Caolán McNamara
2a83910e72 coverity#704644 Dereference after null check 
Change-Id: I9b2aad39c54497b5b53a86cf11a754f89c012d0e
 2014-02-23 14:22:43 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Caolán McNamara
841ea0ace7 coverity#441137 Dereference after null check 
Change-Id: I877abe904885f28560cf43ee70001ac97fadbe04
 2014-02-23 03:28:22 +00:00
Caolán McNamara
ca7c3debbd coverity#738652 Uninitialized scalar field 
Change-Id: Ie191910d49ee9f622bc407a768e79671698d2ac3
 2014-02-21 12:40:27 +00:00
Caolán McNamara
466e8bd416 coverity#738654 Uninitialized scalar field 
Change-Id: I92909b606e06f3d86fc3b66aef1ac52e5d706967
 2014-02-21 12:40:27 +00:00
Caolán McNamara
09f93567e9 coverity#738656 Uninitialized scalar field 
Change-Id: I49e3f47e318ae342738dd1de90673e2aee2bb62b
 2014-02-21 12:40:26 +00:00
Stephan Bergmann
e8f8f24c84 vcl: sal_Bool -> bool 
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
 2014-02-21 12:53:51 +01:00
Noel Grandin
b7180bd14f editeng: sal_Bool->bool 
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
 2014-02-21 12:19:24 +02:00
Noel Grandin
7e06ccad8f editeng: sal_Bool->bool 
Change-Id: I36cb765d87ddef1fba3447a3ea90e5285cbcd678
 2014-02-21 12:19:23 +02:00
Takeshi Abe
5f17e5eaad Replace deprecated std::auto_ptr with boost::scoped_ptr 
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
 2014-02-21 14:35:52 +09:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx 
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-20 16:22:17 +00:00
Stephan Bergmann
12f1faf7bf svl: sal_Bool -> bool 
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
 2014-02-20 08:17:00 +01:00
Takeshi Abe
d548b250db Drop unnecessary #include 
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
 2014-02-18 13:24:11 +09:00
Stephan Bergmann
05f742d28b comphelper: sal_Bool -> bool 
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
 2014-02-17 17:55:19 +01:00
Stephan Bergmann
faced6b5f7 ucbhelper: sal_Bool -> bool 
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
 2014-02-17 17:55:18 +01:00
Caolán McNamara
7426c9d869 coverity#737157 Uncaught exception 
Change-Id: I062dbdf7c29489111f7ba6dc37a191d835fa7824
 2014-02-13 14:56:21 +00:00
Caolán McNamara
2d72cfb502 coverity#737151 Uncaught exception 
Change-Id: I133012cf88020e38eb0fc0932979347b996943fe
 2014-02-13 14:56:20 +00:00
Caolán McNamara
beb0a165ec coverity#737149 Uncaught exception 
Change-Id: I34b31a3574e5a21a506c49b4f69f3b8c8fbdcdbd
 2014-02-13 14:56:20 +00:00
Noel Grandin
2882060775 cid#705175 missing break in switch 
Change-Id: I4565f3eab411a706eddc665b5b35f3b940b4a52c
 2014-02-12 08:59:05 +02:00
Noel Grandin
a3395aab4a cid#705174 missing break in switch 
Change-Id: Id3563f949a210ea4af59a96bbbbbb615368b06c2
 2014-02-12 08:59:05 +02:00
Andras Timar
ac6e8ac7e4 typo fixes in comments 
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
 2014-02-06 23:22:30 +01:00
Lionel Elie Mamane
f5c7e77031 fdo#69652 Default(Date|Time) is a UNO struct now 
Changed to UNO struct from integer by
  fdo#67235 adapt form control code to time nanosecond API change

Change-Id: I5817d44438d70a0da534c03afd22d74a311252f5
 2014-02-05 17:28:01 +01:00
Alexandre Vicenzi
f9369d33a4 fdo#54938 Convert to cppu::supportsService 
Change-Id: I512c525029ebd63d261560d27e9f38bbe94f7e10
Reviewed-on: https://gerrit.libreoffice.org/7649
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
 2014-02-03 14:35:46 +00:00
Michael Stahl
45befb3685 "stati" considered both pretentious and incorrect Latin 
As one knows, the Latin plural of the noun status is statūs.

Change-Id: I6b19c57aa2aedcc1337736becc93d8802fe03f2e
 2014-01-30 14:04:29 +01:00
Alexandre Vicenzi
25d089e09d fdo#63154 Removed unused solar.h ref. in basic, cui, forms and writerfilter. 
Change-Id: I09cca73d8d77af259965e74e1b29a88aa5c315ab
Reviewed-on: https://gerrit.libreoffice.org/7731
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-30 10:48:40 +00:00
Matúš Kukan
19e16083c6 Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton. 
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
 2014-01-30 10:48:25 +01:00
Stephan Bergmann
6d993bc5b4 bool improvements 
Change-Id: I78099f87510355a43ba9b01ca9d545d44ce11a50
 2014-01-28 20:26:28 +01:00
Matúš Kukan
ba8413d262 Introduce com.sun.star.frame.theUICommandDescription singleton. 
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
 2014-01-28 18:52:22 +01:00
Caolán McNamara
d31a216b1f coverity#705814 Dereference before null check 
Change-Id: Ib5eb5a7058098f7222b1597e60ddc84786403805
 2014-01-28 14:30:42 +00:00
Stephan Bergmann
e3133ae237 Let C++ inline functions return bool instead of sal_Bool 
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).

Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
 2014-01-23 18:43:53 +01:00
Stephan Bergmann
bbd9668d5f bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=) 
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
 2014-01-22 15:00:54 +01:00
Arnaud Versini
5a73cceee5 FORMS : Remove usage of DBG_CTOR and DBG_DTOR. 
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db
Reviewed-on: https://gerrit.libreoffice.org/7534
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-21 16:26:50 +00:00
Stephan Bergmann
602c87b425 Window::PreNotify should return bool 
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
 2014-01-18 00:37:49 +01:00
Stephan Bergmann
04683f1488 Window::Notify should return bool 
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
 2014-01-17 16:42:29 +01:00
Caolán McNamara
854188e3b1 remove last xub_StrLen in forms 
Change-Id: If6c711cf9c317411c72260b4029521782f8a282c
 2014-01-15 15:36:23 +00:00
Stephan Bergmann
459c8131ac bool improvements 
Change-Id: Iba5bf2d2207f80098cb43ff8ce290eef741d21c9
 2014-01-14 21:28:07 +01:00
Stephan Bergmann
d7a360eb99 Lock SolarMutex in RichtTextEngine::Create 
...as always, the question is where exactly to place the mutex guard, but
without it querying for XServiceInfo of a freshly instantiated
"stardiv.one.form.component.Edit" (i.e., OFormattedFieldWrapper) would lead to
failing

> DbgTestSolarMutex () at include/tools/debug.hxx:295
> OutputDevice::ImplGetGraphics (this=0x2b81dc11e680) at vcl/source/gdi/outdev.cxx:560
> OutputDevice::DrawRect (this=0x2b81dc11e680, rRect=Rectangle = {...}) at vcl/source/gdi/outdev.cxx:1649
> OutputDevice::ImplDrawColorWallpaper (this=0x2b81dc11e680, nX=0, nY=0, nWidth=1, nHeight=1, rWallpaper=...) at vcl/source/gdi/outdev6.cxx:778
> OutputDevice::ImplDrawWallpaper (this=0x2b81dc11e680, nX=0, nY=0, nWidth=1, nHeight=1, rWallpaper=...) at vcl/source/gdi/outdev6.cxx:1083
> OutputDevice::Erase (this=0x2b81dc11e680) at vcl/source/gdi/outdev6.cxx:1144
> VirtualDevice::ImplInitVirDev (this=0x2b81dc11e680, pOutDev=0x28dc0a0, nDX=1, nDY=1, nBitCount=0, pData=0x0) at vcl/source/gdi/virdev.cxx:114
> VirtualDevice::VirtualDevice (this=0x2b81dc11e680, nBitCount=0) at vcl/source/gdi/virdev.cxx:136
> ImpEditEngine::SetRefDevice (this=0x2b81dc045f10, pRef=0x0) at editeng/source/editeng/impedit2.cxx:195
> ImpEditEngine::ImpEditEngine (this=0x2b81dc045f10, pEE=0x2b81dc0c8a00, pItemPool=0x2b81dc0a0960) at editeng/source/editeng/impedit2.cxx:156
> EditEngine::EditEngine (this=0x2b81dc0c8a00, pItemPool=0x2b81dc0a0960) at editeng/source/editeng/editeng.cxx:104
> frm::RichTextEngine::RichTextEngine (this=0x2b81dc0c8a00, _pPool=0x2b81dc0a0960) at forms/source/richtext/richtextengine.cxx:103
> frm::RichTextEngine::Create () at forms/source/richtext/richtextengine.cxx:52
> frm::ORichTextModel::ORichTextModel (this=0x2b81d866ff30, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at forms/source/richtext/richtextmodel.cxx:66
> frm::ORichTextModel::Create (_rxFactory=uno::Reference to (cppuhelper::ServiceManager *) 0x2b813a25a260) at forms/source/richtext/richtextmodel.cxx:243
> cppu::OSingleFactoryHelper::createInstanceEveryTime (this=0x2b819d66a6a0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:171
> cppu::OSingleFactoryHelper::createInstanceWithContext (this=0x2b819d66a6a0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:203
> cppu::OFactoryComponentHelper::createInstanceWithContext (this=0x2b819d66a638, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:432
> non-virtual thunk to cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) () at cppuhelper/source/factory.cxx:433
> cppuhelper::ServiceManager::createInstanceWithContext (this=0x2b813a25a208, aServiceSpecifier="com.sun.star.form.component.RichTextControl", Context=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/servicemanager.cxx:979
> non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) () at cppuhelper/source/servicemanager.cxx:987
> frm::OControlModel::OControlModel (this=0x2b81d8679408, _rxContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, _rUnoControlModelTypeName="com.sun.star.form.component.RichTextControl", rDefault="com.sun.star.form.control.TextField", _bSetDelegator=0 '\000') at forms/source/component/FormComponent.cxx:593
> frm::OBoundControlModel::OBoundControlModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, _rUnoControlModelTypeName="com.sun.star.form.component.RichTextControl", _rDefault="com.sun.star.form.control.TextField", _bCommitable=1 '\001', _bSupportExternalBinding=1 '\001', _bSupportsValidation=1 '\001') at forms/source/component/FormComponent.cxx:1273
> frm::OEditBaseModel::OEditBaseModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, rUnoControlModelName="com.sun.star.form.component.RichTextControl", rDefault="com.sun.star.form.control.TextField", _bSupportExternalBinding=1 '\001', _bSupportsValidation=1 '\001') at forms/source/component/EditBase.cxx:57
> frm::OEditModel::OEditModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at forms/source/component/Edit.cxx:296
> frm::OEditModel_CreateInstance (_rxFactory=uno::Reference to (cppuhelper::ServiceManager *) 0x2b813a25a260) at forms/source/component/Edit.cxx:280
> cppu::OSingleFactoryHelper::createInstanceEveryTime (this=0x2b819d66a5c0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:171
> cppu::OSingleFactoryHelper::createInstanceWithContext (this=0x2b819d66a5c0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:203
> cppu::OFactoryComponentHelper::createInstanceWithContext (this=0x2b819d66a558, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:432
> non-virtual thunk to cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) () at cppuhelper/source/factory.cxx:433
> cppuhelper::ServiceManager::createInstanceWithContext (this=0x2b813a25a208, aServiceSpecifier="com.sun.star.form.component.TextField", Context=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/servicemanager.cxx:979
> non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) () at cppuhelper/source/servicemanager.cxx:987
> frm::OFormattedFieldWrapper::ensureAggregate (this=0x2b81d8879818) at forms/source/component/FormattedFieldWrapper.cxx:342
> frm::OFormattedFieldWrapper::queryAggregation (this=0x2b81d8879818, _rType=invalid uno::Type) at forms/source/component/FormattedFieldWrapper.cxx:164
> cppu::OWeakAggObject::queryInterface (this=0x2b81d8879818, rType=invalid uno::Type) at cppuhelper/source/weak.cxx:281
> frm::OFormattedFieldWrapper::queryInterface (this=0x2b81d8879818, _rType=invalid uno::Type) at forms/source/component/FormattedFieldWrapper.hxx:68
> com::sun:⭐:uno::BaseReference::iquery (pInterface=0x2b81d8879818, rType=invalid uno::Type) at include/com/sun/star/uno/Reference.hxx:43
> com::sun:⭐:uno::Reference<com::sun:⭐:lang::XServiceInfo>::iquery (pInterface=0x2b81d8879818) at include/com/sun/star/uno/Reference.hxx:58
> com::sun:⭐:uno::Reference<com::sun:⭐:lang::XServiceInfo>::Reference (this=0x2b81d8663a98, rRef=...) at include/com/sun/star/uno/Reference.hxx:158

Change-Id: I16ebbb2caf4f0fe943c9e43bddde03b5a2627e35
 2014-01-08 14:09:15 +01:00
Stephan Bergmann
175f650998 This can be private 
Change-Id: Ida54a46580fb3d1ec49ea5daeb55c0235d2bf85a
 2014-01-08 14:06:01 +01:00
Julien Nabet
151887a955 Fix other typos 
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
 2013-12-22 18:51:41 +01:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp 
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
 2013-12-17 17:32:58 +01:00
Stephan Bergmann
a83b2af9ab Clean-up uno/lbnames.h 
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
 2013-12-16 21:43:12 +01:00