bed18b128f
Remove visual noise from forms
...
Conflicts:
forms/source/component/DatabaseForm.cxx
Change-Id: I4005fe65e89794bd92191c37221c252a3e964917
Reviewed-on: https://gerrit.libreoffice.org/8262
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 14:54:56 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
76b114f849
implicitboolconversion: warn about implicit conversion of call args to bool
...
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f
"sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it"
earlier when converting occurrences of sal_Bool to bool.
Restricting this check to function call arguments avoids too much noise while
hopefully still catching all the relevant problems.
(This check partially overlaps the pointertobool check, so implicit conversions
from pointers to bool call arguments will now generate two loplugin warnings,
but that's harmless.)
Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-24 17:25:05 +01:00
33740b7d5a
Replace exisiting TriState, AutoState with more generic TriState
...
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
b7259532d8
Remove unnecessary bool2any
...
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
ad73967e99
Remove unnecessary extractInterface
...
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
841ea0ace7
coverity#441137 Dereference after null check
...
Change-Id: I877abe904885f28560cf43ee70001ac97fadbe04
2014-02-23 03:28:22 +00:00
ca7c3debbd
coverity#738652 Uninitialized scalar field
...
Change-Id: Ie191910d49ee9f622bc407a768e79671698d2ac3
2014-02-21 12:40:27 +00:00
466e8bd416
coverity#738654 Uninitialized scalar field
...
Change-Id: I92909b606e06f3d86fc3b66aef1ac52e5d706967
2014-02-21 12:40:27 +00:00
09f93567e9
coverity#738656 Uninitialized scalar field
...
Change-Id: I49e3f47e318ae342738dd1de90673e2aee2bb62b
2014-02-21 12:40:26 +00:00
5f17e5eaad
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2014-02-21 14:35:52 +09:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
beb0a165ec
coverity#737149 Uncaught exception
...
Change-Id: I34b31a3574e5a21a506c49b4f69f3b8c8fbdcdbd
2014-02-13 14:56:20 +00:00
2882060775
cid#705175 missing break in switch
...
Change-Id: I4565f3eab411a706eddc665b5b35f3b940b4a52c
2014-02-12 08:59:05 +02:00
a3395aab4a
cid#705174 missing break in switch
...
Change-Id: Id3563f949a210ea4af59a96bbbbbb615368b06c2
2014-02-12 08:59:05 +02:00
ac6e8ac7e4
typo fixes in comments
...
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
f5c7e77031
fdo#69652 Default(Date|Time) is a UNO struct now
...
Changed to UNO struct from integer by
fdo#67235 adapt form control code to time nanosecond API change
Change-Id: I5817d44438d70a0da534c03afd22d74a311252f5
2014-02-05 17:28:01 +01:00
f9369d33a4
fdo#54938 Convert to cppu::supportsService
...
Change-Id: I512c525029ebd63d261560d27e9f38bbe94f7e10
Reviewed-on: https://gerrit.libreoffice.org/7649
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Souza <marcos.souza.org@gmail.com >
2014-02-03 14:35:46 +00:00
6d993bc5b4
bool improvements
...
Change-Id: I78099f87510355a43ba9b01ca9d545d44ce11a50
2014-01-28 20:26:28 +01:00
5a73cceee5
FORMS : Remove usage of DBG_CTOR and DBG_DTOR.
...
Valgrind is capable of detecting such bugs. No need for extra macros.
Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db
Reviewed-on: https://gerrit.libreoffice.org/7534
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-21 16:26:50 +00:00
151887a955
Fix other typos
...
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
2013-12-22 18:51:41 +01:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
83e191e25d
Do not use C++-UNO internal static_type functions in client code
...
...use cppu::UnoType instead.
Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
b0926378ac
Clean up includes of comphelper/stl_types.hxx
...
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06 17:56:11 +01:00
07ab0d43b5
Get rid of DECLARE_STL_VECTOR
...
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
2013-12-06 08:04:23 +01:00
4a8175ebeb
Get rid of DECLARE_STL_USTRINGACCESS_MAP
...
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-06 08:04:22 +01:00
6aefcb6a6f
forms: avoid deadlock when setting FontControlModel properties
...
Deadlock found in forms_unoapi on Windows, with
OGridControlModel::setFastPropertyValue_NoBroadcast() calling event
handler that tries to lock SolarMutex.
FontControlModel::setFastPropertyValue_NoBroadcast() and its callers in
3 other classes must not send events via firePropertyChange()
because they are called by OPropertySetHelper::setFastPropertyValues()
with its Mutex locked.
It is possible (though sadly quite convoluted) to delay the sending of
the events by calling setDependentFastPropertyValue() instead.
Change-Id: I0c767cfec01fe1bcaeb1236287b5faf81a2e7441
2013-11-27 17:20:31 +01:00
e521a803c9
FontControlModel::convertFastPropertyValue: fix bad cast of Kerning
...
Casting sal_Bool to integer lets the comparison always fail.
Change-Id: I33cf9e9b6a65f81166870bdfe32e9a97101501df
2013-11-27 17:14:23 +01:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
ab5d1fbfb4
SAL_WARN_UNUSED com::sun: ⭐ :uno::Any
...
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
d366c9b20e
remove unnecessary sal_Unicode casts in various places
...
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
0a9ef5a18e
convert OUString 0==compareToAscii to equalsAscii
...
Convert code like:
0 == aStr.compareToAscii("XXX")
to
aStr.equalsAscii("XXX")
which is both clearer and faster.
Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11 12:58:12 +02:00
373f352ef2
remove unnecessary use of OUString constructor in FORMS module
...
Change-Id: Ibbf477e99ba0c07a9138497496442b0f9296f5c3
2013-11-11 11:21:22 +02:00
bdf7b2715e
fixincludeguards.sh: forms
...
Change-Id: I634371fcd867f20e20384f75d613dab5f69a246c
2013-11-05 09:28:53 +01:00
aeb41c9b9b
remove redundant calls to OUString constructor
...
Change code like this:
aStr = OUString("xxxx");
into this:
aStr = "xxxx";
Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
0e6a2601b3
Convert code that calls OUString::getStr()[] to use the [] operator
...
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
da5449da0c
fdo#54938: More uses of cppu::supportsService
...
Change-Id: Id6bed78d92eba52283a17ab3ca66e751c225e48d
Reviewed-on: https://gerrit.libreoffice.org/6423
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2013-10-25 08:07:04 +00:00
45e366eadb
drop unnecessary tools/string includes
...
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
080e9c2987
bogus WaE: 'bValue' may be used uninitialized in this function
...
Change-Id: Ifde0f9370d093f447edac4899c5bbc7940da5a8c
2013-10-17 16:00:55 +02:00
2337bb6b40
WaE: unknown warning group '-Wmaybe-uninitialized'
...
Seriously, would it be so awful to initialise the value even if strictly
speaking it is unnecessary? Hopefully avoiding that is not an attempt at
manual micro-optmisation? (Or did the initialisation actually cause some
warning?)
Besides, Clang is not just "the MacOS X compiler". I use Clang on Linux,
too. It is great. Our Clang plug-in (which can be easily used only on Linux)
is very useful.
Change-Id: I379afed707d96745ee29979bd79467309adf0147
2013-10-17 08:34:01 +03:00
efd341157c
MacOS X fixup to bogus WaE: 'bValue' may be used uninitialized
...
Change-Id: I1485e7f6b9147d4cec94833c0a2b35e730c397cf
2013-10-17 04:14:47 +02:00
9d5e05edb2
bogus WaE: 'bValue' may be used uninitialized in this function
...
Change-Id: I14983509a41bd6be0d7fed29d7f89fa4a21fe08a
2013-10-17 04:06:42 +02:00
67cfd9f3cf
WaE: 'bValue' may be used uninitialized in this function
...
Change-Id: I6fd6f679dd81707483c6834a4d4b2ca935f7c515
2013-10-16 21:58:44 +03:00
ffff474592
respect reference values in checkboxes
...
Change-Id: Ifd0953f779f530af6b190425794f009a891f0afb
2013-10-16 18:45:22 +02:00
e036d4b706
Spell "indices" correctly
...
Change-Id: I63b1de195bf2f3f8bfd185181f48b1520cdd849f
2013-10-02 21:57:42 +03:00
183f260e7e
convert FORMS modules from String to OUString
...
Change-Id: Iadb3638b03e1a9712553ea5e4c041493d4e1656a
2013-10-01 10:08:41 +02:00
98de5b40c8
Related: fdo#38838 remove UniString::EqualsIgnoreCaseAscii
...
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-25 19:24:23 +02:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
