Commit Graph

2343 Commits

Author SHA1 Message Date
2c62596cf2 fdo#75260: Correctly draw double lines for both Writer and Calc.
Fix all sorts of incorrect double line handling in drawinglayer in order to
draw thick-thin double line types correctly.  Also change handling of border
lines in writer tables. There are still some outstanding issues but it's
much better than how it was before.

Also realized that Word and Excel handle simple thin double lines differently;
Word varies widths of all of the lines and the gap whereas Excel only has one
fixed size for its double line.  For this reason I decided to add a separate
double line type (DOUBLE_THIN) to handle Excel's double line.

Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4
2014-03-04 22:02:37 -05:00
be4f7ea3f6 OLE preview: Limit the GDI metafile size to 100000 actions.
Excel can copy huge metafiles to the clipboard, with over 3 million of
actions, which are 1) unusable, and 2) crash LibreOffice because of their
size.

So let's just limit the size of metafiles to be under 100000 actions,
otherwise use the 'OLE' bitmap.

Change-Id: I6a50471e6fe6ab9417592c011bf78cad6247236b
2014-03-04 23:05:11 +01:00
20a7a705b5 in the old design all lists needed to be the same size, fdo75200
We did not crash in the invalid memory access because the lists were
continuous in memory and we would just pick the next id. However it
crashed when trying to map some of the ids to non existant strings. This
commit also removes the need for the earlier fix for this bug that just
hit the problem behind some checks much later in the call chain.

Change-Id: Ic6658987815c4e84ed2449934c310e30dcd0ed4c
2014-03-04 21:17:40 +01:00
f566585f08 remove the inheritance to std::map in PropertyMap
Change-Id: Iaaf5b7ab47ffa151cd7c8ea376763d02c883f377
2014-03-04 18:43:38 +01:00
4d6560f506 fdo#54938: Convert some places to use cppu::supportsService
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-03-04 07:30:02 -06:00
9ca4fa05eb fdo#74826: File corruption-Issue related to Series idx & order val.
Problem Description:
- If the document contains more than one charts together.
  ex.Bar & Line chart
- In that case, LO writes idx & order val equal to 0,
  instead of 1 for second chart series.
- After roundtrip, the document get corrupted.

Implementation:
- Added varible to take the series count
  in case of multiple chart.

Note:
- Some of the UT's are failing when --enable-dbgutil is enabled.

Change-Id: I40606b4d69026939fa19ae534dd7b2bb36ec97fc
2014-03-03 13:41:08 +01:00
ded5965ce8 editeng: sal_Bool->bool
Change-Id: I51b4ae54c2c440d38879439f74d4fea39d243004
2014-03-03 08:59:38 +02:00
82ce4dd607 editeng: sal_Bool->bool
Change-Id: Icfda5e8e774b9b5a6c3d99b636e4ce772b93139d
2014-03-03 08:59:38 +02:00
ec960fd3de editeng: sal_Bool->bool
Change-Id: I767aa3d25f6d18e8a6e23b4d3f8d038d581ac292
2014-03-03 08:59:38 +02:00
0f60ab5ebf editeng: sal_Bool->bool
Change-Id: I4fc276e320294d57eb667b6db8e5eff078bc28b3
2014-03-03 08:59:37 +02:00
074a2af8bc editeng: sal_Bool->bool
Change-Id: I26b1fe14023737b85bcf23628e4881c8be79f071
2014-03-03 08:59:37 +02:00
241f1a1ab4 editeng: sal_Bool->bool
Change-Id: I0aa375d35c796cfa1929f9c0e735eaaa05561ee4
2014-03-03 08:59:36 +02:00
0786a72308 editeng: sal_Bool->bool
this had to be done in conjunction with changing
  include/svx/unoshtxt.hxx
because there are two virtual methods "bool IsValid" in two different
base classes and some subclasses are overriding both base-class
methods at once.

Change-Id: Ib43fc5000b443057caaa513b4efeaa6fd16e4260
2014-03-03 08:59:36 +02:00
f27e5ecfba remove unused code oox::AttributeConversion::decodeDouble
Change-Id: I057ebcf125e068653570dabb59a8b7f4494e96db
2014-03-03 08:59:03 +02:00
3b1fefac9a remove unused code in sdr::table
sdr::table::Cell::getName()
sdr::table::SdrTableObj::getRowCount() const

Change-Id: Icd4cbe591703aedb1412f8e9b485c773ffe79551
2014-03-03 08:58:59 +02:00
7b2c8b9771 remove unused code in sfx2::sidebar
sfx2::sidebar::ContextList::IsEmpty()
sfx2::sidebar::Deck::PrintWindowTree(std::vector<sfx2::sidebar::Panel*> > const&)
sfx2::sidebar::EnumContext::EvaluateMatch(sfx2::sidebar::EnumContext const&) const
sfx2::sidebar::EnumContext::GetContext() const
sfx2::sidebar::Paint::Set(sfx2::sidebar::Paint const&)
sfx2::sidebar::Panel::PrintWindowTree()
sfx2::sidebar::SidebarDockingWindow::GetChildWindow()

Change-Id: I285567320677a831b2b786f4f73b000eed39987b
2014-03-03 08:58:59 +02:00
e395801fd2 remove unused code svl::SharedStringPool::SharedStringPool()
Change-Id: I497cb89d0b204b9de9c31f86837664d107e55033
2014-03-03 08:58:59 +02:00
39f67c41a7 remove unused code svx::frame::Style::Style constructor
svx::frame::Style::Style(editeng::SvxBorderLine const&,
    double, unsigned short)

Change-Id: I6fd4bf107d325f714fef8417b2c2072a9f2e4066
2014-03-03 08:58:58 +02:00
9705fbc111 Fix editeng missing spellchecking redline on load
Change-Id: I16bfbff85978702c93932d723180a7f9166bd39e
2014-03-02 16:05:18 -06:00
d739b01b9f Adapt rtl_uriConvertRelToAbs to RFC 3986
...which updates RFC 2396, removes the requirement that the base URI's path
starts with a slash, and clarifies how to treat excess "." and ".." segments.

This nicely allows handling of those odd vnd.sun.star.Package URLs as intended
now, so that making <foo> absolute relative to base URL
<vnd.sun.star.Package:Pictures/bar> yields <vnd.sun.star.Package:Pictures/foo>
instead of provoking a MalformedUriException.

Change-Id: Ice84303a57698a2c05d3a45541fe78b67450fa3c
2014-03-01 19:28:15 +01:00
2f527738ea Set the default cell border line width to 0.75 pt in Calc.
0.75 pt provides a better interop with Excel documents.

Change-Id: Ic1d2cbbe4e35dc0793a0e35d3836261d91138f7c
2014-03-01 12:57:35 -05:00
8792ec7b21 Remove visual noise from include
Conflicts:
	include/framework/preventduplicateinteraction.hxx
	include/sfx2/sfxbasecontroller.hxx
	include/sfx2/sfxbasemodel.hxx
	include/toolkit/awt/vclxtabpagemodel.hxx
	include/vcl/field.hxx
	include/vcl/settings.hxx

Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 09:51:32 -06:00
e34870c239 support OOXML strict documents in Calc
Change-Id: I277d76aeec28e173d913ccc1506464afe4d09c6d
2014-03-01 16:23:09 +01:00
6ba394e611 handle OOXML strict namespaces
Change-Id: I198862388426161e3f054a5f128639c59f3c9d24
2014-03-01 16:23:09 +01:00
875129a8d4 callcatcher: update unused code
Change-Id: I429eeb3fc0dd0d0c55612eb482d99ab4ceda2f56
2014-03-01 11:00:41 +00:00
e218663251 fdo#63154 Remove unused solar.h
Removed from dbaccess. editeng, filter,
framwork, formula, lotuswordpro, reportdesing, rsc,
uui

Conflicts:
	framework/source/uielement/menubarwrapper.cxx
	reportdesign/inc/RptDef.hxx
	uui/source/iahndl.hxx

Change-Id: Ia6f1d8679736c3de99bd8060d8a7f76975268273
Reviewed-on: https://gerrit.libreoffice.org/8118
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-28 15:01:05 -06:00
440fbd6090 DOCX import: handle font theme references in group shape text
Change-Id: I1d5b86ad17b2c4a0945f483c94ac6abf410cf1d6
2014-02-28 13:51:35 +01:00
cd3211dcf1 WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'
Change-Id: I0b325abc275b672a96c5513d285c0f5764dfb4fe
2014-02-28 11:33:52 +02:00
381f8a5673 sal_Bool -> bool in mostly vcl module
Conflicts:
	include/vcl/settings.hxx
	svtools/source/table/tablecontrol_impl.cxx
	sw/source/core/frmedt/fecopy.cxx
	vcl/inc/canvasbitmap.hxx
	vcl/inc/headless/svpframe.hxx
	vcl/inc/unx/salframe.h
	vcl/inc/win/salframe.h
	vcl/inc/win/salprn.h
	vcl/inc/win/salvd.h
	vcl/osx/DragSource.cxx
	vcl/osx/DragSource.hxx
	vcl/osx/DropTarget.cxx
	vcl/osx/DropTarget.hxx
	vcl/osx/OSXTransferable.cxx
	vcl/osx/OSXTransferable.hxx
	vcl/osx/clipboard.cxx
	vcl/osx/clipboard.hxx
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/canvasbitmaptest.cxx
	vcl/source/components/fontident.cxx
	vcl/source/control/edit.cxx
	vcl/source/control/spinfld.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/virdev.cxx
	vcl/source/helper/canvasbitmap.cxx
	vcl/source/window/dockwin.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/kde/UnxFilePicker.cxx
	vcl/unx/kde/UnxFilePicker.hxx
	vcl/unx/kde4/KDE4FilePicker.cxx
	vcl/unx/kde4/KDE4FilePicker.hxx
	vcl/unx/kde4/KDESalFrame.hxx

Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 03:19:47 -06:00
9dfa48405f Missing @since tags, and adapt to semantics of posix_memalign
Change-Id: I677d973fbcf118111b5fc93b09143c66b0afb0d9
2014-02-28 09:30:06 +01:00
2dcc6a491a remove unused code BigInt::GetString()
Change-Id: I0e1b1e07103b7aafd0b6691e0fcf0d2c8f612ac8
2014-02-28 08:33:14 +02:00
f6d97d00cd remove unused code in basic/CodeCompleteDataCache
Specifically:
  CodeCompleteDataCache::GetVars() const
  CodeCompleteDataCache::SetVars(boost::unordered_map const&)
  CodeCompleteDataCache::print() const

Change-Id: I59fb6f50ff47747c3cac959302bf6b7c4f4d79d3
2014-02-28 08:33:14 +02:00
64977e5c2b remove unused code FontSizeBox::GetValue(unsigned short, FieldUnit)
Change-Id: I63df5364d69bf60e7a5ee2b5854b41ce27f10894
2014-02-28 08:32:04 +02:00
a4dd8a2106 remove unused code from i18nlangtag/LanguageTag
Specifically:
  LanguageTag::LanguageTag()
  LanguageTag::getRegion() const
  LanguageTag::reset(_rtl_Locale const&)

Change-Id: I8822db6e1df7cd912e9ae82cb9d9f51370d4c583
2014-02-28 08:32:02 +02:00
3543d2d20b fix name of method in vcl/Menu, SetHightlightItem to SetHighlightItem
Change-Id: I89a61aeffeebc69e06da6c1130436fb25528f1c7
2014-02-28 08:32:02 +02:00
b26047be9f remove unused code Menu::GetHighlightItem()
Change-Id: I9b538bacbb98705b0345c3f6dc38fb554ce25bcf
2014-02-28 08:32:02 +02:00
c16e4b1019 remove unused code PanelLayout::dispatch
full signature:
PanelLayout::dispatch(
    rtl::OUString const&,
    css::uno::Sequence<css:🫘:PropertyValue> const&)

Change-Id: Ib16c32d69e62ccf000de05da7c6f25e993a5be90
2014-02-28 08:32:01 +02:00
9ee630ee01 remove unused code RecentDocsView::SetThumbnailSize(long)
Change-Id: I9a898fda8e494693f48d7611c07bd65e86c22bdf
2014-02-28 08:32:00 +02:00
2191ff899b debug only code Resource::TestRes()
Change-Id: I00743ded162ea2772b2fe74df8aecf1fd3a390fa
2014-02-28 08:32:00 +02:00
9aab0e9ac6 Fix typo: s/Alined/Aligned
Change-Id: I248d002d2ed0e61f97a35ea0d329c64832252ad7
2014-02-28 08:27:17 +02:00
03f7a34201 Ensure that numeric array storage is aligned to 256-byte boundary.
OpenCL devices require this else we would get a performance hit.

Change-Id: I6b1db6320fa84f933b6446022a0fd02ba267bf21
2014-02-27 21:19:36 -05:00
6ef6dd0122 Store the length of originally requested array size prior to trimming.
This change adds GetRequestedArrayLength() method to both single and double
vector ref tokens, which returns the length of the requested array size prior
to trimming of the trailing empty cell region.

Change-Id: Iaba96fa2ea4ff3c8bccb0bc86fa4f1525e2f45fb
2014-02-27 21:19:36 -05:00
af63727b9f Resolves: #i15508# Added support for BMP file type
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4)

Conflicts:
	filter/source/msfilter/escherex.cxx
	include/vcl/gfxlink.hxx
	svx/source/xml/xmlgrhlp.cxx
	sw/source/ui/docvw/romenu.cxx
	vcl/source/filter/graphicfilter.cxx

Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
2014-02-27 19:30:40 +00:00
8240641ce7 fdo#63154 remove unused solar.h reference in tools
Change-Id: I1ad2f6323a787b9ea38031a1427d99dd47f5e030
Reviewed-on: https://gerrit.libreoffice.org/8373
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-27 07:35:41 -06:00
1f8c2a2e5c coverity#1187868 Uninitialized pointer field
Change-Id: I6fa813b983d217eb8ce028f9ae13a0cc764e29da
2014-02-27 12:58:52 +00:00
697ec96e61 coverity#1187646 unused mpAbort
Change-Id: I1fc3f0253c2af4779ba59b5b85ea7fc400226177
2014-02-27 12:58:50 +00:00
0aee68c3fc coverity#1187863 unused mnExtra2
Change-Id: Ic6a55a3640d782ba95a5ba4681f447ee28ae163e
2014-02-27 12:58:48 +00:00
f61b6894ef GetContextMenuDown is always true
Change-Id: Ib2ce1dd91cc7bfaf38feca7b056874a2508869e6
2014-02-27 12:57:24 +00:00
cb40b7d2f9 callcatcher: update unused code
Change-Id: I560471a3c2ac9d8ccf759fca1d8c30ae00d73484
2014-02-27 12:57:24 +00:00
b46f93a3c5 editeng: sal_Bool->bool
Change-Id: Ic59e48341f69b8c6e6fe77b05eeebac56a2c53e7
2014-02-27 12:30:30 +02:00