Commit Graph

295 Commits

Author SHA1 Message Date
b8239ac2f9 typo: noone -> no one 2014-04-14 12:32:54 +02:00
1808330a85 Revert ""Fix" for some SmartArt rendering artefacts on iOS"
Nah, the "fix" is largely accidental. Must. Try. Harder.

This reverts commit c03986e084e8806f66f7490f2aeeb33db5748e4b.
2014-04-11 19:03:31 +03:00
c03986e084 "Fix" for some SmartArt rendering artefacts on iOS
Exactly why this change works (to the extent that it does) is unclear
to me. Whether it could possibly be used across all platforms and not
for iOS is also unclear.

Change-Id: I6dcf5982d51e5715b657dbf263a88776bbf55f4d
2014-04-11 13:20:18 +03:00
b78caf9645 Add a couple of SAL_INFOs using drawinglayer::primitive2d::idToString()
Change-Id: I3fce5ca1af15714b8b20b1b273ccf41a49cb98ff
2014-04-11 13:20:17 +03:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
b89325f7c8 This IOS ifdef has no visible effect either as far as I can see
Change-Id: Ib800abd569cc713065b874f9ebbbd55b4dad986f
2014-04-07 12:35:42 +03:00
fecd4c53ff Clear the VirtualDevice we create for an impBufferDevice on iOS
Helps rendering of complex SmartArt with shapes a lot, especially such
that include shadows. Exact mechanism unknown. Possibly on other
platforms virtual devices get implicitly "cleared" when created? Sigh,
fun.

SmartArt is still not rendered fully like on desktop (OS X), though.

Change-Id: I1bf92e85b5659ab7f9f4d843b77619de3af36d10
2014-04-01 17:07:17 +03:00
ae00e71afd Bin rest of DBG_WARNING[123]
Change-Id: Iaaf36d012e353f73f083c9c0ebbbb6d0953b16c8
2014-03-28 16:52:36 +02:00
6e61ecd096 Merge back branch alg_writerframes to trunk
(cherry picked from commit b635b4fa4e42053d30ab639643d2236a20243f62)

Conflicts:
	comphelper/inc/comphelper/TypeGeneration.hxx
	comphelper/source/property/TypeGeneration.cxx
	cui/source/factory/dlgfact.hxx
	cui/source/inc/cuitabarea.hxx
	cui/source/tabpages/tabarea.cxx
	cui/source/tabpages/tabarea.hrc
	cui/source/tabpages/tabarea.src
	cui/source/tabpages/tparea.cxx
	drawinglayer/source/primitive2d/polypolygonprimitive2d.cxx
	drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
	drawinglayer/source/texture/texture.cxx
	editeng/inc/editeng/unotext.hxx
	editeng/source/items/frmitems.cxx
	include/drawinglayer/texture/texture.hxx
	include/editeng/brushitem.hxx
	include/svx/sdr/primitive2d/sdrdecompositiontools.hxx
	include/svx/svxids.hrc
	include/xmloff/xmltypes.hxx
	reportdesign/source/ui/misc/UITools.cxx
	sc/source/ui/drawfunc/drawsh.cxx
	sfx2/source/dialog/tabdlg.cxx
	svl/source/undo/undo.cxx
	svx/inc/svx/unoshprp.hxx
	sw/Library_sw.mk
	sw/inc/doc.hxx
	sw/inc/format.hxx
	sw/inc/frmfmt.hxx
	sw/inc/swatrset.hxx
	sw/inc/unomap.hxx
	sw/inc/unoprnms.hxx
	sw/source/core/access/accpara.cxx
	sw/source/core/attr/format.cxx
	sw/source/core/attr/swatrset.cxx
	sw/source/core/doc/docdraw.cxx
	sw/source/core/doc/docfly.cxx
	sw/source/core/doc/notxtfrm.cxx
	sw/source/core/inc/frame.hxx
	sw/source/core/inc/frmtool.hxx
	sw/source/core/layout/atrfrm.cxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/text/inftxt.cxx
	sw/source/core/text/porfld.cxx
	sw/source/core/text/txtfly.cxx
	sw/source/core/txtnode/fntcache.cxx
	sw/source/core/uibase/app/docst.cxx
	sw/source/core/uibase/app/docstyle.cxx
	sw/source/core/uibase/shells/drawdlg.cxx
	sw/source/core/uibase/shells/frmsh.cxx
	sw/source/core/unocore/unoframe.cxx
	sw/source/core/unocore/unomap.cxx
	sw/source/core/unocore/unoprnms.cxx
	sw/source/core/unocore/unostyle.cxx
	sw/source/ui/fmtui/tmpdlg.cxx
	sw/source/ui/fmtui/tmpdlg.src
	sw/source/ui/frmdlg/frmdlg.cxx
	sw/source/ui/frmdlg/frmpage.src
	sw/source/ui/inc/frmsh.hxx
	xmloff/source/text/txtprhdl.cxx
	xmloff/source/text/txtprmap.cxx

Change-Id: Id3ffaa83bb5594d287f1ac8f2c1c9cf55c70946d
2014-03-28 14:31:08 +01:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
092eecb7d7 remove whitespace
Change-Id: I81a24a7affa7dffcc3dac65248444679c3c49925
2014-03-20 01:10:19 +01:00
402fffa1b4 Add dash-dot and dash-dot-dot line styles.
We need these for Excel interop.

Change-Id: I91450c1d205f28636edfb4392aa6ae5091b1d7b7
2014-03-19 00:28:16 -04:00
374efa7253 Skeleton of drawinglayer object called OpenGLObject
- Shape name: com.sun.star.drawing.OpenGLObject
- Drawinglayer object: SdrOpenGLObject
- Uno object: SvxOpenGLObject
- View contact: ViewContactOfOpenGL
- Primitive: OpenGLPrimitive2D

Change-Id: I7fc0829d58cb4a8432d0e3007c90223707e5dd84
2014-03-17 23:48:28 +01:00
ff6f3164df Simplify DrawWave
This patch simplifies the DrawWave logic. Callers of that code would try to
figure out what size wave to draw and pass down a style integer to
DrawWaveLine, but DrawWaveLine already has logic which trims the height of the
wave so it doesn't need the hint.

This doesn't change the UNO API
(::com::sun::awt::FontUnderline::SMALLWAVE), but it does get rid of
internal usages and maps those small waves to normal.

Note that changing the zoom in Calc right now causes spelling underlines to
disappear. That bug is not related to these changes.

Conflicts:
	editeng/source/editeng/impedit3.cxx

Change-Id: I3caa2a74a0f5228b924d4e1b0a77f96eaef5fa00
Reviewed-on: https://gerrit.libreoffice.org/8168
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-03-05 09:01:11 -06:00
2c62596cf2 fdo#75260: Correctly draw double lines for both Writer and Calc.
Fix all sorts of incorrect double line handling in drawinglayer in order to
draw thick-thin double line types correctly.  Also change handling of border
lines in writer tables. There are still some outstanding issues but it's
much better than how it was before.

Also realized that Word and Excel handle simple thin double lines differently;
Word varies widths of all of the lines and the gap whereas Excel only has one
fixed size for its double line.  For this reason I decided to add a separate
double line type (DOUBLE_THIN) to handle Excel's double line.

Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4
2014-03-04 22:02:37 -05:00
d0d1534b6b Remove visual noise from drawinglayer
Change-Id: Ida745b9d994d09081ad3d18cdf2494a97438dc56
Reviewed-on: https://gerrit.libreoffice.org/8253
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 07:10:49 -06:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
b540f91728 fix crash on ios 2014-02-14 16:27:57 -08:00
d17c9ee705 fdo#73886: Let's keep the "left" border outer and "right" inner.
This reduces the complexity a bit.

Change-Id: Ieefb57be86e5b66f319920fa61c88d0027c38164
2014-01-22 11:40:20 -05:00
d19de47c2d fdo#73886: Check the right width in case the left width is zero.
Change-Id: I6a0b1dd7382f1d3c7266ba56dbfdc557737380c2
2014-01-22 09:03:08 -05:00
15974abe63 fdo#73487: Center thick border lines around cell grid.
This reduces the amount of gap at line joins. Plus it generally looks better
this way.

Change-Id: Ifd21cd0bc1f61f8a875b1bad9cfb33564c18b9ae
2014-01-20 18:39:54 -05:00
4b2b4133c2 Handle double lines for screen rendering.
Double lines are always drawn as 2 parallel hair lines that are 1 pixel
apart, at any zoom level.

Change-Id: I2796477d0ea45c9880aa8057bd1a10104df96673
2014-01-20 14:37:04 -05:00
01104522ef Ensure that the pixel line is at least 1 pixel wide.
Without this, some dashed lines may not get drawn at all at some zoom levels.

Change-Id: I273c1548325d14f56618df8ca4166aac58a3ff3f
2014-01-20 14:37:04 -05:00
41bee5b831 Do the same when the pixel thickness is zero.
Change-Id: Icfbb295abb19cf58477f4f14f4a7294a540151c2
2014-01-20 14:37:03 -05:00
30f97564f8 Substitute dashed line with a solid line at lower zoom levels.
Change-Id: I0437409b6a5d6163fadf777df5c028950727e786
2014-01-20 14:37:03 -05:00
ae22838d2f Better on-screen drawing of vertical dashed lines.
Change-Id: I53d5f8b0278d1228cd941221a07cd360943c5ce6
2014-01-20 14:37:03 -05:00
b3b57c7a3a Same solid line treatment for vertical lines during on-screen drawing.
Change-Id: Idb352dc2afeb2ee7b48620c972c2a186209228ea
2014-01-20 14:37:02 -05:00
ec1a3157c1 Better pixelization of dashed lines for screen rendering.
Now the dashed lines are evenly placed on screen.  For now, horizontal lines
only.  I'll work on vertical lines later.

Change-Id: I474e9c8214e5f079ea2cfca12b35381d8fcf2ae1
2014-01-20 14:37:02 -05:00
6a3fb868b2 Draw horizontal solid border lines directly in the pixel processor.
This makes slightly skinnier solid lines which look better on screen.

Change-Id: Ia7764be4a53d1dd6bb60ecb3ba5c8966403e4e6c
2014-01-20 14:37:01 -05:00
7b708d3006 Always disable anti-aliasing when drawing table borders.
Change-Id: Idede8220ac36c5bd4a88ceda33a99333f7b9fe90
2014-01-17 11:33:13 -05:00
2c702a31f0 Fixed comment.
Change-Id: I48d8ed8e218508f4f2d8f377fa9052ba02e61f37
2014-01-17 11:33:11 -05:00
c8e9038b13 fdo#72530: drawinglayer: fix PDF export of lossless picture
Don't pass empty Rectangle to PDFExtOutDevData::EndGroup(), it will
result in early return from PDFWriterImpl::drawJPGBitmap() and no
picture in the PDF.  Passing in the same Rectangle for the 3rd and 4th
parameter will avoid cropping in PDFExtOutDevData.

(regression from 677df250becd5cde71c6310f647e78ac3763347e)

Change-Id: Icf110fe3e635319419fcacc7bc684c792a34d6ad
2014-01-17 15:19:32 +01:00
a5351434fb fix rendering issues in iOS with aqua 2014-01-16 12:55:57 -08:00
c648d08720 convert SvStream::operator<< overloads to more explicit methods
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.

Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
deecab601a longparas: xub_StrLen->sal_Int32
Change-Id: I171caa791e1d2a0baa4444a460a7f20ad5428571
2014-01-13 10:04:18 +00:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
5112f6a6c6 remove RTL_CONSTASCII_STRINGPARAM in OString constructor
Convert code like:
    OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX"));
to:
    OString aKeyName("NDX");
which compiles down to the same code

Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
2013-11-20 13:56:07 +02:00
f120005ea4 Resolves: #i123500# redefined ColorModifiers and ColorModifierStack...
redefined GraphicAttr to be expressed as primitives if needed, enhanced render
and export quality if graphic is modified using graphic attributes

(cherry picked from commit 1e79e8da3f8042f7d7bd94b2c9f03cff7545b05c)

Conflicts:
	basegfx/inc/basegfx/color/bcolor.hxx
	basegfx/inc/basegfx/color/bcolormodifier.hxx
	basegfx/source/color/bcolormodifier.cxx
	drawinglayer/inc/drawinglayer/primitive2d/graphicprimitivehelper2d.hxx
	drawinglayer/inc/drawinglayer/primitive2d/modifiedcolorprimitive2d.hxx
	drawinglayer/inc/drawinglayer/primitive3d/modifiedcolorprimitive3d.hxx
	drawinglayer/source/primitive2d/graphicprimitive2d.cxx
	drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
	drawinglayer/source/primitive2d/modifiedcolorprimitive2d.cxx
	drawinglayer/source/primitive3d/modifiedcolorprimitive3d.cxx

Change-Id: Ief2172efc9cc1b9838de48ec7f536c05573c7dc3
2013-11-06 11:46:04 +00:00
36f21914b3 Resolves: i123564 corrected some aspects when working with bitmaps...
with low color depth or small size

(cherry picked from commit ba54ce4fc788605fc96235f432b455311faee406)

Conflicts:
	cui/source/tabpages/tpbitmap.cxx

Change-Id: I10677414ab7d1904dbb29cd395a0c0334e0faa03
2013-11-05 12:37:15 +00:00
3656a57e88 add mode lines to new files (and idls) since last run
Change-Id: Id1e74f18c90e69d1a781c8f02e30dc3c005ed4fd
2013-09-22 12:21:34 +01:00
677df250be Resolves: #i123295# corrected object and clip rect...
in PDFExtOutDevData::EndGroup call in VclMetafileProcessor2D

(cherry picked from commit b756639c139f043a613df6ca16c18f426fca1f29)

Change-Id: I75faf2c8d925ec210cd74d8c29b90f5f9bf61ec8
2013-09-20 20:21:13 +01:00
1591130dc2 convert DRAWINGLAYER module from String to OUString
Change-Id: I0856974cb9fe33418e3be0a5b977100be3bdce00
2013-09-17 09:05:46 +02:00
160a4dd9a3 deleted code that was commented out
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I7a67c3768c0d7e36784ee88fc46680037acb244d
2013-08-31 22:41:11 +02:00
bf42b6f9f5 fdo#62475 - remove visual noise
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-31 22:41:10 +02:00
03e73d57f1 Resolves: #i122923# optimize place to add alpha to bitmaps which need rotation
(cherry picked from commit 2178fea0941c4abb624ecddf2453f670ba68878f)

Change-Id: Ib83d10bcd2d0950fbb8afe8894caa9c0b60e6a5d
2013-08-28 15:37:07 +01:00
5527d5c4e0 convert drawinglayer module from String to OUString
Change-Id: I115dfd5ca7d343b220b2a3e8aa0565f9e4689042
2013-08-22 10:49:33 +02:00
1c7af455ab Re-work 8bit characters in source code, or remove them.
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-08-20 19:30:59 +00:00
ff14c3b595 Resolves: #i122836# fix rotated images looking corrupted on MacOSX
The solution is to intialize the images rotation mask to be opaque,
an approach that also the fix for bug #i122758#.

(cherry picked from commit 78f54616efdcfb1c8cbd1a75d3cf9faf7b5e1b8a)

Change-Id: I417aab21ded9619ae4023edf169136c7115d4a07
2013-07-25 16:08:55 +01:00
7f5faa7f64 Resolves: #i122758# Initialize Mask with non-transparent
(cherry picked from commit db4affff17f202e69447fd22c246843a6cda3e52)

Change-Id: I4851c544b23d2857a0f13cff3ede987ebb813cef
2013-07-16 20:37:10 +01:00
420aa16af0 fdo#66745: drawinglayer: properly restore anti-aliasing mode
VclPixelProcessor2D: the constructor changes the anti-aliasing mode of
the given output device, and the destructor restores a hard-coded mode
instead of what was there before.

Due to this commit 5913506b2193e93ca2767ab7365ab2e76ed7848f turned off
anti-aliasing for FontWork objects simply by creating a
temporary VclPixelProcessor2D.

Change-Id: I7f7fcbf86b0dd425f599cd8e62fce3c69a2744bb
2013-07-12 19:23:06 +02:00