fbf5599c07
Avoid possible memory leaks in case of exceptions
...
Change-Id: Id71cb49d8aa241a17efd4cbe217a48f2d7c34e84
2014-04-14 21:47:43 +09:00
1d057cca8c
Clean up function declarations and some unused functions
...
Change-Id: I47bdc668ecf703d85f4d50c71f1347fb9e8e89d8
2014-04-14 12:46:57 +02:00
0e970f3ba2
typo: occuring -> occurring
2014-04-14 12:33:14 +02:00
228f921bea
typo: obsolet -> obsolete
2014-04-14 12:33:03 +02:00
e4181d9a0a
typo: ULR -> URL
2014-04-14 12:32:30 +02:00
e98e738a82
replace some SvStream seeking with calls to remainingSize()
...
Change-Id: I2905e98425b9991d6138ab0adc15083d313ca445
2014-04-11 23:08:11 +02:00
31911865e5
DownLoad -> Download.
...
Change-Id: Ia1729f570cc80a0375532da6478de9d58518556e
2014-04-10 15:07:53 +02:00
6ac0e1399a
Remove silly PUT_SEMICOLON_AT_THE_END
...
...and rather live with macro calls not terminated by semicolons until those
macros are gone for good anyway. Completely remove unused
DECLARE_UNO3_XCOMPONENT_DEFAULTS.
Change-Id: I0d4eb5a91736004b0da2b09fce860e57f6d1ddbd
2014-04-07 17:27:39 +02:00
7938279a0d
/include/connectivity/dbtools.hxx: sal_Bool->bool
...
Change-Id: Ie1e1952e3d39d53756583482826dfc3b65b5f9e0
2014-04-04 13:44:18 +02:00
627b0c682a
coverity#707862 Uninitialized scalar field
...
Change-Id: I0d94414f4645d3f5da6242bbfefcee449572d2c0
2014-04-04 12:14:21 +01:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
3194d22a24
connectivity: sal_Bool->bool and fix method name
...
Convert method name
getBoleanComparisonPredicate
to
getBooleanComparisonPredicate
Change-Id: I00c726b1fecd8352dc49f2af98c3ae3c799ef424
2014-04-01 07:38:08 +02:00
cc3a302fcb
typo: unfortunally -> unfortunately
2014-03-29 19:16:20 +01:00
1258b576ae
tools: support 64-bit file positions in SvStream
...
Bump stream positions to 64 bits on:
SvLockBytes::SetSize()
SvStream::SeekPos()
SvStream::SetSize()
SvStream::SetStreamSize()
SvStream::Seek()
SvStream::SeekRel()
SvStream::Tell()
SvStream::remainingSize()
SvStream::nActPos
SvStream::nBufFilePos
Change-Id: I0521fd60d31d1a33e5634cbf51dd42edc46ad919
TODO: adapt callers of Seek()/SeekRel()/Tell()/remainingSize()
2014-03-29 02:03:07 +01:00
19bbfc0b39
tools: allow 64-bit positions on SvLockBytes
...
Bump stream positions to 64 bits on:
SvLockBytes::ReadAt()
SvLockBytes::WriteAt()
SvAsyncLockBytes::m_nSize
SvOpenLockBytes::Seek()
SvOpenLockBytes::Tell()
SvOutputStreamOpenLockBytes::m_nPosition
OInputStreamHelper::m_nActPos
Change-Id: Ica3b674e0ab23a756260a51475e97a5396ecdddb
2014-03-29 02:03:07 +01:00
1f90d06bbb
Remove remaining DBG_CTOR etc. remnants from forms
...
Change-Id: I1616d7e77071caa78ffd8c7d7857f50f3afa1bb7
2014-03-28 15:32:45 +01:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
86a32589e9
Find places where OUString and OString are passed by value.
...
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
22684273d5
forward*PropertyValue functions need not be SAL_CALL
...
...and _bSuccess parameter is unused
Change-Id: Iee5e1d5c2d4272f342b2867bfe76f8c87dcd69d4
2014-03-13 14:00:03 +01:00
2598a15ed2
forms: simplify deprecated XTypeProvider.getImplementationId
...
...and remove thus unused unotools/idhelper.hxx
Change-Id: I63affbcb0494ef91bc010b9dd5512d4cc718d7a2
2014-03-10 17:39:55 +01:00
191a50828c
simplify
...
Change-Id: Icd2dff124ca331935412e2653c57943b92deeea4
2014-03-05 17:57:11 +01:00
bed18b128f
Remove visual noise from forms
...
Conflicts:
forms/source/component/DatabaseForm.cxx
Change-Id: I4005fe65e89794bd92191c37221c252a3e964917
Reviewed-on: https://gerrit.libreoffice.org/8262
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 14:54:56 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
76b114f849
implicitboolconversion: warn about implicit conversion of call args to bool
...
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f
"sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it"
earlier when converting occurrences of sal_Bool to bool.
Restricting this check to function call arguments avoids too much noise while
hopefully still catching all the relevant problems.
(This check partially overlaps the pointertobool check, so implicit conversions
from pointers to bool call arguments will now generate two loplugin warnings,
but that's harmless.)
Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-24 17:25:05 +01:00
33740b7d5a
Replace exisiting TriState, AutoState with more generic TriState
...
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
b7259532d8
Remove unnecessary bool2any
...
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
ad73967e99
Remove unnecessary extractInterface
...
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
841ea0ace7
coverity#441137 Dereference after null check
...
Change-Id: I877abe904885f28560cf43ee70001ac97fadbe04
2014-02-23 03:28:22 +00:00
ca7c3debbd
coverity#738652 Uninitialized scalar field
...
Change-Id: Ie191910d49ee9f622bc407a768e79671698d2ac3
2014-02-21 12:40:27 +00:00
466e8bd416
coverity#738654 Uninitialized scalar field
...
Change-Id: I92909b606e06f3d86fc3b66aef1ac52e5d706967
2014-02-21 12:40:27 +00:00
09f93567e9
coverity#738656 Uninitialized scalar field
...
Change-Id: I49e3f47e318ae342738dd1de90673e2aee2bb62b
2014-02-21 12:40:26 +00:00
5f17e5eaad
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2014-02-21 14:35:52 +09:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
beb0a165ec
coverity#737149 Uncaught exception
...
Change-Id: I34b31a3574e5a21a506c49b4f69f3b8c8fbdcdbd
2014-02-13 14:56:20 +00:00
2882060775
cid#705175 missing break in switch
...
Change-Id: I4565f3eab411a706eddc665b5b35f3b940b4a52c
2014-02-12 08:59:05 +02:00
a3395aab4a
cid#705174 missing break in switch
...
Change-Id: Id3563f949a210ea4af59a96bbbbbb615368b06c2
2014-02-12 08:59:05 +02:00
ac6e8ac7e4
typo fixes in comments
...
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
f5c7e77031
fdo#69652 Default(Date|Time) is a UNO struct now
...
Changed to UNO struct from integer by
fdo#67235 adapt form control code to time nanosecond API change
Change-Id: I5817d44438d70a0da534c03afd22d74a311252f5
2014-02-05 17:28:01 +01:00
f9369d33a4
fdo#54938 Convert to cppu::supportsService
...
Change-Id: I512c525029ebd63d261560d27e9f38bbe94f7e10
Reviewed-on: https://gerrit.libreoffice.org/7649
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Souza <marcos.souza.org@gmail.com >
2014-02-03 14:35:46 +00:00
6d993bc5b4
bool improvements
...
Change-Id: I78099f87510355a43ba9b01ca9d545d44ce11a50
2014-01-28 20:26:28 +01:00
5a73cceee5
FORMS : Remove usage of DBG_CTOR and DBG_DTOR.
...
Valgrind is capable of detecting such bugs. No need for extra macros.
Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db
Reviewed-on: https://gerrit.libreoffice.org/7534
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-21 16:26:50 +00:00
151887a955
Fix other typos
...
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
2013-12-22 18:51:41 +01:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
83e191e25d
Do not use C++-UNO internal static_type functions in client code
...
...use cppu::UnoType instead.
Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
b0926378ac
Clean up includes of comphelper/stl_types.hxx
...
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06 17:56:11 +01:00
07ab0d43b5
Get rid of DECLARE_STL_VECTOR
...
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
2013-12-06 08:04:23 +01:00
4a8175ebeb
Get rid of DECLARE_STL_USTRINGACCESS_MAP
...
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-06 08:04:22 +01:00
