1d057cca8c
Clean up function declarations and some unused functions
...
Change-Id: I47bdc668ecf703d85f4d50c71f1347fb9e8e89d8
2014-04-14 12:46:57 +02:00
a7b6623b1f
coverity#707864 Uninitialized scalar field
...
Change-Id: Ieb42d64ead25d9e06175a7664d8659e0907d28f1
2014-04-04 12:14:21 +01:00
c03c9da8c2
fdo#43157 : clean up OSL_POSTCOND
...
Conflicts:
include/sal/log-areas.dox
Change-Id: I770b8b9fb82f873ccb88dc26ac05206f703ddf33
Reviewed-on: https://gerrit.libreoffice.org/8805
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-03 11:23:49 +00:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
2598a15ed2
forms: simplify deprecated XTypeProvider.getImplementationId
...
...and remove thus unused unotools/idhelper.hxx
Change-Id: I63affbcb0494ef91bc010b9dd5512d4cc718d7a2
2014-03-10 17:39:55 +01:00
bed18b128f
Remove visual noise from forms
...
Conflicts:
forms/source/component/DatabaseForm.cxx
Change-Id: I4005fe65e89794bd92191c37221c252a3e964917
Reviewed-on: https://gerrit.libreoffice.org/8262
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 14:54:56 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
f1a73892b3
Typo: apropriate -> appropriate
...
Change-Id: I05e23039dc3ae0b6595c87fe550f4228ad93d5d6
2014-02-25 22:04:17 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
5f17e5eaad
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2014-02-21 14:35:52 +09:00
d548b250db
Drop unnecessary #include
...
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
2014-02-18 13:24:11 +09:00
faced6b5f7
ucbhelper: sal_Bool -> bool
...
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
2014-02-17 17:55:18 +01:00
6d993bc5b4
bool improvements
...
Change-Id: I78099f87510355a43ba9b01ca9d545d44ce11a50
2014-01-28 20:26:28 +01:00
e3133ae237
Let C++ inline functions return bool instead of sal_Bool
...
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx). This change should be
transparent to client code.
Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).
Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-23 18:43:53 +01:00
5a73cceee5
FORMS : Remove usage of DBG_CTOR and DBG_DTOR.
...
Valgrind is capable of detecting such bugs. No need for extra macros.
Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db
Reviewed-on: https://gerrit.libreoffice.org/7534
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-21 16:26:50 +00:00
459c8131ac
bool improvements
...
Change-Id: Iba5bf2d2207f80098cb43ff8ce290eef741d21c9
2014-01-14 21:28:07 +01:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
4ea65db333
cppcheck: Array index is used before limits check
...
Change-Id: I30154dd9504b70dc3212af3ac1d88dfc9a9d8396
2013-11-16 10:52:45 +01:00
ba3783467c
-Werror,-Wunused-member-function
...
Change-Id: Ia04390e5a3d4c5833c24add581985a9491af0443
2013-11-14 10:15:05 +01:00
d366c9b20e
remove unnecessary sal_Unicode casts in various places
...
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
d6809a9ac5
i18npool, forms: remove warnings_guard_unicode*.h
...
These horrible headers use "#pragma GCC system_header" and thereby
prevent generated Makefile dependencies, which is what broke incremental
builds after the ICU upgrade today.
Change-Id: Ife983b3c4de86968da8a0187a1acb1bbb2b5c81f
2013-11-14 00:04:16 +01:00
ef90021abe
convert OUString !compareToAscii to equalsAscii
...
Convert code like
if( ! aStr.compareToAscii("XXX") )
to
if( aStr.equalsAscii("XXX") )
which is both clearer and faster.
Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11 12:58:12 +02:00
373f352ef2
remove unnecessary use of OUString constructor in FORMS module
...
Change-Id: Ibbf477e99ba0c07a9138497496442b0f9296f5c3
2013-11-11 11:21:22 +02:00
bdf7b2715e
fixincludeguards.sh: forms
...
Change-Id: I634371fcd867f20e20384f75d613dab5f69a246c
2013-11-05 09:28:53 +01:00
a7724966ab
Bin comments that claim to say why some header is included
...
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
45e366eadb
drop unnecessary tools/string includes
...
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
075d472a9d
Use std::auto_ptr::reset where applicable
...
(avoids warnings about std::auto_ptr ctor being deprecated)
Change-Id: I39d2d155c0bc62ca77a30c02428ea39102213f42
2013-10-02 16:49:49 +02:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
6cd939111a
BUG:57950 Remove chained appends
...
Removed some chained OUString::append()'s from forms. OUStringBuffer
could really use a append operator(+=).
Change-Id: I635bdd25da9f09373e686d87a1d198bc09bda906
Reviewed-on: https://gerrit.libreoffice.org/5329
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
2013-08-10 15:04:11 +00:00
652ccbdf31
i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.
...
Add IsUTC member to:
com.sun.star.util.DateTime
com.sun.star.util.DateTimeRange
com.sun.star.util.Time
Add new stucts with explicit time zones:
com.sun.star.util.DateTimeWithTimezone
com.sun.star.util.DateWithTimezone
com.sun.star.util.TimeWithTimezone
Adapt the sax::Converter to read/write timezones, and fix the unit test.
Everything else just uses default (no time zone), this commit is just
to fix the API.
STRUCT: /UCR/com/sun/star/util/DateTime
nFields1 = 7 != nFields2 = 8
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/DateTimeRange
nFields1 = 14 != nFields2 = 15
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/Time
nFields1 = 4 != nFields2 = 5
Registry2 contains 1 more fields
Conflicts:
sc/source/filter/oox/unitconverter.cxx
Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18
Reviewed-on: https://gerrit.libreoffice.org/4833
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2013-07-15 11:46:41 +00:00
c54f77b718
callcatcher: update unused code
...
All FontSizeBoxs and SmFontPickListBoxs are now .ui loaded, .res ctors unused
Change-Id: I50aa8606fefacab0b15b6795a7ba90dff8109802
2013-07-15 09:07:49 +01:00
fae7447283
drop unused convertWhitespace
...
Change-Id: I2e27e498cb86d5aaeff692e62e75ee8c8200e729
2013-07-02 11:59:53 +01:00
6a08067902
OUString convertion for unotools
...
Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707
Reviewed-on: https://gerrit.libreoffice.org/4659
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-07-02 07:31:30 +00:00
ba0a57702c
remove OUString wrap for string literals
...
For some functions and all kinds of Exceptions.
CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException
createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService
bash command:
for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
| cut -d ':' -f1 | sort -u
| xargs sed -i
-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
-e "s/\($i.*\)\"+ /\1\" + /g";
done
Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-06-29 21:52:54 +00:00
af7cfa0071
fdo#43460 forms: use isEmpty()
...
Change-Id: If51c22cb28646e7af3785cb086fb4a48af0f7d68
Reviewed-on: https://gerrit.libreoffice.org/4323
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2013-06-17 19:53:45 +00:00
00c9fe2cfc
cppcheck: fix reassignments
...
Change-Id: Ic9a994ccd00f4ca938a93bce000313495f2c31c8
2013-06-13 20:52:19 +02:00
d133d8f0df
make sure class MIP is complete before it is used
...
(cherry picked from commit c8ed66993a98faa4730d507903f110dc80c61445)
Conflicts:
forms/source/xforms/model.hxx
Change-Id: Iec9e999b1568ad422ea2118c04b770000bdbfd75
2013-05-27 12:57:34 +01:00
6a043e9c0a
Use the new type-checking Reference constructor to reduce code noise
...
Also create a Clang compiler plugin to detect such cases.
Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2013-05-22 10:44:29 +00:00
9830fd36db
date/time IDL datatypes incompatible change
...
- nanosecond precision
- signed (allowed negative) year
Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.
Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
60fbefc615
fdo#60724 informations -> information
...
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-15 04:49:39 +02:00
ba044b1e96
remove needless forward rtl::OUString declarations
...
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07 14:23:12 +02:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
2b7ee1db28
remove boilerplate comments
...
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
b10fd86396
Prefer prefix ++/-- operators for non-primitive types
...
Change-Id: I7f536c136dff4c0d868055bf6400b6381750c988
2013-03-29 06:51:07 +01:00
aa753f01ba
-Wunused-macros
...
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
2413a8edc2
Fix warning: unused variable 'sConverted' [loplugin]
...
Change-Id: I14a2d98c519b2eab6645eaf8b2dcdbccc7c36c2f
2013-03-25 23:58:12 +02:00
39d45390f4
removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
...
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms
Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 10:48:30 +00:00
4c0c23af21
Simplify equalsIgnoreAsciiCaseAscii[L] calls
...
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19 11:32:20 +01:00
