wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
417,855 Commits 5 Branches 0 Tags
2e1559cd85d2f1b4e308d63d34bf3632ba4b6d4b
Commit Graph

3876 Commits

Author SHA1 Message Date
ekuiitr
728104b31c tdf#96099 Removed some trivial typedefs related to UnOrderedMap and size_t. 
Change-Id: I59d3d0b2c1097b5ca96505dc99a4a104b4f8ab48
Reviewed-on: https://gerrit.libreoffice.org/47082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-01-10 15:20:44 +01:00
jan Iversen
ee4b074ce2 basic, solve link problems 
When not using scripting, there were a number of
unresolved symbols. First aproach did not work, so this
commit is the more extensive.

Change-Id: Iaf78bde10d9a43862d58d1aa8f46b14aa075eddb
 2018-01-08 13:18:36 +01:00
Noel Grandin
0a1b0458cb SAL_TYPES_SIZEOFINT == 2 no longer possible 
on any of our platforms

Change-Id: Id453ada9c79c76f2736f568436e386b05bcd08c5
Reviewed-on: https://gerrit.libreoffice.org/47468
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-06 13:38:36 +01:00
Stephan Bergmann
54227c9a20 Silence loplugin:unnecessarycatchthrow with --disable-debug 
(An alternative fix could be to suppress warnings for catch blocks containing
preprocessor conditionals, but as these two places seem to be the only ones
affected, keep it simple for now.)

Change-Id: Ia83e56d1eab69bb2920ffdbbfc2182addce47963
Reviewed-on: https://gerrit.libreoffice.org/47331
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-04 08:06:13 +01:00
Noel Grandin
884cbe174e RID_* can be extern global variables 
no need to access them via methods

Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2
Reviewed-on: https://gerrit.libreoffice.org/47245
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-02 12:19:01 +01:00
Andrea Gelmini
d0222ba1fd Fix typos 
Change-Id: I3d16dc162e5fa2e08134d848a835eb392e64056e
Reviewed-on: https://gerrit.libreoffice.org/47126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-12-29 09:54:33 +01:00
Noel Grandin
2a421b26c0 loplugin:passstuffbyref improved return in basic,framework 
Change-Id: Ib19836febb59f4e2bb07dc874cfc6baabc653237
Reviewed-on: https://gerrit.libreoffice.org/47065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-26 19:56:02 +01:00
Jan Holesovsky
101a79cc4d lokdialog: Allow switching language of some of the ResMgr's. 
This way, it is possible to have all the strings translated in dialogs even
when different users use different languages.  [It was already possible
to have different languages previously, but not everything in the dialog has
switched - like the buttons at the bottom of the dialogs etc.]

Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9
Reviewed-on: https://gerrit.libreoffice.org/46417
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/46979
Tested-by: Jenkins <ci@libreoffice.org>
 2017-12-22 22:39:39 +01:00
Noel Grandin
00bc5a0973 wrap scoped enum around css::util::NumberFormat 
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa
Reviewed-on: https://gerrit.libreoffice.org/46339
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2017-12-19 22:08:26 +01:00
Noel Grandin
be359b156b loplugin:unusedenumconstants 
Change-Id: I9dc4b369872a7c6c076ae9be1dcdf2f8385af8a7
Reviewed-on: https://gerrit.libreoffice.org/46684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-19 07:49:33 +01:00
Mike Kaganski
4e144751f1 loplugin:unusedindex 
Change-Id: I256a807dd2a4c81126b5a76f3d472e31b8224146
Reviewed-on: https://gerrit.libreoffice.org/46652
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-18 07:36:32 +01:00
Mike Kaganski
8de8e0ce21 Get rid of loop counter variable 
Change-Id: Ia4f4e24819525287e720a9c016b3666bc006b545
Reviewed-on: https://gerrit.libreoffice.org/46531
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-15 19:54:16 +01:00
Michael Stahl
29baa05bb9 tools: remove unused #include from solar.h 
Change-Id: I214e13add371380701ae39403d90a574a63e495d
 2017-12-13 22:12:39 +01:00
Noel Grandin
3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Noel Grandin
c947a25b3a loplugin:countusersofdefaultparams in basctl..basegfx 
Change-Id: I515acfb9de1f6dff1de94a60055c5b600e5e5241
Reviewed-on: https://gerrit.libreoffice.org/45957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-07 07:19:59 +01:00
Michael Stahl
9f9347c265 basic: SfxLibraryContainer: replace maMutex 
... with cppu::BaseMutex, because a member cannot ensure the life
cycle guarantees expected by WeakComponentImplHelper.

Change-Id: Iaa10c699abf69882d917487740db241ba1455e1c
 2017-12-06 10:03:24 +01:00
Noel Grandin
c0ac78c971 loplugin:salcall handle virtual methods 
Change-Id: Iab95db31188ea2914a46d63a7ebef3d825e6ec42
Reviewed-on: https://gerrit.libreoffice.org/45851
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-06 07:42:50 +01:00
Eike Rathke
ef6940a480 Save an unnecessary duplicate GetObject() call 
Change-Id: Ib0efc84ad2cedc1a149fa57996bc0481bd64591b
 2017-12-05 20:06:07 +01:00
Eike Rathke
36493607d8 Simplify the IsObject()/GetObject() logic here 
Change-Id: I816b15b6795b4946b1bfed0d1f6d103a6a1aba4f
 2017-12-05 18:30:22 +01:00
Eike Rathke
d1cd68fac3 Rather call GetObject() only if IsObject(), tdf#112571 follow-up 
Which effectively is what GetObject() internally also does to
determine whether to set an error, so resetting an error here is
moot (or might even hide a nested error?).

Change-Id: I8736d16e386d1833126965538f96aaa1fd73dfd6
 2017-12-05 18:17:06 +01:00
Eike Rathke
863e269cd3 Resolves: tdf#114232 reset error after unsuccessful GetObject() query 
Probably broken already since

    commit 0b21b8b146fc4b982c7c9bbb866b9ff18a29332a
    Date:   Wed Oct 6 10:16:27 2010 +0100

        initial commit for vba blob ( not including container_control stuff )

Change-Id: Iecce564851a76921b491ff101365c70883ad7475
 2017-12-05 17:27:57 +01:00
Eike Rathke
d915cb417b Resolves: tdf#114231 do not mask ErrCode with GetRest() 
Regression from

    commit 7ca950ec744b7af1d15724ec2abc296573a641e4
    Date:   Wed Aug 23 19:25:02 2017 +0200

	no need to use ERRCODE_RES_MASK here

	the relevant usage sites already call GetRest() before comparing

which exactly is the reason that it didn't work anymore.

Old StringArray ItemList resources stored only 16-bit values,
hence ERRCODE_RES_MASK was used to mask the ErrCode values in the
resource for which code had to mask ERRCODE_RES_MASK as well to
compare values. Now the full ErrCode is stored, so code must not
use GetRest() on a value to compare against, or use GetRest() on
both values (which theoretically could lead to ambiguities, but
probably doesn't in resources that are restricted to one module).

Change-Id: I835e47424bb008bc680dc4f8c502c9558397db36
 2017-12-05 15:20:07 +01:00
Noel Grandin
9a06b99d2f loplugin:salcall fix non-virtual methods 
first, since those are safer to change than virtual methods

Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe
Reviewed-on: https://gerrit.libreoffice.org/45798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-05 07:32:46 +01:00
Eike Rathke
af8431d8db Find VBA-only functions when compiling first on module level 
This likely never worked as there is no SbiInstance in that step,
but worked by chance when running a module's code that was
compiled with VBA support where the VBA-only function was added as
a symbol to be resolved later during runtime and then the
SbiInstance exists and the symbol was magically resolved.

Found when trying to correct vba_tests to actually fail if all
subtests fail that then started to fail in Atn.vb because of the
Round() function being VBA-only.

Change-Id: I7d9f6e2640a73388a2a58c3d180820c6ef85abe3
Reviewed-on: https://gerrit.libreoffice.org/45425
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-11-29 11:08:58 +01:00
Noel Grandin
a566fd1c1a loplugin:unusedmethods 
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1
Reviewed-on: https://gerrit.libreoffice.org/45386
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-29 07:28:57 +01:00
Eike Rathke
bb4cd5271e Get rid of two more temporary SvNumberFormatter instances 
Change-Id: Id2afd9dd9d791383a1374b5abe52b47b43a19f08
Reviewed-on: https://gerrit.libreoffice.org/45236
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-11-24 21:34:14 +01:00
Eike Rathke
5e1d49db80 Get rid of a temporary SvNumberFormatter instance 
For each Format call..

Change-Id: I2f9d875ca27d5a10e609df1c0168be2dad65eaab
Reviewed-on: https://gerrit.libreoffice.org/45230
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-11-24 21:33:30 +01:00
Eike Rathke
f1b5b22a5f Get rid of that LANGUAGE_GERMAN nonsense 
Change-Id: I1ca3125e893a54ac00a3d785d77ed5612fb01857
Reviewed-on: https://gerrit.libreoffice.org/45235
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-11-24 21:32:45 +01:00
Eike Rathke
2f8174594d Aaand another one.. SvNumberFormatter instance 
... just to parse with LANGUAGE_ENGLISH_US if system locale failed..

Change-Id: Id9b7cfb5b5f21c46789f30e8e8c72a7524491e95
Reviewed-on: https://gerrit.libreoffice.org/45238
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-11-24 21:32:01 +01:00
Eike Rathke
28288295ae Get rid of a temporary SvNumberFormatter instance 
... in case we have a runtime instance already. Only used for
scanning date literals in source so not frequently used, otherwise
we could remember a non-runtime instance formatter somewhere.

Change-Id: I1146860c4b0aa4091708c22e498a6f720d6c7a13
Reviewed-on: https://gerrit.libreoffice.org/45232
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-11-24 21:31:15 +01:00
Eike Rathke
4b98e352e5 Make the SbiInstance SvNumberFormatter shared_ptr 
In preparation to get rid of the per call locally created
SvNumberFormatter instances..

Change-Id: Ic7db3bbb655aa18e939f5722964655a20f2eadf2
Reviewed-on: https://gerrit.libreoffice.org/45227
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-11-24 21:30:02 +01:00
Caolán McNamara
462866cfdc various coverity warnings 
Change-Id: I27f20c51f86aeaed8e932f7ca45cce8770bc34ec
Reviewed-on: https://gerrit.libreoffice.org/45140
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-23 21:28:47 +01:00
Eike Rathke
db080dad6c tdf#114011 limit/truncate date, not only year 
Change-Id: I479040f411fb8b5975c0aa1aa24f95c957cf80cf
 2017-11-23 18:44:48 +01:00
Caolán McNamara
df2e78f1a8 replace check of eof and GetError with good 
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291
Reviewed-on: https://gerrit.libreoffice.org/45076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-22 13:33:46 +01:00
Caolán McNamara
2161d04688 drop duplicate method 
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12
Reviewed-on: https://gerrit.libreoffice.org/45075
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-22 13:33:25 +01:00
Caolán McNamara
5280b3eaa6 silence some coverity warnings 
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d
Reviewed-on: https://gerrit.libreoffice.org/44875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-18 21:59:23 +01:00
Noel Grandin
7f055f373b inline SbxMAXSALUINT64 and friends 
which don't offer any value

Change-Id: Ie8082abc80ffd0e7719f4fa9a0d5f93203628ee5
Reviewed-on: https://gerrit.libreoffice.org/44798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-17 08:09:50 +01:00
Andrea Gelmini
a8f31d5120 Fix typos 
Change-Id: I8bdced3fa572074aedabdcfce841adf525ae8b81
Reviewed-on: https://gerrit.libreoffice.org/44710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
 2017-11-15 07:52:19 +01:00
Andrea Gelmini
d71bcc4dc5 Fix typos 
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91
Reviewed-on: https://gerrit.libreoffice.org/44654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
 2017-11-13 08:43:17 +01:00
Noel Grandin
049e026755 loplugin:finalclasses in basic,basegfx 
Change-Id: Iff223782fa0ded0fe46b8b7af35bfd21f331015f
Reviewed-on: https://gerrit.libreoffice.org/44535
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-10 07:44:47 +01:00
Noel Grandin
3dde9d988f loplugin:constparams in various(1) 
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b
Reviewed-on: https://gerrit.libreoffice.org/44261
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-04 07:50:01 +01:00
Noel Grandin
5d618d73ed loplugin:constantparam in basic,basctl 
Change-Id: If918c42d4b82d78c07786cfa47c74d0dfb7493d6
Reviewed-on: https://gerrit.libreoffice.org/44131
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-01 07:14:13 +01:00
Eike Rathke
ae531b69b3 Another ImpGetIntntlSep() fix, tdf#81671 follow-up 
Change-Id: I9c056a137ab873f677e374d75c4e2f06bf370f21
 2017-10-27 19:08:09 +02:00
Eike Rathke
ab7b10d6c3 Fix build of Windows-only code, tdf#81671 follow-up 
Change-Id: I68a468857c529e8cab80d4453832dc9f4b3657d8
 2017-10-27 19:01:59 +02:00
Eike Rathke
dc520c7759 Handle decimalSeparatorAlternative in BASIC ImpScan,..., tdf#81671 
Change-Id: I73ff2bf624ba7c8d88c9419a109c340806bd31f5
 2017-10-27 18:29:44 +02:00
Michael Stahl
11d2f3d6e1 vcl: make MapMode constructor explicit 
Insert constructor everywhere, except a couple places that apparently
want to compare GetMapUnit().

Change-Id: I1910deb60562e5e949203435e827057f70a3f988
 2017-10-26 23:17:45 +02:00
Stephan Bergmann
d4a25418b3 loplugin:includeform: basic 
Change-Id: I6fbba5c4619eec7ae03fed65a18974faa0f190af
 2017-10-23 22:46:13 +02:00
Noel Grandin
87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Noel Grandin
ead920a48a loplugin:redundantcast handle dynamic_cast 
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb
Reviewed-on: https://gerrit.libreoffice.org/43621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-10-21 15:44:11 +02:00
Mike Kaganski
daf7c3e732 basic: consistently use "" and <> in include directives 
Change-Id: I147c0e9b9b1e09af593f54799e45e1348cd40716
Reviewed-on: https://gerrit.libreoffice.org/43298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-10-10 07:43:46 +02:00