Commit Graph

1932 Commits

Author SHA1 Message Date
5cb2e3104b remove toolkit/unohlp.hxx hack
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913
Reviewed-on: https://gerrit.libreoffice.org/4601
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28 11:49:28 +00:00
61027ca6eb improve performance switching modules in large Libraries fdo#66148
object catalog when updated, updates ( all ) entries and was parsing
the source for every method in every module

Change-Id: Id68e3c24d597d29a86d3507a7dc20745c96dd2a2
2013-06-27 16:39:09 +01:00
eebf0a6dfa Revert "tweak object catalog to improve switching modules in large Libraries"
This reverts commit 21eeeccfa64a4c03554c1fe3715d38c1695245ab.
2013-06-27 16:39:09 +01:00
21eeeccfa6 tweak object catalog to improve switching modules in large Libraries
object catalog when updated updates ( all ) entries and was parsing
the source for every method in every module

Change-Id: Id68e3c24d597d29a86d3507a7dc20745c96dd2a2
2013-06-27 15:53:01 +01:00
cb01fc2eb0 Related: #i108689# Invalidate Basic IDE slots to trigger feature update
(cherry picked from commit 060758a289c134548d8ad376eaca3d24ea84a0db)

Conflicts:
	basctl/source/basicide/baside2b.cxx
	basctl/source/basicide/baside3.cxx

Change-Id: I2bbe4eeae9b2e4d3ad257b26a6a9694deeaaa87c
2013-06-15 16:04:17 +01:00
e6c13f2846 fdo#46808, Convert XMultiServiceFactory to XComponentContext
Change-Id: Ice5ec3a056f7f2f5184523bda1c709ccac876736
2013-06-03 10:00:01 +02:00
1d1825db86 fdo#46808, Convert awt::UnoControlDialog to new style
Change-Id: I9a5256c8dbacda60167403b4e26900588943a9b2
2013-05-28 08:10:22 +02:00
e36f83d81c Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654.  As discussed at
<http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re:
fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd
change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get
CreateUnoDialog() work again" appears to fix things again:

  The problem is that the implementation of the css.awt.UnoControlDialogModel
  involves UNO aggregation
  (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in
  toolkit/soruce/helper/registerservices.cxx creating a
  OGeometryControlModel<UnoControlDialogModel> instance that aggregates a
  UnoControlDialogModel instance).  That means that queryInterface can return a
  reference to something that is technically a different object, and that's
  what's happening here, and explains why calling setPropertyValue in two
  different ways on what logically appears to be a single object can end up
  calling two different implementations (of two different physical objects).
  (UNO aggregation is known to be broken and should not be used.  Nevertheless,
  there's still code that does---code that is a horrible mess and hard to clean
  up.)

  That all this worked as intended in the past is just sheer luck, but any
  way of substantially touching it is asking for trouble.  I'm going to
  revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again.

I wasn't able to revert without also reverting
be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert
awt::XUnoControlDialog to new style," as the two were tightly dependant.  Also
reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431
"-Werror,-Wuninitialized" (sans the const-ness fix in
UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452
"Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix
awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086
"scripting: get CreateUnoDialog() work again."

Conflicts:
	basctl/source/dlged/dlged.cxx
	filter/source/t602/t602filter.cxx
	xmlscript/test/imexp.cxx

Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
2013-05-25 11:45:47 +02:00
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-22 10:44:29 +00:00
5ab3015aae fdo#46808, Clean up old usages of ExtToolkit
This service no longer exists in LO, and no-one seems to know what
this service was, so convert it to use the awt::Toolkit service,
since that service returns the interface the code expects.

Change-Id: I761effbd49a9a3a15ec9c8716c72d4220a3e987e
2013-05-21 08:23:59 +02:00
be50ad28f5 fdo#46808, Convert awt::XUnoControlDialog to new style
Change-Id: I40d2e2ddd92186a2ba22ebfbdda8367391e8d355
2013-05-21 08:23:59 +02:00
6c61b20a8d fdo#46808, Convert awt::UnoControlDialogModel to new style
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-21 08:23:58 +02:00
2b5d1c9bf6 Move to MPLv2 license headers, with ESC decision and author's permission.
Change-Id: Ie154eadd9960b159f5a250cde93c4bd7a8a948cf
2013-05-16 12:43:11 +01:00
33b4dc22f8 fdo#46808, Use service constructor
Change-Id: I31a812dfd84a33e3b5f6f44bbd786e14a465886e
2013-05-15 08:25:36 +02:00
96004917df Related: #i120515# fixed memory leak
(cherry picked from commit b24737fc55e797d03002d44a1fa325a101617c55)

Change-Id: Ib59957fb2c9e198012898293aaa2e5afbe561ef4
2013-05-02 11:27:00 +01:00
26bda9f4a8 convert message box return types to an enum
Change-Id: I20889dc94aac1119c1ee9da873ce911887c1c335
2013-05-01 14:42:04 +01:00
72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
97f6625d9a Replace chained O(U)StringBuffer::append() with operator+
modified:   basctl/source/basicide/basides2.cxx

Change-Id: I681188553058ac8712365bc2de39b0453fd19ed9
Reviewed-on: https://gerrit.libreoffice.org/3546
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-22 07:40:47 +00:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
9be3e8e8d5 Should initialise Module::mpModule to 0
Change-Id: Ie4648b82a524a7ddcd427d7d2543bc7691eddcf8
2013-04-12 22:54:00 +03:00
8dba30fcf6 Get rid of GetAppData(SHL_IDE)
It seems to be used only locally in basctl so there is really no reason for
it.

Change-Id: I9ad0a67621e190257e028fd3689f692e639eaf56
2013-04-12 22:42:08 +03:00
648895f9de use common image from res/ folder
Change-Id: I89203c277277d409cfe46f62af82b2621c9101b2
2013-04-09 16:24:22 +02:00
b248624126 fdo#46808, Convert frame::Frame to new style
Change-Id: I74427d1e0059808f04960c648b93245b06c20f7f
2013-04-08 13:53:04 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
c0fde06562 write even better code
Change-Id: I0f193b9c17da5855fd515251543afc68b8885b9b
2013-04-01 22:45:37 +02:00
2b7ee1db28 remove boilerplate comments
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
08b91c6313 remove unused GetCurDocViewWin
Change-Id: I7fe825cd1fb9e988eb8037e1f5dca7252c192f33
2013-04-01 13:20:10 +02:00
b3c914ffff Use OUString in basctl(basicide)
Change-Id: I176088d3d33f02a1721e4027571a1f22dc6bd986
Reviewed-on: https://gerrit.libreoffice.org/3116
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-30 21:37:07 +00:00
5be14df244 ResMgr with LanguageTag
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-29 14:09:01 +01:00
91c1161dd9 Use OUString and sal_Int32 in GetTextWidth()
Change-Id: I0b3cdbe8576300d098027cc98d7dff841d148f18
Reviewed-on: https://gerrit.libreoffice.org/3097
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2013-03-28 13:48:02 +00:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
9c281fda84 String::AppendAscii cleanup
Change-Id: I3c1ff291488b7747e143982aa7ea95169175c2c2
Reviewed-on: https://gerrit.libreoffice.org/2914
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-22 17:17:18 +00:00
5bb4a2ba1d further OUString cleanup
Change-Id: I19954ee5976cb881a5fe73a889c8e04a19b14eb6
2013-03-19 14:18:10 +01:00
56f30adffa make sure basic IDE cut/copy buttons on toolbar are refreshed fdo#30545
Change-Id: I483469f0b76ade7fb107c6f4ae5c28a4b03877b1
2013-03-13 17:24:53 +00:00
5a2cfa6773 Abbreviate Rectangle as Rect, not Rec
Change-Id: If38a5d23150bcd19a6eb6024c2ef1eea826898f5
2013-03-12 09:46:46 +02:00
7d1f4cdec3 fdo#38838: Converting String/UniString to OUString
Change-Id: If64db96005fcd8a42e4fa24041867b99183965f9
Reviewed-on: https://gerrit.libreoffice.org/2586
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-11 15:50:44 +00:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
10bb5b8e24 fdo#38838, replacement of String with OUString
Replaced String with OUString in mediawindow.cxx, basdoc.cxx,
basdoc.hxx and bastype3.cxx. In other files I only replaced,
what was necessary for the changes in basdoc to work.

Change-Id: I1ad0e7e262f8becdf57f182853aaa914a88895a4
Reviewed-on: https://gerrit.libreoffice.org/2554
Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>
2013-03-05 12:48:36 +00:00
30e14d7d3a fdo#38838, change String to OUString
Change-Id: I373f5d2f453dff83141a4cdaeed94ce0268bf70c
Reviewed-on: https://gerrit.libreoffice.org/2497
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-03-04 18:20:24 +00:00
5b04c9063c remove unused and commented out code
This code gets never called.

Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-03-04 11:34:07 +00:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
30975b96e8 coverity#736107: nesting level mismatch
Change-Id: I24655d0e87335ac0356a1082fd993a87613e213e
2013-03-03 04:35:14 +01:00
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
1bda31ac13 loplugin: unused variables
aErrorText usage was commented out since 2000.

Change-Id: Ic4d81c2d48e59a36e2f4280ceb36ea8148b9dc9d
2013-02-25 03:14:00 +01:00
c4cc63badc sal: update log areas
Change-Id: Id7b2c7e871abf19b70f427095371c6a6c0208607
2013-02-23 13:31:09 +01:00
805f1ed598 fix editeng and basctl build
Change-Id: I0d70449ad9b42219969c82e2054694c4a5830dcf
2013-02-22 10:40:16 +00:00
bb82f5c1e9 coverity#982443 Explicitt null dereferenced
Change-Id: I470c34c38eda673e6663b23cdb28ea4be0bef914
Reviewed-on: https://gerrit.libreoffice.org/2218
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:42:27 +00:00
d1ccb1eea8 coverity#735665 Dereference after null check
Change-Id: I9d217789116602838dabbf93e81ab8d0467c5c7b
Reviewed-on: https://gerrit.libreoffice.org/2217
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:36:11 +00:00
f0300c1ade coverity#735664 coverity#736134 coverity#736135 Dereference Null
Change-Id: I1a5c7d7bb2d60a43bb6197fc04a01d981a1396d1
Reviewed-on: https://gerrit.libreoffice.org/2215
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:35:31 +00:00
6d76752bb1 coverity#735601 coverity#736164
Change-Id: I5805d749ba32bec778ae98e9b30ba68d74cc44c3
Reviewed-on: https://gerrit.libreoffice.org/2219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:17:47 +00:00