Commit Graph

2860 Commits

Author SHA1 Message Date
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
1e50f78927 sal_Bool to bool
Change-Id: Ibc63340b3ae431c7cdac78893dbdd1989ebe5ff9
2013-03-25 10:54:06 +09:00
7f4a34e314 basic: Remove non working AboutStarBasic
The content of this function was commented out since the first import. So as it does nothing remove it.

Change-Id: Ia46674f7bdc12e80d61a8142697e875f5c58f482
Reviewed-on: https://gerrit.libreoffice.org/2899
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-24 14:49:52 +00:00
97fa9a882c coverity#704205/704206/704207 Logically dead code
Change-Id: Ic2cbd96f393a21cf2c6634d3c5e5a4c5a5b486ef
2013-03-23 14:13:20 +01:00
e8638ad5a7 in Val() check status after stringToDouble()
instead of calling checkArithmeticOverflow()

Change-Id: I2e3307ee054db77bab0a106d886823dba9e56ea8
2013-03-22 17:47:17 +01:00
caecf6102f SbiScanner::NextSym: check status after rtl_math_uStringToDouble()
For example, 10e308 is overflow, not 0 ...

Change-Id: Ib7d622865bfb73581732bda45c76e078ee7d05d0
2013-03-21 19:32:45 +01:00
e96c7a60c8 replace decimal separator at correct position, rhbz#919020
Change-Id: I97a652e6a1286726fe21ae580f6dbf5536f9d52d
2013-03-20 00:06:40 +01:00
9e9f39d171 resolved rhbz#919020 Basic CDbl() and CSng() scan localized number
Code wrongly replaced decimal separator with '.' and used atof() to scan
the number string which itself may be localized on *iX systems but not
on Windows. Hence on *iX the numbers may had been truncated where on
Windows they were not.

Additionally made this work with Unicode separators if defined for the
locale, removed the awkward conversion to ASCII byte string and
eliminated use of toupper() and isdigit() calls. Also eliminated a
possible buffer overflow.

Change-Id: Ic3f791601c321ef1386fe51a5244d3dacac3d908
2013-03-19 23:36:02 +01:00
5f0ad2a5ac windows build fix
Change-Id: I6ff724052660d73b583fb1e44265a60a6fa4379f
2013-03-19 23:01:16 +01:00
438efb38ec fdo#39445 writing out tools/fsys.hxx (basic)
Change-Id: I2ec7546572fa72359615f371715b4aa82b1182ca
2013-03-19 22:42:02 +01:00
a1e22bdeb4 remove unused header: tools/fsys.hxx
Change-Id: Id6ac74e88e7e57dfbee9aa70a83909c3280a58cd
2013-03-19 18:27:53 +01:00
cd49ebe1aa fdo#39445 writing out tools/fsys.hxx (basic)
removed unused include from runtime.cxx and step0.cxx
changed DirEntry::GetAccessDelimiter() to SAL_PATHDELIMITER in methods1.cxx
removed unused DirEntry declaration from methods1.cxx

Change-Id: I0d8c64b6498cf5b16757edaf13e1108f279934dd
Reviewed-on: https://gerrit.libreoffice.org/2848
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-03-19 17:23:43 +00:00
dfcc20fd8e More "compareToAscii(RTL_CONSTASCII_STRINGPARAM(s)) != compareTo(s)" fixes
Change-Id: Ia93b281b07559fb6f0d67d53dd91dfacf2be0d0b
2013-03-19 17:46:51 +01:00
0054b43801 follow on fix for fdo#62090 ensure out of range startpos is handled
Change-Id: Ic1f57480a36415998748faeea3b606a47d277181
2013-03-19 15:59:21 +00:00
205277f5e6 remove commented out line I inserted to screw up Juliens patch
Change-Id: I7f874267a640a7cc754eb7477b764f7546fdc5ea
2013-03-19 15:48:39 +00:00
14d452d0c2 fix for fdo#62090 Mid function regression
Change-Id: Ia6a73d6a44a34345b512922037d01b8b40ac24a8
2013-03-19 15:45:56 +00:00
9be25f14bd avoid Wundef for various FIXME, FEATURE_NOT_DONE_YET and what not
Change-Id: I8e409ba63d32dca9a1c7f09d143165d1d702d642
2013-03-18 17:15:56 +01:00
4158ae52fb WaE: Werror=shadow
Change-Id: I7f1bddbed85076f1c909d0d9f4ecdd1cda6f1880
2013-03-15 20:49:11 +00:00
c90373f98e detect follow-on default member of default member object bnc#809017
Change-Id: I366c049fc342240081957b81d2f28bfcf8d4e331
2013-03-15 17:24:12 +00:00
a63cc778d1 i119933 - make Basic FORMAT function work with non-ASCII text
Conflicts:
	basic/source/sbx/sbxscan.cxx

Change-Id: I5b77231d1b09cbf32fa914f3d7b60d6e631e5870
2013-03-14 18:07:30 +01:00
9dcfc56c7c Fix Set/Let mixup ( from String -> OUString rework ) fdo#60752
Change-Id: I56f3e8b54d80f4575937f8515e8a8d9318353b8d
2013-03-13 14:39:18 +00:00
59b5ff7574 basic: translation of all debug messages
runtime.cxx: Added some output instead of nothing.

Change-Id: Ia25ae4b5fe8661a8a3ac317bc0562e1339640cd8
2013-03-11 21:36:43 +01:00
d06f4577b5 bnc#805071 fix object assigment problems when default members present
Change-Id: I6f7dfd369a36aff06f15b9a3affadb9d19787a9c
2013-03-11 17:32:52 +00:00
6dddefc6e7 fdo#43460: use isEmpty()
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
2013-03-09 21:47:31 +01:00
a2454a42ad fdo#43460: use isEmpty()
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
2013-03-09 20:32:39 +01:00
ead0a6038b coverity#705627: fix memory leak
Change-Id: I4f73f77b27d2ed28a9f97757105c8a6cc5521b33
2013-03-09 17:59:12 +01:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
8035a3af26 some further OUString cleanup
Change-Id: I13eb94092e29ececc9fbf494074acde5f893b605
2013-03-08 04:51:28 +01:00
a9813b9ab3 doh! sReturnStrg is OUStringBuffer, no need to assign
Change-Id: I490d20e8b494b4f59277b1cc92c73beb65a05813
2013-03-07 17:26:21 +00:00
f202b21770 fix String->OUString foobar
Change-Id: Ia924e6e8f3cfa25b131185713699d64e9d339357
2013-03-07 16:27:35 +00:00
a3bb733ec6 fdo#46808, Convert singleton theMasterScriptProviderFactory
Change-Id: I647a02e552acdd354463fc46c13c5a73b1c90d09
2013-03-07 08:23:39 +02:00
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
ce33f85ffd sal_Bool to bool
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04 23:14:41 +09:00
33d6a7b2d7 doubled namespaces
Change-Id: I0f6a34a459c1492a69afa3ef6bcbaa8ed7639a22
2013-03-04 13:58:40 +01:00
26e37ca4c7 doubled includes
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
5b04c9063c remove unused and commented out code
This code gets never called.

Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-03-04 11:34:07 +00:00
23e572f475 don't do something different in dbgutil mode than product
Change-Id: Ibe0f41206ffaa3ff73018e49b4e710123c7fb14d
2013-03-04 11:23:58 +00:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
d021bb4dae coverity: fix memory leak
Change-Id: I17a09015d98a98349571a35492d516724ae2daa9
2013-03-02 06:51:58 +01:00
ece1af8c7f coverity#736108: nesting level mismatch
Change-Id: I6e6a3baa5aba5591a40fd236e7a2056fb59d6977
2013-03-01 07:00:09 +01:00
1544c17ffd coverity#705626 and coverity#705627: fix memory leak
Change-Id: I68f43d07798ccb3fc3a5ab438992ac74f4cd262a
2013-02-28 06:29:35 +01:00
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
405caad685 loplugin: unused variables
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
94477cb5fb Fix typo accessable/accessible
Change-Id: I2f6d00a6361243a52a593acaaf2bf624d8a2730e
2013-02-23 17:29:22 +01:00
3a014901fd Fix typo seperated/separated
Change-Id: I133423de994b1befe246b6c921802428a3528202
2013-02-23 17:20:45 +01:00
fe86d0ca5d Fix typo "paramater" -> "parameter" + remove some commented lines
Change-Id: I1e6343fdcee91d23aacd776520e8bfdf81d411e4
2013-02-23 15:37:28 +01:00
7ca8407b40 coverity#707499 coverity#735400 coverity#738541
Change-Id: Idc00fe9ad5158043cf2eee652567581111c89177
Reviewed-on: https://gerrit.libreoffice.org/2277
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:53:55 +00:00
558e956403 coverity#704204 Logically dead code
Change-Id: I0a8dbbb3dbe7408e6f4d92c0bbebdaaa7d882f01
Reviewed-on: https://gerrit.libreoffice.org/2271
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:53:22 +00:00
8abb2f4d57 coverity#982288 Logically dead code
Change-Id: I4fb90cb00829bc4be7d050521215528de4748d76
Reviewed-on: https://gerrit.libreoffice.org/2245
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:51:47 +00:00
7f561b9d66 coverity#735398 Logically dead code
Change-Id: Iadb7fbd8a1fb1c535a3ed78d4b2f7120b29aeb75
Reviewed-on: https://gerrit.libreoffice.org/2270
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
2013-02-19 21:00:00 +00:00