Commit Graph

708 Commits

Author SHA1 Message Date
ed0646e52f Fixes for new-style com.sun.star.chart2.FormattedString service
...changed from old-style with 5d1ad167294878789e644452f23ef883af93fe87
"fdo#46808 Convert chart2::FormattedString service to new style."  The
CharacterProperties* services dropped there are property-only old-style
services, so only serve documentation purposes anyway.  Ideally, the new-style
service would offer interface attributes for the relevant properties (and likely
not implement XPropertySet at all), but so be it for now...

Change-Id: I0dd0373cfd372f2320204eb953acce9a2b9e86d2
2013-06-05 14:39:45 +02:00
275225ed4d Resolves: #i120828#, restore some ChartModel::dispose() calls..
to break cyclic reference

Found by: zhangjf
Patch by: zhangjf

(cherry picked from commit 1c564cb9a46fc6435750f9f1a70f654b52efd970)

Change-Id: I8aaac18584d55d9f381acdf4deb0e704bc9bcfc1
2013-05-31 14:59:58 +01:00
f30399c540 Revert "fdo#46808, Convert chart2::Title service to new style"
This reverts commit d256dbede60533369d1aac64cca34721183f6a8a:

For one, the new css.chart2.XTitle2 looked unfinished, in that it transfered the
direct properties of the old-style css.chart2.Title service into attributes, but
left out all the properties inherited by the old-style service from
css.style.ParagraphProperties, css.drawing.FillProperties,
css.drawing.LineProperties (and that missing FIXME css.layout.LayoutElement,
whatever that is supposed to be).  This needs more thought, to either make
available all propertiers as attributes, or none.

For another, this broke JunitTest_chart2_unoapi (sch.ChXChartDocument,
sch.ChartTitle), for hard-to-debug reasons.

Conflicts:
	chart2/source/model/main/Title.cxx
	chart2/source/model/main/Title.hxx
	offapi/com/sun/star/chart2/XTitle2.idl
	sc/source/filter/inc/xlchart.hxx

Change-Id: I4747208a13984904d0e409ea49a73b0f667c86c7
2013-05-23 10:39:21 +02:00
03c3cd9093 fix maybevoid attributes
..from commit d256dbede60533369d1aac64cca34721183f6a8a
"Convert chart2::Title service to new style"

Change-Id: Ib4b8a9126f1042c7d0b8cc07505444f25fe9c55a
2013-05-22 14:35:44 +02:00
d256dbede6 fdo#46808, Convert chart2::Title service to new style
API CHANGE: The chart2::XTitled interface now takes and returns
   a XTitle2 instead of an XTitle.

Change-Id: I96c35909d3a13f1abb544296a782a0b6a7a58ec6
2013-05-21 08:24:01 +02:00
5d1ad16729 fdo#46808 Convert chart2::FormattedString service to new style
API CHANGE: dropped the following services from the new unified
interface because the current service does not implement them.
    service ::com::sun::style::CharacterProperties;
    [optional] service ::com::sun::style::CharacterPropertiesAsian;
    [optional] service ::com::sun::style::CharacterPropertiesComplex;

Change-Id: I7cb6a5d4e998975b1272f4f4da03feea30cd30b6
2013-05-13 09:38:03 +02:00
925e27014e turn this nasty SAL_WARN into a SAL_INFO
Change-Id: I740c1ac683500a406539239f9e5bfe093be58e9b
2013-04-22 13:57:32 +02:00
4a4bdc142a fix the remaining issues with the changed handling of ErrorBar props
Change-Id: I75c839cbfccbe84e7aa98aef6959bcd0c5390ab6
2013-04-22 13:57:31 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
ef53a3a12e Some cppcheck cleaning
Change-Id: I993bd95b31f1090c747f01a899650e8873dcaada
2013-04-02 23:01:14 +02:00
2b7ee1db28 remove boilerplate comments
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
aa46348777 remove C2U in chart2
Change-Id: Id7ebf66319f0891d276a3da95a95658aed59cbc7
2013-03-25 16:14:02 +01:00
bab961dd0a Fix chart2 build
Change-Id: Ia3eb1c1576034c1cbc93e9fb4e60d205a325b132
2013-03-11 18:15:05 +01:00
ded39ea57b #119989# Support relative 3D pie chart height when importing charts.
Reported by: Yan Li
Patch by: Yan Li, Tan Li, alg
Review by: alg(cherry picked from commit 2b1cedbe547ea8f7979f91873dd6e602ebb08a7b)

Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>

Conflicts:
	chart2/source/view/charttypes/PieChart.cxx
	chart2/source/view/main/ChartView.cxx
	sc/source/filter/inc/xlchart.hxx

Change-Id: Ibc6f070021c79809c651ba789409a5fb5096c185
2013-03-11 17:34:44 +01:00
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
41e03a166e doubled using
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-05 12:34:33 +01:00
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
d05287a9f1 RTL_CONSTASCII_USTRINGPARAM removals
Removed all occurences of RTL_CONSTASCII_USTRINGPARAM in chart2.

Change-Id: I0ab188e2d67a5fc17a3653e5213031f6e2c2581d
Reviewed-on: https://gerrit.libreoffice.org/2244
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-20 22:58:20 +00:00
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
f95a7c2c6d fdo#46808, Convert SvNumberFormatter to use XComponentContext
Change-Id: If4e8312dae6bc5eb8bb7655cf250f06ab37b7e5c
2013-01-28 08:25:24 +02:00
49cf14a3ca fdo#46808, Adapt document::GraphicObjectResolver UNO service to new style
The services already existed, it just did not have an IDL file

Change-Id: I245f78c165dbfde11a981efd7033c5c282f4e8ad
2013-01-28 08:22:53 +02:00
d46b2086f2 bnc#798271: Don't delete the PropertyMapEntry instance prematurely.
When using comphelper::PropertyMapEntry array to create a UNO property
set, we need to make sure we keep this instance while the property set
object is alive, else it would cause a very hard-to-debug problem down
the road...

In this particular case, the aExportInfoMap array instance was destroyed
when it went out of scope, but the xInfoSet which references it was used
afterward.

Change-Id: I02132b6b2e6bef7b461f0f77c2c4a3e911e42014
2013-01-24 22:32:21 -05:00
24f0aa76c0 fdo#46808, use service constructor for embed::StorageFactory
Change-Id: I26cd1cf86118122f392f16801a646df753a7df26
2012-12-10 08:05:53 +02:00
9e716494a8 fix some VS 2010 specific issues
Change-Id: Iae27a96c1e2ed72d2744fcbe100d6ada7dc41c82
Reviewed-on: https://gerrit.libreoffice.org/914
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2012-10-28 18:09:02 +00:00
fb741b5e1e fdo#46808, Adapt xml::sax::XWriter UNO service to new style
Create a merged XWriter interface for the service.
The xml.sax.Writer service already existed, it just did not have
an IDL file.

Change-Id: I4e6d3f3c68f9282a55fc7aa19778f97632fd8ad5
2012-10-22 17:01:11 +02:00
a20f9a410f fdo#46808, Adapt xml::sax::XParser UNO service to new style
The xml.sax.Parser service already existed, it just did not have
a new-style service to create it.

Change-Id: I6f145a7504ff9e149c802f723991954a2801cbc9
2012-10-04 16:29:53 +02:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
9ac86f484b Improvement on previous commit, UCB clean up
* As UCB is only ever initialized with "Local"/"Office", remove this
  configuration vector completely.  The "create" ctor creates an instance
  internally initialized with those "Local"/"Office" keys.  Special (test) code
  can still instantiate an uninitialized one via plain createInstance.  And for
  backwards compatilibity process startup still ensures to create an initialized
  instance early, in case there is still code out there (in extensions) that
  later calls plain createInstance and expects to get the already-initialized
  (single) instance.

* XInitialization is an "implementation detail" of the UniversalContentBroker
  service, do not expose in XUniversalContentBroker.

* ucbhelper/configurationkeys.hxx is no longer needed and is removed.

* ucbhelper/contentbroker.hxx is an empty wrapper and is removed; however, that
  requires ucbhelper::Content constructors to take explicit XComponentContext
  arguments now.

* The only remaining code in ucbhelper/source/client/contentbroker.cxx is
  Android-only InitUCBHelper.  Is that relevant still?

Change-Id: I3f7bddd0456bffbcd13590c66d9011915c760f28
2012-09-14 18:24:49 +02:00
176f0de1d4 -Werror,-Wunused-private-field (Clang towards 3.2)
Change-Id: I273139d60a9940a009d6917439fe10783db1ac0d
2012-08-31 09:04:14 +02:00
206c70eef3 fdo#46808, Adapt TempFile UNO service to new style
Change-Id: Ia448d6d74201e2be487c6d8317f94be3745808aa
2012-08-27 15:40:08 +02:00
170cfbc625 fdo#46808, Adapt document::DocumentProperties UNO service to new style
Change-Id: I19015d3e3e9aa6e4b3b4bb011183c73ab00365ca
2012-08-27 15:40:07 +02:00
515ceca515 chart2: merge component files for new chartcore library
Change-Id: Id7cc969d854a98e9bd32fd396eb82ae92a06ba80
2012-08-06 13:10:58 +02:00
63c508e3e8 re-base on ALv2 code. Includes:
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00
1340890ccd simplify include guards
Change-Id: Id4210229b20a1d54b680ff1a2ccbcdd3684ecf5f
2012-07-14 05:44:15 +02:00
d221d4e5a7 removed unnecessary forward declarations of class
this also moved necessary ones to right headers

Change-Id: Idda93aeaa1fdfeda602b14e3b233ffd1cf27c0cf
2012-07-02 22:07:55 +09:00
57154616f0 Remove UNO includes comments
Change-Id: I48e193322967fb75e93eaf81e9e2110d3056f92a
2012-06-29 09:25:09 +02:00
6fcac7dfc4 Remove unused include files
Those never get included at any point in the code.

Change-Id: I17736e005635b9e57759cfc95176a99e7c5e8988
2012-06-27 13:34:23 +02:00
ecf943247f re-base on ALv2 code.
Change-Id: I8018d9b5fa01d1720c0392dc5fdc4a0656f25a35
2012-06-22 09:51:05 +01:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
c1a595aa0b hide local functions harder
Change-Id: I874a7cda6b2948866a56f0559ab737fed5f42385
2012-05-29 12:21:17 +01:00
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
743f22045c Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\)) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 15:07:41 +02:00
f1e8da595d add SAL_CALL to ChartModel::dump 2012-03-28 03:58:44 +02:00
5d8c9ef5e5 implement the layout dumper for chart2 2012-03-28 03:35:22 +02:00
8090cba738 implement XDumper in ChartModel 2012-03-28 03:35:22 +02:00
16244e7f24 removed duplicate includes in avmedia / basic / canvas / chart2 / comphelper 2012-03-28 00:30:29 +09:00
6e67c03dc0 Enable -Wnon-virtual-dtor for GCC 4.6
...which has the necessary features to support it.

Change a lot of classes to either contain a protected non-virtual dtor
(which is backwards compatible, so even works for cppumaker-generated
UNO headers) or a public virtual one.

cppuhelper/propertysetmixin.hxx still needs to disable the warning, as
the relevant class has a non-virtual dtor but friends, which would still
cause GCC to warn.

Includes a patch for libcmis, intended to be upstreamed.
2012-03-14 13:32:02 +01:00
23af031b09 Fix typos in comments 2012-02-18 09:35:43 +00:00
6fca59d9c2 Simplify code by making getProcessComponentContext() implicit. 2012-01-31 17:26:57 +01:00